commit 31829b941ca8ac02a828619440cb62b64673caa8
author Michael Kolb <kolby@google.com> Fri Oct 01 11:50:21 2010 -0700
committer Michael Kolb <kolby@google.com> Fri Oct 01 17:44:26 2010 -0700
tree 5eda5e250bda5e2e8571567b41a0aec65a5f7d7f
parent cb2e46958a8cb39ef90f0436e31e7242b13ca6b3

fix empty bookmark folder names bug

    http://b/issue?id=3052887

Change-Id: I6a9ba0c310cbb4b0ebd42c686785dc09900d4dda

src/com/android/browser/AddBookmarkPage.java

diff --git a/src/com/android/browser/AddBookmarkPage.java b/src/com/android/browser/AddBookmarkPage.java
index 9070218..6c066fb 100644
--- a/src/com/android/browser/AddBookmarkPage.java
+++ b/src/com/android/browser/AddBookmarkPage.java
@@ -108,19 +108,12 @@
                 if (actionId == EditorInfo.IME_NULL) {
                     // Only want to do this once.
                     if (event.getAction() == KeyEvent.ACTION_UP) {
-                        String name = v.getText().toString();
-                        long id = addFolderToCurrent(name);
-                        mFolderNamer.setVisibility(View.GONE);
-                        mAddNewFolder.setVisibility(View.VISIBLE);
-                        descendInto(name,id);
-                        InputMethodManager.getInstance(this)
-                                .hideSoftInputFromWindow(
-                                mFolderNamer.getWindowToken(), 0);
+                        completeFolderNaming();
                     }
-                    // Steal the key press for both up and down
-                    return true;
                 }
             }
+            // Steal the key press; otherwise a newline will be added
+            return true;
         }
         return false;
     }
@@ -131,12 +124,7 @@
             if (mFolderSelector.getVisibility() == View.VISIBLE) {
              // We are showing the folder selector.
                 if (mFolderNamer.getVisibility() == View.VISIBLE) {
-                    // Editing folder name
-                    String name = mFolderNamer.getText().toString();
-                    long id = addFolderToCurrent(mFolderNamer.getText().toString());
-                    descendInto(name, id);
-                    mFolderNamer.setVisibility(View.GONE);
-                    mAddNewFolder.setVisibility(View.VISIBLE);
+                    completeFolderNaming();
                 } else {
                     // User has selected a folder.  Go back to the opening page
                     mFolderSelector.setVisibility(View.GONE);
@@ -165,6 +153,18 @@
         }
     }
 
+    private void completeFolderNaming() {
+        if (!TextUtils.isEmpty(mFolderNamer.getText())) {
+            String name = mFolderNamer.getText().toString();
+            long id = addFolderToCurrent(mFolderNamer.getText().toString());
+            descendInto(name, id);
+            mFolderNamer.setVisibility(View.GONE);
+            mAddNewFolder.setVisibility(View.VISIBLE);
+            InputMethodManager.getInstance(this).hideSoftInputFromWindow(
+                    mFolderNamer.getWindowToken(), 0);
+        }
+    }
+
     private long addFolderToCurrent(String name) {
         // Add the folder to the database
         ContentValues values = new ContentValues();
@@ -598,4 +598,5 @@
         }
         return true;
     }
+
 }