commit 387d45d2284c7fd7f12cbadc96161f946ae29cad
author George Mount <mount@google.com> Fri Oct 07 15:57:53 2011 -0700
committer George Mount <mount@google.com> Mon Oct 10 13:11:56 2011 -0700
tree 04bc0d8cdcca96dc2d5730f26309885f55d99d95
parent 07af26d9ae4239bad876e8fd7ac69984a1d66996

Data URL fixes - bookmarks, save, and wallpaper

 Bug 5383517
 Images kept in data URLs can now be selected and this fixes the
 Save and Set Wallpaper options. It also removes the bookmarking
 capability.

Change-Id: I461bdcb4c950f6fcd8db8b38f4c599212106b027

src/com/android/browser/PhoneUi.java

diff --git a/src/com/android/browser/PhoneUi.java b/src/com/android/browser/PhoneUi.java
index 0e2710d..ddb4e0e 100644
--- a/src/com/android/browser/PhoneUi.java
+++ b/src/com/android/browser/PhoneUi.java
@@ -196,7 +196,9 @@
     public void updateMenuState(Tab tab, Menu menu) {
         MenuItem bm = menu.findItem(R.id.bookmarks_menu_id);
         if (bm != null) {
-            bm.setVisible(!showingNavScreen());
+            String url = tab.getUrl();
+            boolean isDataUrl = DataUri.isDataUri(url);
+            bm.setVisible(!showingNavScreen() && !isDataUrl);
         }
         MenuItem nt = menu.findItem(R.id.new_tab_menu_id);
         if (nt != null) {