commit 4328e0ac69d8f0e385e0306f8c182f473c9db4a8
author Axesh  R. Ajmera <aajmera@codeaurora.org> Thu Oct 30 16:07:54 2014 -0700
committer WebTech Code Review <code-review@localhost> Wed Nov 12 08:06:13 2014 -0800
tree 327b6e2455a8a715b3a93f1536ad7a6d742328cb
parent 87c5aba8f9176ea1d3cdbc5f7e5d3470f180d62a

Use isSavable API for offline reading

This helps in saving pages for offline reading only
for valid mimetypes.

Change-Id: Idbd1dcbf10c955e634fb6234dd0fbc8cd4a8c744

src/com/android/browser/Controller.java

diff --git a/src/com/android/browser/Controller.java b/src/com/android/browser/Controller.java
index 4d72320..73940be 100644
--- a/src/com/android/browser/Controller.java
+++ b/src/com/android/browser/Controller.java
@@ -1821,6 +1821,7 @@
         // items defined in res/menu/browser.xml should be enabled
         boolean isLiveScheme = false;
         boolean isPageFinished = false;
+        boolean isSavable = false;
         if (tab != null) {
             canGoBack = tab.canGoBack();
             canGoForward = tab.canGoForward();
@@ -1828,6 +1829,7 @@
             isLive = !tab.isSnapshot();
             isLiveScheme = UrlUtils.isLiveScheme(tab.getWebView().getUrl());
             isPageFinished = tab.getPageFinishedStatus();
+            isSavable = tab.getWebView().isSavable();
         }
         final MenuItem back = menu.findItem(R.id.back_menu_id);
         back.setEnabled(canGoBack);
@@ -1864,7 +1866,7 @@
         uaSwitcher.setChecked(isDesktopUa);
         menu.setGroupVisible(R.id.LIVE_MENU, isLive && isLiveScheme);
         menu.setGroupVisible(R.id.SNAPSHOT_MENU, !isLive);
-        menu.setGroupEnabled(R.id.OFFLINE_READING, isLive && isLiveScheme && isPageFinished);
+        menu.setGroupEnabled(R.id.OFFLINE_READING, isLive && isLiveScheme && isPageFinished && isSavable);
         // history and snapshots item are the members of COMBO menu group,
         // so if show history item, only make snapshots item invisible.
         menu.findItem(R.id.snapshots_menu_id).setVisible(false);