commit 510e93e535d5e3141f95c0fd1485732c75f943ea
author Michael Kolb <kolby@google.com> Wed Jan 26 17:51:26 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Wed Jan 26 17:51:26 2011 -0800
tree 7f8a12b5f326b8640fd442085a23cc5abe46e158
parent a295c7b034a55bc52d3338370fbff9449475f38b
parent 91902d5db3dcbd161bf824620567e210d6f4fcbe

Merge "fix suggestion dropdown offset" into honeycomb

res/values/dimensions.xml

diff --git a/res/values/dimensions.xml b/res/values/dimensions.xml
index b1e1d92..300714b 100644
--- a/res/values/dimensions.xml
+++ b/res/values/dimensions.xml
@@ -44,4 +44,5 @@
     <dimen name="list_favicon_padding">5dip</dimen>
     <dimen name="list_favicon_corner_radius">3dip</dimen>
     <dimen name="tab_favicon_corner_radius">2dip</dimen>
+    <dimen name="dropdown_offset">8dip</dimen>
 </resources>

src/com/android/browser/TitleBarXLarge.java

diff --git a/src/com/android/browser/TitleBarXLarge.java b/src/com/android/browser/TitleBarXLarge.java
index ff06118..8dc8663 100644
--- a/src/com/android/browser/TitleBarXLarge.java
+++ b/src/com/android/browser/TitleBarXLarge.java
@@ -160,7 +160,7 @@
 
     void setUseQuickControls(boolean useQuickControls) {
         mUseQuickControls = useQuickControls;
-        mUrlInput.setReverseResults(mUseQuickControls);
+        mUrlInput.setUseQuickControls(mUseQuickControls);
         if (mUseQuickControls) {
             mBackButton.setVisibility(View.GONE);
             mForwardButton.setVisibility(View.GONE);

src/com/android/browser/UrlInputView.java

diff --git a/src/com/android/browser/UrlInputView.java b/src/com/android/browser/UrlInputView.java
index 02c9f4c..3e49c06 100644
--- a/src/com/android/browser/UrlInputView.java
+++ b/src/com/android/browser/UrlInputView.java
@@ -60,6 +60,7 @@
     private boolean mLandscape;
     private boolean mInVoiceMode;
     private boolean mIncognitoMode;
+    private int mVOffset;
 
     public UrlInputView(Context context, AttributeSet attrs, int defStyle) {
         super(context, attrs, defStyle);
@@ -86,6 +87,7 @@
         onConfigurationChanged(ctx.getResources().getConfiguration());
         setThreshold(1);
         setOnItemClickListener(this);
+        mVOffset = 0;
     }
 
     void setController(UiController controller) {
@@ -94,6 +96,13 @@
         setCustomSelectionActionModeCallback(urlSelectionMode);
     }
 
+    void setUseQuickControls(boolean useQuickControls) {
+        mVOffset = (useQuickControls
+                ? (int) getResources().getDimension(R.dimen.dropdown_offset)
+                : 0);
+        mAdapter.setReverseResults(useQuickControls);
+    }
+
     void setContainer(View container) {
         mContainer = container;
     }
@@ -135,7 +144,7 @@
         if (getLeft() != -getDropDownHorizontalOffset()) {
             setDropDownHorizontalOffset(-getLeft());
         }
-        setDropDownVerticalOffset(8);
+        setDropDownVerticalOffset(mVOffset);
     }
 
     @Override
@@ -247,10 +256,6 @@
 
     }
 
-    public void setReverseResults(boolean reverse) {
-        mAdapter.setReverseResults(reverse);
-    }
-
     public void setIncognitoMode(boolean incognito) {
         mIncognitoMode = incognito;
         mAdapter.setIncognitoMode(mIncognitoMode);