commit 53ef89355c4cd8511d3dfc2bc5a336f7d60ad4a9
author Vivek Sekhar <vsekhar@codeaurora.org> Thu Jun 18 16:51:43 2015 -0700
committer jrizzoli <joey@cyanogenmoditalia.it> Fri Aug 28 13:15:45 2015 +0200
tree cd36ed11b23b8d79a57114b817e6a9460b2582f2
parent f03c7969c7f10ece782c20c3235ae3d212846635

Minor fixes using Snapshot API

- Changed the browser code to use the asynchronous API for
  getting the snapshot ids.

Change-Id: I3ea2eccba56344e55ce6a19735403c34b54ad651

src/com/android/browser/Tab.java

diff --git a/src/com/android/browser/Tab.java b/src/com/android/browser/Tab.java
index 1bcf4a9..99d57a8 100644
--- a/src/com/android/browser/Tab.java
+++ b/src/com/android/browser/Tab.java
@@ -83,6 +83,7 @@
 import java.util.Map;
 import java.util.UUID;
 import java.util.Vector;
+import java.util.List;
 import java.sql.Timestamp;
 import java.util.Date;
 
@@ -663,15 +664,20 @@
         @Override
         public void onHistoryItemCommit(WebView view, int index) {
             mTabHistoryUpdateObservable.set(index);
-            int maxIdx = view.copyBackForwardList().getSize();
-            int[] ids = view.getSnapshotIds();
-            int currentTabIdx = mWebViewController.getTabControl().getCurrentPosition();
-            for (int id : ids) {
-                if (getTabIdxFromCaptureIdx(id) == currentTabIdx &&
-                        getNavIdxFromCaptureIdx(id) >= maxIdx) {
-                    view.deleteSnapshot(id);
+            final int maxIdx = view.copyBackForwardList().getSize();
+            final WebView wv = view;
+            view.getSnapshotIds(new ValueCallback <List<Integer>>() {
+                @Override
+                public void onReceiveValue(List<Integer> ids) {
+                    int currentTabIdx = mWebViewController.getTabControl().getCurrentPosition();
+                    for (Integer id : ids) {
+                        if (getTabIdxFromCaptureIdx(id) == currentTabIdx &&
+                                getNavIdxFromCaptureIdx(id) >= maxIdx) {
+                            wv.deleteSnapshot(id);
+                        }
+                    }
                 }
-            }
+            });
         }
 
         @Override
@@ -1375,15 +1381,22 @@
         if (mMainView != null) {
             dismissSubWindow();
             // save the WebView to call destroy() after detach it from the tab
-            WebView webView = mMainView;
+            final WebView webView = mMainView;
             if (!mWebViewDestroyedByMemoryMonitor) {
-                int[] ids = webView.getSnapshotIds();
-                int currentTabIdx = mWebViewController.getTabControl().getCurrentPosition();
-                for (int id : ids) {
-                    if (getTabIdxFromCaptureIdx(id) == currentTabIdx) {
-                        webView.deleteSnapshot(id);
+                webView.getSnapshotIds(new ValueCallback<List<Integer>>() {
+                    @Override
+                    public void onReceiveValue(List<Integer> ids) {
+                        int currentTabIdx = mWebViewController.getTabControl().getCurrentPosition();
+                        for (Integer id : ids) {
+                            if (getTabIdxFromCaptureIdx(id) == currentTabIdx) {
+                                webView.deleteSnapshot(id);
+                            }
+                        }
+                        setWebView(null);
+                        webView.destroy();
                     }
-                }
+                });
+                return;
             }
             setWebView(null);
             webView.destroy();