commit 54ed3aa8417f4c6a27eecb9caf10f742a705b6e0
author John Reck <jreck@google.com> Fri Aug 19 15:16:05 2011 -0700
committer John Reck <jreck@google.com> Fri Aug 19 15:16:05 2011 -0700
tree 3cbc53a5959521b1cb19123286f206850af9644a
parent 42229bcdea8a1623d9ac3fce099793a3767fb14d

Fix crash

 Bug: 5180400
 onContextItemSelected is apparantly unordered and goes to the
 "wrong" fragment first, causing this crash

Change-Id: I8d9df87d5799882190bc0fdfee5720c97d2b8f7a

src/com/android/browser/BrowserBookmarksPage.java

diff --git a/src/com/android/browser/BrowserBookmarksPage.java b/src/com/android/browser/BrowserBookmarksPage.java
index 46521cb..2c38334 100644
--- a/src/com/android/browser/BrowserBookmarksPage.java
+++ b/src/com/android/browser/BrowserBookmarksPage.java
@@ -154,7 +154,10 @@
 
     @Override
     public boolean onContextItemSelected(MenuItem item) {
-        BookmarkContextMenuInfo i = (BookmarkContextMenuInfo)item.getMenuInfo();
+        if (!(item.getMenuInfo() instanceof BookmarkContextMenuInfo)) {
+            return false;
+        }
+        BookmarkContextMenuInfo i = (BookmarkContextMenuInfo) item.getMenuInfo();
         // If we have no menu info, we can't tell which item was selected.
         if (i == null) {
             return false;

src/com/android/browser/BrowserHistoryPage.java

diff --git a/src/com/android/browser/BrowserHistoryPage.java b/src/com/android/browser/BrowserHistoryPage.java
index 6625e55..09c6f97 100644
--- a/src/com/android/browser/BrowserHistoryPage.java
+++ b/src/com/android/browser/BrowserHistoryPage.java
@@ -388,7 +388,11 @@
         if (menuInfo == null) {
             return false;
         }
-        HistoryItem historyItem = (HistoryItem) getTargetView(menuInfo);
+        View targetView = getTargetView(menuInfo);
+        if (!(targetView instanceof HistoryItem)) {
+            return false;
+        }
+        HistoryItem historyItem = (HistoryItem) targetView;
         String url = historyItem.getUrl();
         String title = historyItem.getName();
         Activity activity = getActivity();