commit 55db4575ea7bdf0a573896718d5403e13db816f7
author Vivek Sekhar <vsekhar@codeaurora.org> Wed Dec 02 10:20:03 2015 -0800
committer jrizzoli <joey@cyanogenmoditalia.it> Thu Dec 03 19:57:05 2015 +0100
tree 4d4f099dc1b7bd65145fe67204683a004236d9d8
parent 4fded5d617a7934c3c8b15f92ad3e22f9627f4ef

Fix flash of comboview

Hiding the comboview does not check if its visible before starting the animation
to hide the view, this causes flash of comboview if multiple calls are made to
hide the view.

Change-Id: I31da921ee411ac8290df48d8faf6cd4badadaca9

src/com/android/browser/ComboView.java

diff --git a/src/com/android/browser/ComboView.java b/src/com/android/browser/ComboView.java
index 8d64ac9..733de12 100644
--- a/src/com/android/browser/ComboView.java
+++ b/src/com/android/browser/ComboView.java
@@ -204,16 +204,18 @@
     }
 
     public void hideViews() {
-        if(!(BrowserActivity.isTablet(mActivity)))
-          this.startAnimation(mOutAnimation);
-        this.setVisibility(View.INVISIBLE);
-        mActionBarContainerId = getResources().getIdentifier("action_bar_container", "id", "android");
-        ViewGroup actionBarContainer = (ViewGroup) mActivity.getWindow().getDecorView().findViewById(mActionBarContainerId);
-        if (actionBarContainer != null) {
-            actionBarContainer.removeOnLayoutChangeListener(this);
+        if (isShowing()) {
+            if (!(BrowserActivity.isTablet(mActivity)))
+                this.startAnimation(mOutAnimation);
+            this.setVisibility(View.INVISIBLE);
+            mActionBarContainerId = getResources().getIdentifier("action_bar_container", "id", "android");
+            ViewGroup actionBarContainer = (ViewGroup) mActivity.getWindow().getDecorView().findViewById(mActionBarContainerId);
+            if (actionBarContainer != null) {
+                actionBarContainer.removeOnLayoutChangeListener(this);
+            }
+            ActionBar actionBar = mActivity.getActionBar();
+            actionBar.hide();
         }
-        ActionBar actionBar = mActivity.getActionBar();
-        actionBar.hide();
     }
 
     //TODO: Save the selected tab on BrowserActivity's onSaveInstanceState