commit 632e5a00cb521b146e59f13acca14d5d37734421
author Axesh  R. Ajmera <aajmera@codeaurora.org> Thu Nov 13 09:52:46 2014 -0800
committer WebTech Code Review <code-review@localhost> Thu Nov 13 11:49:31 2014 -0800
tree 2b37dd639386c409e0860640c1e63716309c40cd
parent 323e05b62180141ef839fcab512fd59a3801e108

Fix cursor leak in BrowserBookmarks

The cursor should be close once its job is done.

Change-Id: I53401db691323a595e0b71a5f9032a306aaff560

src/com/android/browser/BrowserBookmarksPage.java

diff --git a/src/com/android/browser/BrowserBookmarksPage.java b/src/com/android/browser/BrowserBookmarksPage.java
index 82109e9..16eae77 100644
--- a/src/com/android/browser/BrowserBookmarksPage.java
+++ b/src/com/android/browser/BrowserBookmarksPage.java
@@ -669,10 +669,17 @@
                 throw new IllegalArgumentException("Missing folder id!");
             }
             Uri uri = BookmarkUtils.getBookmarksUri(mContext);
-            Cursor c = mContext.getContentResolver().query(uri,
-                    null, BrowserContract.Bookmarks.PARENT + "=?",
-                    new String[] {params[0].toString()}, null);
-            return c.getCount();
+            Cursor c = null;
+            try {
+                c = mContext.getContentResolver().query(uri,
+                        null, BrowserContract.Bookmarks.PARENT + "=?",
+                        new String[] {params[0].toString()}, null);
+                return c.getCount();
+            } finally {
+                if (c != null) {
+                    c.close();
+                }
+            }
         }
 
         @Override