commit 6f336409081c173b1890aee4d381f3ef10815b7c
author Ben Murdoch <benm@google.com> Thu Oct 27 13:57:33 2011 +0100
committer Ben Murdoch <benm@google.com> Thu Oct 27 15:36:47 2011 +0100
tree e2ad5fe40c90fa778740d70401e7e51a34ef0289
parent 74b1a4ed7c6342a49b3456781433c03a9f65dfa3

Fix monkey crash in AutofillSettingsFragment.

It's possible to trigger the options menu before the
views are fully inflated if you're really fast like the
monkey.

Bug: 5518582

Change-Id: I86402cc1df70289d9f0685a5c9949ac38fbd9cd0

src/com/android/browser/AutoFillSettingsFragment.java

diff --git a/src/com/android/browser/AutoFillSettingsFragment.java b/src/com/android/browser/AutoFillSettingsFragment.java
index 639fcdc..7be657d 100644
--- a/src/com/android/browser/AutoFillSettingsFragment.java
+++ b/src/com/android/browser/AutoFillSettingsFragment.java
@@ -54,6 +54,8 @@
 
     private MenuItem mSaveMenuItem;
 
+    private boolean mInitialised;
+
     // Used to display toast after DB interactions complete.
     private Handler mHandler;
     private BrowserSettings mSettings;
@@ -241,6 +243,8 @@
             mPhoneEdit.setText(activeProfile.getPhoneNumber());
         }
 
+        mInitialised = true;
+
         updateSaveMenuItemState();
 
         return v;
@@ -251,6 +255,11 @@
             return;
         }
 
+        if (!mInitialised) {
+            mSaveMenuItem.setEnabled(false);
+            return;
+        }
+
         boolean currentState = mSaveMenuItem.isEnabled();
         boolean newState = (mFullNameEdit.getText().toString().length() > 0 ||
             mEmailEdit.getText().toString().length() > 0 ||