commit 77df4568331d527f993f4d69168218ddf5acddda
author Michael Kolb <kolby@google.com> Fri Nov 19 14:49:34 2010 -0800
committer Michael Kolb <kolby@google.com> Mon Nov 22 09:13:50 2010 -0800
tree 2cdef545065beb3a3b319978f901e8f7160289e9
parent e8a28338fcd94ef17506b14fed9ebed7dec1124a

fix current tab has no webview bug

    http://b/issue?id=3214823
    setCurrentTab is called before setting the active tab in the UI
    this guarantees the active tab has a webview

Change-Id: I5d56c42be5a19389d7bc2cc0c41039bb90cc8478

src/com/android/browser/BaseUi.java

diff --git a/src/com/android/browser/BaseUi.java b/src/com/android/browser/BaseUi.java
index 832b0b3..2a23bb1 100644
--- a/src/com/android/browser/BaseUi.java
+++ b/src/com/android/browser/BaseUi.java
@@ -66,6 +66,7 @@
     Activity mActivity;
     UiController mUiController;
     TabControl mTabControl;
+    private Tab mActiveTab;
 
     private Drawable mSecLockIcon;
     private Drawable mMixLockIcon;
@@ -295,14 +296,20 @@
 
     @Override
     public void setActiveTab(Tab tab) {
-        Tab current = mTabControl.getCurrentTab();
-        if ((tab != current) && (current != null)) {
-            removeTabFromContentView(current);
+        if ((tab != mActiveTab) && (mActiveTab != null)) {
+            removeTabFromContentView(mActiveTab);
         }
+        mActiveTab = tab;
         attachTabToContentView(tab);
         setShouldShowErrorConsole(tab, mUiController.shouldShowErrorConsole());
 
         WebView view = tab.getWebView();
+        // TabControl.setCurrentTab has been called before this,
+        // so the tab is guaranteed to have a webview
+        if (view == null) {
+            Log.e(LOGTAG, "active tab with no webview detected");
+            return;
+        }
         view.setEmbeddedTitleBar(mTitleBar);
         if (tab.isInVoiceSearchMode()) {
             showVoiceTitleBar(tab.getVoiceDisplayTitle());
@@ -328,8 +335,9 @@
 
     @Override
     public void removeTab(Tab tab) {
-        if (mTabControl.getCurrentTab() == tab) {
+        if (mActiveTab == tab) {
             removeTabFromContentView(tab);
+            mActiveTab = null;
         }
         if (mXLargeScreenSize) {
             mTabBar.onRemoveTab(tab);

src/com/android/browser/Controller.java

diff --git a/src/com/android/browser/Controller.java b/src/com/android/browser/Controller.java
index 79fff3d..aabdb26 100644
--- a/src/com/android/browser/Controller.java
+++ b/src/com/android/browser/Controller.java
@@ -1903,10 +1903,9 @@
     }
 
     protected void setActiveTab(Tab tab) {
-        // Update the UI before setting the current tab in TabControl
-        // so the UI can access the old tab to switch over from
-        mUi.setActiveTab(tab);
         mTabControl.setCurrentTab(tab);
+        // the tab is guaranteed to have a webview after setCurrentTab
+        mUi.setActiveTab(tab);
     }
 
     protected void closeEmptyChildTab() {