commit 8d06e36fe80f516e04ad33ff8b446720e36cabfd
author Leon Scroggins <scroggo@google.com> Wed Mar 24 14:45:57 2010 -0400
committer Leon Scroggins <scroggo@google.com> Wed Mar 24 14:45:57 2010 -0400
tree d062027b4f4559b577df4685f6de6eff92f4a743
parent 184f08bc3dca3352b2fd37c75a13640c167f4269

Use AsyncTask when calling Browser.updateVisitedHistory

Previously updateVisitedHistory itself used an AsyncTask, but
since that method could be called from a non-main thread, move
the AsyncTask to the call site.

Part of http://b/issue?id=2539948

Change-Id: I9a70130ab125490fa96964ea9637eba67732180a

src/com/android/browser/BrowserActivity.java

diff --git a/src/com/android/browser/BrowserActivity.java b/src/com/android/browser/BrowserActivity.java
index 1f15186..ff16e4e 100644
--- a/src/com/android/browser/BrowserActivity.java
+++ b/src/com/android/browser/BrowserActivity.java
@@ -597,8 +597,15 @@
             return false;
         }
 
-        Browser.updateVisitedHistory(mResolver, url, false);
-        Browser.addSearchUrl(mResolver, url);
+        final ContentResolver cr = mResolver;
+        final String newUrl = url;
+        new AsyncTask<Void, Void, Void>() {
+            protected Void doInBackground(Void... unused) {
+                Browser.updateVisitedHistory(cr, newUrl, false);
+                Browser.addSearchUrl(cr, newUrl);
+                return null;
+            }
+        }.execute();
 
         Intent intent = new Intent(Intent.ACTION_WEB_SEARCH);
         intent.addCategory(Intent.CATEGORY_DEFAULT);
@@ -651,7 +658,14 @@
                     // But currently, we get the user-typed URL from search box as well.
                     url = fixUrl(url);
                     url = smartUrlFilter(url);
-                    Browser.updateVisitedHistory(mResolver, url, false);
+                    final ContentResolver cr = mResolver;
+                    final String newUrl = url;
+                    new AsyncTask<Void, Void, Void>() {
+                        protected Void doInBackground(Void... unused) {
+                            Browser.updateVisitedHistory(cr, newUrl, false);
+                            return null;
+                        }
+                    }.execute();
                     String searchSource = "&source=android-" + GOOGLE_SEARCH_SOURCE_SUGGEST + "&";
                     if (url.contains(searchSource)) {
                         String source = null;