commit b0a86db3bfa39863977efd3bac5c9bf527d224aa
author John Reck <jreck@google.com> Tue May 24 14:05:58 2011 -0700
committer John Reck <jreck@google.com> Tue May 24 14:07:36 2011 -0700
tree 4a74d5feb1ea2c2a3fe9c2c3d7cb0c0db5efe5f5
parent aec5b0930dae41b4d1a0e844dc53c4dd6c66ff07

Useragent switcher tweaks

 Children inherit parent tab's setting
 Setting is now save/restored across kills

Change-Id: I664d2d887281df7b99e8239e3ba41ba540f4bbec

src/com/android/browser/BrowserSettings.java

diff --git a/src/com/android/browser/BrowserSettings.java b/src/com/android/browser/BrowserSettings.java
index dd46314..46d47b0 100644
--- a/src/com/android/browser/BrowserSettings.java
+++ b/src/com/android/browser/BrowserSettings.java
@@ -399,6 +399,9 @@
     }
 
     public void toggleDesktopUseragent(WebView view) {
+        if (view == null) {
+            return;
+        }
         WebSettings settings = view.getSettings();
         if (mCustomUserAgents.get(settings) != null) {
             mCustomUserAgents.remove(settings);

src/com/android/browser/Tab.java

diff --git a/src/com/android/browser/Tab.java b/src/com/android/browser/Tab.java
index e1dd1ca..8962475 100644
--- a/src/com/android/browser/Tab.java
+++ b/src/com/android/browser/Tab.java
@@ -191,6 +191,7 @@
     static final String APPID = "appid";
     static final String INCOGNITO = "privateBrowsingEnabled";
     static final String SCREENSHOT = "screenshot";
+    static final String USERAGENT = "useragent";
 
     // -------------------------------------------------------------------------
 
@@ -1449,6 +1450,12 @@
                 mSavedState.putLong(PARENTTAB, parent.getId());
             }
         }
+
+        // Sync the WebView useragent with the parent
+        if (parent != null && mSettings.hasDesktopUseragent(parent.getWebView())
+                != mSettings.hasDesktopUseragent(getWebView())) {
+            mSettings.toggleDesktopUseragent(getWebView());
+        }
     }
 
     /**
@@ -1739,6 +1746,8 @@
         if (mScreenshot != null) {
             mSavedState.putParcelable(SCREENSHOT, mScreenshot);
         }
+        mSavedState.putBoolean(USERAGENT,
+                mSettings.hasDesktopUseragent(getWebView()));
         return true;
     }
 
@@ -1755,6 +1764,10 @@
         mId = b.getLong(ID);
         mAppId = b.getString(APPID);
         mScreenshot = b.getParcelable(SCREENSHOT);
+        if (b.getBoolean(USERAGENT)
+                != mSettings.hasDesktopUseragent(getWebView())) {
+            mSettings.toggleDesktopUseragent(getWebView());
+        }
 
         final WebBackForwardList list = mMainView.restoreState(b);
         if (list == null) {