commit b17d2ebfb249342541bf3c57ecb60eb81dc82739
author Leon Scroggins <scroggo@google.com> Fri Sep 11 11:12:58 2009 -0400
committer Leon Scroggins <scroggo@google.com> Fri Sep 11 14:21:19 2009 -0400
tree 05bd967f4a8bb586940f2255aa58a340dcecef93
parent 652ff87f0905abd11f2fdb6cb4de7840985a0810

Adjustments for the look of the tab page.

Remove http://; center "New tab"
Use a drawable with a hi dpi version
Add some padding
Add a divider before the close button

Change-Id: I1e7c98e3e03f2a7b3c8df6db1917a604a6309fb8

res/layout/tab_view.xml

diff --git a/res/layout/tab_view.xml b/res/layout/tab_view.xml
index 8f42937..167621e 100644
--- a/res/layout/tab_view.xml
+++ b/res/layout/tab_view.xml
@@ -24,8 +24,8 @@
     <com.android.browser.FakeWebView android:id="@+id/screen_shot"
         android:layout_width="40dip"
         android:layout_height="40dip"
-        android:layout_marginLeft="4dip"
-        android:layout_marginRight="4dip"
+        android:layout_marginLeft="8dip"
+        android:layout_marginRight="8dip"
         />
     <LinearLayout
         android:layout_width="0dip"
@@ -50,11 +50,19 @@
             android:ellipsize="end"
             />
     </LinearLayout>
+    <View android:id="@+id/divider"
+        android:background="#ff313431"
+        android:layout_width="1dip"
+        android:layout_height="fill_parent"
+        android:layout_marginLeft="8dip"
+        android:layout_marginTop="5dip"
+        android:layout_marginBottom="5dip"
+        />
     <ImageView android:id="@+id/close"
-        android:src="@drawable/ic_close_tab"
+        android:src="@drawable/ic_btn_close_panel"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginLeft="4dip"
-        android:layout_marginRight="4dip"
+        android:layout_marginLeft="8dip"
+        android:layout_marginRight="8dip"
         />
 </LinearLayout>

src/com/android/browser/ActiveTabsPage.java

diff --git a/src/com/android/browser/ActiveTabsPage.java b/src/com/android/browser/ActiveTabsPage.java
index c1b402a..9837ad6 100644
--- a/src/com/android/browser/ActiveTabsPage.java
+++ b/src/com/android/browser/ActiveTabsPage.java
@@ -97,6 +97,7 @@
             FakeWebView webView
                     = (FakeWebView) convertView.findViewById(R.id.screen_shot);
             View close = convertView.findViewById(R.id.close);
+            View divider = convertView.findViewById(R.id.divider);
 
             final int tabCount = mControl.getTabCount();
             if (tabCount < TabControl.MAX_TABS) {
@@ -104,15 +105,18 @@
             }
             if (position == -1) {
                 title.setText(R.string.new_tab);
-                url.setText(R.string.http);
+                url.setVisibility(View.GONE);
                 webView.setImageResource(R.drawable.ic_add_tab);
                 close.setVisibility(View.GONE);
+                divider.setVisibility(View.GONE);
             } else {
                 TabControl.Tab tab = mControl.getTab(position);
                 mControl.populatePickerData(tab);
                 title.setText(tab.getTitle());
                 url.setText(tab.getUrl());
+                url.setVisibility(View.VISIBLE);
                 webView.setTab(tab);
+                divider.setVisibility(View.VISIBLE);
                 close.setVisibility(View.VISIBLE);
                 final int closePosition = position;
                 close.setOnClickListener(new View.OnClickListener() {