commit b2f6cce1a0d73c01136968b22d4c5c88ea44cf63
author Pankaj Garg <pgarg@codeaurora.org> Thu Jul 16 15:13:49 2015 -0700
committer jrizzoli <joey@cyanogenmoditalia.it> Fri Aug 28 13:15:46 2015 +0200
tree 6ea2dcd0e9f67c0c2544693efc8abeb4172310cc
parent 7e9d24738169bf376c20e5c4c5411c9c8dacd13e

Fix page scrolling glitches with edge navigation

- When edge navigation was not enabled, it was causing
  page scroll to be non uniform and sometime unresponsive.
  This was caused by the edge navigation settings class.

Change-Id: I30586afd01acb3bfd1170eb4245938d18ecb4236

src/com/android/browser/EdgeSwipeSettings.java

diff --git a/src/com/android/browser/EdgeSwipeSettings.java b/src/com/android/browser/EdgeSwipeSettings.java
index 3425142..71c8a56 100644
--- a/src/com/android/browser/EdgeSwipeSettings.java
+++ b/src/com/android/browser/EdgeSwipeSettings.java
@@ -100,8 +100,6 @@
         closeBtn.setOnClickListener(
             new View.OnClickListener() {
                 public void onClick(View v) {
-                    mbWaitForSettings = false;
-                    mSettingsView.setVisibility(View.GONE);
                     goLive();
                 }
             }
@@ -112,8 +110,6 @@
         temporalNavButton.setOnClickListener(
             new View.OnClickListener() {
                 public void onClick(View v) {
-                    mbWaitForSettings = false;
-                    mSettingsView.setVisibility(View.GONE);
                     BrowserSettings.getInstance().setEdgeSwipeTemporal();
                     goLive();
                     applySettingsAndRefresh(ui, container);
@@ -129,8 +125,6 @@
         spatialNavButton.setOnClickListener(
             new View.OnClickListener() {
                 public void onClick(View v) {
-                    mbWaitForSettings = false;
-                    mSettingsView.setVisibility(View.GONE);
                     BrowserSettings.getInstance().setEdgeSwipeSpatial();
                     goLive();
                     applySettingsAndRefresh(ui, container);
@@ -146,8 +140,6 @@
         disabledNavButton.setOnClickListener(
             new View.OnClickListener() {
                 public void onClick(View v) {
-                    mbWaitForSettings = false;
-                    mSettingsView.setVisibility(View.GONE);
                     BrowserSettings.getInstance().setEdgeSwipeDisabled();
                     goLive();
                     applySettingsAndRefresh(ui, container);
@@ -171,10 +163,12 @@
     }
 
     private void goLive() {
+        mbWaitForSettings = false;
         mFromEdge = ViewDragHelper.EDGE_TOP;
         mLiveView.setVisibility(View.VISIBLE);
         mStationaryView.setVisibility(View.GONE);
         mSlidingViewShadow.setVisibility(View.GONE);
+        mSettingsView.setVisibility(View.GONE);
         mViewGroup.invalidate();
     }
 
@@ -185,7 +179,6 @@
     }
 
     public void onConfigurationChanged() {
-        mSettingsView.setVisibility(View.GONE);
         goLive();
     }
 
@@ -213,7 +206,6 @@
 
     public void onViewDragStateChanged(int state) {
         if (ViewDragHelper.STATE_IDLE == state && !mbWaitForSettings) {
-            mSettingsView.setVisibility(View.GONE);
             goLive();
         }
     }
@@ -309,7 +301,7 @@
     }
 
     public boolean tryCaptureView(View child, int pointerId) {
-        return (child == mSettingsView);
+        return (mFromEdge != ViewDragHelper.EDGE_TOP && child == mSettingsView);
     }
 
     public int clampViewPositionHorizontal(View child, int left, int dx) {