commit c7db091b60913927fef214420a21f1e897772d16
author John Reck <jreck@google.com> Thu Mar 31 14:14:38 2011 -0700
committer John Reck <jreck@google.com> Thu Mar 31 16:22:56 2011 -0700
tree 56da21396c717cdc96de1b1d8e101a260cb230c3
parent a2cedb170d90b564b3234e7fb7e598e8698bb638

DO NOT MERGE Fix widget update listener

 Bug: 4193627
 Just need to expand the lifecycle during which we listen for preference changes
 Specifically, instead of listening between onResume and onPause, listen between
 onCreate and onDestroy since the dialog that sets the preference will cause the
 fragment to receive an onPause.

Change-Id: Ibaa62fc722d74840f159d6023af7ec1543ae4541

src/com/android/browser/preferences/GeneralPreferencesFragment.java

diff --git a/src/com/android/browser/preferences/GeneralPreferencesFragment.java b/src/com/android/browser/preferences/GeneralPreferencesFragment.java
index d64f062..0c63ab5 100644
--- a/src/com/android/browser/preferences/GeneralPreferencesFragment.java
+++ b/src/com/android/browser/preferences/GeneralPreferencesFragment.java
@@ -68,6 +68,8 @@
                 .getString(BrowserSettings.PREF_HOMEPAGE, null));
         ((BrowserHomepagePreference) e).setCurrentPage(
                 getActivity().getIntent().getStringExtra(BrowserPreferencesPage.CURRENT_PAGE));
+        mSharedPrefs = PreferenceManager.getDefaultSharedPreferences(getActivity());
+        mSharedPrefs.registerOnSharedPreferenceChangeListener(mListener);
     }
 
     @Override
@@ -94,13 +96,11 @@
         // Setup the proper state for the sync with chrome item
         mChromeSync = findPreference(PREF_CHROME_SYNC);
         refreshUi();
-        mSharedPrefs = PreferenceManager.getDefaultSharedPreferences(getActivity());
-        mSharedPrefs.registerOnSharedPreferenceChangeListener(mListener);
     }
 
     @Override
-    public void onPause() {
-        super.onPause();
+    public void onDestroy() {
+        super.onDestroy();
 
         mSharedPrefs.unregisterOnSharedPreferenceChangeListener(mListener);
     }