commit c928c30a51eee84b40cb7045842c288c1cfafff0
author Grace Kloba <klobag@google.com> Thu Sep 17 11:51:21 2009 -0700
committer Grace Kloba <klobag@google.com> Thu Sep 17 13:11:16 2009 -0700
tree d0e980834963b0b1b4d54c57465967b3e71e3e4c
parent 8f0076b720c9ee1e9ef9d29910c261634fd5fb25

This tries to address a potential Browser CPU spinning
problem. 

Fix http://b/issue?id=2127825

src/com/android/browser/BrowserActivity.java

diff --git a/src/com/android/browser/BrowserActivity.java b/src/com/android/browser/BrowserActivity.java
index 42bc1ab..1801b52 100644
--- a/src/com/android/browser/BrowserActivity.java
+++ b/src/com/android/browser/BrowserActivity.java
@@ -1758,6 +1758,7 @@
     }
 
     // Attach the given tab to the content view.
+    // this should only be called for the current tab.
     private void attachTabToContentView(TabControl.Tab t) {
         // Attach the container that contains the main WebView and any other UI
         // associated with the tab.
@@ -1776,9 +1777,12 @@
                                                   ViewGroup.LayoutParams.WRAP_CONTENT));
         }
 
-        if (t == mTabControl.getCurrentTab()) {
-            setLockIconType(t.getLockIconType());
-            setPrevLockType(t.getPrevLockIconType());
+        setLockIconType(t.getLockIconType());
+        setPrevLockType(t.getPrevLockIconType());
+
+        // this is to match the code in removeTabFromContentView()
+        if (!mPageStarted && t.getTopWindow().getProgress() < 100) {
+            mPageStarted = true;
         }
 
         WebView view = t.getWebView();
@@ -1807,9 +1811,21 @@
             view.setEmbeddedTitleBar(null);
         }
 
+        // unlike attachTabToContentView(), removeTabFromContentView() can be
+        // called for the non-current tab. Need to add the check.
         if (t == mTabControl.getCurrentTab()) {
             t.setLockIconType(getLockIconType());
             t.setPrevLockIconType(getPrevLockType());
+
+            // this is not a perfect solution. But currently there is one
+            // WebViewClient for all the WebView. if user switches from an
+            // in-load window to an already loaded window, mPageStarted will not
+            // be set to false. If user leaves the Browser, pauseWebViewTimers()
+            // won't do anything and leaves the timer running even Browser is in
+            // the background.
+            if (mPageStarted) {
+                mPageStarted = false;
+            }
         }
     }