commit cd424e99aa19d00933e6540a95805042659f596f
author Michael Kolb <kolby@google.com> Thu Feb 24 10:26:26 2011 -0800
committer Michael Kolb <kolby@google.com> Thu Feb 24 10:26:37 2011 -0800
tree a309af675fc2af2a8a2bb5ceca14e5692dfcc74c
parent 29ccf8a32bf65a5512191d3633353132bb2cd88b

fix NPEs after delayed start

    Bug: 3476031
    Bug: 3480829
    add check for valid tab

Change-Id: I4430ba2f369125fe263599aa5c8b3460bf6e7ffa

src/com/android/browser/Controller.java

diff --git a/src/com/android/browser/Controller.java b/src/com/android/browser/Controller.java
index 8ca151a..da98a1c 100644
--- a/src/com/android/browser/Controller.java
+++ b/src/com/android/browser/Controller.java
@@ -317,7 +317,10 @@
             if (urlData.isEmpty()) {
                 loadUrl(webView, mSettings.getHomePage());
             } else {
-                loadUrlDataIn(t, urlData);
+                // monkey protection against delayed start
+                if (t != null) {
+                    loadUrlDataIn(t, urlData);
+                }
             }
         } else {
             mTabControl.restoreState(icicle, currentTab, restoreIncognitoTabs,
@@ -2088,9 +2091,12 @@
     }
 
     protected void setActiveTab(Tab tab) {
-        mTabControl.setCurrentTab(tab);
-        // the tab is guaranteed to have a webview after setCurrentTab
-        mUi.setActiveTab(tab);
+        // monkey protection against delayed start
+        if (tab != null) {
+            mTabControl.setCurrentTab(tab);
+            // the tab is guaranteed to have a webview after setCurrentTab
+            mUi.setActiveTab(tab);
+        }
     }
 
     protected void closeEmptyChildTab() {