Titlebar auto hide fixes.
- Remove setTranslationY on webview during scroll.
- Use WebView API setFullscreen when Tab goes to
fullscreen mode.
Change-Id: I33960cec02ade01ddacad719298ea53a4723145b
diff --git a/src/com/android/browser/Tab.java b/src/com/android/browser/Tab.java
index d0a27b9..fab2ec0 100644
--- a/src/com/android/browser/Tab.java
+++ b/src/com/android/browser/Tab.java
@@ -201,6 +201,7 @@
private Handler mHandler;
private boolean mUpdateThumbnail;
private Timestamp timestamp;
+ private boolean mFullScreen = false;
/**
* See {@link #clearBackStackWhenItemAdded(String)}.
@@ -724,6 +725,13 @@
mCurrentState.mIncognito = view.isPrivateBrowsingEnabled();
}
+ protected void setTabFullscreen(boolean fullScreen) {
+ if (mMainView != null) {
+ mFullScreen = fullScreen;
+ mMainView.setFullScreen(fullScreen);
+ }
+ }
+
// -------------------------------------------------------------------------
// WebChromeClient implementation for the main WebView
// -------------------------------------------------------------------------
@@ -749,7 +757,8 @@
public void toggleFullscreenModeForTab(boolean enterFullscreen) {
if (mWebViewController instanceof Controller) {
Controller controller = (Controller)mWebViewController;
- controller.getUi().setTabFullscreen(enterFullscreen);
+ controller.getUi().setFullscreen(enterFullscreen);
+ setTabFullscreen(enterFullscreen);
}
}
@@ -760,19 +769,13 @@
mContext.getResources().getBoolean(R.bool.hide_title_on_scroll);
if (mWebViewController instanceof Controller && hide_title_on_scroll) {
Controller controller = (Controller)mWebViewController;
- mMainView.setTranslationY(contentOffsetYPix);
controller.getUi().transalateTitleBar(topControlsOffsetYPix);
}
}
@Override
public boolean isTabFullScreen() {
- if (mWebViewController instanceof Controller) {
- Controller controller = (Controller)mWebViewController;
- return controller.getUi().isTabFullScreen();
- } else {
- return false;
- }
+ return mFullScreen;
}
@Override
@@ -1404,6 +1407,10 @@
}
}
+ public boolean isTabFullScreen() {
+ return mFullScreen;
+ }
+
/**
* Destroy the tab's main WebView and subWindow if any
*/