commit 56023ad2c6b9d9565adcbec854d16bccbe947fa4
author Joe Onorato <joeo@android.com> Wed Sep 01 21:18:22 2010 -0700
committer Joe Onorato <joeo@android.com> Wed Sep 01 21:18:22 2010 -0700
tree 95725643b7d4ba92321d6293a7a103e99289355a
parent 329e04abc866ee246d0f53e57bfbdbda6a4800e1

Revert "Changed ConnectivityService#getServiceInstance so its a singleton."

This reverts commit 7323ea10cd029e0f3bcbcc1679e9b7314aa04328 which causes this exception:

E/SystemServer( 2653): Failure starting Connectivity Service
E/SystemServer( 2653): java.lang.IllegalMonitorStateException: object not locked by thread before wait()
E/SystemServer( 2653):  at java.lang.Object.wait(Native Method)
E/SystemServer( 2653):  at java.lang.Object.wait(Object.java:358)
E/SystemServer( 2653):  at com.android.server.ConnectivityService$ConnectivityThread.getServiceInstance(ConnectivityService.java:186)
E/SystemServer( 2653):  at com.android.server.ConnectivityService.getInstance(ConnectivityService.java:200)
E/SystemServer( 2653):  at com.android.server.ServerThread.run(SystemServer.java:262)

Change-Id: Idd139e426e61a1913b0bf343e2f0a0b1990ba8bb

services/java/com/android/server/ConnectivityService.java

diff --git a/services/java/com/android/server/ConnectivityService.java b/services/java/com/android/server/ConnectivityService.java
index 54ff69f..c28a373 100644
--- a/services/java/com/android/server/ConnectivityService.java
+++ b/services/java/com/android/server/ConnectivityService.java
@@ -105,7 +105,7 @@
     private int mNumDnsEntries;
 
     private boolean mTestMode;
-    private static volatile ConnectivityService sServiceInstance;
+    private static ConnectivityService sServiceInstance;
 
     private Handler mHandler;
 
@@ -176,10 +176,11 @@
             Looper.loop();
         }
 
-        public static synchronized ConnectivityService getServiceInstance(Context context) {
-            if (sServiceInstance == null) {
-                ConnectivityThread thread = new ConnectivityThread(context);
-                thread.start();
+        public static ConnectivityService getServiceInstance(Context context) {
+            ConnectivityThread thread = new ConnectivityThread(context);
+            thread.start();
+
+            synchronized (thread) {
                 while (sServiceInstance == null) {
                     try {
                         // Wait until sServiceInstance has been initialized.