commit 6a095dfa6bd2000f650308cdfa5a69e2635c02ec
author Lorenzo Colitti <lorenzo@google.com> Wed Apr 10 23:22:30 2019 +0900
committer Lorenzo Colitti <lorenzo@google.com> Wed Apr 10 23:50:39 2019 +0900
tree 0a8afeddec201ee6f1b47629cd6bdaefad13b8ca
parent 60bce378cfa29463f57756fc724d1572747f4fc5

Enable clang-tidy for clatd.

Enable the same warnings used elsewhere in the tree, and fix two
warnings it found (a safe use of strcpy, and a missing O_CLOEXEC
when opening the tun device node.

Test: builds, boots, clatd works
Test: m clatd clatd_test clatd_microbenchmark && atest clatd_test
Change-Id: I9a5ea4de5f31d3c495871250a6493b07535a604b

clatd.c

diff --git a/clatd.c b/clatd.c
index 06ca799..d68dc05 100644
--- a/clatd.c
+++ b/clatd.c
@@ -381,7 +381,7 @@
     logmsg(ANDROID_LOG_WARN, "ipv4mtu now set to = %d", Global_Clatd_Config.ipv4mtu);
   }
 
-  error = tun_alloc(tunnel->device4, tunnel->fd4);
+  error = tun_alloc(tunnel->device4, tunnel->fd4, sizeof(tunnel->device4));
   if (error < 0) {
     logmsg(ANDROID_LOG_FATAL, "tun_alloc/4 failed: %s", strerror(errno));
     exit(1);