Fix all our unused parameter warnings so we let GCC report them.
There were a couple of genuine bugs here (fixed), plus there's a missing
feature in trace.cc that I've just added a TODO for.
Also note that I haven't touched the compilers; this warning is still
explicitly disabled for that code. I'll do that when there's less going
on in those directories.
Change-Id: Ic3570bf82411a07c7530bfaf1995ac995b9fc00f
diff --git a/src/dex_verifier_test.cc b/src/dex_verifier_test.cc
index 9106b76..fba1d34 100644
--- a/src/dex_verifier_test.cc
+++ b/src/dex_verifier_test.cc
@@ -28,7 +28,7 @@
class DexVerifierTest : public CommonTest {
protected:
- void VerifyClass(ClassLoader* class_loader, const std::string& descriptor) {
+ void VerifyClass(const std::string& descriptor) {
ASSERT_TRUE(descriptor != NULL);
Class* klass = class_linker_->FindSystemClass(descriptor.c_str());
@@ -37,20 +37,20 @@
ASSERT_TRUE(DexVerifier::VerifyClass(klass, error_msg)) << error_msg;
}
- void VerifyDexFile(const DexFile* dex, ClassLoader* class_loader) {
+ void VerifyDexFile(const DexFile* dex) {
ASSERT_TRUE(dex != NULL);
// Verify all the classes defined in this file
for (size_t i = 0; i < dex->NumClassDefs(); i++) {
const DexFile::ClassDef& class_def = dex->GetClassDef(i);
const char* descriptor = dex->GetClassDescriptor(class_def);
- VerifyClass(class_loader, descriptor);
+ VerifyClass(descriptor);
}
}
};
TEST_F(DexVerifierTest, LibCore) {
- VerifyDexFile(java_lang_dex_file_, NULL);
+ VerifyDexFile(java_lang_dex_file_);
}
TEST_F(DexVerifierTest, IntMath) {