Fix detaching a debugger while threads are suspended.
The interesting part of this change is in "thread_list.cc".
I've done a TODO in TagFromClass, but haven't seen it make any practical
difference in a debugger. I also tightened up the types in GetThreadStatus
while investigating the fact that we report some threads as "RUNNING, SUSPENDED",
which makes no sense until you realize that TS_RUNNING corresponds to both
our kRunnable thread state and our kNative thread state, the latter of which
may actually be a suspended thread.
I've also made us fail faster in the "address in use" jdwp failure case,
and tidied up a bunch of the capitalization in logging.
Change-Id: I0fe705791d07db31c4615addce44da4fdfbfd0d1
diff --git a/src/check_jni.cc b/src/check_jni.cc
index 570e937..423bc2f 100644
--- a/src/check_jni.cc
+++ b/src/check_jni.cc
@@ -555,7 +555,7 @@
va_arg(ap, long); // Skip this argument.
} else if (ch == '.') {
} else {
- LOG(FATAL) << "unknown check format specifier: " << ch;
+ LOG(FATAL) << "Unknown check format specifier: " << ch;
}
}
va_end(ap);
@@ -718,7 +718,7 @@
}
break;
default:
- LOG(FATAL) << "bad flags (internal error): " << flags;
+ LOG(FATAL) << "Bad flags (internal error): " << flags;
}
/*