| commit | 7cd01f5d496c384874ea8c21eafb2b6479833e6a | [log] [tgz] |
|---|---|---|
| author | Vladimir Marko <vmarko@google.com> | Mon Oct 13 18:29:44 2014 +0100 |
| committer | Vladimir Marko <vmarko@google.com> | Mon Oct 13 18:29:44 2014 +0100 |
| tree | 14850b67072afaa67273c1e9e9b75e8c9c898421 | |
| parent | 72ab3cadce5002163783d7b76781b9f26413b773 [diff] [blame] |
Add regression test for null check elimination.
Prompted by
https://android-review.googlesource.com/110090
Bug: 17969907
Change-Id: I938c27cda0681b9431d69baf4eafa7ca2f9b5c9c
diff --git a/compiler/dex/mir_optimization.cc b/compiler/dex/mir_optimization.cc index 2ac0b51..84c056d 100644 --- a/compiler/dex/mir_optimization.cc +++ b/compiler/dex/mir_optimization.cc
@@ -929,6 +929,8 @@ mir->optimization_flags |= MIR_IGNORE_NULL_CHECK; } else { // Do the null check. + // TODO: Rewrite the pass to converge first before doing any modifications so that + // we don't lose the MIR_IGNORE_NULL_CHECK here if previously set by some other pass. mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK; // Mark s_reg as null-checked ssa_regs_to_check->ClearBit(src_sreg);