commit 98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98
author Andreas Gampe <agampe@google.com> Fri Oct 19 14:06:15 2018 -0700
committer Andreas Gampe <agampe@google.com> Tue Oct 23 15:19:55 2018 -0700
tree a848b7e41ff227a2d3d4d6795ec11089f39cb6ca
parent 02338775e33b553be51d44ff60bb1ef8e527bd94

ART: Refactor for bugprone-argument-comment

Handles runtime.

Bug: 116054210
Test: WITH_TIDY=1 mmma art
Change-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0

runtime/quick_exception_handler.cc

diff --git a/runtime/quick_exception_handler.cc b/runtime/quick_exception_handler.cc
index 36a6b7f..afdfefa 100644
--- a/runtime/quick_exception_handler.cc
+++ b/runtime/quick_exception_handler.cc
@@ -126,7 +126,7 @@
         exception_handler_->SetHandlerDexPc(found_dex_pc);
         exception_handler_->SetHandlerQuickFramePc(
             GetCurrentOatQuickMethodHeader()->ToNativeQuickPc(
-                method, found_dex_pc, /* is_catch_handler */ true));
+                method, found_dex_pc, /* is_for_catch_handler= */ true));
         exception_handler_->SetHandlerQuickFrame(GetCurrentQuickFrame());
         exception_handler_->SetHandlerMethodHeader(GetCurrentOatQuickMethodHeader());
         return false;  // End stack walk.
@@ -218,7 +218,10 @@
     }
 
     // Walk the stack to find catch handler.
-    CatchBlockStackVisitor visitor(self_, context_, &exception_ref, this, /*skip*/already_popped);
+    CatchBlockStackVisitor visitor(self_, context_,
+                                   &exception_ref,
+                                   this,
+                                   /*skip_frames=*/already_popped);
     visitor.WalkStack(true);
     uint32_t new_pop_count = handler_frame_depth_;
     DCHECK_GE(new_pop_count, already_popped);
@@ -606,7 +609,7 @@
               << deopt_method->PrettyMethod()
               << " due to "
               << GetDeoptimizationKindName(kind);
-    DumpFramesWithType(self_, /* details */ true);
+    DumpFramesWithType(self_, /* details= */ true);
   }
   if (Runtime::Current()->UseJitCompilation()) {
     Runtime::Current()->GetJit()->GetCodeCache()->InvalidateCompiledCodeFor(