commit d59c70627cc42878cc30b46bd29ff497b4483b22
author Aart Bik <ajcbik@google.com> Sat Nov 21 05:21:52 2015 +0000
committer Aart Bik <ajcbik@google.com> Sat Nov 21 05:21:52 2015 +0000
tree b0b7013ea78b10f23fae75ef145e53a696ff797c
parent 0b5849be045c5683d4a6b6b6c306abadba5f0fcc

Revert "Dynamic BCE (based on induction range analysis)"

This reverts commit 0b5849be045c5683d4a6b6b6c306abadba5f0fcc.


Change-Id: Id33f5da42bbdfb1aff7e2281417c8a7aa492df05
Rationale: so close :-( but bullhead-userdebug (linux) build in git_mnc-dr-dev-plus-aosp reported a breakage with a type inconsistency (long vs int in probably the codegen of dynamic bce); no time to investigate and fix this fully before my trip, so rolling back for now

compiler/optimizing/graph_checker.cc

diff --git a/compiler/optimizing/graph_checker.cc b/compiler/optimizing/graph_checker.cc
index b3b09d2..5814d75 100644
--- a/compiler/optimizing/graph_checker.cc
+++ b/compiler/optimizing/graph_checker.cc
@@ -735,29 +735,26 @@
     }
   }
 
-  // Test phi equivalents. There should not be two of the same type and they should only be
-  // created for constants which were untyped in DEX. Note that this test can be skipped for
-  // a synthetic phi (indicated by lack of a virtual register).
-  if (phi->GetRegNumber() != kNoRegNumber) {
-    for (HInstructionIterator phi_it(phi->GetBlock()->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
-      HPhi* other_phi = phi_it.Current()->AsPhi();
-      if (phi != other_phi && phi->GetRegNumber() == other_phi->GetRegNumber()) {
-        if (phi->GetType() == other_phi->GetType()) {
-          std::stringstream type_str;
-          type_str << phi->GetType();
-          AddError(StringPrintf("Equivalent phi (%d) found for VReg %d with type: %s.",
+  // Test phi equivalents. There should not be two of the same type and they
+  // should only be created for constants which were untyped in DEX.
+  for (HInstructionIterator phi_it(phi->GetBlock()->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
+    HPhi* other_phi = phi_it.Current()->AsPhi();
+    if (phi != other_phi && phi->GetRegNumber() == other_phi->GetRegNumber()) {
+      if (phi->GetType() == other_phi->GetType()) {
+        std::stringstream type_str;
+        type_str << phi->GetType();
+        AddError(StringPrintf("Equivalent phi (%d) found for VReg %d with type: %s.",
+                              phi->GetId(),
+                              phi->GetRegNumber(),
+                              type_str.str().c_str()));
+      } else {
+        ArenaBitVector visited(GetGraph()->GetArena(), 0, /* expandable */ true);
+        if (!IsConstantEquivalent(phi, other_phi, &visited)) {
+          AddError(StringPrintf("Two phis (%d and %d) found for VReg %d but they "
+                                "are not equivalents of constants.",
                                 phi->GetId(),
-                                phi->GetRegNumber(),
-                                type_str.str().c_str()));
-        } else {
-          ArenaBitVector visited(GetGraph()->GetArena(), 0, /* expandable */ true);
-          if (!IsConstantEquivalent(phi, other_phi, &visited)) {
-            AddError(StringPrintf("Two phis (%d and %d) found for VReg %d but they "
-                                  "are not equivalents of constants.",
-                                  phi->GetId(),
-                                  other_phi->GetId(),
-                                  phi->GetRegNumber()));
-          }
+                                other_phi->GetId(),
+                                phi->GetRegNumber()));
         }
       }
     }