blob: 95530be20267947588727300854d05c9e508910f [file] [log] [blame]
Elliott Hughes2faa5f12012-01-30 14:42:07 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Carl Shapiro69759ea2011-07-21 18:13:35 -070016
Brian Carlstrom578bbdc2011-07-21 14:07:47 -070017#include "mark_sweep.h"
Carl Shapiro69759ea2011-07-21 18:13:35 -070018
Mathieu Chartier2b82db42012-11-14 17:29:05 -080019#include <functional>
20#include <numeric>
Carl Shapiro58551df2011-07-24 03:09:51 -070021#include <climits>
22#include <vector>
23
Mathieu Chartier94c32c52013-08-09 11:14:04 -070024#include "base/bounded_fifo.h"
Elliott Hughes07ed66b2012-12-12 18:34:25 -080025#include "base/logging.h"
Elliott Hughes76160052012-12-12 16:31:20 -080026#include "base/macros.h"
Ian Rogers693ff612013-02-01 10:56:12 -080027#include "base/mutex-inl.h"
Sameer Abu Asala8439542013-02-14 16:06:42 -080028#include "base/timing_logger.h"
Ian Rogers1d54e732013-05-02 21:10:01 -070029#include "gc/accounting/card_table-inl.h"
Mathieu Chartier4aeec172014-03-27 16:09:46 -070030#include "gc/accounting/heap_bitmap-inl.h"
Mathieu Chartier11409ae2013-09-23 11:49:36 -070031#include "gc/accounting/mod_union_table.h"
Ian Rogers1d54e732013-05-02 21:10:01 -070032#include "gc/accounting/space_bitmap-inl.h"
33#include "gc/heap.h"
Mathieu Chartier78f7b4c2014-05-06 10:57:27 -070034#include "gc/reference_processor.h"
Ian Rogers1d54e732013-05-02 21:10:01 -070035#include "gc/space/image_space.h"
36#include "gc/space/large_object_space.h"
37#include "gc/space/space-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080038#include "mark_sweep-inl.h"
Brian Carlstromea46f952013-07-30 01:26:50 -070039#include "mirror/art_field-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080040#include "mirror/object-inl.h"
Brian Carlstrom1f870082011-08-23 16:02:11 -070041#include "runtime.h"
Mathieu Chartier4aeec172014-03-27 16:09:46 -070042#include "scoped_thread_state_change.h"
Ian Rogers1d54e732013-05-02 21:10:01 -070043#include "thread-inl.h"
Mathieu Chartier6f1c9492012-10-15 12:08:41 -070044#include "thread_list.h"
Carl Shapiro69759ea2011-07-21 18:13:35 -070045
Brian Carlstrom3e3d5912013-07-18 00:19:45 -070046using ::art::mirror::Object;
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080047
Carl Shapiro69759ea2011-07-21 18:13:35 -070048namespace art {
Ian Rogers1d54e732013-05-02 21:10:01 -070049namespace gc {
50namespace collector {
Carl Shapiro69759ea2011-07-21 18:13:35 -070051
Mathieu Chartier02b6a782012-10-26 13:51:26 -070052// Performance options.
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -080053static constexpr bool kUseRecursiveMark = false;
54static constexpr bool kUseMarkStackPrefetch = true;
55static constexpr size_t kSweepArrayChunkFreeSize = 1024;
56static constexpr bool kPreCleanCards = true;
Mathieu Chartier94c32c52013-08-09 11:14:04 -070057
58// Parallelism options.
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -080059static constexpr bool kParallelCardScan = true;
60static constexpr bool kParallelRecursiveMark = true;
Mathieu Chartier94c32c52013-08-09 11:14:04 -070061// Don't attempt to parallelize mark stack processing unless the mark stack is at least n
62// elements. This is temporary until we reduce the overhead caused by allocating tasks, etc.. Not
63// having this can add overhead in ProcessReferences since we may end up doing many calls of
64// ProcessMarkStack with very small mark stacks.
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -080065static constexpr size_t kMinimumParallelMarkStackSize = 128;
66static constexpr bool kParallelProcessMarkStack = true;
Mathieu Chartier858f1c52012-10-17 17:45:55 -070067
Mathieu Chartier02b6a782012-10-26 13:51:26 -070068// Profiling and information flags.
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -080069static constexpr bool kProfileLargeObjects = false;
70static constexpr bool kMeasureOverhead = false;
71static constexpr bool kCountTasks = false;
72static constexpr bool kCountJavaLangRefs = false;
Mathieu Chartier0e54cd02014-03-20 12:41:23 -070073static constexpr bool kCountMarkedObjects = false;
Mathieu Chartier94c32c52013-08-09 11:14:04 -070074
75// Turn off kCheckLocks when profiling the GC since it slows the GC down by up to 40%.
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -080076static constexpr bool kCheckLocks = kDebugLocking;
Mathieu Chartier7bf9f192014-04-04 11:09:41 -070077static constexpr bool kVerifyRootsMarked = kIsDebugBuild;
Mathieu Chartier02b6a782012-10-26 13:51:26 -070078
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -070079// If true, revoke the rosalloc thread-local buffers at the
80// checkpoint, as opposed to during the pause.
81static constexpr bool kRevokeRosAllocThreadLocalBuffersAtCheckpoint = true;
82
Mathieu Chartier2b82db42012-11-14 17:29:05 -080083void MarkSweep::BindBitmaps() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -070084 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier2b82db42012-11-14 17:29:05 -080085 WriterMutexLock mu(Thread::Current(), *Locks::heap_bitmap_lock_);
Mathieu Chartier2b82db42012-11-14 17:29:05 -080086 // Mark all of the spaces we never collect as immune.
Mathieu Chartier94c32c52013-08-09 11:14:04 -070087 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Ian Rogers1d54e732013-05-02 21:10:01 -070088 if (space->GetGcRetentionPolicy() == space::kGcRetentionPolicyNeverCollect) {
Mathieu Chartier8d562102014-03-12 17:42:10 -070089 CHECK(immune_region_.AddContinuousSpace(space)) << "Failed to add space " << *space;
Mathieu Chartier2b82db42012-11-14 17:29:05 -080090 }
91 }
92}
93
Ian Rogers1d54e732013-05-02 21:10:01 -070094MarkSweep::MarkSweep(Heap* heap, bool is_concurrent, const std::string& name_prefix)
95 : GarbageCollector(heap,
Mathieu Chartier590fee92013-09-13 13:46:47 -070096 name_prefix +
Ian Rogers1d54e732013-05-02 21:10:01 -070097 (is_concurrent ? "concurrent mark sweep": "mark sweep")),
Ian Rogers3e5cf302014-05-20 16:40:37 -070098 current_space_bitmap_(nullptr), mark_bitmap_(nullptr), mark_stack_(nullptr),
Mathieu Chartier2b82db42012-11-14 17:29:05 -080099 gc_barrier_(new Barrier(0)),
Mathieu Chartier958291c2013-08-27 18:14:55 -0700100 mark_stack_lock_("mark sweep mark stack lock", kMarkSweepMarkStackLock),
Ian Rogers3e5cf302014-05-20 16:40:37 -0700101 is_concurrent_(is_concurrent), live_stack_freeze_size_(0) {
Hiroshi Yamauchibbdc5bc2014-05-28 14:04:59 -0700102 std::string error_msg;
103 MemMap* mem_map = MemMap::MapAnonymous(
104 "mark sweep sweep array free buffer", nullptr,
105 RoundUp(kSweepArrayChunkFreeSize * sizeof(mirror::Object*), kPageSize),
106 PROT_READ | PROT_WRITE, false, &error_msg);
107 CHECK(mem_map != nullptr) << "Couldn't allocate sweep array free buffer: " << error_msg;
108 sweep_array_free_buffer_mem_map_.reset(mem_map);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800109}
110
111void MarkSweep::InitializePhase() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700112 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700113 mark_stack_ = heap_->GetMarkStack();
Mathieu Chartiere53225c2013-08-19 10:59:11 -0700114 DCHECK(mark_stack_ != nullptr);
Mathieu Chartier8d562102014-03-12 17:42:10 -0700115 immune_region_.Reset();
Ian Rogers3e5cf302014-05-20 16:40:37 -0700116 class_count_.StoreRelaxed(0);
117 array_count_.StoreRelaxed(0);
118 other_count_.StoreRelaxed(0);
119 large_object_test_.StoreRelaxed(0);
120 large_object_mark_.StoreRelaxed(0);
121 overhead_time_ .StoreRelaxed(0);
122 work_chunks_created_.StoreRelaxed(0);
123 work_chunks_deleted_.StoreRelaxed(0);
124 reference_count_.StoreRelaxed(0);
125 mark_null_count_.StoreRelaxed(0);
126 mark_immune_count_.StoreRelaxed(0);
127 mark_fastpath_count_.StoreRelaxed(0);
128 mark_slowpath_count_.StoreRelaxed(0);
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700129 {
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700130 // TODO: I don't think we should need heap bitmap lock to Get the mark bitmap.
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700131 ReaderMutexLock mu(Thread::Current(), *Locks::heap_bitmap_lock_);
132 mark_bitmap_ = heap_->GetMarkBitmap();
133 }
Mathieu Chartier10fb83a2014-06-15 15:15:43 -0700134 if (!GetCurrentIteration()->GetClearSoftReferences()) {
Hiroshi Yamauchidf386c52014-04-08 16:21:52 -0700135 // Always clear soft references if a non-sticky collection.
Mathieu Chartier10fb83a2014-06-15 15:15:43 -0700136 GetCurrentIteration()->SetClearSoftReferences(GetGcType() != collector::kGcTypeSticky);
Hiroshi Yamauchidf386c52014-04-08 16:21:52 -0700137 }
Mathieu Chartier6f365cc2014-04-23 12:42:27 -0700138}
139
140void MarkSweep::RunPhases() {
141 Thread* self = Thread::Current();
142 InitializePhase();
143 Locks::mutator_lock_->AssertNotHeld(self);
144 if (IsConcurrent()) {
145 GetHeap()->PreGcVerification(this);
146 {
147 ReaderMutexLock mu(self, *Locks::mutator_lock_);
148 MarkingPhase();
149 }
150 ScopedPause pause(this);
151 GetHeap()->PrePauseRosAllocVerification(this);
152 PausePhase();
153 RevokeAllThreadLocalBuffers();
154 } else {
155 ScopedPause pause(this);
156 GetHeap()->PreGcVerificationPaused(this);
157 MarkingPhase();
158 GetHeap()->PrePauseRosAllocVerification(this);
159 PausePhase();
160 RevokeAllThreadLocalBuffers();
161 }
162 {
163 // Sweeping always done concurrently, even for non concurrent mark sweep.
164 ReaderMutexLock mu(self, *Locks::mutator_lock_);
165 ReclaimPhase();
166 }
167 GetHeap()->PostGcVerification(this);
168 FinishPhase();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800169}
170
171void MarkSweep::ProcessReferences(Thread* self) {
Mathieu Chartier8e56c7e2012-11-20 13:25:50 -0800172 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier78f7b4c2014-05-06 10:57:27 -0700173 GetHeap()->GetReferenceProcessor()->ProcessReferences(
Mathieu Chartier10fb83a2014-06-15 15:15:43 -0700174 true, GetTimings(), GetCurrentIteration()->GetClearSoftReferences(),
175 &HeapReferenceMarkedCallback, &MarkObjectCallback, &ProcessMarkStackCallback, this);
Mathieu Chartier1ad27842014-03-19 17:08:17 -0700176}
177
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700178void MarkSweep::PausePhase() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700179 TimingLogger::ScopedTiming t("(Paused)PausePhase", GetTimings());
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800180 Thread* self = Thread::Current();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800181 Locks::mutator_lock_->AssertExclusiveHeld(self);
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700182 if (IsConcurrent()) {
183 // Handle the dirty objects if we are a concurrent GC.
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800184 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800185 // Re-mark root set.
186 ReMarkRoots();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800187 // Scan dirty objects, this is only required if we are not doing concurrent GC.
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700188 RecursiveMarkDirtyObjects(true, accounting::CardTable::kCardDirty);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800189 }
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700190 {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700191 TimingLogger::ScopedTiming t2("SwapStacks", GetTimings());
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800192 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700193 heap_->SwapStacks(self);
194 live_stack_freeze_size_ = heap_->GetLiveStack()->Size();
195 // Need to revoke all the thread local allocation stacks since we just swapped the allocation
196 // stacks and don't want anybody to allocate into the live stack.
Mathieu Chartierc22c59e2014-02-24 15:16:06 -0800197 RevokeAllThreadLocalAllocationStacks(self);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800198 }
Mathieu Chartier0f72e412013-09-06 16:40:01 -0700199 heap_->PreSweepingGcVerification(this);
Mathieu Chartier6f365cc2014-04-23 12:42:27 -0700200 // Disallow new system weaks to prevent a race which occurs when someone adds a new system
201 // weak before we sweep them. Since this new system weak may not be marked, the GC may
202 // incorrectly sweep it. This also fixes a race where interning may attempt to return a strong
203 // reference to a string that is about to be swept.
204 Runtime::Current()->DisallowNewSystemWeaks();
Mathieu Chartier78f7b4c2014-05-06 10:57:27 -0700205 // Enable the reference processing slow path, needs to be done with mutators paused since there
206 // is no lock in the GetReferent fast path.
207 GetHeap()->GetReferenceProcessor()->EnableSlowPath();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800208}
209
Mathieu Chartierdda54f52014-02-24 09:58:40 -0800210void MarkSweep::PreCleanCards() {
211 // Don't do this for non concurrent GCs since they don't have any dirty cards.
212 if (kPreCleanCards && IsConcurrent()) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700213 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartierdda54f52014-02-24 09:58:40 -0800214 Thread* self = Thread::Current();
215 CHECK(!Locks::mutator_lock_->IsExclusiveHeld(self));
216 // Process dirty cards and add dirty cards to mod union tables, also ages cards.
Mathieu Chartier10fb83a2014-06-15 15:15:43 -0700217 heap_->ProcessCards(GetTimings(), false);
Mathieu Chartiereb7bbad2014-02-25 15:52:46 -0800218 // The checkpoint root marking is required to avoid a race condition which occurs if the
219 // following happens during a reference write:
220 // 1. mutator dirties the card (write barrier)
221 // 2. GC ages the card (the above ProcessCards call)
222 // 3. GC scans the object (the RecursiveMarkDirtyObjects call below)
223 // 4. mutator writes the value (corresponding to the write barrier in 1.)
224 // This causes the GC to age the card but not necessarily mark the reference which the mutator
225 // wrote into the object stored in the card.
226 // Having the checkpoint fixes this issue since it ensures that the card mark and the
227 // reference write are visible to the GC before the card is scanned (this is due to locks being
228 // acquired / released in the checkpoint code).
229 // The other roots are also marked to help reduce the pause.
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700230 MarkRootsCheckpoint(self, false);
Mathieu Chartierdda54f52014-02-24 09:58:40 -0800231 MarkNonThreadRoots();
Mathieu Chartier893263b2014-03-04 11:07:42 -0800232 MarkConcurrentRoots(
233 static_cast<VisitRootFlags>(kVisitRootFlagClearRootLog | kVisitRootFlagNewRoots));
Mathieu Chartierdda54f52014-02-24 09:58:40 -0800234 // Process the newly aged cards.
235 RecursiveMarkDirtyObjects(false, accounting::CardTable::kCardDirty - 1);
236 // TODO: Empty allocation stack to reduce the number of objects we need to test / mark as live
237 // in the next GC.
238 }
239}
240
Mathieu Chartierc22c59e2014-02-24 15:16:06 -0800241void MarkSweep::RevokeAllThreadLocalAllocationStacks(Thread* self) {
242 if (kUseThreadLocalAllocationStack) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700243 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartierc22c59e2014-02-24 15:16:06 -0800244 Locks::mutator_lock_->AssertExclusiveHeld(self);
245 heap_->RevokeAllThreadLocalAllocationStacks(self);
246 }
247}
248
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800249void MarkSweep::MarkingPhase() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700250 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800251 Thread* self = Thread::Current();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800252 BindBitmaps();
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700253 FindDefaultSpaceBitmap();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800254 // Process dirty cards and add dirty cards to mod union tables.
Mathieu Chartier10fb83a2014-06-15 15:15:43 -0700255 heap_->ProcessCards(GetTimings(), false);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800256 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier893263b2014-03-04 11:07:42 -0800257 MarkRoots(self);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800258 MarkReachableObjects();
Mathieu Chartierdda54f52014-02-24 09:58:40 -0800259 // Pre-clean dirtied cards to reduce pauses.
260 PreCleanCards();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800261}
262
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700263void MarkSweep::UpdateAndMarkModUnion() {
264 for (const auto& space : heap_->GetContinuousSpaces()) {
Mathieu Chartier8d562102014-03-12 17:42:10 -0700265 if (immune_region_.ContainsSpace(space)) {
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700266 const char* name = space->IsZygoteSpace() ? "UpdateAndMarkZygoteModUnionTable" :
267 "UpdateAndMarkImageModUnionTable";
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700268 TimingLogger::ScopedTiming t(name, GetTimings());
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700269 accounting::ModUnionTable* mod_union_table = heap_->FindModUnionTableFromSpace(space);
270 CHECK(mod_union_table != nullptr);
Mathieu Chartier407f7022014-02-18 14:37:05 -0800271 mod_union_table->UpdateAndMarkReferences(MarkHeapReferenceCallback, this);
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700272 }
273 }
274}
275
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800276void MarkSweep::MarkReachableObjects() {
Mathieu Chartier4aeec172014-03-27 16:09:46 -0700277 UpdateAndMarkModUnion();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800278 // Recursively mark all the non-image bits set in the mark bitmap.
279 RecursiveMark();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800280}
281
282void MarkSweep::ReclaimPhase() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700283 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier720ef762013-08-17 14:46:54 -0700284 Thread* self = Thread::Current();
Mathieu Chartier78f7b4c2014-05-06 10:57:27 -0700285 // Process the references concurrently.
286 ProcessReferences(self);
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700287 SweepSystemWeaks(self);
Mathieu Chartier6f365cc2014-04-23 12:42:27 -0700288 Runtime::Current()->AllowNewSystemWeaks();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800289 {
290 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800291 // Reclaim unmarked objects.
Ian Rogers1d54e732013-05-02 21:10:01 -0700292 Sweep(false);
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800293 // Swap the live and mark bitmaps for each space which we modified space. This is an
294 // optimization that enables us to not clear live bits inside of the sweep. Only swaps unbound
295 // bitmaps.
296 SwapBitmaps();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800297 // Unbind the live and mark bitmaps.
Mathieu Chartiera1602f22014-01-13 17:19:19 -0800298 GetHeap()->UnBindBitmaps();
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800299 }
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800300}
301
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700302void MarkSweep::FindDefaultSpaceBitmap() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700303 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier02e25112013-08-14 16:14:24 -0700304 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700305 accounting::ContinuousSpaceBitmap* bitmap = space->GetMarkBitmap();
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700306 // We want to have the main space instead of non moving if possible.
Mathieu Chartier590fee92013-09-13 13:46:47 -0700307 if (bitmap != nullptr &&
308 space->GetGcRetentionPolicy() == space::kGcRetentionPolicyAlwaysCollect) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700309 current_space_bitmap_ = bitmap;
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700310 // If we are not the non moving space exit the loop early since this will be good enough.
311 if (space != heap_->GetNonMovingSpace()) {
312 break;
313 }
Mathieu Chartier7469ebf2012-09-24 16:28:36 -0700314 }
315 }
Mathieu Chartier4c13a3f2014-07-14 14:57:16 -0700316 CHECK(current_space_bitmap_ != nullptr) << "Could not find a default mark bitmap\n"
317 << heap_->DumpSpaces();
Mathieu Chartier7469ebf2012-09-24 16:28:36 -0700318}
319
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800320void MarkSweep::ExpandMarkStack() {
Mathieu Chartierba311b42013-08-27 13:02:30 -0700321 ResizeMarkStack(mark_stack_->Capacity() * 2);
322}
323
324void MarkSweep::ResizeMarkStack(size_t new_size) {
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800325 // Rare case, no need to have Thread::Current be a parameter.
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800326 if (UNLIKELY(mark_stack_->Size() < mark_stack_->Capacity())) {
327 // Someone else acquired the lock and expanded the mark stack before us.
328 return;
329 }
Mathieu Chartier02e25112013-08-14 16:14:24 -0700330 std::vector<Object*> temp(mark_stack_->Begin(), mark_stack_->End());
Mathieu Chartierba311b42013-08-27 13:02:30 -0700331 CHECK_LE(mark_stack_->Size(), new_size);
332 mark_stack_->Resize(new_size);
Mathieu Chartier02e25112013-08-14 16:14:24 -0700333 for (const auto& obj : temp) {
334 mark_stack_->PushBack(obj);
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800335 }
336}
337
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700338inline void MarkSweep::MarkObjectNonNullParallel(Object* obj) {
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700339 DCHECK(obj != nullptr);
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800340 if (MarkObjectParallel(obj)) {
Mathieu Chartierba311b42013-08-27 13:02:30 -0700341 MutexLock mu(Thread::Current(), mark_stack_lock_);
342 if (UNLIKELY(mark_stack_->Size() >= mark_stack_->Capacity())) {
Mathieu Chartier184e3222013-08-03 14:02:57 -0700343 ExpandMarkStack();
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800344 }
Mathieu Chartierba311b42013-08-27 13:02:30 -0700345 // The object must be pushed on to the mark stack.
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700346 mark_stack_->PushBack(obj);
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800347 }
348}
349
Mathieu Chartier3bb57c72014-02-18 11:38:45 -0800350mirror::Object* MarkSweep::MarkObjectCallback(mirror::Object* obj, void* arg) {
Mathieu Chartier39e32612013-11-12 16:28:05 -0800351 MarkSweep* mark_sweep = reinterpret_cast<MarkSweep*>(arg);
352 mark_sweep->MarkObject(obj);
Mathieu Chartier39e32612013-11-12 16:28:05 -0800353 return obj;
354}
355
Mathieu Chartier407f7022014-02-18 14:37:05 -0800356void MarkSweep::MarkHeapReferenceCallback(mirror::HeapReference<mirror::Object>* ref, void* arg) {
357 reinterpret_cast<MarkSweep*>(arg)->MarkObject(ref->AsMirrorPtr());
358}
359
Mathieu Chartier308351a2014-06-15 12:39:02 -0700360bool MarkSweep::HeapReferenceMarkedCallback(mirror::HeapReference<mirror::Object>* ref, void* arg) {
361 return reinterpret_cast<MarkSweep*>(arg)->IsMarked(ref->AsMirrorPtr());
362}
363
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700364class MarkSweepMarkObjectSlowPath {
365 public:
366 explicit MarkSweepMarkObjectSlowPath(MarkSweep* mark_sweep) : mark_sweep_(mark_sweep) {
367 }
368
369 void operator()(const Object* obj) const ALWAYS_INLINE {
370 if (kProfileLargeObjects) {
371 // TODO: Differentiate between marking and testing somehow.
372 ++mark_sweep_->large_object_test_;
373 ++mark_sweep_->large_object_mark_;
374 }
375 space::LargeObjectSpace* large_object_space = mark_sweep_->GetHeap()->GetLargeObjectsSpace();
Mathieu Chartiera17288e2014-05-08 17:53:19 -0700376 if (UNLIKELY(obj == nullptr || !IsAligned<kPageSize>(obj) ||
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700377 (kIsDebugBuild && !large_object_space->Contains(obj)))) {
378 LOG(ERROR) << "Tried to mark " << obj << " not contained by any spaces";
379 LOG(ERROR) << "Attempting see if it's a bad root";
380 mark_sweep_->VerifyRoots();
381 LOG(FATAL) << "Can't mark invalid object";
382 }
383 }
384
385 private:
386 MarkSweep* const mark_sweep_;
387};
388
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700389inline void MarkSweep::MarkObjectNonNull(Object* obj) {
390 DCHECK(obj != nullptr);
Hiroshi Yamauchi624468c2014-03-31 15:14:47 -0700391 if (kUseBakerOrBrooksReadBarrier) {
392 // Verify all the objects have the correct pointer installed.
393 obj->AssertReadBarrierPointer();
Hiroshi Yamauchi9d04a202014-01-31 13:35:49 -0800394 }
Mathieu Chartier8d562102014-03-12 17:42:10 -0700395 if (immune_region_.ContainsObject(obj)) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700396 if (kCountMarkedObjects) {
397 ++mark_immune_count_;
398 }
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700399 DCHECK(mark_bitmap_->Test(obj));
400 } else if (LIKELY(current_space_bitmap_->HasAddress(obj))) {
401 if (kCountMarkedObjects) {
402 ++mark_fastpath_count_;
403 }
404 if (UNLIKELY(!current_space_bitmap_->Set(obj))) {
405 PushOnMarkStack(obj); // This object was not previously marked.
406 }
407 } else {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700408 if (kCountMarkedObjects) {
409 ++mark_slowpath_count_;
410 }
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700411 MarkSweepMarkObjectSlowPath visitor(this);
412 // TODO: We already know that the object is not in the current_space_bitmap_ but MarkBitmap::Set
413 // will check again.
414 if (!mark_bitmap_->Set(obj, visitor)) {
415 PushOnMarkStack(obj); // Was not already marked, push.
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700416 }
Carl Shapiro69759ea2011-07-21 18:13:35 -0700417 }
418}
419
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700420inline void MarkSweep::PushOnMarkStack(Object* obj) {
421 if (UNLIKELY(mark_stack_->Size() >= mark_stack_->Capacity())) {
422 // Lock is not needed but is here anyways to please annotalysis.
423 MutexLock mu(Thread::Current(), mark_stack_lock_);
424 ExpandMarkStack();
425 }
426 // The object must be pushed on to the mark stack.
427 mark_stack_->PushBack(obj);
428}
429
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700430inline bool MarkSweep::MarkObjectParallel(const Object* obj) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700431 DCHECK(obj != nullptr);
Hiroshi Yamauchi624468c2014-03-31 15:14:47 -0700432 if (kUseBakerOrBrooksReadBarrier) {
433 // Verify all the objects have the correct pointer installed.
434 obj->AssertReadBarrierPointer();
Hiroshi Yamauchi9d04a202014-01-31 13:35:49 -0800435 }
Mathieu Chartier8d562102014-03-12 17:42:10 -0700436 if (immune_region_.ContainsObject(obj)) {
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700437 DCHECK(IsMarked(obj));
438 return false;
439 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700440 // Try to take advantage of locality of references within a space, failing this find the space
441 // the hard way.
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700442 accounting::ContinuousSpaceBitmap* object_bitmap = current_space_bitmap_;
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700443 if (LIKELY(object_bitmap->HasAddress(obj))) {
444 return !object_bitmap->AtomicTestAndSet(obj);
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700445 }
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700446 MarkSweepMarkObjectSlowPath visitor(this);
447 return !mark_bitmap_->AtomicTestAndSet(obj, visitor);
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700448}
449
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700450// Used to mark objects when processing the mark stack. If an object is null, it is not marked.
451inline void MarkSweep::MarkObject(Object* obj) {
452 if (obj != nullptr) {
Mathieu Chartier9642c962013-08-05 17:40:36 -0700453 MarkObjectNonNull(obj);
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700454 } else if (kCountMarkedObjects) {
455 ++mark_null_count_;
Carl Shapiro69759ea2011-07-21 18:13:35 -0700456 }
457}
458
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700459void MarkSweep::MarkRootParallelCallback(Object** root, void* arg, uint32_t /*thread_id*/,
Mathieu Chartier815873e2014-02-13 18:02:13 -0800460 RootType /*root_type*/) {
Mathieu Chartier815873e2014-02-13 18:02:13 -0800461 reinterpret_cast<MarkSweep*>(arg)->MarkObjectNonNullParallel(*root);
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800462}
463
Mathieu Chartier893263b2014-03-04 11:07:42 -0800464void MarkSweep::VerifyRootMarked(Object** root, void* arg, uint32_t /*thread_id*/,
465 RootType /*root_type*/) {
466 CHECK(reinterpret_cast<MarkSweep*>(arg)->IsMarked(*root));
467}
468
Mathieu Chartier815873e2014-02-13 18:02:13 -0800469void MarkSweep::MarkRootCallback(Object** root, void* arg, uint32_t /*thread_id*/,
470 RootType /*root_type*/) {
Mathieu Chartier815873e2014-02-13 18:02:13 -0800471 reinterpret_cast<MarkSweep*>(arg)->MarkObjectNonNull(*root);
472}
473
Mathieu Chartier6f1c9492012-10-15 12:08:41 -0700474void MarkSweep::VerifyRootCallback(const Object* root, void* arg, size_t vreg,
Mathieu Chartier7bf9f192014-04-04 11:09:41 -0700475 const StackVisitor* visitor, RootType root_type) {
476 reinterpret_cast<MarkSweep*>(arg)->VerifyRoot(root, vreg, visitor, root_type);
Mathieu Chartier6f1c9492012-10-15 12:08:41 -0700477}
478
Mathieu Chartier7bf9f192014-04-04 11:09:41 -0700479void MarkSweep::VerifyRoot(const Object* root, size_t vreg, const StackVisitor* visitor,
480 RootType root_type) {
Mathieu Chartier6f1c9492012-10-15 12:08:41 -0700481 // See if the root is on any space bitmap.
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700482 if (heap_->GetLiveBitmap()->GetContinuousSpaceBitmap(root) == nullptr) {
Ian Rogers1d54e732013-05-02 21:10:01 -0700483 space::LargeObjectSpace* large_object_space = GetHeap()->GetLargeObjectsSpace();
Mathieu Chartier4202b742012-10-17 17:51:25 -0700484 if (!large_object_space->Contains(root)) {
Mathieu Chartier7bf9f192014-04-04 11:09:41 -0700485 LOG(ERROR) << "Found invalid root: " << root << " with type " << root_type;
Ian Rogers40e3bac2012-11-20 00:09:14 -0800486 if (visitor != NULL) {
487 LOG(ERROR) << visitor->DescribeLocation() << " in VReg: " << vreg;
Mathieu Chartier6f1c9492012-10-15 12:08:41 -0700488 }
489 }
490 }
491}
492
493void MarkSweep::VerifyRoots() {
494 Runtime::Current()->GetThreadList()->VerifyRoots(VerifyRootCallback, this);
495}
496
Mathieu Chartier893263b2014-03-04 11:07:42 -0800497void MarkSweep::MarkRoots(Thread* self) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700498 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier893263b2014-03-04 11:07:42 -0800499 if (Locks::mutator_lock_->IsExclusiveHeld(self)) {
500 // If we exclusively hold the mutator lock, all threads must be suspended.
Mathieu Chartier893263b2014-03-04 11:07:42 -0800501 Runtime::Current()->VisitRoots(MarkRootCallback, this);
Mathieu Chartier893263b2014-03-04 11:07:42 -0800502 RevokeAllThreadLocalAllocationStacks(self);
503 } else {
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700504 MarkRootsCheckpoint(self, kRevokeRosAllocThreadLocalBuffersAtCheckpoint);
Mathieu Chartier893263b2014-03-04 11:07:42 -0800505 // At this point the live stack should no longer have any mutators which push into it.
506 MarkNonThreadRoots();
507 MarkConcurrentRoots(
508 static_cast<VisitRootFlags>(kVisitRootFlagAllRoots | kVisitRootFlagStartLoggingNewRoots));
509 }
Mathieu Chartier9ebae1f2012-10-15 17:38:16 -0700510}
511
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700512void MarkSweep::MarkNonThreadRoots() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700513 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier423d2a32013-09-12 17:33:56 -0700514 Runtime::Current()->VisitNonThreadRoots(MarkRootCallback, this);
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700515}
516
Mathieu Chartier893263b2014-03-04 11:07:42 -0800517void MarkSweep::MarkConcurrentRoots(VisitRootFlags flags) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700518 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Ian Rogers1d54e732013-05-02 21:10:01 -0700519 // Visit all runtime roots and clear dirty flags.
Mathieu Chartier893263b2014-03-04 11:07:42 -0800520 Runtime::Current()->VisitConcurrentRoots(MarkRootCallback, this, flags);
Carl Shapiro69759ea2011-07-21 18:13:35 -0700521}
522
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700523class ScanObjectVisitor {
Mathieu Chartiercc236d72012-07-20 10:29:05 -0700524 public:
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700525 explicit ScanObjectVisitor(MarkSweep* const mark_sweep) ALWAYS_INLINE
526 : mark_sweep_(mark_sweep) {}
Mathieu Chartiercc236d72012-07-20 10:29:05 -0700527
Mathieu Chartier407f7022014-02-18 14:37:05 -0800528 void operator()(Object* obj) const ALWAYS_INLINE SHARED_LOCKS_REQUIRED(Locks::mutator_lock_)
529 EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) {
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700530 if (kCheckLocks) {
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800531 Locks::mutator_lock_->AssertSharedHeld(Thread::Current());
532 Locks::heap_bitmap_lock_->AssertExclusiveHeld(Thread::Current());
533 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -0700534 mark_sweep_->ScanObject(obj);
Mathieu Chartiercc236d72012-07-20 10:29:05 -0700535 }
536
537 private:
538 MarkSweep* const mark_sweep_;
539};
540
Mathieu Chartier407f7022014-02-18 14:37:05 -0800541class DelayReferenceReferentVisitor {
542 public:
543 explicit DelayReferenceReferentVisitor(MarkSweep* collector) : collector_(collector) {
544 }
545
546 void operator()(mirror::Class* klass, mirror::Reference* ref) const
547 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_)
548 EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) {
549 collector_->DelayReferenceReferent(klass, ref);
550 }
551
552 private:
553 MarkSweep* const collector_;
554};
555
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700556template <bool kUseFinger = false>
557class MarkStackTask : public Task {
558 public:
559 MarkStackTask(ThreadPool* thread_pool, MarkSweep* mark_sweep, size_t mark_stack_size,
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700560 Object** mark_stack)
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700561 : mark_sweep_(mark_sweep),
562 thread_pool_(thread_pool),
563 mark_stack_pos_(mark_stack_size) {
564 // We may have to copy part of an existing mark stack when another mark stack overflows.
565 if (mark_stack_size != 0) {
566 DCHECK(mark_stack != NULL);
567 // TODO: Check performance?
568 std::copy(mark_stack, mark_stack + mark_stack_size, mark_stack_);
Ian Rogers1d54e732013-05-02 21:10:01 -0700569 }
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700570 if (kCountTasks) {
571 ++mark_sweep_->work_chunks_created_;
572 }
573 }
574
575 static const size_t kMaxSize = 1 * KB;
576
577 protected:
Mathieu Chartier407f7022014-02-18 14:37:05 -0800578 class MarkObjectParallelVisitor {
579 public:
580 explicit MarkObjectParallelVisitor(MarkStackTask<kUseFinger>* chunk_task,
581 MarkSweep* mark_sweep) ALWAYS_INLINE
582 : chunk_task_(chunk_task), mark_sweep_(mark_sweep) {}
583
584 void operator()(Object* obj, MemberOffset offset, bool /* static */) const ALWAYS_INLINE
585 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogersb0fa5dc2014-04-28 16:47:08 -0700586 mirror::Object* ref = obj->GetFieldObject<mirror::Object>(offset);
Mathieu Chartier407f7022014-02-18 14:37:05 -0800587 if (ref != nullptr && mark_sweep_->MarkObjectParallel(ref)) {
588 if (kUseFinger) {
589 android_memory_barrier();
590 if (reinterpret_cast<uintptr_t>(ref) >=
Ian Rogers3e5cf302014-05-20 16:40:37 -0700591 static_cast<uintptr_t>(mark_sweep_->atomic_finger_.LoadRelaxed())) {
Mathieu Chartier407f7022014-02-18 14:37:05 -0800592 return;
593 }
594 }
595 chunk_task_->MarkStackPush(ref);
596 }
597 }
598
599 private:
600 MarkStackTask<kUseFinger>* const chunk_task_;
601 MarkSweep* const mark_sweep_;
602 };
603
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700604 class ScanObjectParallelVisitor {
605 public:
606 explicit ScanObjectParallelVisitor(MarkStackTask<kUseFinger>* chunk_task) ALWAYS_INLINE
607 : chunk_task_(chunk_task) {}
608
Mathieu Chartier407f7022014-02-18 14:37:05 -0800609 // No thread safety analysis since multiple threads will use this visitor.
610 void operator()(Object* obj) const SHARED_LOCKS_REQUIRED(Locks::mutator_lock_)
611 EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) {
612 MarkSweep* const mark_sweep = chunk_task_->mark_sweep_;
613 MarkObjectParallelVisitor mark_visitor(chunk_task_, mark_sweep);
614 DelayReferenceReferentVisitor ref_visitor(mark_sweep);
615 mark_sweep->ScanObjectVisit(obj, mark_visitor, ref_visitor);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700616 }
617
618 private:
619 MarkStackTask<kUseFinger>* const chunk_task_;
620 };
621
622 virtual ~MarkStackTask() {
623 // Make sure that we have cleared our mark stack.
624 DCHECK_EQ(mark_stack_pos_, 0U);
625 if (kCountTasks) {
626 ++mark_sweep_->work_chunks_deleted_;
627 }
628 }
629
630 MarkSweep* const mark_sweep_;
631 ThreadPool* const thread_pool_;
632 // Thread local mark stack for this task.
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700633 Object* mark_stack_[kMaxSize];
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700634 // Mark stack position.
635 size_t mark_stack_pos_;
636
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700637 void MarkStackPush(Object* obj) ALWAYS_INLINE {
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700638 if (UNLIKELY(mark_stack_pos_ == kMaxSize)) {
639 // Mark stack overflow, give 1/2 the stack to the thread pool as a new work task.
640 mark_stack_pos_ /= 2;
641 auto* task = new MarkStackTask(thread_pool_, mark_sweep_, kMaxSize - mark_stack_pos_,
642 mark_stack_ + mark_stack_pos_);
643 thread_pool_->AddTask(Thread::Current(), task);
644 }
645 DCHECK(obj != nullptr);
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700646 DCHECK_LT(mark_stack_pos_, kMaxSize);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700647 mark_stack_[mark_stack_pos_++] = obj;
648 }
649
650 virtual void Finalize() {
651 delete this;
652 }
653
654 // Scans all of the objects
Mathieu Chartier407f7022014-02-18 14:37:05 -0800655 virtual void Run(Thread* self) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_)
656 EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) {
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700657 ScanObjectParallelVisitor visitor(this);
658 // TODO: Tune this.
659 static const size_t kFifoSize = 4;
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700660 BoundedFifoPowerOfTwo<Object*, kFifoSize> prefetch_fifo;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700661 for (;;) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700662 Object* obj = nullptr;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700663 if (kUseMarkStackPrefetch) {
664 while (mark_stack_pos_ != 0 && prefetch_fifo.size() < kFifoSize) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700665 Object* obj = mark_stack_[--mark_stack_pos_];
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700666 DCHECK(obj != nullptr);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700667 __builtin_prefetch(obj);
668 prefetch_fifo.push_back(obj);
669 }
670 if (UNLIKELY(prefetch_fifo.empty())) {
671 break;
672 }
673 obj = prefetch_fifo.front();
674 prefetch_fifo.pop_front();
675 } else {
676 if (UNLIKELY(mark_stack_pos_ == 0)) {
677 break;
678 }
679 obj = mark_stack_[--mark_stack_pos_];
680 }
Mathieu Chartier11409ae2013-09-23 11:49:36 -0700681 DCHECK(obj != nullptr);
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700682 visitor(obj);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700683 }
684 }
685};
686
687class CardScanTask : public MarkStackTask<false> {
688 public:
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700689 CardScanTask(ThreadPool* thread_pool, MarkSweep* mark_sweep,
690 accounting::ContinuousSpaceBitmap* bitmap,
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700691 byte* begin, byte* end, byte minimum_age, size_t mark_stack_size,
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700692 Object** mark_stack_obj)
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700693 : MarkStackTask<false>(thread_pool, mark_sweep, mark_stack_size, mark_stack_obj),
694 bitmap_(bitmap),
695 begin_(begin),
696 end_(end),
697 minimum_age_(minimum_age) {
698 }
699
700 protected:
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700701 accounting::ContinuousSpaceBitmap* const bitmap_;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700702 byte* const begin_;
703 byte* const end_;
704 const byte minimum_age_;
705
706 virtual void Finalize() {
707 delete this;
708 }
709
710 virtual void Run(Thread* self) NO_THREAD_SAFETY_ANALYSIS {
711 ScanObjectParallelVisitor visitor(this);
712 accounting::CardTable* card_table = mark_sweep_->GetHeap()->GetCardTable();
Mathieu Chartier0f72e412013-09-06 16:40:01 -0700713 size_t cards_scanned = card_table->Scan(bitmap_, begin_, end_, visitor, minimum_age_);
Mathieu Chartier0f72e412013-09-06 16:40:01 -0700714 VLOG(heap) << "Parallel scanning cards " << reinterpret_cast<void*>(begin_) << " - "
715 << reinterpret_cast<void*>(end_) << " = " << cards_scanned;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700716 // Finish by emptying our local mark stack.
717 MarkStackTask::Run(self);
718 }
719};
720
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700721size_t MarkSweep::GetThreadCount(bool paused) const {
722 if (heap_->GetThreadPool() == nullptr || !heap_->CareAboutPauseTimes()) {
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700723 return 1;
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700724 }
725 if (paused) {
726 return heap_->GetParallelGCThreadCount() + 1;
727 } else {
728 return heap_->GetConcGCThreadCount() + 1;
729 }
730}
731
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700732void MarkSweep::ScanGrayObjects(bool paused, byte minimum_age) {
733 accounting::CardTable* card_table = GetHeap()->GetCardTable();
734 ThreadPool* thread_pool = GetHeap()->GetThreadPool();
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700735 size_t thread_count = GetThreadCount(paused);
736 // The parallel version with only one thread is faster for card scanning, TODO: fix.
Mathieu Chartierbbd695c2014-04-16 09:48:48 -0700737 if (kParallelCardScan && thread_count > 1) {
Mathieu Chartier720ef762013-08-17 14:46:54 -0700738 Thread* self = Thread::Current();
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700739 // Can't have a different split for each space since multiple spaces can have their cards being
740 // scanned at the same time.
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700741 TimingLogger::ScopedTiming t(paused ? "(Paused)ScanGrayObjects" : __FUNCTION__,
742 GetTimings());
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700743 // Try to take some of the mark stack since we can pass this off to the worker tasks.
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700744 Object** mark_stack_begin = mark_stack_->Begin();
745 Object** mark_stack_end = mark_stack_->End();
Mathieu Chartier720ef762013-08-17 14:46:54 -0700746 const size_t mark_stack_size = mark_stack_end - mark_stack_begin;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700747 // Estimated number of work tasks we will create.
748 const size_t mark_stack_tasks = GetHeap()->GetContinuousSpaces().size() * thread_count;
749 DCHECK_NE(mark_stack_tasks, 0U);
750 const size_t mark_stack_delta = std::min(CardScanTask::kMaxSize / 2,
751 mark_stack_size / mark_stack_tasks + 1);
752 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Mathieu Chartier590fee92013-09-13 13:46:47 -0700753 if (space->GetMarkBitmap() == nullptr) {
754 continue;
755 }
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700756 byte* card_begin = space->Begin();
757 byte* card_end = space->End();
Hiroshi Yamauchi0941b042013-11-05 11:34:03 -0800758 // Align up the end address. For example, the image space's end
759 // may not be card-size-aligned.
760 card_end = AlignUp(card_end, accounting::CardTable::kCardSize);
761 DCHECK(IsAligned<accounting::CardTable::kCardSize>(card_begin));
762 DCHECK(IsAligned<accounting::CardTable::kCardSize>(card_end));
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700763 // Calculate how many bytes of heap we will scan,
764 const size_t address_range = card_end - card_begin;
765 // Calculate how much address range each task gets.
766 const size_t card_delta = RoundUp(address_range / thread_count + 1,
767 accounting::CardTable::kCardSize);
768 // Create the worker tasks for this space.
769 while (card_begin != card_end) {
770 // Add a range of cards.
771 size_t addr_remaining = card_end - card_begin;
772 size_t card_increment = std::min(card_delta, addr_remaining);
773 // Take from the back of the mark stack.
774 size_t mark_stack_remaining = mark_stack_end - mark_stack_begin;
775 size_t mark_stack_increment = std::min(mark_stack_delta, mark_stack_remaining);
776 mark_stack_end -= mark_stack_increment;
777 mark_stack_->PopBackCount(static_cast<int32_t>(mark_stack_increment));
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700778 DCHECK_EQ(mark_stack_end, mark_stack_->End());
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700779 // Add the new task to the thread pool.
780 auto* task = new CardScanTask(thread_pool, this, space->GetMarkBitmap(), card_begin,
781 card_begin + card_increment, minimum_age,
782 mark_stack_increment, mark_stack_end);
783 thread_pool->AddTask(self, task);
784 card_begin += card_increment;
785 }
786 }
Mathieu Chartier0f72e412013-09-06 16:40:01 -0700787
Hiroshi Yamauchi0941b042013-11-05 11:34:03 -0800788 // Note: the card scan below may dirty new cards (and scan them)
789 // as a side effect when a Reference object is encountered and
790 // queued during the marking. See b/11465268.
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700791 thread_pool->SetMaxActiveWorkers(thread_count - 1);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700792 thread_pool->StartWorkers(self);
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700793 thread_pool->Wait(self, true, true);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700794 thread_pool->StopWorkers(self);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700795 } else {
796 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Mathieu Chartier590fee92013-09-13 13:46:47 -0700797 if (space->GetMarkBitmap() != nullptr) {
798 // Image spaces are handled properly since live == marked for them.
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700799 const char* name = nullptr;
Mathieu Chartier590fee92013-09-13 13:46:47 -0700800 switch (space->GetGcRetentionPolicy()) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700801 case space::kGcRetentionPolicyNeverCollect:
802 name = paused ? "(Paused)ScanGrayImageSpaceObjects" : "ScanGrayImageSpaceObjects";
803 break;
804 case space::kGcRetentionPolicyFullCollect:
805 name = paused ? "(Paused)ScanGrayZygoteSpaceObjects" : "ScanGrayZygoteSpaceObjects";
806 break;
807 case space::kGcRetentionPolicyAlwaysCollect:
808 name = paused ? "(Paused)ScanGrayAllocSpaceObjects" : "ScanGrayAllocSpaceObjects";
809 break;
810 default:
811 LOG(FATAL) << "Unreachable";
812 }
813 TimingLogger::ScopedTiming t(name, GetTimings());
Mathieu Chartier590fee92013-09-13 13:46:47 -0700814 ScanObjectVisitor visitor(this);
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700815 card_table->Scan(space->GetMarkBitmap(), space->Begin(), space->End(), visitor,
816 minimum_age);
Mathieu Chartier590fee92013-09-13 13:46:47 -0700817 }
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700818 }
Mathieu Chartier262e5ff2012-06-01 17:35:38 -0700819 }
820}
821
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700822class RecursiveMarkTask : public MarkStackTask<false> {
823 public:
824 RecursiveMarkTask(ThreadPool* thread_pool, MarkSweep* mark_sweep,
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700825 accounting::ContinuousSpaceBitmap* bitmap, uintptr_t begin, uintptr_t end)
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700826 : MarkStackTask<false>(thread_pool, mark_sweep, 0, NULL), bitmap_(bitmap), begin_(begin),
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700827 end_(end) {
828 }
829
830 protected:
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -0700831 accounting::ContinuousSpaceBitmap* const bitmap_;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700832 const uintptr_t begin_;
833 const uintptr_t end_;
834
835 virtual void Finalize() {
836 delete this;
837 }
838
839 // Scans all of the objects
840 virtual void Run(Thread* self) NO_THREAD_SAFETY_ANALYSIS {
841 ScanObjectParallelVisitor visitor(this);
842 bitmap_->VisitMarkedRange(begin_, end_, visitor);
843 // Finish by emptying our local mark stack.
844 MarkStackTask::Run(self);
845 }
846};
847
Carl Shapiro58551df2011-07-24 03:09:51 -0700848// Populates the mark stack based on the set of marked objects and
849// recursively marks until the mark stack is emptied.
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800850void MarkSweep::RecursiveMark() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700851 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartiera1602f22014-01-13 17:19:19 -0800852 // RecursiveMark will build the lists of known instances of the Reference classes. See
853 // DelayReferenceReferent for details.
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700854 if (kUseRecursiveMark) {
855 const bool partial = GetGcType() == kGcTypePartial;
856 ScanObjectVisitor scan_visitor(this);
857 auto* self = Thread::Current();
858 ThreadPool* thread_pool = heap_->GetThreadPool();
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700859 size_t thread_count = GetThreadCount(false);
860 const bool parallel = kParallelRecursiveMark && thread_count > 1;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700861 mark_stack_->Reset();
Mathieu Chartier02e25112013-08-14 16:14:24 -0700862 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Ian Rogers1d54e732013-05-02 21:10:01 -0700863 if ((space->GetGcRetentionPolicy() == space::kGcRetentionPolicyAlwaysCollect) ||
864 (!partial && space->GetGcRetentionPolicy() == space::kGcRetentionPolicyFullCollect)) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700865 current_space_bitmap_ = space->GetMarkBitmap();
866 if (current_space_bitmap_ == nullptr) {
Mathieu Chartier590fee92013-09-13 13:46:47 -0700867 continue;
Mathieu Chartier2b82db42012-11-14 17:29:05 -0800868 }
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700869 if (parallel) {
870 // We will use the mark stack the future.
871 // CHECK(mark_stack_->IsEmpty());
872 // This function does not handle heap end increasing, so we must use the space end.
873 uintptr_t begin = reinterpret_cast<uintptr_t>(space->Begin());
874 uintptr_t end = reinterpret_cast<uintptr_t>(space->End());
Ian Rogers3e5cf302014-05-20 16:40:37 -0700875 atomic_finger_.StoreRelaxed(AtomicInteger::MaxValue());
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700876
877 // Create a few worker tasks.
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700878 const size_t n = thread_count * 2;
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700879 while (begin != end) {
880 uintptr_t start = begin;
881 uintptr_t delta = (end - begin) / n;
882 delta = RoundUp(delta, KB);
883 if (delta < 16 * KB) delta = end - begin;
884 begin += delta;
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700885 auto* task = new RecursiveMarkTask(thread_pool, this, current_space_bitmap_, start,
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700886 begin);
887 thread_pool->AddTask(self, task);
888 }
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700889 thread_pool->SetMaxActiveWorkers(thread_count - 1);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700890 thread_pool->StartWorkers(self);
Mathieu Chartier2775ee42013-08-20 17:43:47 -0700891 thread_pool->Wait(self, true, true);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700892 thread_pool->StopWorkers(self);
893 } else {
894 // This function does not handle heap end increasing, so we must use the space end.
895 uintptr_t begin = reinterpret_cast<uintptr_t>(space->Begin());
896 uintptr_t end = reinterpret_cast<uintptr_t>(space->End());
Mathieu Chartier0e54cd02014-03-20 12:41:23 -0700897 current_space_bitmap_->VisitMarkedRange(begin, end, scan_visitor);
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700898 }
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700899 }
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700900 }
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700901 }
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700902 ProcessMarkStack(false);
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700903}
904
Mathieu Chartier83c8ee02014-01-28 14:50:23 -0800905mirror::Object* MarkSweep::IsMarkedCallback(mirror::Object* object, void* arg) {
Mathieu Chartier5712d5d2013-09-18 17:59:36 -0700906 if (reinterpret_cast<MarkSweep*>(arg)->IsMarked(object)) {
Mathieu Chartier6aa3df92013-09-17 15:17:28 -0700907 return object;
908 }
909 return nullptr;
Mathieu Chartier357e9be2012-08-01 11:00:14 -0700910}
911
Mathieu Chartier94c32c52013-08-09 11:14:04 -0700912void MarkSweep::RecursiveMarkDirtyObjects(bool paused, byte minimum_age) {
913 ScanGrayObjects(paused, minimum_age);
914 ProcessMarkStack(paused);
Mathieu Chartier262e5ff2012-06-01 17:35:38 -0700915}
916
Carl Shapiro58551df2011-07-24 03:09:51 -0700917void MarkSweep::ReMarkRoots() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700918 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier893263b2014-03-04 11:07:42 -0800919 Locks::mutator_lock_->AssertExclusiveHeld(Thread::Current());
Mathieu Chartier893263b2014-03-04 11:07:42 -0800920 Runtime::Current()->VisitRoots(
921 MarkRootCallback, this, static_cast<VisitRootFlags>(kVisitRootFlagNewRoots |
922 kVisitRootFlagStopLoggingNewRoots |
923 kVisitRootFlagClearRootLog));
Mathieu Chartier7bf9f192014-04-04 11:09:41 -0700924 if (kVerifyRootsMarked) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700925 TimingLogger::ScopedTiming t("(Paused)VerifyRoots", GetTimings());
Mathieu Chartier893263b2014-03-04 11:07:42 -0800926 Runtime::Current()->VisitRoots(VerifyRootMarked, this);
Mathieu Chartier893263b2014-03-04 11:07:42 -0800927 }
Carl Shapiro69759ea2011-07-21 18:13:35 -0700928}
929
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700930void MarkSweep::SweepSystemWeaks(Thread* self) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700931 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700932 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700933 Runtime::Current()->SweepSystemWeaks(IsMarkedCallback, this);
Carl Shapiro58551df2011-07-24 03:09:51 -0700934}
935
Mathieu Chartier6aa3df92013-09-17 15:17:28 -0700936mirror::Object* MarkSweep::VerifySystemWeakIsLiveCallback(Object* obj, void* arg) {
Mathieu Chartierc7b83a02012-09-11 18:07:39 -0700937 reinterpret_cast<MarkSweep*>(arg)->VerifyIsLive(obj);
938 // We don't actually want to sweep the object, so lets return "marked"
Mathieu Chartier6aa3df92013-09-17 15:17:28 -0700939 return obj;
Mathieu Chartierc7b83a02012-09-11 18:07:39 -0700940}
941
942void MarkSweep::VerifyIsLive(const Object* obj) {
Mathieu Chartier4aeec172014-03-27 16:09:46 -0700943 if (!heap_->GetLiveBitmap()->Test(obj)) {
Mathieu Chartier4c13a3f2014-07-14 14:57:16 -0700944 accounting::ObjectStack* allocation_stack = heap_->allocation_stack_.get();
945 CHECK(std::find(allocation_stack->Begin(), allocation_stack->End(), obj) !=
946 allocation_stack->End()) << "Found dead object " << obj << "\n" << heap_->DumpSpaces();
Mathieu Chartierc7b83a02012-09-11 18:07:39 -0700947 }
948}
949
950void MarkSweep::VerifySystemWeaks() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700951 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier6aa3df92013-09-17 15:17:28 -0700952 // Verify system weaks, uses a special object visitor which returns the input object.
953 Runtime::Current()->SweepSystemWeaks(VerifySystemWeakIsLiveCallback, this);
Mathieu Chartierc7b83a02012-09-11 18:07:39 -0700954}
955
Mathieu Chartier0e4627e2012-10-23 16:13:36 -0700956class CheckpointMarkThreadRoots : public Closure {
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700957 public:
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700958 explicit CheckpointMarkThreadRoots(MarkSweep* mark_sweep,
959 bool revoke_ros_alloc_thread_local_buffers_at_checkpoint)
960 : mark_sweep_(mark_sweep),
961 revoke_ros_alloc_thread_local_buffers_at_checkpoint_(
962 revoke_ros_alloc_thread_local_buffers_at_checkpoint) {
963 }
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700964
Mathieu Chartier4aeec172014-03-27 16:09:46 -0700965 virtual void Run(Thread* thread) OVERRIDE NO_THREAD_SAFETY_ANALYSIS {
Mathieu Chartier3f966702013-09-04 16:50:05 -0700966 ATRACE_BEGIN("Marking thread roots");
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700967 // Note: self is not necessarily equal to thread since thread may be suspended.
968 Thread* self = Thread::Current();
Mathieu Chartierd22d5482012-11-06 17:14:12 -0800969 CHECK(thread == self || thread->IsSuspended() || thread->GetState() == kWaitingPerformingGc)
970 << thread->GetState() << " thread " << thread << " self " << self;
Mathieu Chartierac86a7c2012-11-12 15:03:16 -0800971 thread->VisitRoots(MarkSweep::MarkRootParallelCallback, mark_sweep_);
Mathieu Chartier3f966702013-09-04 16:50:05 -0700972 ATRACE_END();
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700973 if (revoke_ros_alloc_thread_local_buffers_at_checkpoint_) {
974 ATRACE_BEGIN("RevokeRosAllocThreadLocalBuffers");
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -0700975 mark_sweep_->GetHeap()->RevokeRosAllocThreadLocalBuffers(thread);
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700976 ATRACE_END();
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -0700977 }
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700978 mark_sweep_->GetBarrier().Pass(self);
979 }
980
981 private:
Mathieu Chartier4aeec172014-03-27 16:09:46 -0700982 MarkSweep* const mark_sweep_;
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700983 const bool revoke_ros_alloc_thread_local_buffers_at_checkpoint_;
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700984};
985
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700986void MarkSweep::MarkRootsCheckpoint(Thread* self,
987 bool revoke_ros_alloc_thread_local_buffers_at_checkpoint) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700988 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -0700989 CheckpointMarkThreadRoots check_point(this, revoke_ros_alloc_thread_local_buffers_at_checkpoint);
Mathieu Chartier858f1c52012-10-17 17:45:55 -0700990 ThreadList* thread_list = Runtime::Current()->GetThreadList();
Ian Rogers1d54e732013-05-02 21:10:01 -0700991 // Request the check point is run on all threads returning a count of the threads that must
992 // run through the barrier including self.
993 size_t barrier_count = thread_list->RunCheckpoint(&check_point);
994 // Release locks then wait for all mutator threads to pass the barrier.
995 // TODO: optimize to not release locks when there are no threads to wait for.
996 Locks::heap_bitmap_lock_->ExclusiveUnlock(self);
997 Locks::mutator_lock_->SharedUnlock(self);
Mathieu Chartier4aeec172014-03-27 16:09:46 -0700998 {
999 ScopedThreadStateChange tsc(self, kWaitingForCheckPointsToRun);
1000 gc_barrier_->Increment(self, barrier_count);
1001 }
Ian Rogers1d54e732013-05-02 21:10:01 -07001002 Locks::mutator_lock_->SharedLock(self);
1003 Locks::heap_bitmap_lock_->ExclusiveLock(self);
Mathieu Chartier858f1c52012-10-17 17:45:55 -07001004}
1005
Ian Rogers1d54e732013-05-02 21:10:01 -07001006void MarkSweep::SweepArray(accounting::ObjectStack* allocations, bool swap_bitmaps) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001007 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001008 Thread* self = Thread::Current();
Hiroshi Yamauchibbdc5bc2014-05-28 14:04:59 -07001009 mirror::Object** chunk_free_buffer = reinterpret_cast<mirror::Object**>(
1010 sweep_array_free_buffer_mem_map_->BaseBegin());
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001011 size_t chunk_free_pos = 0;
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001012 ObjectBytePair freed;
1013 ObjectBytePair freed_los;
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001014 // How many objects are left in the array, modified after each space is swept.
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -07001015 Object** objects = allocations->Begin();
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001016 size_t count = allocations->Size();
1017 // Change the order to ensure that the non-moving space last swept as an optimization.
1018 std::vector<space::ContinuousSpace*> sweep_spaces;
1019 space::ContinuousSpace* non_moving_space = nullptr;
1020 for (space::ContinuousSpace* space : heap_->GetContinuousSpaces()) {
Mathieu Chartier8d562102014-03-12 17:42:10 -07001021 if (space->IsAllocSpace() && !immune_region_.ContainsSpace(space) &&
1022 space->GetLiveBitmap() != nullptr) {
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001023 if (space == heap_->GetNonMovingSpace()) {
1024 non_moving_space = space;
1025 } else {
1026 sweep_spaces.push_back(space);
1027 }
1028 }
1029 }
1030 // Unlikely to sweep a significant amount of non_movable objects, so we do these after the after
1031 // the other alloc spaces as an optimization.
1032 if (non_moving_space != nullptr) {
1033 sweep_spaces.push_back(non_moving_space);
1034 }
1035 // Start by sweeping the continuous spaces.
1036 for (space::ContinuousSpace* space : sweep_spaces) {
1037 space::AllocSpace* alloc_space = space->AsAllocSpace();
Mathieu Chartiera8e8f9c2014-04-09 14:51:05 -07001038 accounting::ContinuousSpaceBitmap* live_bitmap = space->GetLiveBitmap();
1039 accounting::ContinuousSpaceBitmap* mark_bitmap = space->GetMarkBitmap();
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001040 if (swap_bitmaps) {
1041 std::swap(live_bitmap, mark_bitmap);
1042 }
1043 Object** out = objects;
1044 for (size_t i = 0; i < count; ++i) {
1045 Object* obj = objects[i];
Hiroshi Yamauchif5b0e202014-02-11 17:02:22 -08001046 if (kUseThreadLocalAllocationStack && obj == nullptr) {
1047 continue;
1048 }
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001049 if (space->HasAddress(obj)) {
1050 // This object is in the space, remove it from the array and add it to the sweep buffer
1051 // if needed.
1052 if (!mark_bitmap->Test(obj)) {
1053 if (chunk_free_pos >= kSweepArrayChunkFreeSize) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001054 TimingLogger::ScopedTiming t("FreeList", GetTimings());
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001055 freed.objects += chunk_free_pos;
1056 freed.bytes += alloc_space->FreeList(self, chunk_free_pos, chunk_free_buffer);
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001057 chunk_free_pos = 0;
1058 }
1059 chunk_free_buffer[chunk_free_pos++] = obj;
1060 }
1061 } else {
1062 *(out++) = obj;
1063 }
1064 }
1065 if (chunk_free_pos > 0) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001066 TimingLogger::ScopedTiming t("FreeList", GetTimings());
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001067 freed.objects += chunk_free_pos;
1068 freed.bytes += alloc_space->FreeList(self, chunk_free_pos, chunk_free_buffer);
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001069 chunk_free_pos = 0;
1070 }
1071 // All of the references which space contained are no longer in the allocation stack, update
1072 // the count.
1073 count = out - objects;
1074 }
1075 // Handle the large object space.
1076 space::LargeObjectSpace* large_object_space = GetHeap()->GetLargeObjectsSpace();
Mathieu Chartierbbd695c2014-04-16 09:48:48 -07001077 accounting::LargeObjectBitmap* large_live_objects = large_object_space->GetLiveBitmap();
1078 accounting::LargeObjectBitmap* large_mark_objects = large_object_space->GetMarkBitmap();
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001079 if (swap_bitmaps) {
1080 std::swap(large_live_objects, large_mark_objects);
1081 }
Brian Carlstrom02c8cc62013-07-18 15:54:44 -07001082 for (size_t i = 0; i < count; ++i) {
Mathieu Chartier357e9be2012-08-01 11:00:14 -07001083 Object* obj = objects[i];
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001084 // Handle large objects.
Hiroshi Yamauchif5b0e202014-02-11 17:02:22 -08001085 if (kUseThreadLocalAllocationStack && obj == nullptr) {
1086 continue;
1087 }
Mathieu Chartiere6da9af2013-12-16 11:54:42 -08001088 if (!large_mark_objects->Test(obj)) {
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001089 ++freed_los.objects;
1090 freed_los.bytes += large_object_space->Free(self, obj);
Mathieu Chartier357e9be2012-08-01 11:00:14 -07001091 }
1092 }
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001093 {
1094 TimingLogger::ScopedTiming t("RecordFree", GetTimings());
1095 RecordFree(freed);
1096 RecordFreeLOS(freed_los);
1097 t.NewTiming("ResetStack");
1098 allocations->Reset();
1099 }
Ian Rogersc5f17732014-06-05 20:48:42 -07001100 sweep_array_free_buffer_mem_map_->MadviseDontNeedAndZero();
Mathieu Chartier357e9be2012-08-01 11:00:14 -07001101}
1102
Ian Rogers1d54e732013-05-02 21:10:01 -07001103void MarkSweep::Sweep(bool swap_bitmaps) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001104 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartier0f7bf6a2014-03-28 10:05:39 -07001105 // Ensure that nobody inserted items in the live stack after we swapped the stacks.
1106 CHECK_GE(live_stack_freeze_size_, GetHeap()->GetLiveStack()->Size());
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001107 {
1108 TimingLogger::ScopedTiming t2("MarkAllocStackAsLive", GetTimings());
1109 // Mark everything allocated since the last as GC live so that we can sweep concurrently,
1110 // knowing that new allocations won't be marked as live.
1111 accounting::ObjectStack* live_stack = heap_->GetLiveStack();
1112 heap_->MarkAllocStackAsLive(live_stack);
1113 live_stack->Reset();
1114 DCHECK(mark_stack_->IsEmpty());
1115 }
Mathieu Chartier02e25112013-08-14 16:14:24 -07001116 for (const auto& space : GetHeap()->GetContinuousSpaces()) {
Mathieu Chartiera1602f22014-01-13 17:19:19 -08001117 if (space->IsContinuousMemMapAllocSpace()) {
1118 space::ContinuousMemMapAllocSpace* alloc_space = space->AsContinuousMemMapAllocSpace();
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001119 TimingLogger::ScopedTiming split(
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001120 alloc_space->IsZygoteSpace() ? "SweepZygoteSpace" : "SweepMallocSpace", GetTimings());
1121 RecordFree(alloc_space->Sweep(swap_bitmaps));
Carl Shapiro58551df2011-07-24 03:09:51 -07001122 }
1123 }
Mathieu Chartier2b82db42012-11-14 17:29:05 -08001124 SweepLargeObjects(swap_bitmaps);
Carl Shapiro58551df2011-07-24 03:09:51 -07001125}
1126
Mathieu Chartiere0f0cb32012-08-28 11:26:00 -07001127void MarkSweep::SweepLargeObjects(bool swap_bitmaps) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001128 TimingLogger::ScopedTiming split(__FUNCTION__, GetTimings());
Mathieu Chartier10fb83a2014-06-15 15:15:43 -07001129 RecordFreeLOS(heap_->GetLargeObjectsSpace()->Sweep(swap_bitmaps));
Mathieu Chartiere0f0cb32012-08-28 11:26:00 -07001130}
1131
Mathieu Chartier407f7022014-02-18 14:37:05 -08001132// Process the "referent" field in a java.lang.ref.Reference. If the referent has not yet been
1133// marked, put it on the appropriate list in the heap for later processing.
1134void MarkSweep::DelayReferenceReferent(mirror::Class* klass, mirror::Reference* ref) {
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001135 if (kCountJavaLangRefs) {
1136 ++reference_count_;
1137 }
Mathieu Chartier308351a2014-06-15 12:39:02 -07001138 heap_->GetReferenceProcessor()->DelayReferenceReferent(klass, ref, &HeapReferenceMarkedCallback,
1139 this);
Carl Shapiro69759ea2011-07-21 18:13:35 -07001140}
1141
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001142class MarkObjectVisitor {
1143 public:
Mathieu Chartier407f7022014-02-18 14:37:05 -08001144 explicit MarkObjectVisitor(MarkSweep* const mark_sweep) ALWAYS_INLINE : mark_sweep_(mark_sweep) {
1145 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001146
Mathieu Chartier407f7022014-02-18 14:37:05 -08001147 void operator()(Object* obj, MemberOffset offset, bool /* is_static */) const
1148 ALWAYS_INLINE SHARED_LOCKS_REQUIRED(Locks::mutator_lock_)
1149 EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) {
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001150 if (kCheckLocks) {
Mathieu Chartier2b82db42012-11-14 17:29:05 -08001151 Locks::mutator_lock_->AssertSharedHeld(Thread::Current());
1152 Locks::heap_bitmap_lock_->AssertExclusiveHeld(Thread::Current());
1153 }
Ian Rogersb0fa5dc2014-04-28 16:47:08 -07001154 mark_sweep_->MarkObject(obj->GetFieldObject<mirror::Object>(offset));
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001155 }
1156
1157 private:
1158 MarkSweep* const mark_sweep_;
1159};
1160
Carl Shapiro69759ea2011-07-21 18:13:35 -07001161// Scans an object reference. Determines the type of the reference
1162// and dispatches to a specialized scanning routine.
Mathieu Chartier590fee92013-09-13 13:46:47 -07001163void MarkSweep::ScanObject(Object* obj) {
Mathieu Chartier407f7022014-02-18 14:37:05 -08001164 MarkObjectVisitor mark_visitor(this);
1165 DelayReferenceReferentVisitor ref_visitor(this);
1166 ScanObjectVisit(obj, mark_visitor, ref_visitor);
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001167}
1168
Mathieu Chartier78f7b4c2014-05-06 10:57:27 -07001169void MarkSweep::ProcessMarkStackCallback(void* arg) {
1170 reinterpret_cast<MarkSweep*>(arg)->ProcessMarkStack(false);
Mathieu Chartier3bb57c72014-02-18 11:38:45 -08001171}
1172
Mathieu Chartier2775ee42013-08-20 17:43:47 -07001173void MarkSweep::ProcessMarkStackParallel(size_t thread_count) {
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001174 Thread* self = Thread::Current();
1175 ThreadPool* thread_pool = GetHeap()->GetThreadPool();
Mathieu Chartier2775ee42013-08-20 17:43:47 -07001176 const size_t chunk_size = std::min(mark_stack_->Size() / thread_count + 1,
1177 static_cast<size_t>(MarkStackTask<false>::kMaxSize));
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001178 CHECK_GT(chunk_size, 0U);
1179 // Split the current mark stack up into work tasks.
1180 for (mirror::Object **it = mark_stack_->Begin(), **end = mark_stack_->End(); it < end; ) {
1181 const size_t delta = std::min(static_cast<size_t>(end - it), chunk_size);
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001182 thread_pool->AddTask(self, new MarkStackTask<false>(thread_pool, this, delta, it));
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001183 it += delta;
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001184 }
Mathieu Chartier2775ee42013-08-20 17:43:47 -07001185 thread_pool->SetMaxActiveWorkers(thread_count - 1);
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001186 thread_pool->StartWorkers(self);
Mathieu Chartier2775ee42013-08-20 17:43:47 -07001187 thread_pool->Wait(self, true, true);
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001188 thread_pool->StopWorkers(self);
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001189 mark_stack_->Reset();
Ian Rogers3e5cf302014-05-20 16:40:37 -07001190 CHECK_EQ(work_chunks_created_.LoadSequentiallyConsistent(),
1191 work_chunks_deleted_.LoadSequentiallyConsistent())
1192 << " some of the work chunks were leaked";
Carl Shapiro69759ea2011-07-21 18:13:35 -07001193}
1194
Ian Rogers5d76c432011-10-31 21:42:49 -07001195// Scan anything that's on the mark stack.
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001196void MarkSweep::ProcessMarkStack(bool paused) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001197 TimingLogger::ScopedTiming t(paused ? "(Paused)ProcessMarkStack" : __FUNCTION__, GetTimings());
Mathieu Chartier2775ee42013-08-20 17:43:47 -07001198 size_t thread_count = GetThreadCount(paused);
1199 if (kParallelProcessMarkStack && thread_count > 1 &&
1200 mark_stack_->Size() >= kMinimumParallelMarkStackSize) {
1201 ProcessMarkStackParallel(thread_count);
Mathieu Chartierd8195f12012-10-05 12:21:28 -07001202 } else {
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001203 // TODO: Tune this.
1204 static const size_t kFifoSize = 4;
Mathieu Chartier590fee92013-09-13 13:46:47 -07001205 BoundedFifoPowerOfTwo<Object*, kFifoSize> prefetch_fifo;
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001206 for (;;) {
Mathieu Chartier590fee92013-09-13 13:46:47 -07001207 Object* obj = NULL;
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001208 if (kUseMarkStackPrefetch) {
1209 while (!mark_stack_->IsEmpty() && prefetch_fifo.size() < kFifoSize) {
Mathieu Chartier590fee92013-09-13 13:46:47 -07001210 Object* obj = mark_stack_->PopBack();
Mathieu Chartier94c32c52013-08-09 11:14:04 -07001211 DCHECK(obj != NULL);
1212 __builtin_prefetch(obj);
1213 prefetch_fifo.push_back(obj);
1214 }
1215 if (prefetch_fifo.empty()) {
1216 break;
1217 }
1218 obj = prefetch_fifo.front();
1219 prefetch_fifo.pop_front();
1220 } else {
1221 if (mark_stack_->IsEmpty()) {
1222 break;
1223 }
1224 obj = mark_stack_->PopBack();
1225 }
Mathieu Chartier4aeec172014-03-27 16:09:46 -07001226 DCHECK(obj != nullptr);
Mathieu Chartierd8195f12012-10-05 12:21:28 -07001227 ScanObject(obj);
Mathieu Chartier357e9be2012-08-01 11:00:14 -07001228 }
1229 }
Carl Shapiro69759ea2011-07-21 18:13:35 -07001230}
1231
Mathieu Chartier52e4b432014-06-10 11:22:31 -07001232inline bool MarkSweep::IsMarked(const Object* object) const {
Mathieu Chartier8d562102014-03-12 17:42:10 -07001233 if (immune_region_.ContainsObject(object)) {
Mathieu Chartier7469ebf2012-09-24 16:28:36 -07001234 return true;
1235 }
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001236 if (current_space_bitmap_->HasAddress(object)) {
1237 return current_space_bitmap_->Test(object);
Mathieu Chartier7469ebf2012-09-24 16:28:36 -07001238 }
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001239 return mark_bitmap_->Test(object);
Mathieu Chartier7469ebf2012-09-24 16:28:36 -07001240}
1241
Mathieu Chartier2b82db42012-11-14 17:29:05 -08001242void MarkSweep::FinishPhase() {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001243 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Mathieu Chartierd22d5482012-11-06 17:14:12 -08001244 if (kCountScannedTypes) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001245 VLOG(gc) << "MarkSweep scanned classes=" << class_count_.LoadRelaxed()
1246 << " arrays=" << array_count_.LoadRelaxed() << " other=" << other_count_.LoadRelaxed();
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001247 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001248 if (kCountTasks) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001249 VLOG(gc) << "Total number of work chunks allocated: " << work_chunks_created_.LoadRelaxed();
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001250 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001251 if (kMeasureOverhead) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001252 VLOG(gc) << "Overhead time " << PrettyDuration(overhead_time_.LoadRelaxed());
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001253 }
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001254 if (kProfileLargeObjects) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001255 VLOG(gc) << "Large objects tested " << large_object_test_.LoadRelaxed()
1256 << " marked " << large_object_mark_.LoadRelaxed();
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001257 }
Mathieu Chartierd22d5482012-11-06 17:14:12 -08001258 if (kCountJavaLangRefs) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001259 VLOG(gc) << "References scanned " << reference_count_.LoadRelaxed();
Mathieu Chartier02b6a782012-10-26 13:51:26 -07001260 }
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001261 if (kCountMarkedObjects) {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001262 VLOG(gc) << "Marked: null=" << mark_null_count_.LoadRelaxed()
1263 << " immune=" << mark_immune_count_.LoadRelaxed()
1264 << " fastpath=" << mark_fastpath_count_.LoadRelaxed()
1265 << " slowpath=" << mark_slowpath_count_.LoadRelaxed();
Mathieu Chartier0e54cd02014-03-20 12:41:23 -07001266 }
Mathieu Chartier4aeec172014-03-27 16:09:46 -07001267 CHECK(mark_stack_->IsEmpty()); // Ensure that the mark stack is empty.
Mathieu Chartier5301cd22012-05-31 12:11:36 -07001268 mark_stack_->Reset();
Mathieu Chartier4aeec172014-03-27 16:09:46 -07001269 WriterMutexLock mu(Thread::Current(), *Locks::heap_bitmap_lock_);
1270 heap_->ClearMarkedObjects();
Carl Shapiro69759ea2011-07-21 18:13:35 -07001271}
1272
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -07001273void MarkSweep::RevokeAllThreadLocalBuffers() {
1274 if (kRevokeRosAllocThreadLocalBuffersAtCheckpoint && IsConcurrent()) {
1275 // If concurrent, rosalloc thread-local buffers are revoked at the
1276 // thread checkpoint. Bump pointer space thread-local buffers must
1277 // not be in use.
1278 GetHeap()->AssertAllBumpPointerSpaceThreadLocalBuffersAreRevoked();
1279 } else {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001280 TimingLogger::ScopedTiming t(__FUNCTION__, GetTimings());
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -07001281 GetHeap()->RevokeAllThreadLocalBuffers();
Hiroshi Yamauchic93c5302014-03-20 16:15:37 -07001282 }
1283}
1284
Ian Rogers1d54e732013-05-02 21:10:01 -07001285} // namespace collector
1286} // namespace gc
Carl Shapiro69759ea2011-07-21 18:13:35 -07001287} // namespace art