blob: 946c0602cf38de03fe0a803fb04e12e9b2ccee9a [file] [log] [blame]
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001/*
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Nicolas Geoffraye5038322014-07-04 09:41:32 +010017#include "builder.h"
18
Mathieu Chartierc7853442015-03-27 14:35:38 -070019#include "art_field-inl.h"
Andreas Gamped881df52014-11-24 23:28:39 -080020#include "base/logging.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010021#include "class_linker.h"
Jeff Hao848f70a2014-01-15 13:49:50 -080022#include "dex/verified_method.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000023#include "dex_file-inl.h"
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +000024#include "dex_instruction-inl.h"
Roland Levillain4c0eb422015-04-24 16:43:49 +010025#include "dex/verified_method.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010026#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000027#include "driver/compiler_options.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010028#include "mirror/class_loader.h"
29#include "mirror/dex_cache.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000030#include "nodes.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000031#include "primitive.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010032#include "scoped_thread_state_change.h"
33#include "thread.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000034
35namespace art {
36
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010037/**
38 * Helper class to add HTemporary instructions. This class is used when
39 * converting a DEX instruction to multiple HInstruction, and where those
40 * instructions do not die at the following instruction, but instead spans
41 * multiple instructions.
42 */
43class Temporaries : public ValueObject {
44 public:
Calin Juravlef97f9fb2014-11-11 15:38:19 +000045 explicit Temporaries(HGraph* graph) : graph_(graph), index_(0) {}
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010046
47 void Add(HInstruction* instruction) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +000048 HInstruction* temp = new (graph_->GetArena()) HTemporary(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010049 instruction->GetBlock()->AddInstruction(temp);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000050
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010051 DCHECK(temp->GetPrevious() == instruction);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000052
53 size_t offset;
54 if (instruction->GetType() == Primitive::kPrimLong
55 || instruction->GetType() == Primitive::kPrimDouble) {
56 offset = 2;
57 } else {
58 offset = 1;
59 }
60 index_ += offset;
61
62 graph_->UpdateTemporariesVRegSlots(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010063 }
64
65 private:
66 HGraph* const graph_;
67
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010068 // Current index in the temporary stack, updated by `Add`.
69 size_t index_;
70};
71
Andreas Gamped881df52014-11-24 23:28:39 -080072class SwitchTable : public ValueObject {
73 public:
74 SwitchTable(const Instruction& instruction, uint32_t dex_pc, bool sparse)
75 : instruction_(instruction), dex_pc_(dex_pc), sparse_(sparse) {
76 int32_t table_offset = instruction.VRegB_31t();
77 const uint16_t* table = reinterpret_cast<const uint16_t*>(&instruction) + table_offset;
78 if (sparse) {
79 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kSparseSwitchSignature));
80 } else {
81 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kPackedSwitchSignature));
82 }
83 num_entries_ = table[1];
84 values_ = reinterpret_cast<const int32_t*>(&table[2]);
85 }
86
87 uint16_t GetNumEntries() const {
88 return num_entries_;
89 }
90
Andreas Gampee4d4d322014-12-04 09:09:57 -080091 void CheckIndex(size_t index) const {
92 if (sparse_) {
93 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
94 DCHECK_LT(index, 2 * static_cast<size_t>(num_entries_));
95 } else {
96 // In a packed table, we have the starting key and num_entries_ values.
97 DCHECK_LT(index, 1 + static_cast<size_t>(num_entries_));
98 }
99 }
100
Andreas Gamped881df52014-11-24 23:28:39 -0800101 int32_t GetEntryAt(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800102 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800103 return values_[index];
104 }
105
106 uint32_t GetDexPcForIndex(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800107 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800108 return dex_pc_ +
109 (reinterpret_cast<const int16_t*>(values_ + index) -
110 reinterpret_cast<const int16_t*>(&instruction_));
111 }
112
Andreas Gampee4d4d322014-12-04 09:09:57 -0800113 // Index of the first value in the table.
114 size_t GetFirstValueIndex() const {
115 if (sparse_) {
116 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
117 return num_entries_;
118 } else {
119 // In a packed table, we have the starting key and num_entries_ values.
120 return 1;
121 }
122 }
123
Andreas Gamped881df52014-11-24 23:28:39 -0800124 private:
125 const Instruction& instruction_;
126 const uint32_t dex_pc_;
127
128 // Whether this is a sparse-switch table (or a packed-switch one).
129 const bool sparse_;
130
131 // This can't be const as it needs to be computed off of the given instruction, and complicated
132 // expressions in the initializer list seemed very ugly.
133 uint16_t num_entries_;
134
135 const int32_t* values_;
136
137 DISALLOW_COPY_AND_ASSIGN(SwitchTable);
138};
139
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100140void HGraphBuilder::InitializeLocals(uint16_t count) {
141 graph_->SetNumberOfVRegs(count);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000142 locals_.SetSize(count);
143 for (int i = 0; i < count; i++) {
144 HLocal* local = new (arena_) HLocal(i);
145 entry_block_->AddInstruction(local);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000146 locals_.Put(i, local);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000147 }
148}
149
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000150void HGraphBuilder::InitializeParameters(uint16_t number_of_parameters) {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100151 // dex_compilation_unit_ is null only when unit testing.
152 if (dex_compilation_unit_ == nullptr) {
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000153 return;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100154 }
155
156 graph_->SetNumberOfInVRegs(number_of_parameters);
157 const char* shorty = dex_compilation_unit_->GetShorty();
158 int locals_index = locals_.Size() - number_of_parameters;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100159 int parameter_index = 0;
160
161 if (!dex_compilation_unit_->IsStatic()) {
162 // Add the implicit 'this' argument, not expressed in the signature.
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100163 HParameterValue* parameter =
Calin Juravle10e244f2015-01-26 18:54:32 +0000164 new (arena_) HParameterValue(parameter_index++, Primitive::kPrimNot, true);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100165 entry_block_->AddInstruction(parameter);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100166 HLocal* local = GetLocalAt(locals_index++);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100167 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100168 number_of_parameters--;
169 }
170
171 uint32_t pos = 1;
172 for (int i = 0; i < number_of_parameters; i++) {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100173 HParameterValue* parameter =
174 new (arena_) HParameterValue(parameter_index++, Primitive::GetType(shorty[pos++]));
175 entry_block_->AddInstruction(parameter);
176 HLocal* local = GetLocalAt(locals_index++);
177 // Store the parameter value in the local that the dex code will use
178 // to reference that parameter.
179 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter));
180 bool is_wide = (parameter->GetType() == Primitive::kPrimLong)
181 || (parameter->GetType() == Primitive::kPrimDouble);
182 if (is_wide) {
183 i++;
184 locals_index++;
185 parameter_index++;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100186 }
187 }
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100188}
189
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100190template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000191void HGraphBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000192 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000193 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
194 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
195 DCHECK(branch_target != nullptr);
196 DCHECK(fallthrough_target != nullptr);
197 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100198 HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
199 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
Dave Allison20dfc792014-06-16 20:44:29 -0700200 T* comparison = new (arena_) T(first, second);
201 current_block_->AddInstruction(comparison);
202 HInstruction* ifinst = new (arena_) HIf(comparison);
203 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000204 current_block_->AddSuccessor(branch_target);
205 current_block_->AddSuccessor(fallthrough_target);
Dave Allison20dfc792014-06-16 20:44:29 -0700206 current_block_ = nullptr;
207}
208
209template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000210void HGraphBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000211 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000212 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
213 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
214 DCHECK(branch_target != nullptr);
215 DCHECK(fallthrough_target != nullptr);
216 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700217 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000218 T* comparison = new (arena_) T(value, graph_->GetIntConstant(0));
Dave Allison20dfc792014-06-16 20:44:29 -0700219 current_block_->AddInstruction(comparison);
220 HInstruction* ifinst = new (arena_) HIf(comparison);
221 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000222 current_block_->AddSuccessor(branch_target);
223 current_block_->AddSuccessor(fallthrough_target);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100224 current_block_ = nullptr;
225}
226
Calin Juravle48c2b032014-12-09 18:11:36 +0000227void HGraphBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) {
228 if (compilation_stats_ != nullptr) {
229 compilation_stats_->RecordStat(compilation_stat);
230 }
231}
232
David Brazdil1b498722015-03-31 11:37:18 +0100233bool HGraphBuilder::SkipCompilation(const DexFile::CodeItem& code_item,
Calin Juravle48c2b032014-12-09 18:11:36 +0000234 size_t number_of_branches) {
235 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000236 CompilerOptions::CompilerFilter compiler_filter = compiler_options.GetCompilerFilter();
237 if (compiler_filter == CompilerOptions::kEverything) {
238 return false;
239 }
240
David Brazdil1b498722015-03-31 11:37:18 +0100241 if (compiler_options.IsHugeMethod(code_item.insns_size_in_code_units_)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000242 VLOG(compiler) << "Skip compilation of huge method "
243 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100244 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000245 MaybeRecordStat(MethodCompilationStat::kNotCompiledHugeMethod);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000246 return true;
247 }
248
249 // If it's large and contains no branches, it's likely to be machine generated initialization.
David Brazdil1b498722015-03-31 11:37:18 +0100250 if (compiler_options.IsLargeMethod(code_item.insns_size_in_code_units_)
251 && (number_of_branches == 0)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000252 VLOG(compiler) << "Skip compilation of large method with no branch "
253 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100254 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000255 MaybeRecordStat(MethodCompilationStat::kNotCompiledLargeMethodNoBranches);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000256 return true;
257 }
258
259 return false;
260}
261
David Brazdil5e8b1372015-01-23 14:39:08 +0000262bool HGraphBuilder::BuildGraph(const DexFile::CodeItem& code_item) {
263 DCHECK(graph_->GetBlocks().IsEmpty());
264
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000265 const uint16_t* code_ptr = code_item.insns_;
266 const uint16_t* code_end = code_item.insns_ + code_item.insns_size_in_code_units_;
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100267 code_start_ = code_ptr;
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000268
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000269 // Setup the graph with the entry block and exit block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100270 entry_block_ = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000271 graph_->AddBlock(entry_block_);
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100272 exit_block_ = new (arena_) HBasicBlock(graph_, kNoDexPc);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000273 graph_->SetEntryBlock(entry_block_);
274 graph_->SetExitBlock(exit_block_);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000275
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000276 InitializeLocals(code_item.registers_size_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000277 graph_->SetMaximumNumberOfOutVRegs(code_item.outs_size_);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000278
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000279 // Compute the number of dex instructions, blocks, and branches. We will
280 // check these values against limits given to the compiler.
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000281 size_t number_of_branches = 0;
282
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000283 // To avoid splitting blocks, we compute ahead of time the instructions that
284 // start a new block, and create these blocks.
Calin Juravle702d2602015-04-30 19:28:21 +0100285 if (!ComputeBranchTargets(code_ptr, code_end, &number_of_branches)) {
286 MaybeRecordStat(MethodCompilationStat::kNotCompiledBranchOutsideMethodCode);
287 return false;
288 }
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000289
290 // Note that the compiler driver is null when unit testing.
David Brazdil1b498722015-03-31 11:37:18 +0100291 if ((compiler_driver_ != nullptr) && SkipCompilation(code_item, number_of_branches)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000292 return false;
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000293 }
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000294
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +0000295 // Also create blocks for catch handlers.
296 if (code_item.tries_size_ != 0) {
297 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(code_item, 0);
298 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr);
299 for (uint32_t idx = 0; idx < handlers_size; ++idx) {
300 CatchHandlerIterator iterator(handlers_ptr);
301 for (; iterator.HasNext(); iterator.Next()) {
302 uint32_t address = iterator.GetHandlerAddress();
303 HBasicBlock* block = FindBlockStartingAt(address);
304 if (block == nullptr) {
305 block = new (arena_) HBasicBlock(graph_, address);
306 branch_targets_.Put(address, block);
307 }
308 block->SetIsCatchBlock();
309 }
310 handlers_ptr = iterator.EndDataPointer();
311 }
312 }
313
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000314 InitializeParameters(code_item.ins_size_);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100315
Calin Juravle225ff812014-11-13 16:46:39 +0000316 size_t dex_pc = 0;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000317 while (code_ptr < code_end) {
Calin Juravle225ff812014-11-13 16:46:39 +0000318 // Update the current block if dex_pc starts a new block.
319 MaybeUpdateCurrentBlock(dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000320 const Instruction& instruction = *Instruction::At(code_ptr);
Calin Juravle48c2b032014-12-09 18:11:36 +0000321 if (!AnalyzeDexInstruction(instruction, dex_pc)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000322 return false;
Calin Juravle48c2b032014-12-09 18:11:36 +0000323 }
Calin Juravle225ff812014-11-13 16:46:39 +0000324 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000325 code_ptr += instruction.SizeInCodeUnits();
326 }
327
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000328 // Add the exit block at the end to give it the highest id.
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000329 graph_->AddBlock(exit_block_);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000330 exit_block_->AddInstruction(new (arena_) HExit());
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000331 // Add the suspend check to the entry block.
332 entry_block_->AddInstruction(new (arena_) HSuspendCheck(0));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000333 entry_block_->AddInstruction(new (arena_) HGoto());
David Brazdil5e8b1372015-01-23 14:39:08 +0000334
335 return true;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000336}
337
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000338void HGraphBuilder::MaybeUpdateCurrentBlock(size_t index) {
339 HBasicBlock* block = FindBlockStartingAt(index);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000340 if (block == nullptr) {
341 return;
342 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000343
344 if (current_block_ != nullptr) {
345 // Branching instructions clear current_block, so we know
346 // the last instruction of the current block is not a branching
347 // instruction. We add an unconditional goto to the found block.
348 current_block_->AddInstruction(new (arena_) HGoto());
349 current_block_->AddSuccessor(block);
350 }
351 graph_->AddBlock(block);
352 current_block_ = block;
353}
354
Calin Juravle702d2602015-04-30 19:28:21 +0100355bool HGraphBuilder::ComputeBranchTargets(const uint16_t* code_ptr,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000356 const uint16_t* code_end,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000357 size_t* number_of_branches) {
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000358 branch_targets_.SetSize(code_end - code_ptr);
359
360 // Create the first block for the dex instructions, single successor of the entry block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100361 HBasicBlock* block = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000362 branch_targets_.Put(0, block);
363 entry_block_->AddSuccessor(block);
364
365 // Iterate over all instructions and find branching instructions. Create blocks for
366 // the locations these instructions branch to.
Andreas Gamped881df52014-11-24 23:28:39 -0800367 uint32_t dex_pc = 0;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000368 while (code_ptr < code_end) {
369 const Instruction& instruction = *Instruction::At(code_ptr);
370 if (instruction.IsBranch()) {
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000371 (*number_of_branches)++;
Calin Juravle225ff812014-11-13 16:46:39 +0000372 int32_t target = instruction.GetTargetOffset() + dex_pc;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000373 // Create a block for the target instruction.
374 if (FindBlockStartingAt(target) == nullptr) {
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100375 block = new (arena_) HBasicBlock(graph_, target);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000376 branch_targets_.Put(target, block);
377 }
Calin Juravle225ff812014-11-13 16:46:39 +0000378 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000379 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100380
381 if (code_ptr >= code_end) {
382 if (instruction.CanFlowThrough()) {
383 // In the normal case we should never hit this but someone can artificially forge a dex
384 // file to fall-through out the method code. In this case we bail out compilation.
385 return false;
386 }
387 } else if (FindBlockStartingAt(dex_pc) == nullptr) {
Calin Juravle225ff812014-11-13 16:46:39 +0000388 block = new (arena_) HBasicBlock(graph_, dex_pc);
389 branch_targets_.Put(dex_pc, block);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000390 }
Andreas Gampee4d4d322014-12-04 09:09:57 -0800391 } else if (instruction.IsSwitch()) {
392 SwitchTable table(instruction, dex_pc, instruction.Opcode() == Instruction::SPARSE_SWITCH);
Andreas Gamped881df52014-11-24 23:28:39 -0800393
394 uint16_t num_entries = table.GetNumEntries();
395
Andreas Gampee4d4d322014-12-04 09:09:57 -0800396 // In a packed-switch, the entry at index 0 is the starting key. In a sparse-switch, the
397 // entry at index 0 is the first key, and values are after *all* keys.
398 size_t offset = table.GetFirstValueIndex();
399
400 // Use a larger loop counter type to avoid overflow issues.
401 for (size_t i = 0; i < num_entries; ++i) {
Andreas Gamped881df52014-11-24 23:28:39 -0800402 // The target of the case.
Andreas Gampee4d4d322014-12-04 09:09:57 -0800403 uint32_t target = dex_pc + table.GetEntryAt(i + offset);
Andreas Gamped881df52014-11-24 23:28:39 -0800404 if (FindBlockStartingAt(target) == nullptr) {
405 block = new (arena_) HBasicBlock(graph_, target);
406 branch_targets_.Put(target, block);
Andreas Gamped881df52014-11-24 23:28:39 -0800407 }
408
409 // The next case gets its own block.
410 if (i < num_entries) {
411 block = new (arena_) HBasicBlock(graph_, target);
412 branch_targets_.Put(table.GetDexPcForIndex(i), block);
Andreas Gamped881df52014-11-24 23:28:39 -0800413 }
414 }
415
416 // Fall-through. Add a block if there is more code afterwards.
417 dex_pc += instruction.SizeInCodeUnits();
418 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100419 if (code_ptr >= code_end) {
420 // In the normal case we should never hit this but someone can artificially forge a dex
421 // file to fall-through out the method code. In this case we bail out compilation.
422 // (A switch can fall-through so we don't need to check CanFlowThrough().)
423 return false;
424 } else if (FindBlockStartingAt(dex_pc) == nullptr) {
Andreas Gamped881df52014-11-24 23:28:39 -0800425 block = new (arena_) HBasicBlock(graph_, dex_pc);
426 branch_targets_.Put(dex_pc, block);
Andreas Gamped881df52014-11-24 23:28:39 -0800427 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000428 } else {
429 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle225ff812014-11-13 16:46:39 +0000430 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000431 }
432 }
Calin Juravle702d2602015-04-30 19:28:21 +0100433 return true;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000434}
435
436HBasicBlock* HGraphBuilder::FindBlockStartingAt(int32_t index) const {
437 DCHECK_GE(index, 0);
438 return branch_targets_.Get(index);
439}
440
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100441template<typename T>
Roland Levillain88cb1752014-10-20 16:36:47 +0100442void HGraphBuilder::Unop_12x(const Instruction& instruction, Primitive::Type type) {
443 HInstruction* first = LoadLocal(instruction.VRegB(), type);
444 current_block_->AddInstruction(new (arena_) T(type, first));
445 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
446}
447
Roland Levillaindff1f282014-11-05 14:15:05 +0000448void HGraphBuilder::Conversion_12x(const Instruction& instruction,
449 Primitive::Type input_type,
Roland Levillain624279f2014-12-04 11:54:28 +0000450 Primitive::Type result_type,
451 uint32_t dex_pc) {
Roland Levillaindff1f282014-11-05 14:15:05 +0000452 HInstruction* first = LoadLocal(instruction.VRegB(), input_type);
Roland Levillain624279f2014-12-04 11:54:28 +0000453 current_block_->AddInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc));
Roland Levillaindff1f282014-11-05 14:15:05 +0000454 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
455}
456
Roland Levillain88cb1752014-10-20 16:36:47 +0100457template<typename T>
Nicolas Geoffray412f10c2014-06-19 10:00:34 +0100458void HGraphBuilder::Binop_23x(const Instruction& instruction, Primitive::Type type) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100459 HInstruction* first = LoadLocal(instruction.VRegB(), type);
460 HInstruction* second = LoadLocal(instruction.VRegC(), type);
461 current_block_->AddInstruction(new (arena_) T(type, first, second));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100462 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
463}
464
465template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000466void HGraphBuilder::Binop_23x(const Instruction& instruction,
467 Primitive::Type type,
468 uint32_t dex_pc) {
469 HInstruction* first = LoadLocal(instruction.VRegB(), type);
470 HInstruction* second = LoadLocal(instruction.VRegC(), type);
471 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
472 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
473}
474
475template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000476void HGraphBuilder::Binop_23x_shift(const Instruction& instruction,
477 Primitive::Type type) {
478 HInstruction* first = LoadLocal(instruction.VRegB(), type);
479 HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt);
480 current_block_->AddInstruction(new (arena_) T(type, first, second));
481 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
482}
483
Calin Juravleddb7df22014-11-25 20:56:51 +0000484void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction,
485 Primitive::Type type,
486 HCompare::Bias bias) {
487 HInstruction* first = LoadLocal(instruction.VRegB(), type);
488 HInstruction* second = LoadLocal(instruction.VRegC(), type);
489 current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias));
490 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
491}
492
Calin Juravle9aec02f2014-11-18 23:06:35 +0000493template<typename T>
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100494void HGraphBuilder::Binop_12x(const Instruction& instruction, Primitive::Type type) {
495 HInstruction* first = LoadLocal(instruction.VRegA(), type);
496 HInstruction* second = LoadLocal(instruction.VRegB(), type);
497 current_block_->AddInstruction(new (arena_) T(type, first, second));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100498 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
499}
500
501template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000502void HGraphBuilder::Binop_12x_shift(const Instruction& instruction, Primitive::Type type) {
503 HInstruction* first = LoadLocal(instruction.VRegA(), type);
504 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
505 current_block_->AddInstruction(new (arena_) T(type, first, second));
506 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
507}
508
509template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000510void HGraphBuilder::Binop_12x(const Instruction& instruction,
511 Primitive::Type type,
512 uint32_t dex_pc) {
513 HInstruction* first = LoadLocal(instruction.VRegA(), type);
514 HInstruction* second = LoadLocal(instruction.VRegB(), type);
515 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
516 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
517}
518
519template<typename T>
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100520void HGraphBuilder::Binop_22s(const Instruction& instruction, bool reverse) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100521 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000522 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s());
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100523 if (reverse) {
524 std::swap(first, second);
525 }
526 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second));
527 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
528}
529
530template<typename T>
531void HGraphBuilder::Binop_22b(const Instruction& instruction, bool reverse) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100532 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000533 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b());
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100534 if (reverse) {
535 std::swap(first, second);
536 }
537 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second));
538 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
539}
540
Calin Juravle0c25d102015-04-20 14:49:09 +0100541static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, const CompilerDriver& driver) {
Calin Juravle27df7582015-04-17 19:12:31 +0100542 Thread* self = Thread::Current();
Calin Juravle0c25d102015-04-20 14:49:09 +0100543 return cu->IsConstructor()
544 && driver.RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex());
Calin Juravle27df7582015-04-17 19:12:31 +0100545}
546
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100547void HGraphBuilder::BuildReturn(const Instruction& instruction, Primitive::Type type) {
548 if (type == Primitive::kPrimVoid) {
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100549 if (graph_->ShouldGenerateConstructorBarrier()) {
550 // The compilation unit is null during testing.
551 if (dex_compilation_unit_ != nullptr) {
552 DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, *compiler_driver_))
553 << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier.";
554 }
Calin Juravle27df7582015-04-17 19:12:31 +0100555 current_block_->AddInstruction(new (arena_) HMemoryBarrier(kStoreStore));
556 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100557 current_block_->AddInstruction(new (arena_) HReturnVoid());
558 } else {
559 HInstruction* value = LoadLocal(instruction.VRegA(), type);
560 current_block_->AddInstruction(new (arena_) HReturn(value));
561 }
562 current_block_->AddSuccessor(exit_block_);
563 current_block_ = nullptr;
564}
565
566bool HGraphBuilder::BuildInvoke(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +0000567 uint32_t dex_pc,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100568 uint32_t method_idx,
569 uint32_t number_of_vreg_arguments,
570 bool is_range,
571 uint32_t* args,
572 uint32_t register_index) {
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100573 Instruction::Code opcode = instruction.Opcode();
574 InvokeType invoke_type;
575 switch (opcode) {
576 case Instruction::INVOKE_STATIC:
577 case Instruction::INVOKE_STATIC_RANGE:
578 invoke_type = kStatic;
579 break;
580 case Instruction::INVOKE_DIRECT:
581 case Instruction::INVOKE_DIRECT_RANGE:
582 invoke_type = kDirect;
583 break;
584 case Instruction::INVOKE_VIRTUAL:
585 case Instruction::INVOKE_VIRTUAL_RANGE:
586 invoke_type = kVirtual;
587 break;
588 case Instruction::INVOKE_INTERFACE:
589 case Instruction::INVOKE_INTERFACE_RANGE:
590 invoke_type = kInterface;
591 break;
592 case Instruction::INVOKE_SUPER_RANGE:
593 case Instruction::INVOKE_SUPER:
594 invoke_type = kSuper;
595 break;
596 default:
597 LOG(FATAL) << "Unexpected invoke op: " << opcode;
598 return false;
599 }
600
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100601 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx);
602 const DexFile::ProtoId& proto_id = dex_file_->GetProtoId(method_id.proto_idx_);
603 const char* descriptor = dex_file_->StringDataByIdx(proto_id.shorty_idx_);
604 Primitive::Type return_type = Primitive::GetType(descriptor[0]);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100605 bool is_instance_call = invoke_type != kStatic;
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100606 // Remove the return type from the 'proto'.
607 size_t number_of_arguments = strlen(descriptor) - 1;
608 if (is_instance_call) {
609 // One extra argument for 'this'.
610 ++number_of_arguments;
611 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100612
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000613 MethodReference target_method(dex_file_, method_idx);
614 uintptr_t direct_code;
615 uintptr_t direct_method;
616 int table_index;
617 InvokeType optimized_invoke_type = invoke_type;
Nicolas Geoffray52839d12014-11-07 17:47:25 +0000618
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000619 if (!compiler_driver_->ComputeInvokeInfo(dex_compilation_unit_, dex_pc, true, true,
620 &optimized_invoke_type, &target_method, &table_index,
621 &direct_code, &direct_method)) {
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100622 VLOG(compiler) << "Did not compile "
623 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
Calin Juravle48c2b032014-12-09 18:11:36 +0000624 << " because a method call could not be resolved";
625 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod);
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000626 return false;
627 }
628 DCHECK(optimized_invoke_type != kSuper);
629
Roland Levillain4c0eb422015-04-24 16:43:49 +0100630 // By default, consider that the called method implicitly requires
631 // an initialization check of its declaring method.
632 HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement =
633 HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit;
634 // Potential class initialization check, in the case of a static method call.
635 HClinitCheck* clinit_check = nullptr;
Jeff Hao848f70a2014-01-15 13:49:50 -0800636 // Replace calls to String.<init> with StringFactory.
637 int32_t string_init_offset = 0;
638 bool is_string_init = compiler_driver_->IsStringInit(method_idx, dex_file_, &string_init_offset);
639 if (is_string_init) {
640 return_type = Primitive::kPrimNot;
641 is_instance_call = false;
642 number_of_arguments--;
643 invoke_type = kStatic;
644 optimized_invoke_type = kStatic;
645 }
Roland Levillain4c0eb422015-04-24 16:43:49 +0100646
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000647 HInvoke* invoke = nullptr;
Roland Levillain4c0eb422015-04-24 16:43:49 +0100648
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000649 if (optimized_invoke_type == kVirtual) {
650 invoke = new (arena_) HInvokeVirtual(
Andreas Gampe71fb52f2014-12-29 17:43:08 -0800651 arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index);
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000652 } else if (optimized_invoke_type == kInterface) {
653 invoke = new (arena_) HInvokeInterface(
654 arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100655 } else {
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000656 DCHECK(optimized_invoke_type == kDirect || optimized_invoke_type == kStatic);
657 // Sharpening to kDirect only works if we compile PIC.
658 DCHECK((optimized_invoke_type == invoke_type) || (optimized_invoke_type != kDirect)
659 || compiler_driver_->GetCompilerOptions().GetCompilePic());
Nicolas Geoffray1cf95282014-12-12 19:22:03 +0000660 bool is_recursive =
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100661 (target_method.dex_method_index == outer_compilation_unit_->GetDexMethodIndex())
662 && (target_method.dex_file == outer_compilation_unit_->GetDexFile());
Roland Levillain4c0eb422015-04-24 16:43:49 +0100663
664 if (optimized_invoke_type == kStatic) {
665 ScopedObjectAccess soa(Thread::Current());
666 StackHandleScope<4> hs(soa.Self());
667 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
668 dex_compilation_unit_->GetClassLinker()->FindDexCache(
669 *dex_compilation_unit_->GetDexFile())));
670 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
671 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartiere401d142015-04-22 13:56:20 -0700672 ArtMethod* resolved_method = compiler_driver_->ResolveMethod(
673 soa, dex_cache, class_loader, dex_compilation_unit_, method_idx, optimized_invoke_type);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100674
675 if (resolved_method == nullptr) {
676 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod);
677 return false;
678 }
679
680 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
681 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
682 outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file)));
683 Handle<mirror::Class> referrer_class(hs.NewHandle(GetOutermostCompilingClass()));
684
685 // The index at which the method's class is stored in the DexCache's type array.
686 uint32_t storage_index = DexFile::kDexNoIndex;
687 bool is_referrer_class = (resolved_method->GetDeclaringClass() == referrer_class.Get());
688 if (is_referrer_class) {
689 storage_index = referrer_class->GetDexTypeIndex();
690 } else if (outer_dex_cache.Get() == dex_cache.Get()) {
691 // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer.
692 compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(),
693 referrer_class.Get(),
694 resolved_method,
695 method_idx,
696 &storage_index);
697 }
698
Roland Levillain5f02c6c2015-04-24 19:14:22 +0100699 if (referrer_class.Get()->IsSubClass(resolved_method->GetDeclaringClass())) {
700 // If the referrer class is the declaring class or a subclass
701 // of the declaring class, no class initialization is needed
702 // before the static method call.
Roland Levillain4c0eb422015-04-24 16:43:49 +0100703 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
704 } else if (storage_index != DexFile::kDexNoIndex) {
705 // If the method's class type index is available, check
706 // whether we should add an explicit class initialization
707 // check for its declaring class before the static method call.
708
709 // TODO: find out why this check is needed.
710 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
711 *outer_compilation_unit_->GetDexFile(), storage_index);
712 bool is_initialized =
713 resolved_method->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
714
715 if (is_initialized) {
716 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
717 } else {
718 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit;
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +0100719 HLoadClass* load_class = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +0100720 graph_->GetCurrentMethod(),
721 storage_index,
722 *dex_compilation_unit_->GetDexFile(),
723 is_referrer_class,
724 dex_pc);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100725 current_block_->AddInstruction(load_class);
726 clinit_check = new (arena_) HClinitCheck(load_class, dex_pc);
727 current_block_->AddInstruction(clinit_check);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100728 }
729 }
730 }
731
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100732 invoke = new (arena_) HInvokeStaticOrDirect(arena_,
733 number_of_arguments,
734 return_type,
735 dex_pc,
736 target_method.dex_method_index,
737 is_recursive,
738 string_init_offset,
739 invoke_type,
740 optimized_invoke_type,
741 clinit_check_requirement);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100742 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100743
744 size_t start_index = 0;
Calin Juravlef97f9fb2014-11-11 15:38:19 +0000745 Temporaries temps(graph_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100746 if (is_instance_call) {
747 HInstruction* arg = LoadLocal(is_range ? register_index : args[0], Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +0000748 HNullCheck* null_check = new (arena_) HNullCheck(arg, dex_pc);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +0100749 current_block_->AddInstruction(null_check);
750 temps.Add(null_check);
751 invoke->SetArgumentAt(0, null_check);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100752 start_index = 1;
753 }
754
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100755 uint32_t descriptor_index = 1; // Skip the return type.
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100756 uint32_t argument_index = start_index;
Jeff Hao848f70a2014-01-15 13:49:50 -0800757 if (is_string_init) {
758 start_index = 1;
759 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100760 for (size_t i = start_index;
761 // Make sure we don't go over the expected arguments or over the number of
762 // dex registers given. If the instruction was seen as dead by the verifier,
763 // it hasn't been properly checked.
764 (i < number_of_vreg_arguments) && (argument_index < number_of_arguments);
765 i++, argument_index++) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100766 Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100767 bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble);
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100768 if (!is_range
769 && is_wide
770 && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) {
771 // Longs and doubles should be in pairs, that is, sequential registers. The verifier should
772 // reject any class where this is violated. However, the verifier only does these checks
773 // on non trivially dead instructions, so we just bailout the compilation.
774 VLOG(compiler) << "Did not compile "
775 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
776 << " because of non-sequential dex register pair in wide argument";
777 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
778 return false;
779 }
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100780 HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type);
781 invoke->SetArgumentAt(argument_index, arg);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100782 if (is_wide) {
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100783 i++;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100784 }
785 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100786
787 if (argument_index != number_of_arguments) {
788 VLOG(compiler) << "Did not compile "
789 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
790 << " because of wrong number of arguments in invoke instruction";
791 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
792 return false;
793 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100794
Nicolas Geoffray38207af2015-06-01 15:46:22 +0100795 if (invoke->IsInvokeStaticOrDirect()) {
796 invoke->SetArgumentAt(argument_index, graph_->GetCurrentMethod());
797 argument_index++;
798 }
799
Roland Levillain4c0eb422015-04-24 16:43:49 +0100800 if (clinit_check_requirement == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit) {
801 // Add the class initialization check as last input of `invoke`.
802 DCHECK(clinit_check != nullptr);
Roland Levillain3e3d7332015-04-28 11:00:54 +0100803 invoke->SetArgumentAt(argument_index, clinit_check);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100804 }
805
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100806 current_block_->AddInstruction(invoke);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100807 latest_result_ = invoke;
Jeff Hao848f70a2014-01-15 13:49:50 -0800808
809 // Add move-result for StringFactory method.
810 if (is_string_init) {
811 uint32_t orig_this_reg = is_range ? register_index : args[0];
812 const VerifiedMethod* verified_method =
813 compiler_driver_->GetVerifiedMethod(dex_file_, dex_compilation_unit_->GetDexMethodIndex());
814 if (verified_method == nullptr) {
815 LOG(WARNING) << "No verified method for method calling String.<init>: "
816 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_);
817 return false;
818 }
819 const SafeMap<uint32_t, std::set<uint32_t>>& string_init_map =
820 verified_method->GetStringInitPcRegMap();
821 auto map_it = string_init_map.find(dex_pc);
822 if (map_it != string_init_map.end()) {
823 std::set<uint32_t> reg_set = map_it->second;
824 for (auto set_it = reg_set.begin(); set_it != reg_set.end(); ++set_it) {
825 UpdateLocal(*set_it, invoke);
826 }
827 }
828 UpdateLocal(orig_this_reg, invoke);
829 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100830 return true;
831}
832
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100833bool HGraphBuilder::BuildInstanceFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +0000834 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100835 bool is_put) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100836 uint32_t source_or_dest_reg = instruction.VRegA_22c();
837 uint32_t obj_reg = instruction.VRegB_22c();
838 uint16_t field_index = instruction.VRegC_22c();
839
840 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -0700841 ArtField* resolved_field =
842 compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa);
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100843
Mathieu Chartierc7853442015-03-27 14:35:38 -0700844 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000845 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100846 return false;
847 }
Calin Juravle52c48962014-12-16 17:02:57 +0000848
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100849 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100850
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100851 HInstruction* object = LoadLocal(obj_reg, Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +0000852 current_block_->AddInstruction(new (arena_) HNullCheck(object, dex_pc));
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100853 if (is_put) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +0000854 Temporaries temps(graph_);
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100855 HInstruction* null_check = current_block_->GetLastInstruction();
856 // We need one temporary for the null check.
857 temps.Add(null_check);
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100858 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100859 current_block_->AddInstruction(new (arena_) HInstanceFieldSet(
860 null_check,
861 value,
Nicolas Geoffray39468442014-09-02 15:17:15 +0100862 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +0000863 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +0100864 resolved_field->IsVolatile(),
865 field_index,
866 *dex_file_));
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100867 } else {
868 current_block_->AddInstruction(new (arena_) HInstanceFieldGet(
869 current_block_->GetLastInstruction(),
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100870 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +0000871 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +0100872 resolved_field->IsVolatile(),
873 field_index,
874 *dex_file_));
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100875
876 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
877 }
878 return true;
879}
880
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000881mirror::Class* HGraphBuilder::GetOutermostCompilingClass() const {
882 ScopedObjectAccess soa(Thread::Current());
883 StackHandleScope<2> hs(soa.Self());
884 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
885 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
886 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
887 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
888 outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file)));
889
890 return compiler_driver_->ResolveCompilingMethodsClass(
891 soa, outer_dex_cache, class_loader, outer_compilation_unit_);
892}
893
894bool HGraphBuilder::IsOutermostCompilingClass(uint16_t type_index) const {
895 ScopedObjectAccess soa(Thread::Current());
896 StackHandleScope<4> hs(soa.Self());
897 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
898 dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile())));
899 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
900 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
901 Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass(
902 soa, dex_cache, class_loader, type_index, dex_compilation_unit_)));
903 Handle<mirror::Class> compiling_class(hs.NewHandle(GetOutermostCompilingClass()));
904
905 return compiling_class.Get() == cls.Get();
906}
907
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100908bool HGraphBuilder::BuildStaticFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +0000909 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100910 bool is_put) {
911 uint32_t source_or_dest_reg = instruction.VRegA_21c();
912 uint16_t field_index = instruction.VRegB_21c();
913
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000914 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -0700915 StackHandleScope<4> hs(soa.Self());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000916 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
917 dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile())));
918 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
919 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartierc7853442015-03-27 14:35:38 -0700920 ArtField* resolved_field = compiler_driver_->ResolveField(
921 soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100922
Mathieu Chartierc7853442015-03-27 14:35:38 -0700923 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000924 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100925 return false;
926 }
927
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000928 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
929 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
930 outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file)));
931 Handle<mirror::Class> referrer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000932
933 // The index at which the field's class is stored in the DexCache's type array.
934 uint32_t storage_index;
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000935 bool is_referrer_class = (referrer_class.Get() == resolved_field->GetDeclaringClass());
936 if (is_referrer_class) {
937 storage_index = referrer_class->GetDexTypeIndex();
938 } else if (outer_dex_cache.Get() != dex_cache.Get()) {
Roland Levillain4c0eb422015-04-24 16:43:49 +0100939 // The compiler driver cannot currently understand multiple dex caches involved. Just bailout.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000940 return false;
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000941 } else {
942 std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField(
943 outer_dex_cache.Get(),
944 referrer_class.Get(),
Mathieu Chartierc7853442015-03-27 14:35:38 -0700945 resolved_field,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000946 field_index,
947 &storage_index);
948 bool can_easily_access = is_put ? pair.second : pair.first;
949 if (!can_easily_access) {
950 return false;
951 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000952 }
953
954 // TODO: find out why this check is needed.
955 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
Nicolas Geoffray6a816cf2015-03-24 16:17:56 +0000956 *outer_compilation_unit_->GetDexFile(), storage_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000957 bool is_initialized = resolved_field->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000958
Nicolas Geoffray76b1e172015-05-27 17:18:33 +0100959 HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(),
960 storage_index,
961 *dex_compilation_unit_->GetDexFile(),
962 is_referrer_class,
963 dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100964 current_block_->AddInstruction(constant);
965
966 HInstruction* cls = constant;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000967 if (!is_initialized && !is_referrer_class) {
Calin Juravle225ff812014-11-13 16:46:39 +0000968 cls = new (arena_) HClinitCheck(constant, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100969 current_block_->AddInstruction(cls);
970 }
971
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000972 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100973 if (is_put) {
974 // We need to keep the class alive before loading the value.
Calin Juravlef97f9fb2014-11-11 15:38:19 +0000975 Temporaries temps(graph_);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100976 temps.Add(cls);
977 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
978 DCHECK_EQ(value->GetType(), field_type);
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +0100979 current_block_->AddInstruction(new (arena_) HStaticFieldSet(cls,
980 value,
981 field_type,
982 resolved_field->GetOffset(),
983 resolved_field->IsVolatile(),
984 field_index,
985 *dex_file_));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100986 } else {
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +0100987 current_block_->AddInstruction(new (arena_) HStaticFieldGet(cls,
988 field_type,
989 resolved_field->GetOffset(),
990 resolved_field->IsVolatile(),
991 field_index,
992 *dex_file_));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +0100993 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
994 }
995 return true;
996}
997
Calin Juravlebacfec32014-11-14 15:54:36 +0000998void HGraphBuilder::BuildCheckedDivRem(uint16_t out_vreg,
999 uint16_t first_vreg,
1000 int64_t second_vreg_or_constant,
1001 uint32_t dex_pc,
1002 Primitive::Type type,
1003 bool second_is_constant,
1004 bool isDiv) {
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001005 DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong);
Calin Juravled0d48522014-11-04 16:40:20 +00001006
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001007 HInstruction* first = LoadLocal(first_vreg, type);
1008 HInstruction* second = nullptr;
1009 if (second_is_constant) {
1010 if (type == Primitive::kPrimInt) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001011 second = graph_->GetIntConstant(second_vreg_or_constant);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001012 } else {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001013 second = graph_->GetLongConstant(second_vreg_or_constant);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001014 }
1015 } else {
1016 second = LoadLocal(second_vreg_or_constant, type);
1017 }
1018
1019 if (!second_is_constant
1020 || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0)
1021 || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) {
1022 second = new (arena_) HDivZeroCheck(second, dex_pc);
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001023 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001024 current_block_->AddInstruction(second);
1025 temps.Add(current_block_->GetLastInstruction());
1026 }
1027
Calin Juravlebacfec32014-11-14 15:54:36 +00001028 if (isDiv) {
1029 current_block_->AddInstruction(new (arena_) HDiv(type, first, second, dex_pc));
1030 } else {
1031 current_block_->AddInstruction(new (arena_) HRem(type, first, second, dex_pc));
1032 }
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001033 UpdateLocal(out_vreg, current_block_->GetLastInstruction());
Calin Juravled0d48522014-11-04 16:40:20 +00001034}
1035
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001036void HGraphBuilder::BuildArrayAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001037 uint32_t dex_pc,
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001038 bool is_put,
1039 Primitive::Type anticipated_type) {
1040 uint8_t source_or_dest_reg = instruction.VRegA_23x();
1041 uint8_t array_reg = instruction.VRegB_23x();
1042 uint8_t index_reg = instruction.VRegC_23x();
1043
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001044 // We need one temporary for the null check, one for the index, and one for the length.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001045 Temporaries temps(graph_);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001046
1047 HInstruction* object = LoadLocal(array_reg, Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00001048 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001049 current_block_->AddInstruction(object);
1050 temps.Add(object);
1051
1052 HInstruction* length = new (arena_) HArrayLength(object);
1053 current_block_->AddInstruction(length);
1054 temps.Add(length);
1055 HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt);
Calin Juravle225ff812014-11-13 16:46:39 +00001056 index = new (arena_) HBoundsCheck(index, length, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001057 current_block_->AddInstruction(index);
1058 temps.Add(index);
1059 if (is_put) {
1060 HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type);
1061 // TODO: Insert a type check node if the type is Object.
Nicolas Geoffray39468442014-09-02 15:17:15 +01001062 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001063 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001064 } else {
1065 current_block_->AddInstruction(new (arena_) HArrayGet(object, index, anticipated_type));
1066 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1067 }
Mark Mendell1152c922015-04-24 17:06:35 -04001068 graph_->SetHasBoundsChecks(true);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001069}
1070
Calin Juravle225ff812014-11-13 16:46:39 +00001071void HGraphBuilder::BuildFilledNewArray(uint32_t dex_pc,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001072 uint32_t type_index,
1073 uint32_t number_of_vreg_arguments,
1074 bool is_range,
1075 uint32_t* args,
1076 uint32_t register_index) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001077 HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001078 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
1079 ? kQuickAllocArrayWithAccessCheck
1080 : kQuickAllocArray;
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001081 HInstruction* object = new (arena_) HNewArray(length,
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01001082 graph_->GetCurrentMethod(),
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001083 dex_pc,
1084 type_index,
1085 *dex_compilation_unit_->GetDexFile(),
1086 entrypoint);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001087 current_block_->AddInstruction(object);
1088
1089 const char* descriptor = dex_file_->StringByTypeIdx(type_index);
1090 DCHECK_EQ(descriptor[0], '[') << descriptor;
1091 char primitive = descriptor[1];
1092 DCHECK(primitive == 'I'
1093 || primitive == 'L'
1094 || primitive == '[') << descriptor;
1095 bool is_reference_array = (primitive == 'L') || (primitive == '[');
1096 Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt;
1097
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001098 Temporaries temps(graph_);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001099 temps.Add(object);
1100 for (size_t i = 0; i < number_of_vreg_arguments; ++i) {
1101 HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type);
David Brazdil8d5b8b22015-03-24 10:51:52 +00001102 HInstruction* index = graph_->GetIntConstant(i);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001103 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001104 new (arena_) HArraySet(object, index, value, type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001105 }
1106 latest_result_ = object;
1107}
1108
1109template <typename T>
1110void HGraphBuilder::BuildFillArrayData(HInstruction* object,
1111 const T* data,
1112 uint32_t element_count,
1113 Primitive::Type anticipated_type,
Calin Juravle225ff812014-11-13 16:46:39 +00001114 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001115 for (uint32_t i = 0; i < element_count; ++i) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001116 HInstruction* index = graph_->GetIntConstant(i);
1117 HInstruction* value = graph_->GetIntConstant(data[i]);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001118 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001119 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001120 }
1121}
1122
Calin Juravle225ff812014-11-13 16:46:39 +00001123void HGraphBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001124 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001125 HInstruction* array = LoadLocal(instruction.VRegA_31t(), Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00001126 HNullCheck* null_check = new (arena_) HNullCheck(array, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001127 current_block_->AddInstruction(null_check);
1128 temps.Add(null_check);
1129
1130 HInstruction* length = new (arena_) HArrayLength(null_check);
1131 current_block_->AddInstruction(length);
1132
Calin Juravle225ff812014-11-13 16:46:39 +00001133 int32_t payload_offset = instruction.VRegB_31t() + dex_pc;
Calin Juravled0d48522014-11-04 16:40:20 +00001134 const Instruction::ArrayDataPayload* payload =
1135 reinterpret_cast<const Instruction::ArrayDataPayload*>(code_start_ + payload_offset);
1136 const uint8_t* data = payload->data;
1137 uint32_t element_count = payload->element_count;
1138
1139 // Implementation of this DEX instruction seems to be that the bounds check is
1140 // done before doing any stores.
David Brazdil8d5b8b22015-03-24 10:51:52 +00001141 HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1);
Calin Juravle225ff812014-11-13 16:46:39 +00001142 current_block_->AddInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc));
Calin Juravled0d48522014-11-04 16:40:20 +00001143
1144 switch (payload->element_width) {
1145 case 1:
1146 BuildFillArrayData(null_check,
1147 reinterpret_cast<const int8_t*>(data),
1148 element_count,
1149 Primitive::kPrimByte,
Calin Juravle225ff812014-11-13 16:46:39 +00001150 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001151 break;
1152 case 2:
1153 BuildFillArrayData(null_check,
1154 reinterpret_cast<const int16_t*>(data),
1155 element_count,
1156 Primitive::kPrimShort,
Calin Juravle225ff812014-11-13 16:46:39 +00001157 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001158 break;
1159 case 4:
1160 BuildFillArrayData(null_check,
1161 reinterpret_cast<const int32_t*>(data),
1162 element_count,
1163 Primitive::kPrimInt,
Calin Juravle225ff812014-11-13 16:46:39 +00001164 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001165 break;
1166 case 8:
1167 BuildFillWideArrayData(null_check,
1168 reinterpret_cast<const int64_t*>(data),
1169 element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001170 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001171 break;
1172 default:
1173 LOG(FATAL) << "Unknown element width for " << payload->element_width;
1174 }
Mark Mendell1152c922015-04-24 17:06:35 -04001175 graph_->SetHasBoundsChecks(true);
Calin Juravled0d48522014-11-04 16:40:20 +00001176}
1177
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001178void HGraphBuilder::BuildFillWideArrayData(HInstruction* object,
Nicolas Geoffray8d6ae522014-10-23 18:32:13 +01001179 const int64_t* data,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001180 uint32_t element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001181 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001182 for (uint32_t i = 0; i < element_count; ++i) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001183 HInstruction* index = graph_->GetIntConstant(i);
1184 HInstruction* value = graph_->GetLongConstant(data[i]);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001185 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001186 object, index, value, Primitive::kPrimLong, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001187 }
1188}
1189
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001190bool HGraphBuilder::BuildTypeCheck(const Instruction& instruction,
1191 uint8_t destination,
1192 uint8_t reference,
1193 uint16_t type_index,
Calin Juravle225ff812014-11-13 16:46:39 +00001194 uint32_t dex_pc) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001195 bool type_known_final;
1196 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001197 // `CanAccessTypeWithoutChecks` will tell whether the method being
1198 // built is trying to access its own class, so that the generated
1199 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001200 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001201 bool dont_use_is_referrers_class;
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001202 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
1203 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001204 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001205 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001206 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001207 return false;
1208 }
1209 HInstruction* object = LoadLocal(reference, Primitive::kPrimNot);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001210 HLoadClass* cls = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001211 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01001212 type_index,
1213 *dex_compilation_unit_->GetDexFile(),
1214 IsOutermostCompilingClass(type_index),
1215 dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001216 current_block_->AddInstruction(cls);
1217 // The class needs a temporary before being used by the type check.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001218 Temporaries temps(graph_);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001219 temps.Add(cls);
1220 if (instruction.Opcode() == Instruction::INSTANCE_OF) {
1221 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001222 new (arena_) HInstanceOf(object, cls, type_known_final, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001223 UpdateLocal(destination, current_block_->GetLastInstruction());
1224 } else {
1225 DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST);
1226 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001227 new (arena_) HCheckCast(object, cls, type_known_final, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001228 }
1229 return true;
1230}
1231
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001232bool HGraphBuilder::NeedsAccessCheck(uint32_t type_index) const {
1233 return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks(
1234 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index);
1235}
1236
Calin Juravle48c2b032014-12-09 18:11:36 +00001237void HGraphBuilder::BuildPackedSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001238 // Verifier guarantees that the payload for PackedSwitch contains:
1239 // (a) number of entries (may be zero)
1240 // (b) first and lowest switch case value (entry 0, always present)
1241 // (c) list of target pcs (entries 1 <= i <= N)
Andreas Gamped881df52014-11-24 23:28:39 -08001242 SwitchTable table(instruction, dex_pc, false);
1243
1244 // Value to test against.
1245 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
1246
David Brazdil2ef645b2015-06-17 18:20:52 +01001247 // Retrieve number of entries.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001248 uint16_t num_entries = table.GetNumEntries();
David Brazdil2ef645b2015-06-17 18:20:52 +01001249 if (num_entries == 0) {
1250 return;
1251 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001252
Andreas Gamped881df52014-11-24 23:28:39 -08001253 // Chained cmp-and-branch, starting from starting_key.
1254 int32_t starting_key = table.GetEntryAt(0);
1255
Andreas Gamped881df52014-11-24 23:28:39 -08001256 for (size_t i = 1; i <= num_entries; i++) {
Andreas Gampee4d4d322014-12-04 09:09:57 -08001257 BuildSwitchCaseHelper(instruction, i, i == num_entries, table, value, starting_key + i - 1,
1258 table.GetEntryAt(i), dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08001259 }
Andreas Gamped881df52014-11-24 23:28:39 -08001260}
1261
Calin Juravle48c2b032014-12-09 18:11:36 +00001262void HGraphBuilder::BuildSparseSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001263 // Verifier guarantees that the payload for SparseSwitch contains:
1264 // (a) number of entries (may be zero)
1265 // (b) sorted key values (entries 0 <= i < N)
1266 // (c) target pcs corresponding to the switch values (entries N <= i < 2*N)
Andreas Gampee4d4d322014-12-04 09:09:57 -08001267 SwitchTable table(instruction, dex_pc, true);
1268
1269 // Value to test against.
1270 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
1271
1272 uint16_t num_entries = table.GetNumEntries();
Andreas Gampee4d4d322014-12-04 09:09:57 -08001273
1274 for (size_t i = 0; i < num_entries; i++) {
1275 BuildSwitchCaseHelper(instruction, i, i == static_cast<size_t>(num_entries) - 1, table, value,
1276 table.GetEntryAt(i), table.GetEntryAt(i + num_entries), dex_pc);
1277 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001278}
1279
1280void HGraphBuilder::BuildSwitchCaseHelper(const Instruction& instruction, size_t index,
1281 bool is_last_case, const SwitchTable& table,
1282 HInstruction* value, int32_t case_value_int,
1283 int32_t target_offset, uint32_t dex_pc) {
David Brazdil852eaff2015-02-02 15:23:05 +00001284 HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset);
1285 DCHECK(case_target != nullptr);
1286 PotentiallyAddSuspendCheck(case_target, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001287
1288 // The current case's value.
David Brazdil8d5b8b22015-03-24 10:51:52 +00001289 HInstruction* this_case_value = graph_->GetIntConstant(case_value_int);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001290
1291 // Compare value and this_case_value.
1292 HEqual* comparison = new (arena_) HEqual(value, this_case_value);
1293 current_block_->AddInstruction(comparison);
1294 HInstruction* ifinst = new (arena_) HIf(comparison);
1295 current_block_->AddInstruction(ifinst);
1296
1297 // Case hit: use the target offset to determine where to go.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001298 current_block_->AddSuccessor(case_target);
1299
1300 // Case miss: go to the next case (or default fall-through).
1301 // When there is a next case, we use the block stored with the table offset representing this
1302 // case (that is where we registered them in ComputeBranchTargets).
1303 // When there is no next case, we use the following instruction.
1304 // TODO: Find a good way to peel the last iteration to avoid conditional, but still have re-use.
1305 if (!is_last_case) {
1306 HBasicBlock* next_case_target = FindBlockStartingAt(table.GetDexPcForIndex(index));
1307 DCHECK(next_case_target != nullptr);
1308 current_block_->AddSuccessor(next_case_target);
1309
1310 // Need to manually add the block, as there is no dex-pc transition for the cases.
1311 graph_->AddBlock(next_case_target);
1312
1313 current_block_ = next_case_target;
1314 } else {
1315 HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
1316 DCHECK(default_target != nullptr);
1317 current_block_->AddSuccessor(default_target);
1318 current_block_ = nullptr;
1319 }
1320}
1321
David Brazdil852eaff2015-02-02 15:23:05 +00001322void HGraphBuilder::PotentiallyAddSuspendCheck(HBasicBlock* target, uint32_t dex_pc) {
1323 int32_t target_offset = target->GetDexPc() - dex_pc;
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001324 if (target_offset <= 0) {
David Brazdil852eaff2015-02-02 15:23:05 +00001325 // DX generates back edges to the first encountered return. We can save
1326 // time of later passes by not adding redundant suspend checks.
David Brazdil2fd6aa52015-02-02 18:58:27 +00001327 HInstruction* last_in_target = target->GetLastInstruction();
1328 if (last_in_target != nullptr &&
1329 (last_in_target->IsReturn() || last_in_target->IsReturnVoid())) {
1330 return;
David Brazdil852eaff2015-02-02 15:23:05 +00001331 }
1332
1333 // Add a suspend check to backward branches which may potentially loop. We
1334 // can remove them after we recognize loops in the graph.
Calin Juravle225ff812014-11-13 16:46:39 +00001335 current_block_->AddInstruction(new (arena_) HSuspendCheck(dex_pc));
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001336 }
1337}
1338
Calin Juravle225ff812014-11-13 16:46:39 +00001339bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001340 if (current_block_ == nullptr) {
1341 return true; // Dead code
1342 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001343
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001344 switch (instruction.Opcode()) {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001345 case Instruction::CONST_4: {
1346 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001347 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n());
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001348 UpdateLocal(register_index, constant);
1349 break;
1350 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001351
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001352 case Instruction::CONST_16: {
1353 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001354 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s());
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001355 UpdateLocal(register_index, constant);
1356 break;
1357 }
1358
Dave Allison20dfc792014-06-16 20:44:29 -07001359 case Instruction::CONST: {
1360 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001361 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i());
Dave Allison20dfc792014-06-16 20:44:29 -07001362 UpdateLocal(register_index, constant);
1363 break;
1364 }
1365
1366 case Instruction::CONST_HIGH16: {
1367 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001368 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16);
Dave Allison20dfc792014-06-16 20:44:29 -07001369 UpdateLocal(register_index, constant);
1370 break;
1371 }
1372
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001373 case Instruction::CONST_WIDE_16: {
1374 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001375 // Get 16 bits of constant value, sign extended to 64 bits.
1376 int64_t value = instruction.VRegB_21s();
1377 value <<= 48;
1378 value >>= 48;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001379 HLongConstant* constant = graph_->GetLongConstant(value);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001380 UpdateLocal(register_index, constant);
1381 break;
1382 }
1383
1384 case Instruction::CONST_WIDE_32: {
1385 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001386 // Get 32 bits of constant value, sign extended to 64 bits.
1387 int64_t value = instruction.VRegB_31i();
1388 value <<= 32;
1389 value >>= 32;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001390 HLongConstant* constant = graph_->GetLongConstant(value);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001391 UpdateLocal(register_index, constant);
1392 break;
1393 }
1394
1395 case Instruction::CONST_WIDE: {
1396 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001397 HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l());
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001398 UpdateLocal(register_index, constant);
1399 break;
1400 }
1401
Dave Allison20dfc792014-06-16 20:44:29 -07001402 case Instruction::CONST_WIDE_HIGH16: {
1403 int32_t register_index = instruction.VRegA();
1404 int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001405 HLongConstant* constant = graph_->GetLongConstant(value);
Dave Allison20dfc792014-06-16 20:44:29 -07001406 UpdateLocal(register_index, constant);
1407 break;
1408 }
1409
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001410 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001411 case Instruction::MOVE:
1412 case Instruction::MOVE_FROM16:
1413 case Instruction::MOVE_16: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001414 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001415 UpdateLocal(instruction.VRegA(), value);
1416 break;
1417 }
1418
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001419 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001420 case Instruction::MOVE_WIDE:
1421 case Instruction::MOVE_WIDE_FROM16:
1422 case Instruction::MOVE_WIDE_16: {
1423 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong);
1424 UpdateLocal(instruction.VRegA(), value);
1425 break;
1426 }
1427
1428 case Instruction::MOVE_OBJECT:
1429 case Instruction::MOVE_OBJECT_16:
1430 case Instruction::MOVE_OBJECT_FROM16: {
1431 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot);
1432 UpdateLocal(instruction.VRegA(), value);
1433 break;
1434 }
1435
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001436 case Instruction::RETURN_VOID: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001437 BuildReturn(instruction, Primitive::kPrimVoid);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001438 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001439 }
1440
Dave Allison20dfc792014-06-16 20:44:29 -07001441#define IF_XX(comparison, cond) \
Calin Juravle225ff812014-11-13 16:46:39 +00001442 case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \
1443 case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001444
Dave Allison20dfc792014-06-16 20:44:29 -07001445 IF_XX(HEqual, EQ);
1446 IF_XX(HNotEqual, NE);
1447 IF_XX(HLessThan, LT);
1448 IF_XX(HLessThanOrEqual, LE);
1449 IF_XX(HGreaterThan, GT);
1450 IF_XX(HGreaterThanOrEqual, GE);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001451
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001452 case Instruction::GOTO:
1453 case Instruction::GOTO_16:
1454 case Instruction::GOTO_32: {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001455 int32_t offset = instruction.GetTargetOffset();
Calin Juravle225ff812014-11-13 16:46:39 +00001456 HBasicBlock* target = FindBlockStartingAt(offset + dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001457 DCHECK(target != nullptr);
David Brazdil852eaff2015-02-02 15:23:05 +00001458 PotentiallyAddSuspendCheck(target, dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001459 current_block_->AddInstruction(new (arena_) HGoto());
1460 current_block_->AddSuccessor(target);
1461 current_block_ = nullptr;
1462 break;
1463 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001464
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001465 case Instruction::RETURN: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001466 BuildReturn(instruction, return_type_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001467 break;
1468 }
1469
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001470 case Instruction::RETURN_OBJECT: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001471 BuildReturn(instruction, return_type_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001472 break;
1473 }
1474
1475 case Instruction::RETURN_WIDE: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001476 BuildReturn(instruction, return_type_);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001477 break;
1478 }
1479
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001480 case Instruction::INVOKE_DIRECT:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001481 case Instruction::INVOKE_INTERFACE:
1482 case Instruction::INVOKE_STATIC:
1483 case Instruction::INVOKE_SUPER:
1484 case Instruction::INVOKE_VIRTUAL: {
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00001485 uint32_t method_idx = instruction.VRegB_35c();
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001486 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001487 uint32_t args[5];
Ian Rogers29a26482014-05-02 15:27:29 -07001488 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00001489 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001490 number_of_vreg_arguments, false, args, -1)) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001491 return false;
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001492 }
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001493 break;
1494 }
1495
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001496 case Instruction::INVOKE_DIRECT_RANGE:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001497 case Instruction::INVOKE_INTERFACE_RANGE:
1498 case Instruction::INVOKE_STATIC_RANGE:
1499 case Instruction::INVOKE_SUPER_RANGE:
1500 case Instruction::INVOKE_VIRTUAL_RANGE: {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001501 uint32_t method_idx = instruction.VRegB_3rc();
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001502 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
1503 uint32_t register_index = instruction.VRegC();
Calin Juravle225ff812014-11-13 16:46:39 +00001504 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001505 number_of_vreg_arguments, true, nullptr, register_index)) {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001506 return false;
1507 }
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00001508 break;
1509 }
1510
Roland Levillain88cb1752014-10-20 16:36:47 +01001511 case Instruction::NEG_INT: {
1512 Unop_12x<HNeg>(instruction, Primitive::kPrimInt);
1513 break;
1514 }
1515
Roland Levillain2e07b4f2014-10-23 18:12:09 +01001516 case Instruction::NEG_LONG: {
1517 Unop_12x<HNeg>(instruction, Primitive::kPrimLong);
1518 break;
1519 }
1520
Roland Levillain3dbcb382014-10-28 17:30:07 +00001521 case Instruction::NEG_FLOAT: {
1522 Unop_12x<HNeg>(instruction, Primitive::kPrimFloat);
1523 break;
1524 }
1525
1526 case Instruction::NEG_DOUBLE: {
1527 Unop_12x<HNeg>(instruction, Primitive::kPrimDouble);
1528 break;
1529 }
1530
Roland Levillain1cc5f2512014-10-22 18:06:21 +01001531 case Instruction::NOT_INT: {
1532 Unop_12x<HNot>(instruction, Primitive::kPrimInt);
1533 break;
1534 }
1535
Roland Levillain70566432014-10-24 16:20:17 +01001536 case Instruction::NOT_LONG: {
1537 Unop_12x<HNot>(instruction, Primitive::kPrimLong);
1538 break;
1539 }
1540
Roland Levillaindff1f282014-11-05 14:15:05 +00001541 case Instruction::INT_TO_LONG: {
Roland Levillain624279f2014-12-04 11:54:28 +00001542 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc);
Roland Levillaindff1f282014-11-05 14:15:05 +00001543 break;
1544 }
1545
Roland Levillaincff13742014-11-17 14:32:17 +00001546 case Instruction::INT_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001547 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00001548 break;
1549 }
1550
1551 case Instruction::INT_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001552 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00001553 break;
1554 }
1555
Roland Levillain946e1432014-11-11 17:35:19 +00001556 case Instruction::LONG_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001557 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc);
Roland Levillain946e1432014-11-11 17:35:19 +00001558 break;
1559 }
1560
Roland Levillain6d0e4832014-11-27 18:31:21 +00001561 case Instruction::LONG_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001562 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc);
Roland Levillain6d0e4832014-11-27 18:31:21 +00001563 break;
1564 }
1565
Roland Levillain647b9ed2014-11-27 12:06:00 +00001566 case Instruction::LONG_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001567 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc);
Roland Levillain647b9ed2014-11-27 12:06:00 +00001568 break;
1569 }
1570
Roland Levillain3f8f9362014-12-02 17:45:01 +00001571 case Instruction::FLOAT_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001572 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc);
1573 break;
1574 }
1575
1576 case Instruction::FLOAT_TO_LONG: {
1577 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc);
Roland Levillain3f8f9362014-12-02 17:45:01 +00001578 break;
1579 }
1580
Roland Levillain8964e2b2014-12-04 12:10:50 +00001581 case Instruction::FLOAT_TO_DOUBLE: {
1582 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc);
1583 break;
1584 }
1585
Roland Levillain4c0b61f2014-12-05 12:06:01 +00001586 case Instruction::DOUBLE_TO_INT: {
1587 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc);
1588 break;
1589 }
1590
1591 case Instruction::DOUBLE_TO_LONG: {
1592 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc);
1593 break;
1594 }
1595
Roland Levillain8964e2b2014-12-04 12:10:50 +00001596 case Instruction::DOUBLE_TO_FLOAT: {
1597 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc);
1598 break;
1599 }
1600
Roland Levillain51d3fc42014-11-13 14:11:42 +00001601 case Instruction::INT_TO_BYTE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001602 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc);
Roland Levillain51d3fc42014-11-13 14:11:42 +00001603 break;
1604 }
1605
Roland Levillain01a8d712014-11-14 16:27:39 +00001606 case Instruction::INT_TO_SHORT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001607 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc);
Roland Levillain01a8d712014-11-14 16:27:39 +00001608 break;
1609 }
1610
Roland Levillain981e4542014-11-14 11:47:14 +00001611 case Instruction::INT_TO_CHAR: {
Roland Levillain624279f2014-12-04 11:54:28 +00001612 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc);
Roland Levillain981e4542014-11-14 11:47:14 +00001613 break;
1614 }
1615
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001616 case Instruction::ADD_INT: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001617 Binop_23x<HAdd>(instruction, Primitive::kPrimInt);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001618 break;
1619 }
1620
1621 case Instruction::ADD_LONG: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001622 Binop_23x<HAdd>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001623 break;
1624 }
1625
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001626 case Instruction::ADD_DOUBLE: {
1627 Binop_23x<HAdd>(instruction, Primitive::kPrimDouble);
1628 break;
1629 }
1630
1631 case Instruction::ADD_FLOAT: {
1632 Binop_23x<HAdd>(instruction, Primitive::kPrimFloat);
1633 break;
1634 }
1635
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001636 case Instruction::SUB_INT: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001637 Binop_23x<HSub>(instruction, Primitive::kPrimInt);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001638 break;
1639 }
1640
1641 case Instruction::SUB_LONG: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001642 Binop_23x<HSub>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001643 break;
1644 }
1645
Calin Juravle096cc022014-10-23 17:01:13 +01001646 case Instruction::SUB_FLOAT: {
1647 Binop_23x<HSub>(instruction, Primitive::kPrimFloat);
1648 break;
1649 }
1650
1651 case Instruction::SUB_DOUBLE: {
1652 Binop_23x<HSub>(instruction, Primitive::kPrimDouble);
1653 break;
1654 }
1655
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001656 case Instruction::ADD_INT_2ADDR: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001657 Binop_12x<HAdd>(instruction, Primitive::kPrimInt);
1658 break;
1659 }
1660
Calin Juravle34bacdf2014-10-07 20:23:36 +01001661 case Instruction::MUL_INT: {
1662 Binop_23x<HMul>(instruction, Primitive::kPrimInt);
1663 break;
1664 }
1665
1666 case Instruction::MUL_LONG: {
1667 Binop_23x<HMul>(instruction, Primitive::kPrimLong);
1668 break;
1669 }
1670
Calin Juravleb5bfa962014-10-21 18:02:24 +01001671 case Instruction::MUL_FLOAT: {
1672 Binop_23x<HMul>(instruction, Primitive::kPrimFloat);
1673 break;
1674 }
1675
1676 case Instruction::MUL_DOUBLE: {
1677 Binop_23x<HMul>(instruction, Primitive::kPrimDouble);
1678 break;
1679 }
1680
Calin Juravled0d48522014-11-04 16:40:20 +00001681 case Instruction::DIV_INT: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001682 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1683 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravled0d48522014-11-04 16:40:20 +00001684 break;
1685 }
1686
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001687 case Instruction::DIV_LONG: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001688 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1689 dex_pc, Primitive::kPrimLong, false, true);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001690 break;
1691 }
1692
Calin Juravle7c4954d2014-10-28 16:57:40 +00001693 case Instruction::DIV_FLOAT: {
Calin Juravle225ff812014-11-13 16:46:39 +00001694 Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001695 break;
1696 }
1697
1698 case Instruction::DIV_DOUBLE: {
Calin Juravle225ff812014-11-13 16:46:39 +00001699 Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001700 break;
1701 }
1702
Calin Juravlebacfec32014-11-14 15:54:36 +00001703 case Instruction::REM_INT: {
1704 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1705 dex_pc, Primitive::kPrimInt, false, false);
1706 break;
1707 }
1708
1709 case Instruction::REM_LONG: {
1710 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1711 dex_pc, Primitive::kPrimLong, false, false);
1712 break;
1713 }
1714
Calin Juravled2ec87d2014-12-08 14:24:46 +00001715 case Instruction::REM_FLOAT: {
1716 Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
1717 break;
1718 }
1719
1720 case Instruction::REM_DOUBLE: {
1721 Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
1722 break;
1723 }
1724
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001725 case Instruction::AND_INT: {
1726 Binop_23x<HAnd>(instruction, Primitive::kPrimInt);
1727 break;
1728 }
1729
1730 case Instruction::AND_LONG: {
1731 Binop_23x<HAnd>(instruction, Primitive::kPrimLong);
1732 break;
1733 }
1734
Calin Juravle9aec02f2014-11-18 23:06:35 +00001735 case Instruction::SHL_INT: {
1736 Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt);
1737 break;
1738 }
1739
1740 case Instruction::SHL_LONG: {
1741 Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong);
1742 break;
1743 }
1744
1745 case Instruction::SHR_INT: {
1746 Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt);
1747 break;
1748 }
1749
1750 case Instruction::SHR_LONG: {
1751 Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong);
1752 break;
1753 }
1754
1755 case Instruction::USHR_INT: {
1756 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt);
1757 break;
1758 }
1759
1760 case Instruction::USHR_LONG: {
1761 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong);
1762 break;
1763 }
1764
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001765 case Instruction::OR_INT: {
1766 Binop_23x<HOr>(instruction, Primitive::kPrimInt);
1767 break;
1768 }
1769
1770 case Instruction::OR_LONG: {
1771 Binop_23x<HOr>(instruction, Primitive::kPrimLong);
1772 break;
1773 }
1774
1775 case Instruction::XOR_INT: {
1776 Binop_23x<HXor>(instruction, Primitive::kPrimInt);
1777 break;
1778 }
1779
1780 case Instruction::XOR_LONG: {
1781 Binop_23x<HXor>(instruction, Primitive::kPrimLong);
1782 break;
1783 }
1784
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001785 case Instruction::ADD_LONG_2ADDR: {
1786 Binop_12x<HAdd>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001787 break;
1788 }
1789
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001790 case Instruction::ADD_DOUBLE_2ADDR: {
1791 Binop_12x<HAdd>(instruction, Primitive::kPrimDouble);
1792 break;
1793 }
1794
1795 case Instruction::ADD_FLOAT_2ADDR: {
1796 Binop_12x<HAdd>(instruction, Primitive::kPrimFloat);
1797 break;
1798 }
1799
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001800 case Instruction::SUB_INT_2ADDR: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001801 Binop_12x<HSub>(instruction, Primitive::kPrimInt);
1802 break;
1803 }
1804
1805 case Instruction::SUB_LONG_2ADDR: {
1806 Binop_12x<HSub>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001807 break;
1808 }
1809
Calin Juravle096cc022014-10-23 17:01:13 +01001810 case Instruction::SUB_FLOAT_2ADDR: {
1811 Binop_12x<HSub>(instruction, Primitive::kPrimFloat);
1812 break;
1813 }
1814
1815 case Instruction::SUB_DOUBLE_2ADDR: {
1816 Binop_12x<HSub>(instruction, Primitive::kPrimDouble);
1817 break;
1818 }
1819
Calin Juravle34bacdf2014-10-07 20:23:36 +01001820 case Instruction::MUL_INT_2ADDR: {
1821 Binop_12x<HMul>(instruction, Primitive::kPrimInt);
1822 break;
1823 }
1824
1825 case Instruction::MUL_LONG_2ADDR: {
1826 Binop_12x<HMul>(instruction, Primitive::kPrimLong);
1827 break;
1828 }
1829
Calin Juravleb5bfa962014-10-21 18:02:24 +01001830 case Instruction::MUL_FLOAT_2ADDR: {
1831 Binop_12x<HMul>(instruction, Primitive::kPrimFloat);
1832 break;
1833 }
1834
1835 case Instruction::MUL_DOUBLE_2ADDR: {
1836 Binop_12x<HMul>(instruction, Primitive::kPrimDouble);
1837 break;
1838 }
1839
Calin Juravle865fc882014-11-06 17:09:03 +00001840 case Instruction::DIV_INT_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001841 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
1842 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravle865fc882014-11-06 17:09:03 +00001843 break;
1844 }
1845
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001846 case Instruction::DIV_LONG_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001847 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
1848 dex_pc, Primitive::kPrimLong, false, true);
1849 break;
1850 }
1851
1852 case Instruction::REM_INT_2ADDR: {
1853 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
1854 dex_pc, Primitive::kPrimInt, false, false);
1855 break;
1856 }
1857
1858 case Instruction::REM_LONG_2ADDR: {
1859 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
1860 dex_pc, Primitive::kPrimLong, false, false);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001861 break;
1862 }
1863
Calin Juravled2ec87d2014-12-08 14:24:46 +00001864 case Instruction::REM_FLOAT_2ADDR: {
1865 Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
1866 break;
1867 }
1868
1869 case Instruction::REM_DOUBLE_2ADDR: {
1870 Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
1871 break;
1872 }
1873
Calin Juravle9aec02f2014-11-18 23:06:35 +00001874 case Instruction::SHL_INT_2ADDR: {
1875 Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt);
1876 break;
1877 }
1878
1879 case Instruction::SHL_LONG_2ADDR: {
1880 Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong);
1881 break;
1882 }
1883
1884 case Instruction::SHR_INT_2ADDR: {
1885 Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt);
1886 break;
1887 }
1888
1889 case Instruction::SHR_LONG_2ADDR: {
1890 Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong);
1891 break;
1892 }
1893
1894 case Instruction::USHR_INT_2ADDR: {
1895 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt);
1896 break;
1897 }
1898
1899 case Instruction::USHR_LONG_2ADDR: {
1900 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong);
1901 break;
1902 }
1903
Calin Juravle7c4954d2014-10-28 16:57:40 +00001904 case Instruction::DIV_FLOAT_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00001905 Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001906 break;
1907 }
1908
1909 case Instruction::DIV_DOUBLE_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00001910 Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001911 break;
1912 }
1913
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001914 case Instruction::AND_INT_2ADDR: {
1915 Binop_12x<HAnd>(instruction, Primitive::kPrimInt);
1916 break;
1917 }
1918
1919 case Instruction::AND_LONG_2ADDR: {
1920 Binop_12x<HAnd>(instruction, Primitive::kPrimLong);
1921 break;
1922 }
1923
1924 case Instruction::OR_INT_2ADDR: {
1925 Binop_12x<HOr>(instruction, Primitive::kPrimInt);
1926 break;
1927 }
1928
1929 case Instruction::OR_LONG_2ADDR: {
1930 Binop_12x<HOr>(instruction, Primitive::kPrimLong);
1931 break;
1932 }
1933
1934 case Instruction::XOR_INT_2ADDR: {
1935 Binop_12x<HXor>(instruction, Primitive::kPrimInt);
1936 break;
1937 }
1938
1939 case Instruction::XOR_LONG_2ADDR: {
1940 Binop_12x<HXor>(instruction, Primitive::kPrimLong);
1941 break;
1942 }
1943
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001944 case Instruction::ADD_INT_LIT16: {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001945 Binop_22s<HAdd>(instruction, false);
1946 break;
1947 }
1948
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001949 case Instruction::AND_INT_LIT16: {
1950 Binop_22s<HAnd>(instruction, false);
1951 break;
1952 }
1953
1954 case Instruction::OR_INT_LIT16: {
1955 Binop_22s<HOr>(instruction, false);
1956 break;
1957 }
1958
1959 case Instruction::XOR_INT_LIT16: {
1960 Binop_22s<HXor>(instruction, false);
1961 break;
1962 }
1963
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001964 case Instruction::RSUB_INT: {
1965 Binop_22s<HSub>(instruction, true);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001966 break;
1967 }
1968
Calin Juravle34bacdf2014-10-07 20:23:36 +01001969 case Instruction::MUL_INT_LIT16: {
1970 Binop_22s<HMul>(instruction, false);
1971 break;
1972 }
1973
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001974 case Instruction::ADD_INT_LIT8: {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001975 Binop_22b<HAdd>(instruction, false);
1976 break;
1977 }
1978
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001979 case Instruction::AND_INT_LIT8: {
1980 Binop_22b<HAnd>(instruction, false);
1981 break;
1982 }
1983
1984 case Instruction::OR_INT_LIT8: {
1985 Binop_22b<HOr>(instruction, false);
1986 break;
1987 }
1988
1989 case Instruction::XOR_INT_LIT8: {
1990 Binop_22b<HXor>(instruction, false);
1991 break;
1992 }
1993
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001994 case Instruction::RSUB_INT_LIT8: {
1995 Binop_22b<HSub>(instruction, true);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001996 break;
1997 }
1998
Calin Juravle34bacdf2014-10-07 20:23:36 +01001999 case Instruction::MUL_INT_LIT8: {
2000 Binop_22b<HMul>(instruction, false);
2001 break;
2002 }
2003
Calin Juravled0d48522014-11-04 16:40:20 +00002004 case Instruction::DIV_INT_LIT16:
2005 case Instruction::DIV_INT_LIT8: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002006 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2007 dex_pc, Primitive::kPrimInt, true, true);
2008 break;
2009 }
2010
2011 case Instruction::REM_INT_LIT16:
2012 case Instruction::REM_INT_LIT8: {
2013 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2014 dex_pc, Primitive::kPrimInt, true, false);
Calin Juravled0d48522014-11-04 16:40:20 +00002015 break;
2016 }
2017
Calin Juravle9aec02f2014-11-18 23:06:35 +00002018 case Instruction::SHL_INT_LIT8: {
2019 Binop_22b<HShl>(instruction, false);
2020 break;
2021 }
2022
2023 case Instruction::SHR_INT_LIT8: {
2024 Binop_22b<HShr>(instruction, false);
2025 break;
2026 }
2027
2028 case Instruction::USHR_INT_LIT8: {
2029 Binop_22b<HUShr>(instruction, false);
2030 break;
2031 }
2032
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002033 case Instruction::NEW_INSTANCE: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002034 uint16_t type_index = instruction.VRegB_21c();
Jeff Hao848f70a2014-01-15 13:49:50 -08002035 if (compiler_driver_->IsStringTypeIndex(type_index, dex_file_)) {
2036 // Turn new-instance of string into a const 0.
2037 int32_t register_index = instruction.VRegA();
2038 HNullConstant* constant = graph_->GetNullConstant();
2039 UpdateLocal(register_index, constant);
2040 } else {
2041 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2042 ? kQuickAllocObjectWithAccessCheck
2043 : kQuickAllocObject;
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002044
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002045 current_block_->AddInstruction(new (arena_) HNewInstance(
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002046 graph_->GetCurrentMethod(),
2047 dex_pc,
2048 type_index,
2049 *dex_compilation_unit_->GetDexFile(),
2050 entrypoint));
Jeff Hao848f70a2014-01-15 13:49:50 -08002051 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
2052 }
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002053 break;
2054 }
2055
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002056 case Instruction::NEW_ARRAY: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002057 uint16_t type_index = instruction.VRegC_22c();
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002058 HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002059 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2060 ? kQuickAllocArrayWithAccessCheck
2061 : kQuickAllocArray;
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002062 current_block_->AddInstruction(new (arena_) HNewArray(length,
2063 graph_->GetCurrentMethod(),
2064 dex_pc,
2065 type_index,
2066 *dex_compilation_unit_->GetDexFile(),
2067 entrypoint));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002068 UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction());
2069 break;
2070 }
2071
2072 case Instruction::FILLED_NEW_ARRAY: {
2073 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
2074 uint32_t type_index = instruction.VRegB_35c();
2075 uint32_t args[5];
2076 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00002077 BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002078 break;
2079 }
2080
2081 case Instruction::FILLED_NEW_ARRAY_RANGE: {
2082 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2083 uint32_t type_index = instruction.VRegB_3rc();
2084 uint32_t register_index = instruction.VRegC_3rc();
2085 BuildFilledNewArray(
Calin Juravle225ff812014-11-13 16:46:39 +00002086 dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002087 break;
2088 }
2089
2090 case Instruction::FILL_ARRAY_DATA: {
Calin Juravle225ff812014-11-13 16:46:39 +00002091 BuildFillArrayData(instruction, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002092 break;
2093 }
2094
Nicolas Geoffrayddb311f2014-05-16 09:28:54 +01002095 case Instruction::MOVE_RESULT:
Dave Allison20dfc792014-06-16 20:44:29 -07002096 case Instruction::MOVE_RESULT_WIDE:
2097 case Instruction::MOVE_RESULT_OBJECT:
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002098 UpdateLocal(instruction.VRegA(), latest_result_);
2099 latest_result_ = nullptr;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002100 break;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002101
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002102 case Instruction::CMP_LONG: {
Calin Juravleddb7df22014-11-25 20:56:51 +00002103 Binop_23x_cmp(instruction, Primitive::kPrimLong, HCompare::kNoBias);
2104 break;
2105 }
2106
2107 case Instruction::CMPG_FLOAT: {
2108 Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kGtBias);
2109 break;
2110 }
2111
2112 case Instruction::CMPG_DOUBLE: {
2113 Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kGtBias);
2114 break;
2115 }
2116
2117 case Instruction::CMPL_FLOAT: {
2118 Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kLtBias);
2119 break;
2120 }
2121
2122 case Instruction::CMPL_DOUBLE: {
2123 Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kLtBias);
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002124 break;
2125 }
2126
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00002127 case Instruction::NOP:
2128 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00002129
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002130 case Instruction::IGET:
2131 case Instruction::IGET_WIDE:
2132 case Instruction::IGET_OBJECT:
2133 case Instruction::IGET_BOOLEAN:
2134 case Instruction::IGET_BYTE:
2135 case Instruction::IGET_CHAR:
2136 case Instruction::IGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002137 if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002138 return false;
2139 }
2140 break;
2141 }
2142
2143 case Instruction::IPUT:
2144 case Instruction::IPUT_WIDE:
2145 case Instruction::IPUT_OBJECT:
2146 case Instruction::IPUT_BOOLEAN:
2147 case Instruction::IPUT_BYTE:
2148 case Instruction::IPUT_CHAR:
2149 case Instruction::IPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002150 if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002151 return false;
2152 }
2153 break;
2154 }
2155
2156 case Instruction::SGET:
2157 case Instruction::SGET_WIDE:
2158 case Instruction::SGET_OBJECT:
2159 case Instruction::SGET_BOOLEAN:
2160 case Instruction::SGET_BYTE:
2161 case Instruction::SGET_CHAR:
2162 case Instruction::SGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002163 if (!BuildStaticFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002164 return false;
2165 }
2166 break;
2167 }
2168
2169 case Instruction::SPUT:
2170 case Instruction::SPUT_WIDE:
2171 case Instruction::SPUT_OBJECT:
2172 case Instruction::SPUT_BOOLEAN:
2173 case Instruction::SPUT_BYTE:
2174 case Instruction::SPUT_CHAR:
2175 case Instruction::SPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002176 if (!BuildStaticFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002177 return false;
2178 }
2179 break;
2180 }
2181
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002182#define ARRAY_XX(kind, anticipated_type) \
2183 case Instruction::AGET##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002184 BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002185 break; \
2186 } \
2187 case Instruction::APUT##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002188 BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002189 break; \
2190 }
2191
2192 ARRAY_XX(, Primitive::kPrimInt);
2193 ARRAY_XX(_WIDE, Primitive::kPrimLong);
2194 ARRAY_XX(_OBJECT, Primitive::kPrimNot);
2195 ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean);
2196 ARRAY_XX(_BYTE, Primitive::kPrimByte);
2197 ARRAY_XX(_CHAR, Primitive::kPrimChar);
2198 ARRAY_XX(_SHORT, Primitive::kPrimShort);
2199
Nicolas Geoffray39468442014-09-02 15:17:15 +01002200 case Instruction::ARRAY_LENGTH: {
2201 HInstruction* object = LoadLocal(instruction.VRegB_12x(), Primitive::kPrimNot);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002202 // No need for a temporary for the null check, it is the only input of the following
2203 // instruction.
Calin Juravle225ff812014-11-13 16:46:39 +00002204 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002205 current_block_->AddInstruction(object);
Nicolas Geoffray39468442014-09-02 15:17:15 +01002206 current_block_->AddInstruction(new (arena_) HArrayLength(object));
2207 UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction());
2208 break;
2209 }
2210
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002211 case Instruction::CONST_STRING: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002212 current_block_->AddInstruction(
2213 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_21c(), dex_pc));
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002214 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2215 break;
2216 }
2217
2218 case Instruction::CONST_STRING_JUMBO: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002219 current_block_->AddInstruction(
2220 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_31c(), dex_pc));
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002221 UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction());
2222 break;
2223 }
2224
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002225 case Instruction::CONST_CLASS: {
2226 uint16_t type_index = instruction.VRegB_21c();
2227 bool type_known_final;
2228 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002229 bool dont_use_is_referrers_class;
2230 // `CanAccessTypeWithoutChecks` will tell whether the method being
2231 // built is trying to access its own class, so that the generated
2232 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002233 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002234 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
2235 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002236 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002237 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00002238 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002239 return false;
2240 }
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002241 current_block_->AddInstruction(new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01002242 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002243 type_index,
2244 *dex_compilation_unit_->GetDexFile(),
2245 IsOutermostCompilingClass(type_index),
2246 dex_pc));
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002247 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2248 break;
2249 }
2250
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002251 case Instruction::MOVE_EXCEPTION: {
2252 current_block_->AddInstruction(new (arena_) HLoadException());
2253 UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction());
2254 break;
2255 }
2256
2257 case Instruction::THROW: {
2258 HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00002259 current_block_->AddInstruction(new (arena_) HThrow(exception, dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002260 // A throw instruction must branch to the exit block.
2261 current_block_->AddSuccessor(exit_block_);
2262 // We finished building this block. Set the current block to null to avoid
2263 // adding dead instructions to it.
2264 current_block_ = nullptr;
2265 break;
2266 }
2267
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002268 case Instruction::INSTANCE_OF: {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002269 uint8_t destination = instruction.VRegA_22c();
2270 uint8_t reference = instruction.VRegB_22c();
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002271 uint16_t type_index = instruction.VRegC_22c();
Calin Juravle225ff812014-11-13 16:46:39 +00002272 if (!BuildTypeCheck(instruction, destination, reference, type_index, dex_pc)) {
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002273 return false;
2274 }
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002275 break;
2276 }
2277
2278 case Instruction::CHECK_CAST: {
2279 uint8_t reference = instruction.VRegA_21c();
2280 uint16_t type_index = instruction.VRegB_21c();
Calin Juravle225ff812014-11-13 16:46:39 +00002281 if (!BuildTypeCheck(instruction, -1, reference, type_index, dex_pc)) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002282 return false;
2283 }
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002284 break;
2285 }
2286
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002287 case Instruction::MONITOR_ENTER: {
2288 current_block_->AddInstruction(new (arena_) HMonitorOperation(
2289 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2290 HMonitorOperation::kEnter,
Calin Juravle225ff812014-11-13 16:46:39 +00002291 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002292 break;
2293 }
2294
2295 case Instruction::MONITOR_EXIT: {
2296 current_block_->AddInstruction(new (arena_) HMonitorOperation(
2297 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2298 HMonitorOperation::kExit,
Calin Juravle225ff812014-11-13 16:46:39 +00002299 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002300 break;
2301 }
2302
Andreas Gamped881df52014-11-24 23:28:39 -08002303 case Instruction::PACKED_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002304 BuildPackedSwitch(instruction, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08002305 break;
2306 }
2307
Andreas Gampee4d4d322014-12-04 09:09:57 -08002308 case Instruction::SPARSE_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002309 BuildSparseSwitch(instruction, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08002310 break;
2311 }
2312
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002313 default:
Calin Juravle48c2b032014-12-09 18:11:36 +00002314 VLOG(compiler) << "Did not compile "
2315 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
2316 << " because of unhandled instruction "
2317 << instruction.Name();
2318 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002319 return false;
2320 }
2321 return true;
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00002322} // NOLINT(readability/fn_size)
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002323
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002324HLocal* HGraphBuilder::GetLocalAt(int register_index) const {
2325 return locals_.Get(register_index);
2326}
2327
2328void HGraphBuilder::UpdateLocal(int register_index, HInstruction* instruction) const {
2329 HLocal* local = GetLocalAt(register_index);
2330 current_block_->AddInstruction(new (arena_) HStoreLocal(local, instruction));
2331}
2332
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002333HInstruction* HGraphBuilder::LoadLocal(int register_index, Primitive::Type type) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002334 HLocal* local = GetLocalAt(register_index);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002335 current_block_->AddInstruction(new (arena_) HLoadLocal(local, type));
Nicolas Geoffray787c3072014-03-17 10:20:19 +00002336 return current_block_->GetLastInstruction();
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002337}
2338
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002339} // namespace art