blob: f6e66616aaa1726039753c205e34b8501745c06a [file] [log] [blame]
Elliott Hughes2faa5f12012-01-30 14:42:07 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Brian Carlstrom7e93b502011-08-04 14:16:22 -070016
17#include "intern_table.h"
18
Ian Rogers700a4022014-05-19 16:49:03 -070019#include <memory>
20
Ian Rogers7dfb28c2013-08-22 08:18:36 -070021#include "gc/space/image_space.h"
22#include "mirror/dex_cache.h"
23#include "mirror/object_array-inl.h"
24#include "mirror/object-inl.h"
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070025#include "mirror/string-inl.h"
Ian Rogers2dd0e2c2013-01-24 12:42:14 -080026#include "thread.h"
Elliott Hughes814e4032011-08-23 12:07:56 -070027#include "utf.h"
Brian Carlstrom7e93b502011-08-04 14:16:22 -070028
29namespace art {
30
Ian Rogers7dfb28c2013-08-22 08:18:36 -070031InternTable::InternTable()
Mathieu Chartier893263b2014-03-04 11:07:42 -080032 : log_new_roots_(false), allow_new_interns_(true),
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +010033 new_intern_condition_("New intern condition", *Locks::intern_table_lock_) {
Mathieu Chartierc11d9b82013-09-19 10:01:59 -070034}
Elliott Hughesde69d7f2011-08-18 16:49:37 -070035
Brian Carlstroma663ea52011-08-19 23:33:41 -070036size_t InternTable::Size() const {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +010037 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
Elliott Hughescf4c6c42011-09-01 15:16:42 -070038 return strong_interns_.size() + weak_interns_.size();
Brian Carlstroma663ea52011-08-19 23:33:41 -070039}
40
Hiroshi Yamauchia91a4bc2014-06-13 16:44:55 -070041size_t InternTable::StrongSize() const {
42 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
43 return strong_interns_.size();
44}
45
46size_t InternTable::WeakSize() const {
47 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
48 return weak_interns_.size();
49}
50
Elliott Hughescac6cc72011-11-03 20:31:21 -070051void InternTable::DumpForSigQuit(std::ostream& os) const {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +010052 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
Elliott Hughescac6cc72011-11-03 20:31:21 -070053 os << "Intern table: " << strong_interns_.size() << " strong; "
Ian Rogers7dfb28c2013-08-22 08:18:36 -070054 << weak_interns_.size() << " weak\n";
Elliott Hughescac6cc72011-11-03 20:31:21 -070055}
56
Mathieu Chartier893263b2014-03-04 11:07:42 -080057void InternTable::VisitRoots(RootCallback* callback, void* arg, VisitRootFlags flags) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +010058 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
Mathieu Chartier893263b2014-03-04 11:07:42 -080059 if ((flags & kVisitRootFlagAllRoots) != 0) {
Mathieu Chartierb3070522013-09-17 14:18:21 -070060 for (auto& strong_intern : strong_interns_) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070061 const_cast<GcRoot<mirror::String>&>(strong_intern).
62 VisitRoot(callback, arg, 0, kRootInternedString);
63 DCHECK(!strong_intern.IsNull());
Mathieu Chartierc4621982013-09-16 19:43:47 -070064 }
Mathieu Chartier893263b2014-03-04 11:07:42 -080065 } else if ((flags & kVisitRootFlagNewRoots) != 0) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070066 for (auto& root : new_strong_intern_roots_) {
67 mirror::String* old_ref = root.Read<kWithoutReadBarrier>();
68 root.VisitRoot(callback, arg, 0, kRootInternedString);
69 mirror::String* new_ref = root.Read<kWithoutReadBarrier>();
Hiroshi Yamauchi94f7b492014-07-22 18:08:23 -070070 if (UNLIKELY(new_ref != old_ref)) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070071 // The GC moved a root in the log. Need to search the strong interns and update the
Hiroshi Yamauchi94f7b492014-07-22 18:08:23 -070072 // corresponding object. This is slow, but luckily for us, this may only happen with a
73 // concurrent moving GC.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070074 auto it = strong_interns_.find(GcRoot<mirror::String>(old_ref));
75 DCHECK(it != strong_interns_.end());
76 strong_interns_.erase(it);
77 strong_interns_.insert(GcRoot<mirror::String>(new_ref));
Hiroshi Yamauchi94f7b492014-07-22 18:08:23 -070078 }
79 }
Mathieu Chartier893263b2014-03-04 11:07:42 -080080 }
81
82 if ((flags & kVisitRootFlagClearRootLog) != 0) {
83 new_strong_intern_roots_.clear();
84 }
85 if ((flags & kVisitRootFlagStartLoggingNewRoots) != 0) {
86 log_new_roots_ = true;
87 } else if ((flags & kVisitRootFlagStopLoggingNewRoots) != 0) {
88 log_new_roots_ = false;
Ian Rogers1d54e732013-05-02 21:10:01 -070089 }
Mathieu Chartier423d2a32013-09-12 17:33:56 -070090 // Note: we deliberately don't visit the weak_interns_ table and the immutable image roots.
Brian Carlstrom7e93b502011-08-04 14:16:22 -070091}
92
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070093mirror::String* InternTable::LookupStrong(mirror::String* s) {
94 return Lookup(&strong_interns_, s);
Hiroshi Yamauchi1bd48722014-05-23 19:58:15 -070095}
96
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070097mirror::String* InternTable::LookupWeak(mirror::String* s) {
Hiroshi Yamauchi1bd48722014-05-23 19:58:15 -070098 // Weak interns need a read barrier because they are weak roots.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -070099 return Lookup(&weak_interns_, s);
Hiroshi Yamauchi1bd48722014-05-23 19:58:15 -0700100}
101
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700102mirror::String* InternTable::Lookup(Table* table, mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100103 Locks::intern_table_lock_->AssertHeld(Thread::Current());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700104 auto it = table->find(GcRoot<mirror::String>(s));
105 if (LIKELY(it != table->end())) {
Mathieu Chartierc2bda532014-09-02 16:20:45 -0700106 return const_cast<GcRoot<mirror::String>&>(*it).Read();
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700107 }
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700108 return nullptr;
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700109}
110
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700111mirror::String* InternTable::InsertStrong(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100112 Runtime* runtime = Runtime::Current();
113 if (runtime->IsActiveTransaction()) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700114 runtime->RecordStrongStringInsertion(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100115 }
Mathieu Chartier893263b2014-03-04 11:07:42 -0800116 if (log_new_roots_) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700117 new_strong_intern_roots_.push_back(GcRoot<mirror::String>(s));
Mathieu Chartier893263b2014-03-04 11:07:42 -0800118 }
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700119 strong_interns_.insert(GcRoot<mirror::String>(s));
Mathieu Chartier893263b2014-03-04 11:07:42 -0800120 return s;
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100121}
122
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700123mirror::String* InternTable::InsertWeak(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100124 Runtime* runtime = Runtime::Current();
125 if (runtime->IsActiveTransaction()) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700126 runtime->RecordWeakStringInsertion(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100127 }
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700128 weak_interns_.insert(GcRoot<mirror::String>(s));
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700129 return s;
130}
131
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700132void InternTable::RemoveStrong(mirror::String* s) {
133 Remove(&strong_interns_, s);
Hiroshi Yamauchi1bd48722014-05-23 19:58:15 -0700134}
135
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700136void InternTable::RemoveWeak(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100137 Runtime* runtime = Runtime::Current();
138 if (runtime->IsActiveTransaction()) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700139 runtime->RecordWeakStringRemoval(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100140 }
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700141 Remove(&weak_interns_, s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100142}
143
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700144void InternTable::Remove(Table* table, mirror::String* s) {
145 auto it = table->find(GcRoot<mirror::String>(s));
146 DCHECK(it != table->end());
147 table->erase(it);
Brian Carlstrom7e93b502011-08-04 14:16:22 -0700148}
149
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100150// Insert/remove methods used to undo changes made during an aborted transaction.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700151mirror::String* InternTable::InsertStrongFromTransaction(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100152 DCHECK(!Runtime::Current()->IsActiveTransaction());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700153 return InsertStrong(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100154}
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700155mirror::String* InternTable::InsertWeakFromTransaction(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100156 DCHECK(!Runtime::Current()->IsActiveTransaction());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700157 return InsertWeak(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100158}
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700159void InternTable::RemoveStrongFromTransaction(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100160 DCHECK(!Runtime::Current()->IsActiveTransaction());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700161 RemoveStrong(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100162}
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700163void InternTable::RemoveWeakFromTransaction(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100164 DCHECK(!Runtime::Current()->IsActiveTransaction());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700165 RemoveWeak(s);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100166}
167
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700168static mirror::String* LookupStringFromImage(mirror::String* s)
169 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
170 gc::space::ImageSpace* image = Runtime::Current()->GetHeap()->GetImageSpace();
171 if (image == NULL) {
172 return NULL; // No image present.
173 }
174 mirror::Object* root = image->GetImageHeader().GetImageRoot(ImageHeader::kDexCaches);
175 mirror::ObjectArray<mirror::DexCache>* dex_caches = root->AsObjectArray<mirror::DexCache>();
176 const std::string utf8 = s->ToModifiedUtf8();
177 for (int32_t i = 0; i < dex_caches->GetLength(); ++i) {
178 mirror::DexCache* dex_cache = dex_caches->Get(i);
179 const DexFile* dex_file = dex_cache->GetDexFile();
180 // Binary search the dex file for the string index.
181 const DexFile::StringId* string_id = dex_file->FindStringId(utf8.c_str());
182 if (string_id != NULL) {
183 uint32_t string_idx = dex_file->GetIndexForStringId(*string_id);
184 mirror::String* image = dex_cache->GetResolvedString(string_idx);
185 if (image != NULL) {
186 return image;
187 }
188 }
189 }
190 return NULL;
191}
192
Mathieu Chartierc11d9b82013-09-19 10:01:59 -0700193void InternTable::AllowNewInterns() {
194 Thread* self = Thread::Current();
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100195 MutexLock mu(self, *Locks::intern_table_lock_);
Mathieu Chartierc11d9b82013-09-19 10:01:59 -0700196 allow_new_interns_ = true;
197 new_intern_condition_.Broadcast(self);
198}
199
200void InternTable::DisallowNewInterns() {
201 Thread* self = Thread::Current();
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100202 MutexLock mu(self, *Locks::intern_table_lock_);
Mathieu Chartierc11d9b82013-09-19 10:01:59 -0700203 allow_new_interns_ = false;
204}
205
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800206mirror::String* InternTable::Insert(mirror::String* s, bool is_strong) {
Mathieu Chartierc11d9b82013-09-19 10:01:59 -0700207 Thread* self = Thread::Current();
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100208 MutexLock mu(self, *Locks::intern_table_lock_);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700209
210 DCHECK(s != NULL);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700211
Mathieu Chartierc11d9b82013-09-19 10:01:59 -0700212 while (UNLIKELY(!allow_new_interns_)) {
213 new_intern_condition_.WaitHoldingLocks(self);
214 }
215
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700216 if (is_strong) {
jeffhaob1c6f342012-03-20 17:57:26 -0700217 // Check the strong table for a match.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700218 mirror::String* strong = LookupStrong(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700219 if (strong != NULL) {
220 return strong;
221 }
222
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700223 // Check the image for a match.
224 mirror::String* image = LookupStringFromImage(s);
225 if (image != NULL) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700226 return InsertStrong(image);
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700227 }
228
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700229 // There is no match in the strong table, check the weak table.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700230 mirror::String* weak = LookupWeak(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700231 if (weak != NULL) {
232 // A match was found in the weak table. Promote to the strong table.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700233 RemoveWeak(weak);
234 return InsertStrong(weak);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700235 }
236
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700237 // No match in the strong table or the weak table. Insert into the strong
238 // table.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700239 return InsertStrong(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700240 }
241
242 // Check the strong table for a match.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700243 mirror::String* strong = LookupStrong(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700244 if (strong != NULL) {
245 return strong;
246 }
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700247 // Check the image for a match.
248 mirror::String* image = LookupStringFromImage(s);
jeffhaob1c6f342012-03-20 17:57:26 -0700249 if (image != NULL) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700250 return InsertWeak(image);
jeffhaob1c6f342012-03-20 17:57:26 -0700251 }
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700252 // Check the weak table for a match.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700253 mirror::String* weak = LookupWeak(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700254 if (weak != NULL) {
255 return weak;
256 }
257 // Insert into the weak table.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700258 return InsertWeak(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700259}
260
Mathieu Chartiered0fc1d2014-03-21 14:09:35 -0700261mirror::String* InternTable::InternStrong(int32_t utf16_length, const char* utf8_data) {
262 DCHECK(utf8_data != nullptr);
Ian Rogers7dfb28c2013-08-22 08:18:36 -0700263 return InternStrong(mirror::String::AllocFromModifiedUtf8(
264 Thread::Current(), utf16_length, utf8_data));
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700265}
266
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800267mirror::String* InternTable::InternStrong(const char* utf8_data) {
Mathieu Chartiered0fc1d2014-03-21 14:09:35 -0700268 DCHECK(utf8_data != nullptr);
269 return InternStrong(mirror::String::AllocFromModifiedUtf8(Thread::Current(), utf8_data));
Brian Carlstromc74255f2011-09-11 22:47:39 -0700270}
271
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800272mirror::String* InternTable::InternStrong(mirror::String* s) {
Mathieu Chartier83c8ee02014-01-28 14:50:23 -0800273 if (s == nullptr) {
274 return nullptr;
Elliott Hughes37d4e6b2011-10-13 12:05:20 -0700275 }
Brian Carlstromc74255f2011-09-11 22:47:39 -0700276 return Insert(s, true);
277}
278
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800279mirror::String* InternTable::InternWeak(mirror::String* s) {
Mathieu Chartier83c8ee02014-01-28 14:50:23 -0800280 if (s == nullptr) {
281 return nullptr;
Elliott Hughes37d4e6b2011-10-13 12:05:20 -0700282 }
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700283 return Insert(s, false);
284}
285
Ian Rogers2dd0e2c2013-01-24 12:42:14 -0800286bool InternTable::ContainsWeak(mirror::String* s) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100287 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700288 const mirror::String* found = LookupWeak(s);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700289 return found == s;
290}
291
Mathieu Chartier83c8ee02014-01-28 14:50:23 -0800292void InternTable::SweepInternTableWeaks(IsMarkedCallback* callback, void* arg) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +0100293 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
Mathieu Chartier02e25112013-08-14 16:14:24 -0700294 for (auto it = weak_interns_.begin(), end = weak_interns_.end(); it != end;) {
Hiroshi Yamauchi1bd48722014-05-23 19:58:15 -0700295 // This does not need a read barrier because this is called by GC.
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700296 GcRoot<mirror::String>& root = const_cast<GcRoot<mirror::String>&>(*it);
297 mirror::Object* object = root.Read<kWithoutReadBarrier>();
Mathieu Chartier83c8ee02014-01-28 14:50:23 -0800298 mirror::Object* new_object = callback(object, arg);
Mathieu Chartier6aa3df92013-09-17 15:17:28 -0700299 if (new_object == nullptr) {
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700300 it = weak_interns_.erase(it);
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700301 } else {
Mathieu Chartierc2bda532014-09-02 16:20:45 -0700302 root = GcRoot<mirror::String>(down_cast<mirror::String*>(new_object));
Elliott Hughescf4c6c42011-09-01 15:16:42 -0700303 ++it;
304 }
305 }
Brian Carlstroma663ea52011-08-19 23:33:41 -0700306}
307
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700308std::size_t InternTable::StringHashEquals::operator()(const GcRoot<mirror::String>& root) {
309 if (kIsDebugBuild) {
310 Locks::mutator_lock_->AssertSharedHeld(Thread::Current());
311 }
Mathieu Chartierc2bda532014-09-02 16:20:45 -0700312 return static_cast<size_t>(const_cast<GcRoot<mirror::String>&>(root).Read()->GetHashCode());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700313}
314
315bool InternTable::StringHashEquals::operator()(const GcRoot<mirror::String>& a,
316 const GcRoot<mirror::String>& b) {
317 if (kIsDebugBuild) {
318 Locks::mutator_lock_->AssertSharedHeld(Thread::Current());
319 }
Mathieu Chartierc2bda532014-09-02 16:20:45 -0700320 return const_cast<GcRoot<mirror::String>&>(a).Read()->Equals(
321 const_cast<GcRoot<mirror::String>&>(b).Read());
Mathieu Chartiercdfd39f2014-08-29 18:16:58 -0700322}
323
Brian Carlstrom7e93b502011-08-04 14:16:22 -0700324} // namespace art