Fix the C library initialization to avoid calling static C++ constructors twice.
The problem was due to the fact that, in the case of dynamic executables,
the dynamic linker calls the DT_PREINIT_ARRAY, DT_INIT and DT_INIT_ARRAY
constructors when loading shared libraries and dynamic executables,
*before* calling the executable's entry point (i.e. arch-$ARCH/bionic/crtbegin_dynamic.c)
which in turns call __libc_init() in libc.so, as defined by bionic/libc_init_dynamic.c
The latter did call these constructors array again, mistakenly.
The patch also updates the documentation of many related functions.
Also adds a new section to linker/README.TXT explaining restrictions on
C library usage.
The patch has been tested on a Dream for stability issues with
proprietary blobs:
- H264 decoding works
- Camera + Video recording works
- GPS works
- Sensors work
The tests in system/extra/tests/bionic/libc/common/test_static_cpp_mutex.cpp has been
run and shows the static C++ constructor being called only once.
diff --git a/libc/bionic/libc_init_dynamic.c b/libc/bionic/libc_init_dynamic.c
index 8cf24b4..e1ff13d 100644
--- a/libc/bionic/libc_init_dynamic.c
+++ b/libc/bionic/libc_init_dynamic.c
@@ -25,18 +25,29 @@
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
+
/*
* libc_init_static.c
*
- * This function takes the raw data block set up by the ELF loader
- * in the kernel and parses it. It is invoked by crt0.S which makes
- * any necessary adjustments and passes calls this function using
- * the standard C calling convention.
+ * This function is called for dynamic executables after the dynamic
+ * linker has loaded and initialized all dependent shared libraries.
+ *
+ * It takes the raw data block set up by the ELF loader
+ * in the kernel and parses it.
*
* The arguments are:
- * uintptr_t *elfdata -- The ELF loader data block; usually from the stack.
- * Basically a pointer to argc.
- * void (*onexit)(void) -- Function to install into onexit
+ * elfdata -- The ELF loader data block; usually from the stack.
+ * Basically a pointer to argc.
+ *
+ * onexit -- Function to call on exit, can be NULL.
+ *
+ * slingshot -- Address of the program's main function
+ *
+ * structors -- Table of constructor functions arrays that must
+ * be called before the slingshot.
+ *
+ * It is called from the assembly fragment found in
+ * arch-$ARCH/bionic/crtbegin_dynamic.S
*/
/*
@@ -62,5 +73,18 @@
int (*slingshot)(int, char**, char**),
structors_array_t const * const structors)
{
- __libc_init_common(elfdata, onexit, slingshot, structors, malloc_debug_init);
+ /* NOTE: At this point, the dynamic linker has *already* called
+ * all initializers properly, so we ignore 'structors' to
+ * avoid calling them twice.
+ */
+
+ /* NOTE2: Is it worthwhile to use malloc_debug_init() in the case of
+ * of the non-debug shared C library ?
+ *
+ * The implementation in bionic/malloc_leak.c contains a lot
+ * of code which will turn to be unused, and we add a dispatch
+ * overhead to malloc() et al. that proved to be significant
+ * in the past (e.g. making boot sequence 5% slower)
+ */
+ __libc_init_common(elfdata, onexit, slingshot, NULL, malloc_debug_init);
}