Add fortify compile test.
Two parts of tests are added:
1. Compile time warnings for gcc checking built-in functions.
2. Compile time errors for each errordecl() in bionic.
Bug: 19234260
Change-Id: Iec6e4a8070c36815574fe9e0af9595d6143a4757
diff --git a/tests/fortify_sprintf_warnings.cpp b/tests/fortify_sprintf_warnings.cpp
index 3a2d3c4..141bc1d 100644
--- a/tests/fortify_sprintf_warnings.cpp
+++ b/tests/fortify_sprintf_warnings.cpp
@@ -16,7 +16,16 @@
#undef _FORTIFY_SOURCE
#define _FORTIFY_SOURCE 2
+#include <fcntl.h>
+#include <netinet/in.h>
+#include <poll.h>
+#include <stdarg.h>
#include <stdio.h>
+#include <string.h>
+#include <sys/socket.h>
+#include <sys/stat.h>
+#include <time.h>
+#include <unistd.h>
void test_sprintf() {
char buf[4];
@@ -24,12 +33,12 @@
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___sprintf_chk(char*, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- sprintf(buf, "foobar"); // NOLINT(runtime/printf)
+ sprintf(buf, "foobar"); // NOLINT(runtime/printf)
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___sprintf_chk(char*, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- sprintf(buf, "%s", "foobar"); // NOLINT(runtime/printf)
+ sprintf(buf, "%s", "foobar"); // NOLINT(runtime/printf)
}
void test_snprintf() {
@@ -38,20 +47,186 @@
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___snprintf_chk(char*, {{(long )?}}unsigned int, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- snprintf(buf, 5, "foobar"); // NOLINT(runtime/printf)
+ snprintf(buf, 5, "foobar"); // NOLINT(runtime/printf)
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___snprintf_chk(char*, {{(long )?}}unsigned int, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- snprintf(buf, 5, "%s", "foobar"); // NOLINT(runtime/printf)
+ snprintf(buf, 5, "%s", "foobar"); // NOLINT(runtime/printf)
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___snprintf_chk(char*, {{(long )?}}unsigned int, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- snprintf(buf, 5, " %s ", "foobar"); // NOLINT(runtime/printf)
+ snprintf(buf, 5, " %s ", "foobar"); // NOLINT(runtime/printf)
// NOLINTNEXTLINE(whitespace/line_length)
// GCC: warning: call to int __builtin___snprintf_chk(char*, {{(long )?}}unsigned int, int, {{(long )?}}unsigned int, const char*, ...) will always overflow destination buffer
// clang should emit a warning, but doesn't
- snprintf(buf, 5, "%d", 100000); // NOLINT(runtime/printf)
+ snprintf(buf, 5, "%d", 100000); // NOLINT(runtime/printf)
+}
+
+void test_memcpy() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to void* __builtin___memcpy_chk(void*, const void*, {{(long )?}}unsigned int, {{(long )?}}unsigned int) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ memcpy(buf, "foobar", sizeof("foobar"));
+}
+
+void test_memmove() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to void* __builtin___memmove_chk(void*, const void*, {{(long )?}}unsigned int, {{(long )?}}unsigned int) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ memmove(buf, "foobar", sizeof("foobar"));
+}
+
+void test_memset() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to void* __builtin___memset_chk(void*, int, {{(long )?}}unsigned int, {{(long )?}}unsigned int) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ memset(buf, 0, 6);
+}
+
+void test_strcpy() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to {{(char\* __builtin___strcpy_chk\(char\*, const char\*, unsigned int\))|(void\* __builtin___memcpy_chk\(void\*, const void\*, long unsigned int, long unsigned int\))}} will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ strcpy(buf, "foobar"); // NOLINT(runtime/printf)
+}
+
+void test_stpcpy() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to char* __builtin___stpcpy_chk(char*, const char*, {{(long )?}}unsigned int) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ stpcpy(buf, "foobar");
+}
+
+void test_strncpy() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to char* __builtin___strncpy_chk(char*, const char*, {{(long )?}}unsigned int, {{(long )?}}unsigned int) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ strncpy(buf, "foobar", sizeof("foobar"));
+}
+
+void test_strcat() {
+ char buf[4] = "";
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to {{(char\* __builtin___strcat_chk\(char\*, const char\*, unsigned int\))|(void\* __builtin___memcpy_chk\(void\*, const void\*, long unsigned int, long unsigned int\))}} will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ strcat(buf, "foobar"); // NOLINT(runtime/printf)
+}
+
+void test_strncat() {
+ char buf[4] = "";
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to {{(char\* __builtin___strcat_chk\(char\*, const char\*, unsigned int\))|(void\* __builtin___memcpy_chk\(void\*, const void\*, long unsigned int, long unsigned int\))}} will always overflow destination buffer
+ // gcc output warning with __builtin___strcat_chk for __builtin___strncat_chk.
+ // clang should emit a warning, but doesn't
+ strncat(buf, "foobar", sizeof("foobar"));
+}
+
+void test_vsprintf(const char* fmt, ...) {
+ va_list va;
+ char buf[4];
+ va_start(va, fmt);
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to int __builtin___vsprintf_chk(char*, int, {{(long )?}}unsigned int, const char*, __va_list) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ vsprintf(buf, "foobar", va);
+ va_end(va);
+}
+
+void test_vsnprintf(const char* fmt, ...) {
+ va_list va;
+ char buf[4];
+ va_start(va, fmt);
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: warning: call to int __builtin___vsnprintf_chk(char*, {{(long )?}}unsigned int, int, {{(long )?}}unsigned int, const char*, __va_list) will always overflow destination buffer
+ // clang should emit a warning, but doesn't
+ vsnprintf(buf, 5, "foobar", va); // NOLINT(runtime/printf)
+
+ va_end(va);
+}
+
+void test_fgets() {
+ char buf[4];
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__fgets_too_small_error' declared with attribute error: fgets called with size less than zero
+ // clang should emit a warning, but doesn't
+ fgets(buf, -1, stdin);
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__fgets_too_big_error' declared with attribute error: fgets called with size bigger than buffer
+ // clang should emit a warning, but doesn't
+ fgets(buf, 6, stdin);
+}
+
+void test_recvfrom() {
+ char buf[4];
+ sockaddr_in addr;
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__recvfrom_error' declared with attribute error: recvfrom called with size bigger than buffer
+ // clang should emit a warning, but doesn't
+ recvfrom(0, buf, 6, 0, reinterpret_cast<sockaddr*>(&addr), NULL);
+}
+
+void test_umask() {
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__umask_invalid_mode' declared with attribute error: umask called with invalid mode
+ // clang should emit a warning, but doesn't
+ umask(01777);
+}
+
+void test_read() {
+ char buf[4];
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__read_dest_size_error' declared with attribute error: read called with size bigger than destination
+ // clang should emit a warning, but doesn't
+ read(0, buf, 6);
+}
+
+void test_open() {
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__creat_missing_mode' declared with attribute error: called with O_CREAT, but missing mode
+ // clang should emit a warning, but doesn't
+ open("/dev/null", O_CREAT);
+
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__creat_too_many_args' declared with attribute error: too many arguments
+ // clang should emit a warning, but doesn't
+ open("/dev/null", O_CREAT, 0, 0);
+}
+
+void test_poll() {
+ pollfd fds[1];
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__poll_too_small_error' declared with attribute error: poll: pollfd array smaller than fd count
+ // clang should emit a warning, but doesn't
+ poll(fds, 2, 0);
+}
+
+void test_ppoll() {
+ pollfd fds[1];
+ timespec timeout;
+ // NOLINTNEXTLINE(whitespace/line_length)
+ // GCC: error: call to '__ppoll_too_small_error' declared with attribute error: ppoll: pollfd array smaller than fd count
+ // clang should emit a warning, but doesn't
+ ppoll(fds, 2, &timeout, NULL);
}