commit 2270dfa0c418ab06e89412ea7b4ffe650490bcc9
author Srinavasa Nagaraju <srinavasa.x.nagaraju@sonyericsson.com> Tue Feb 28 12:08:22 2012 +0900
committer Johan Redestig <johan.redestig@sonymobile.com> Tue Jul 31 12:30:28 2012 +0200
tree 533d23fa27577c4b6b34acb9b851e4ec1caea0b6
parent 643e5722338d303c0b5aac41107432d8fde4081c

fix __cxa_finalize() implementation to be thread safe.

__cxa_finalize() modifies the access permissions of __atexit
global variable without acquiring  _ATEXIT_LOCK(). Fix it prevent
any possible races.

Change-Id: I11939d0ebcbf6f360c14163222d40a449d96948e

libc/stdlib/atexit.c

diff --git a/libc/stdlib/atexit.c b/libc/stdlib/atexit.c
index f4bcab9..55b7132 100644
--- a/libc/stdlib/atexit.c
+++ b/libc/stdlib/atexit.c
@@ -131,6 +131,7 @@
 	if (__atexit_invalid)
 		return;
 
+	_ATEXIT_LOCK();
 	call_depth++;
 
 	for (p = __atexit; p != NULL; p = p->next) {
@@ -149,6 +150,7 @@
 				p->fns[n].fn_ptr.cxa_func = NULL;
 				mprotect(p, pgsize, PROT_READ);
 			}
+			_ATEXIT_UNLOCK();
 #if ANDROID
                         /* it looks like we should always call the function
                          * with an argument, even if dso is not NULL. Otherwise
@@ -162,6 +164,7 @@
 			else
 				(*fn.fn_ptr.std_func)();
 #endif /* !ANDROID */
+			_ATEXIT_LOCK();
 		}
 	}
 
@@ -178,6 +181,7 @@
 		}
 		__atexit = NULL;
 	}
+	_ATEXIT_UNLOCK();
 }
 
 /*