commit 6f94de3ca49e4ea147b1c59e5818fa175846518f
author Elliott Hughes <enh@google.com> Tue Feb 12 06:06:22 2013 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Feb 12 06:06:22 2013 +0000
tree 9a2c45004114f53c4cf1f9468a58fe54c58320fa
parent 2a1bb4e64677b9abbc17173c79768ed494565047

Revert "More pthreads cleanup."

This reverts commit 2a1bb4e64677b9abbc17173c79768ed494565047

Change-Id: Ia443d0748015c8e9fc3121e40e68258616767b51

tests/pthread_test.cpp

diff --git a/tests/pthread_test.cpp b/tests/pthread_test.cpp
index 12ebd1e..2cf45f3 100644
--- a/tests/pthread_test.cpp
+++ b/tests/pthread_test.cpp
@@ -28,14 +28,12 @@
   ASSERT_EQ(EINVAL, pthread_key_delete(key));
 }
 
-#if !defined(__GLIBC__) // glibc uses keys internally that its sysconf value doesn't account for.
 TEST(pthread, pthread_key_create_lots) {
   // We can allocate _SC_THREAD_KEYS_MAX keys.
   std::vector<pthread_key_t> keys;
   for (int i = 0; i < sysconf(_SC_THREAD_KEYS_MAX); ++i) {
     pthread_key_t key;
-    // If this fails, it's likely that GLOBAL_INIT_THREAD_LOCAL_BUFFER_COUNT is wrong.
-    ASSERT_EQ(0, pthread_key_create(&key, NULL)) << i << " of " << sysconf(_SC_THREAD_KEYS_MAX);
+    ASSERT_EQ(0, pthread_key_create(&key, NULL));
     keys.push_back(key);
   }
 
@@ -48,7 +46,6 @@
     ASSERT_EQ(0, pthread_key_delete(keys[i]));
   }
 }
-#endif
 
 static void* IdFn(void* arg) {
   return arg;
@@ -90,15 +87,6 @@
   ASSERT_EQ(expected_result, result);
 }
 
-TEST(pthread, pthread_create_EAGAIN) {
-  pthread_attr_t attributes;
-  ASSERT_EQ(0, pthread_attr_init(&attributes));
-  ASSERT_EQ(0, pthread_attr_setstacksize(&attributes, static_cast<size_t>(-1) & ~(getpagesize() - 1)));
-
-  pthread_t t;
-  ASSERT_EQ(EAGAIN, pthread_create(&t, &attributes, IdFn, NULL));
-}
-
 TEST(pthread, pthread_no_join_after_detach) {
   pthread_t t1;
   ASSERT_EQ(0, pthread_create(&t1, NULL, SleepFn, reinterpret_cast<void*>(5)));