commit 8f3eb5a4e5dbbac1fb431e40e25eec07ecc24ee8
author Yabin Cui <yabinc@google.com> Thu Mar 26 18:14:22 2015 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Mar 26 18:14:23 2015 +0000
tree 6eaa84d2960c9e3788093101dd9ae2c9d9426ad7
parent 7c01e3a9ba80c85c7e7998d2347885e9a6e3bbf2
parent 220b99bdc1c5f51825ac2a87062bc05fe3e0d722

Merge "Revert "Cause Fatal error when invalid pthread_id is detected.""

libc/bionic/pthread_internal.cpp

diff --git a/libc/bionic/pthread_internal.cpp b/libc/bionic/pthread_internal.cpp
index afafad8..1967ccf 100644
--- a/libc/bionic/pthread_internal.cpp
+++ b/libc/bionic/pthread_internal.cpp
@@ -81,16 +81,12 @@
 
 pthread_internal_t* __pthread_internal_find(pthread_t thread_id) {
   pthread_internal_t* thread = reinterpret_cast<pthread_internal_t*>(thread_id);
-  {
-    ScopedPthreadMutexLocker locker(&g_thread_list_lock);
+  ScopedPthreadMutexLocker locker(&g_thread_list_lock);
 
-    for (pthread_internal_t* t = g_thread_list; t != NULL; t = t->next) {
-      if (t == thread) {
-        return thread;
-      }
+  for (pthread_internal_t* t = g_thread_list; t != NULL; t = t->next) {
+    if (t == thread) {
+      return thread;
     }
   }
-  // TODO: Remove g_thread_list/g_thread_list_lock when the fatal error below doesn't happen.
-  __libc_fatal("No such thread: %p", thread);
   return NULL;
 }

tests/pthread_test.cpp

diff --git a/tests/pthread_test.cpp b/tests/pthread_test.cpp
index 632e285..13d743f 100644
--- a/tests/pthread_test.cpp
+++ b/tests/pthread_test.cpp
@@ -400,17 +400,12 @@
   ASSERT_EQ(0, pthread_setname_np(t1, "short 2"));
 }
 
-TEST_F(pthread_DeathTest, pthread_setname_np__no_such_thread) {
+TEST(pthread, pthread_setname_np__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
   // Call pthread_setname_np after thread has already exited.
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_setname_np(dead_thread, "short 3"), testing::KilledBySignal(SIGABRT),
-              "No such thread");
-#else
   ASSERT_EQ(ENOENT, pthread_setname_np(dead_thread, "short 3"));
-#endif
 }
 
 TEST(pthread, pthread_kill__0) {
@@ -436,15 +431,11 @@
   ASSERT_EQ(0, pthread_kill(pthread_self(), SIGALRM));
 }
 
-TEST_F(pthread_DeathTest, pthread_detach__no_such_thread) {
+TEST(pthread, pthread_detach__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_detach(dead_thread), testing::KilledBySignal(SIGABRT), "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_detach(dead_thread));
-#endif
 }
 
 TEST(pthread, pthread_detach_no_leak) {
@@ -495,67 +486,44 @@
   ASSERT_EQ(0, clock_gettime(c, &ts));
 }
 
-TEST_F(pthread_DeathTest, pthread_getcpuclockid__no_such_thread) {
+TEST(pthread, pthread_getcpuclockid__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
   clockid_t c;
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_getcpuclockid(dead_thread, &c), testing::KilledBySignal(SIGABRT),
-              "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_getcpuclockid(dead_thread, &c));
-#endif
 }
 
-TEST_F(pthread_DeathTest, pthread_getschedparam__no_such_thread) {
+TEST(pthread, pthread_getschedparam__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
   int policy;
   sched_param param;
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_getschedparam(dead_thread, &policy, &param), testing::KilledBySignal(SIGABRT),
-              "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_getschedparam(dead_thread, &policy, &param));
-#endif
 }
 
-TEST_F(pthread_DeathTest, pthread_setschedparam__no_such_thread) {
+TEST(pthread, pthread_setschedparam__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
   int policy = 0;
   sched_param param;
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_setschedparam(dead_thread, policy, &param), testing::KilledBySignal(SIGABRT),
-              "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_setschedparam(dead_thread, policy, &param));
-#endif
 }
 
-TEST_F(pthread_DeathTest, pthread_join__no_such_thread) {
+TEST(pthread, pthread_join__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_join(dead_thread, NULL), testing::KilledBySignal(SIGABRT), "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_join(dead_thread, NULL));
-#endif
 }
 
-TEST_F(pthread_DeathTest, pthread_kill__no_such_thread) {
+TEST(pthread, pthread_kill__no_such_thread) {
   pthread_t dead_thread;
   MakeDeadThread(dead_thread);
 
-#if defined(__BIONIC__)
-  ASSERT_EXIT(pthread_kill(dead_thread, 0), testing::KilledBySignal(SIGABRT), "No such thread");
-#else
   ASSERT_EQ(ESRCH, pthread_kill(dead_thread, 0));
-#endif
 }
 
 TEST(pthread, pthread_join__multijoin) {