Merge "updater: Clean up LoadSrcTgtVersion2()."
diff --git a/bootloader_message/bootloader_message.cpp b/bootloader_message/bootloader_message.cpp
index d17e055..d8086be 100644
--- a/bootloader_message/bootloader_message.cpp
+++ b/bootloader_message/bootloader_message.cpp
@@ -19,7 +19,6 @@
#include <errno.h>
#include <fcntl.h>
#include <string.h>
-#include <unistd.h>
#include <string>
#include <vector>
@@ -31,13 +30,8 @@
#include <fs_mgr.h>
static std::string get_misc_blk_device(std::string* err) {
- std::unique_ptr<fstab, decltype(&fs_mgr_free_fstab)> fstab(nullptr, fs_mgr_free_fstab);
- // Use different fstab paths for normal boot and recovery boot, respectively
- if (access("/sbin/recovery", F_OK) == 0) {
- fstab.reset(fs_mgr_read_fstab_with_dt("/etc/recovery.fstab"));
- } else {
- fstab.reset(fs_mgr_read_fstab_default());
- }
+ std::unique_ptr<fstab, decltype(&fs_mgr_free_fstab)> fstab(fs_mgr_read_fstab_default(),
+ fs_mgr_free_fstab);
if (!fstab) {
*err = "failed to read default fstab";
return "";
diff --git a/install.cpp b/install.cpp
index db8fb97..7cef44a 100644
--- a/install.cpp
+++ b/install.cpp
@@ -546,17 +546,21 @@
std::chrono::duration<double> duration = std::chrono::system_clock::now() - start;
int time_total = static_cast<int>(duration.count());
- if (ensure_path_mounted(UNCRYPT_STATUS) != 0) {
+ bool has_cache = volume_for_path("/cache") != nullptr;
+ // Skip logging the uncrypt_status on devices without /cache.
+ if (has_cache) {
+ if (ensure_path_mounted(UNCRYPT_STATUS) != 0) {
LOG(WARNING) << "Can't mount " << UNCRYPT_STATUS;
- } else {
+ } else {
std::string uncrypt_status;
if (!android::base::ReadFileToString(UNCRYPT_STATUS, &uncrypt_status)) {
- PLOG(WARNING) << "failed to read uncrypt status";
+ PLOG(WARNING) << "failed to read uncrypt status";
} else if (!android::base::StartsWith(uncrypt_status, "uncrypt_")) {
- PLOG(WARNING) << "corrupted uncrypt_status: " << uncrypt_status;
+ LOG(WARNING) << "corrupted uncrypt_status: " << uncrypt_status;
} else {
- log_buffer.push_back(android::base::Trim(uncrypt_status));
+ log_buffer.push_back(android::base::Trim(uncrypt_status));
}
+ }
}
// The first two lines need to be the package name and install result.