Gitiles
Code Review Sign In
review.blissroms.org / platform_build_blueprint / 0ce142ca05952b911855a0f87a56e5a30f5a1f76
commit0ce142ca05952b911855a0f87a56e5a30f5a1f76[log] [tgz]
authorColin Cross <ccross@android.com>Fri Dec 09 10:29:05 2016 -0800
committerColin Cross <ccross@android.com>Fri Dec 09 10:35:33 2016 -0800
tree55ea95dbf7e6d856271c49e5d1a776d29daff70a
parent0f1fa92e86c7540a19088ec7fb2eed66f9028c16 [diff]
Fix data race when applying replacements

Mutator context goroutines appending directly to the global Context's
replacements list causes a data race.  Send them over a channel
instead.

The renames and replacements are local to the mutator, so move them
out of Context and into the runMutator method.

Change-Id: I797edb1e27ee29f8946c58101b40fcfb50a32eb9
2 files changed
tree: 55ea95dbf7e6d856271c49e5d1a776d29daff70a
  1. bootstrap/
  2. bpfmt/
  3. bpmodify/
  4. deptools/
  5. gotestmain/
  6. gotestrunner/
  7. loadplugins/
  8. parser/
  9. pathtools/
  10. proptools/
  11. tests/
  12. .gitignore
  13. .travis.fix-fork.sh
  14. .travis.gofmt.sh
  15. .travis.install-ninja.sh
  16. .travis.yml
  17. blueprint.bash
  18. Blueprints
  19. bootstrap.bash
  20. build.ninja.in
  21. context.go
  22. context_test.go
  23. CONTRIBUTING.md
  24. doc.go
  25. fs.go
  26. glob.go
  27. LICENSE
  28. live_tracker.go
  29. mangle.go
  30. module_ctx.go
  31. ninja_defs.go
  32. ninja_strings.go
  33. ninja_strings_test.go
  34. ninja_writer.go
  35. ninja_writer_test.go
  36. package_ctx.go
  37. README.md
  38. scope.go
  39. singleton_ctx.go
  40. splice_modules_test.go
  41. unpack.go
  42. unpack_test.go
  43. visit_test.go
README.md

Blueprint Build System

Build Status

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.