Gitiles
Code Review Sign In
review.blissroms.org / platform_build_blueprint / 77418b70b4856ba0b55497a016041b8a34efb54a
commit77418b70b4856ba0b55497a016041b8a34efb54a[log] [tgz]
authorSasha Smundak <asmundak@google.com>Tue Jan 21 13:31:06 2020 -0800
committerSasha Smundak <asmundak@google.com>Thu Jan 23 13:32:43 2020 -0800
treef72a51a9c13ac0ff39a7c2b90243d58a9f8ef112
parent0c4d1db0a0fd0affb77a9175872256ba4eea1524 [diff]
Fix null pointer dereference printing an expression.

Parser.parseVariable method should always set the value of the variable
it creates. Failure to do so may end up in the following:

```
$ androidmk  <(printf "FOO:=(X)\nFOO:=bar\n")
parse error:
<input>:3:1: variable already set, previous assignment: FOO@<input>:1:5 = %!s(PANIC=String method: runtime error: invalid memory address or nil pointer dereference) (%!s(PANIC=String method: runtime error: invalid memory address or nil pointer dereference)) false
```

The cause is that calling Parser.Parse to parse `FOO=abc` created
a Variable instance with nil value, causing panic on print attempt.

Test: m androidmk && androidmk  <(printf "FOO:=(X)\nFOO:=bar\n")
(should print:
ERROR:  parse error:
<input>:3:1: variable already set, previous assignment: FOO@<input>:1:5 = X = Not Evaluated (X = Not Evaluated) false)

Change-Id: I296d7984df6d8796e0075f9eb692b234f8c94f08
3 files changed
tree: f72a51a9c13ac0ff39a7c2b90243d58a9f8ef112
  1. bootstrap/
  2. bpfmt/
  3. bpmodify/
  4. deptools/
  5. gotestmain/
  6. gotestrunner/
  7. loadplugins/
  8. microfactory/
  9. parser/
  10. pathtools/
  11. proptools/
  12. tests/
  13. .gitignore
  14. .travis.fix-fork.sh
  15. .travis.gofmt.sh
  16. .travis.install-ninja.sh
  17. .travis.yml
  18. blueprint.bash
  19. blueprint_impl.bash
  20. Blueprints
  21. bootstrap.bash
  22. context.go
  23. context_test.go
  24. CONTRIBUTING.md
  25. doc.go
  26. glob.go
  27. glob_test.go
  28. go.mod
  29. LICENSE
  30. live_tracker.go
  31. mangle.go
  32. module_ctx.go
  33. module_ctx_test.go
  34. name_interface.go
  35. ninja_defs.go
  36. ninja_strings.go
  37. ninja_strings_test.go
  38. ninja_writer.go
  39. ninja_writer_test.go
  40. package_ctx.go
  41. README.md
  42. scope.go
  43. singleton_ctx.go
  44. splice_modules_test.go
  45. visit_test.go
README.md

Blueprint Build System

Build Status

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.