Gitiles
Code Review Sign In
review.blissroms.org / platform_build_blueprint / 526e02f0c68dc1cd0545ffc8ea51db577faa7575
commit526e02f0c68dc1cd0545ffc8ea51db577faa7575[log] [tgz]
authorColin Cross <ccross@android.com>Thu Jun 21 13:31:53 2018 -0700
committerColin Cross <ccross@android.com>Thu Jun 21 13:41:42 2018 -0700
tree935bda9639c4eff6d3c58073671f73f6261813e8
parentcd0310f22560ac38270cdd6f22aa5123fe5e384b [diff]
Prevent duplicate visit calls in WalkDeps

WalkDeps was following every possible path through the dependency
tree, which can be enormous.  Modify it to only call visit for
any particular (child, parent) pair once for each direct dependency
by not recursing into child if visitDown returns true but child
has already been visited.

Test: TestWalkDeps, TestWalkDepsDuplicates
Change-Id: Ieef28399bd10e744417cdeb661dfa04fbeb4ec60
3 files changed
tree: 935bda9639c4eff6d3c58073671f73f6261813e8
  1. bootstrap/
  2. bpfmt/
  3. bpmodify/
  4. deptools/
  5. gotestmain/
  6. gotestrunner/
  7. loadplugins/
  8. microfactory/
  9. parser/
  10. pathtools/
  11. proptools/
  12. tests/
  13. .gitignore
  14. .travis.fix-fork.sh
  15. .travis.gofmt.sh
  16. .travis.install-ninja.sh
  17. .travis.yml
  18. blueprint.bash
  19. blueprint_impl.bash
  20. Blueprints
  21. bootstrap.bash
  22. context.go
  23. context_test.go
  24. CONTRIBUTING.md
  25. doc.go
  26. glob.go
  27. glob_test.go
  28. LICENSE
  29. live_tracker.go
  30. mangle.go
  31. module_ctx.go
  32. name_interface.go
  33. ninja_defs.go
  34. ninja_strings.go
  35. ninja_strings_test.go
  36. ninja_writer.go
  37. ninja_writer_test.go
  38. package_ctx.go
  39. README.md
  40. scope.go
  41. singleton_ctx.go
  42. splice_modules_test.go
  43. unpack.go
  44. unpack_test.go
  45. visit_test.go
README.md

Blueprint Build System

Build Status

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.