Gitiles
Code Review Sign In
review.blissroms.org / platform_build_blueprint / 3adb2409648d6f8b25354ac47f083dae87731f10
commit3adb2409648d6f8b25354ac47f083dae87731f10[log] [tgz]
authorColin Cross <ccross@android.com>Fri Jan 15 20:09:51 2021 -0800
committerColin Cross <ccross@android.com>Fri Jan 15 22:21:28 2021 -0800
treec2a2bf6ce948954736c6b52033880045936b3f38
parentf6ef1558843fc847e15dd11516e20f098b1ad325 [diff]
Fix silently ignoring values assigned to map properties

Values assigned to map properties were silently ignored instead of
reported as an error.  Add a check when recursing into structs that
the value is a map.

Fixes: 177706602
Test: m nothing
Test: TestUnpackErrors
Change-Id: Ic56aeb1b9da6d5c86b6d98adae7bddb60c450404
2 files changed
tree: c2a2bf6ce948954736c6b52033880045936b3f38
  1. .github/
  2. bootstrap/
  3. bpfmt/
  4. bpmodify/
  5. deptools/
  6. gotestmain/
  7. gotestrunner/
  8. loadplugins/
  9. microfactory/
  10. parser/
  11. pathtools/
  12. proptools/
  13. tests/
  14. .gitignore
  15. .gofmt.sh
  16. blueprint.bash
  17. blueprint_impl.bash
  18. Blueprints
  19. bootstrap.bash
  20. CODEOWNERS
  21. context.go
  22. context_test.go
  23. CONTRIBUTING.md
  24. doc.go
  25. glob.go
  26. glob_test.go
  27. go.mod
  28. LICENSE
  29. live_tracker.go
  30. mangle.go
  31. module_ctx.go
  32. module_ctx_test.go
  33. name_interface.go
  34. ninja_defs.go
  35. ninja_strings.go
  36. ninja_strings_test.go
  37. ninja_writer.go
  38. ninja_writer_test.go
  39. package_ctx.go
  40. provider.go
  41. provider_test.go
  42. README.md
  43. scope.go
  44. singleton_ctx.go
  45. splice_modules_test.go
  46. visit_test.go
README.md

Blueprint Build System

build

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.