Gitiles
Code Review Sign In
review.blissroms.org / platform_build_blueprint / 1ac43bd65a55065fc9803af51344baa9d7fdff87
commit1ac43bd65a55065fc9803af51344baa9d7fdff87[log] [tgz]
authorFrancois Berder <francois.berder@arm.com>Mon Jan 18 14:02:09 2021 +0000
committerFrancois Berder <francois.berder@arm.com>Thu Jan 28 14:28:34 2021 +0000
tree2e80128b02a256ebf82103270b7c6603cb8af4d9
parent53e92a0de6c2528401cbf5cf3b1be9958fbe99e9 [diff]
Optimize HasTag function

The commits optimizes HasTag function by avoiding
the call to strings.Split that allocates a list of strings.

HasTag is called from the ExtendProperties family of functions.
So this new implementation would benefit any primary builder
that extensively uses property appending.

Add a small benchmark for HasTag function.
It shows that HasTag is speed up by a factor of 2-3 with the new
implementation.

Before:
goos: linux
goarch: amd64
BenchmarkHasTag/NoTag-56         	20000000	       118 ns/op
BenchmarkHasTag/EmptyTag-56      	20000000	       120 ns/op
BenchmarkHasTag/OtherTag-56      	10000000	       131 ns/op
BenchmarkHasTag/MatchingTag-56   	10000000	       177 ns/op
BenchmarkHasTag/ExtraValues-56   	 5000000	       392 ns/op
BenchmarkHasTag/ExtraTags-56     	10000000	       183 ns/op

After:
goos: linux
goarch: amd64
BenchmarkHasTag/NoTag-56         	200000000	        11.5 ns/op
BenchmarkHasTag/EmptyTag-56      	200000000	        11.5 ns/op
BenchmarkHasTag/OtherTag-56      	50000000	        25.2 ns/op
BenchmarkHasTag/MatchingTag-56   	20000000	        61.4 ns/op
BenchmarkHasTag/ExtraValues-56   	20000000	        94.3 ns/op
BenchmarkHasTag/ExtraTags-56     	20000000	        79.1 ns/op

Signed-off-by: Francois Berder <francois.berder@arm.com>
Change-Id: Ib45498e9ad6aebeca2beddea63543da40c0b1a21
2 files changed
tree: 2e80128b02a256ebf82103270b7c6603cb8af4d9
  1. .github/
  2. bootstrap/
  3. bpfmt/
  4. bpmodify/
  5. deptools/
  6. gotestmain/
  7. gotestrunner/
  8. loadplugins/
  9. microfactory/
  10. parser/
  11. pathtools/
  12. proptools/
  13. tests/
  14. .gitignore
  15. .gofmt.sh
  16. blueprint.bash
  17. blueprint_impl.bash
  18. Blueprints
  19. bootstrap.bash
  20. CODEOWNERS
  21. context.go
  22. context_test.go
  23. CONTRIBUTING.md
  24. doc.go
  25. glob.go
  26. glob_test.go
  27. go.mod
  28. LICENSE
  29. live_tracker.go
  30. mangle.go
  31. module_ctx.go
  32. module_ctx_test.go
  33. name_interface.go
  34. ninja_defs.go
  35. ninja_strings.go
  36. ninja_strings_test.go
  37. ninja_writer.go
  38. ninja_writer_test.go
  39. package_ctx.go
  40. provider.go
  41. provider_test.go
  42. README.md
  43. scope.go
  44. singleton_ctx.go
  45. splice_modules_test.go
  46. visit_test.go
README.md

Blueprint Build System

build

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.