| commit | 9e1ff7423bc96c4325179e3c69fe1e8884ef3fcb | [log] [tgz] |
|---|---|---|
| author | Colin Cross <ccross@android.com> | Thu Sep 20 22:44:36 2018 -0700 |
| committer | Colin Cross <ccross@android.com> | Mon Sep 24 15:09:32 2018 -0700 |
| tree | 58fca6bf994fcdf9c4725004d28bd88348e647ae | |
| parent | c64f26418e2af6131584bf498d3dd41fb970f9a4 [diff] |
Fix recursive globs through symlinks filepath.Walk does not walk symlinks to directories, which leads to inconsitent behavior with following symlinks. Replace the use of filepath.Walk in ListDirsRecursive with a helper function that lists each directory and walks anything for which IsDir reports true, which includes following symlinks, and then reconstructs the path through the symlink. Test: fs_test.go Test: glob_test.go Change-Id: Ie4dd0820e9c7c0a124caa65210ce20439a44da16
- pathtools/fs.go[diff]
- pathtools/fs_test.go[diff]
- pathtools/glob_test.go[diff]
- pathtools/testdata/dangling/a/a/a[Added - diff]
- pathtools/testdata/dangling/b[Added - diff]
- pathtools/testdata/dangling/c[Added - diff]
- pathtools/testdata/dangling/d[Added - diff]
- pathtools/testdata/dangling/dangling[Added - diff]
- pathtools/testdata/dangling/e[Added - diff]
- pathtools/testdata/symlinks/a/a/a[Added - diff]
- pathtools/testdata/symlinks/b[Added - diff]
- pathtools/testdata/symlinks/c[Added - diff]
- pathtools/testdata/symlinks/d[Added - diff]
- pathtools/testdata/symlinks/e[Added - diff]
14 files changed
tree: 58fca6bf994fcdf9c4725004d28bd88348e647ae
- bootstrap/
- bpfmt/
- bpmodify/
- deptools/
- gotestmain/
- gotestrunner/
- loadplugins/
- microfactory/
- parser/
- pathtools/
- proptools/
- tests/
- .gitignore
- .travis.fix-fork.sh
- .travis.gofmt.sh
- .travis.install-ninja.sh
- .travis.yml
- blueprint.bash
- blueprint_impl.bash
- Blueprints
- bootstrap.bash
- context.go
- context_test.go
- CONTRIBUTING.md
- doc.go
- glob.go
- glob_test.go
- go.mod
- LICENSE
- live_tracker.go
- mangle.go
- module_ctx.go
- name_interface.go
- ninja_defs.go
- ninja_strings.go
- ninja_strings_test.go
- ninja_writer.go
- ninja_writer_test.go
- package_ctx.go
- README.md
- scope.go
- singleton_ctx.go
- splice_modules_test.go
- unpack.go
- unpack_test.go
- visit_test.go
README.md
Blueprint Build System
Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.