| commit | c1a1ec30df41635336433fea51f102c44ea17ccf | [log] [tgz] |
|---|---|---|
| author | Tao Bao <tbao@google.com> | Tue Jun 18 16:29:37 2019 -0700 |
| committer | Tao Bao <tbao@google.com> | Tue Jun 18 23:53:53 2019 -0700 |
| tree | cc11f7dba524994835d24181ba3a9cde56990b1f | |
| parent | e346d8c25e8bc568db0f00da31cf52433c5b7a7e [diff] |
releasetools: Make common.ZipWriteStr Python 3 compatible. Python 2 and 3 behave differently when calling ZipFile.writestr() with zinfo.external_attr being 0. Python 3 uses `0o600 << 16` as the value for such a case (since https://github.com/python/cpython/commit/18ee29d0b870caddc0806916ca2c823254f1a1f9), which seems to make more sense. Otherwise the entry will end up with 0o000 as the permission bits. This CL updates common.ZipWriteStr to follow the logic in Python 3, in order to get consistent behavior between using the two versions. Bug: 131631303 Test: `python -m unittest test_common.CommonZipTest` Test: `python3 -m unittest test_common.CommonZipTest` Change-Id: If8429855d922ef1ad76591f703215a0ce5089f0f
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.