Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1 | #!/usr/bin/python |
Marco Nelissen | 8e20196 | 2010-03-10 16:16:02 -0800 | [diff] [blame] | 2 | # This file uses the following encoding: utf-8 |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 3 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 4 | """Grep warnings messages and output HTML tables or warning counts in CSV. |
| 5 | |
| 6 | Default is to output warnings in HTML tables grouped by warning severity. |
| 7 | Use option --byproject to output tables grouped by source file projects. |
| 8 | Use option --gencsv to output warning counts in CSV format. |
| 9 | """ |
| 10 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 11 | # List of important data structures and functions in this script. |
| 12 | # |
| 13 | # To parse and keep warning message in the input file: |
| 14 | # severity: classification of message severity |
| 15 | # severity.range [0, 1, ... last_severity_level] |
| 16 | # severity.colors for header background |
| 17 | # severity.column_headers for the warning count table |
| 18 | # severity.headers for warning message tables |
| 19 | # warn_patterns: |
| 20 | # warn_patterns[w]['category'] tool that issued the warning, not used now |
| 21 | # warn_patterns[w]['description'] table heading |
| 22 | # warn_patterns[w]['members'] matched warnings from input |
| 23 | # warn_patterns[w]['option'] compiler flag to control the warning |
| 24 | # warn_patterns[w]['patterns'] regular expressions to match warnings |
| 25 | # warn_patterns[w]['projects'][p] number of warnings of pattern w in p |
| 26 | # warn_patterns[w]['severity'] severity level |
| 27 | # project_list[p][0] project name |
| 28 | # project_list[p][1] regular expression to match a project path |
| 29 | # project_patterns[p] re.compile(project_list[p][1]) |
| 30 | # project_names[p] project_list[p][0] |
| 31 | # warning_messages array of each warning message, without source url |
| 32 | # warning_records array of [idx to warn_patterns, |
| 33 | # idx to project_names, |
| 34 | # idx to warning_messages] |
| 35 | # platform_version |
| 36 | # target_product |
| 37 | # target_variant |
| 38 | # compile_patterns, parse_input_file |
| 39 | # |
| 40 | # To emit html page of warning messages: |
| 41 | # flags: --byproject, --url, --separator |
| 42 | # Old stuff for static html components: |
| 43 | # html_script_style: static html scripts and styles |
| 44 | # htmlbig: |
| 45 | # dump_stats, dump_html_prologue, dump_html_epilogue: |
| 46 | # emit_buttons: |
| 47 | # dump_fixed |
| 48 | # sort_warnings: |
| 49 | # emit_stats_by_project: |
| 50 | # all_patterns, |
| 51 | # findproject, classify_warning |
| 52 | # dump_html |
| 53 | # |
| 54 | # New dynamic HTML page's static JavaScript data: |
| 55 | # Some data are copied from Python to JavaScript, to generate HTML elements. |
| 56 | # FlagURL args.url |
| 57 | # FlagSeparator args.separator |
| 58 | # SeverityColors: severity.colors |
| 59 | # SeverityHeaders: severity.headers |
| 60 | # SeverityColumnHeaders: severity.column_headers |
| 61 | # ProjectNames: project_names, or project_list[*][0] |
| 62 | # WarnPatternsSeverity: warn_patterns[*]['severity'] |
| 63 | # WarnPatternsDescription: warn_patterns[*]['description'] |
| 64 | # WarnPatternsOption: warn_patterns[*]['option'] |
| 65 | # WarningMessages: warning_messages |
| 66 | # Warnings: warning_records |
| 67 | # StatsHeader: warning count table header row |
| 68 | # StatsRows: array of warning count table rows |
| 69 | # |
| 70 | # New dynamic HTML page's dynamic JavaScript data: |
| 71 | # |
| 72 | # New dynamic HTML related function to emit data: |
| 73 | # escape_string, strip_escape_string, emit_warning_arrays |
| 74 | # emit_js_data(): |
| 75 | # |
| 76 | # To emit csv files of warning message counts: |
| 77 | # flag --gencsv |
| 78 | # description_for_csv, string_for_csv: |
| 79 | # count_severity(sev, kind): |
| 80 | # dump_csv(): |
| 81 | |
Ian Rogers | f382973 | 2016-05-10 12:06:01 -0700 | [diff] [blame] | 82 | import argparse |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 83 | import re |
| 84 | |
Ian Rogers | f382973 | 2016-05-10 12:06:01 -0700 | [diff] [blame] | 85 | parser = argparse.ArgumentParser(description='Convert a build log into HTML') |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 86 | parser.add_argument('--gencsv', |
| 87 | help='Generate a CSV file with number of various warnings', |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 88 | action='store_true', |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 89 | default=False) |
Chih-Hung Hsieh | 4354a33 | 2016-07-22 14:09:31 -0700 | [diff] [blame] | 90 | parser.add_argument('--byproject', |
| 91 | help='Separate warnings in HTML output by project names', |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 92 | action='store_true', |
Chih-Hung Hsieh | 4354a33 | 2016-07-22 14:09:31 -0700 | [diff] [blame] | 93 | default=False) |
Ian Rogers | f382973 | 2016-05-10 12:06:01 -0700 | [diff] [blame] | 94 | parser.add_argument('--url', |
| 95 | help='Root URL of an Android source code tree prefixed ' |
| 96 | 'before files in warnings') |
| 97 | parser.add_argument('--separator', |
| 98 | help='Separator between the end of a URL and the line ' |
| 99 | 'number argument. e.g. #') |
| 100 | parser.add_argument(dest='buildlog', metavar='build.log', |
| 101 | help='Path to build.log file') |
| 102 | args = parser.parse_args() |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 103 | |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 104 | |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 105 | class Severity(object): |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 106 | """Severity levels and attributes.""" |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 107 | # numbered by dump order |
| 108 | FIXMENOW = 0 |
| 109 | HIGH = 1 |
| 110 | MEDIUM = 2 |
| 111 | LOW = 3 |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 112 | ANALYZER = 4 |
| 113 | TIDY = 5 |
| 114 | HARMLESS = 6 |
| 115 | UNKNOWN = 7 |
| 116 | SKIP = 8 |
| 117 | range = range(SKIP + 1) |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 118 | attributes = [ |
| 119 | # pylint:disable=bad-whitespace |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 120 | ['fuchsia', 'FixNow', 'Critical warnings, fix me now'], |
| 121 | ['red', 'High', 'High severity warnings'], |
| 122 | ['orange', 'Medium', 'Medium severity warnings'], |
| 123 | ['yellow', 'Low', 'Low severity warnings'], |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 124 | ['hotpink', 'Analyzer', 'Clang-Analyzer warnings'], |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 125 | ['peachpuff', 'Tidy', 'Clang-Tidy warnings'], |
| 126 | ['limegreen', 'Harmless', 'Harmless warnings'], |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 127 | ['lightblue', 'Unknown', 'Unknown warnings'], |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 128 | ['grey', 'Unhandled', 'Unhandled warnings'] |
| 129 | ] |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 130 | colors = [a[0] for a in attributes] |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 131 | column_headers = [a[1] for a in attributes] |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 132 | headers = [a[2] for a in attributes] |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 133 | |
| 134 | warn_patterns = [ |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 135 | # pylint:disable=line-too-long,g-inconsistent-quotes |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 136 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
| 137 | 'description': 'clang-analyzer Security warning', |
| 138 | 'patterns': [r".*: warning: .+\[clang-analyzer-security.*\]"]}, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 139 | {'category': 'make', 'severity': Severity.MEDIUM, |
| 140 | 'description': 'make: overriding commands/ignoring old commands', |
| 141 | 'patterns': [r".*: warning: overriding commands for target .+", |
| 142 | r".*: warning: ignoring old commands for target .+"]}, |
| 143 | {'category': 'make', 'severity': Severity.HIGH, |
| 144 | 'description': 'make: LOCAL_CLANG is false', |
| 145 | 'patterns': [r".*: warning: LOCAL_CLANG is set to false"]}, |
| 146 | {'category': 'make', 'severity': Severity.HIGH, |
| 147 | 'description': 'SDK App using platform shared library', |
| 148 | 'patterns': [r".*: warning: .+ \(.*app:sdk.*\) should not link to .+ \(native:platform\)"]}, |
| 149 | {'category': 'make', 'severity': Severity.HIGH, |
| 150 | 'description': 'System module linking to a vendor module', |
| 151 | 'patterns': [r".*: warning: .+ \(.+\) should not link to .+ \(partition:.+\)"]}, |
| 152 | {'category': 'make', 'severity': Severity.MEDIUM, |
| 153 | 'description': 'Invalid SDK/NDK linking', |
| 154 | 'patterns': [r".*: warning: .+ \(.+\) should not link to .+ \(.+\)"]}, |
| 155 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Wimplicit-function-declaration', |
| 156 | 'description': 'Implicit function declaration', |
| 157 | 'patterns': [r".*: warning: implicit declaration of function .+", |
| 158 | r".*: warning: implicitly declaring library function"]}, |
| 159 | {'category': 'C/C++', 'severity': Severity.SKIP, |
| 160 | 'description': 'skip, conflicting types for ...', |
| 161 | 'patterns': [r".*: warning: conflicting types for '.+'"]}, |
| 162 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Wtype-limits', |
| 163 | 'description': 'Expression always evaluates to true or false', |
| 164 | 'patterns': [r".*: warning: comparison is always .+ due to limited range of data type", |
| 165 | r".*: warning: comparison of unsigned .*expression .+ is always true", |
| 166 | r".*: warning: comparison of unsigned .*expression .+ is always false"]}, |
| 167 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 168 | 'description': 'Potential leak of memory, bad free, use after free', |
| 169 | 'patterns': [r".*: warning: Potential leak of memory", |
| 170 | r".*: warning: Potential memory leak", |
| 171 | r".*: warning: Memory allocated by alloca\(\) should not be deallocated", |
| 172 | r".*: warning: Memory allocated by .+ should be deallocated by .+ not .+", |
| 173 | r".*: warning: 'delete' applied to a pointer that was allocated", |
| 174 | r".*: warning: Use of memory after it is freed", |
| 175 | r".*: warning: Argument to .+ is the address of .+ variable", |
| 176 | r".*: warning: Argument to free\(\) is offset by .+ of memory allocated by", |
| 177 | r".*: warning: Attempt to .+ released memory"]}, |
| 178 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 179 | 'description': 'Use transient memory for control value', |
| 180 | 'patterns': [r".*: warning: .+Using such transient memory for the control value is .*dangerous."]}, |
| 181 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 182 | 'description': 'Return address of stack memory', |
| 183 | 'patterns': [r".*: warning: Address of stack memory .+ returned to caller", |
| 184 | r".*: warning: Address of stack memory .+ will be a dangling reference"]}, |
| 185 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 186 | 'description': 'Problem with vfork', |
| 187 | 'patterns': [r".*: warning: This .+ is prohibited after a successful vfork", |
| 188 | r".*: warning: Call to function '.+' is insecure "]}, |
| 189 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': 'infinite-recursion', |
| 190 | 'description': 'Infinite recursion', |
| 191 | 'patterns': [r".*: warning: all paths through this function will call itself"]}, |
| 192 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 193 | 'description': 'Potential buffer overflow', |
| 194 | 'patterns': [r".*: warning: Size argument is greater than .+ the destination buffer", |
| 195 | r".*: warning: Potential buffer overflow.", |
| 196 | r".*: warning: String copy function overflows destination buffer"]}, |
| 197 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 198 | 'description': 'Incompatible pointer types', |
| 199 | 'patterns': [r".*: warning: assignment from incompatible pointer type", |
| 200 | r".*: warning: return from incompatible pointer type", |
| 201 | r".*: warning: passing argument [0-9]+ of '.*' from incompatible pointer type", |
| 202 | r".*: warning: initialization from incompatible pointer type"]}, |
| 203 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-fno-builtin', |
| 204 | 'description': 'Incompatible declaration of built in function', |
| 205 | 'patterns': [r".*: warning: incompatible implicit declaration of built-in function .+"]}, |
| 206 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Wincompatible-library-redeclaration', |
| 207 | 'description': 'Incompatible redeclaration of library function', |
| 208 | 'patterns': [r".*: warning: incompatible redeclaration of library function .+"]}, |
| 209 | {'category': 'C/C++', 'severity': Severity.HIGH, |
| 210 | 'description': 'Null passed as non-null argument', |
| 211 | 'patterns': [r".*: warning: Null passed to a callee that requires a non-null"]}, |
| 212 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunused-parameter', |
| 213 | 'description': 'Unused parameter', |
| 214 | 'patterns': [r".*: warning: unused parameter '.*'"]}, |
| 215 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunused', |
| 216 | 'description': 'Unused function, variable or label', |
| 217 | 'patterns': [r".*: warning: '.+' defined but not used", |
| 218 | r".*: warning: unused function '.+'", |
| 219 | r".*: warning: private field '.+' is not used", |
| 220 | r".*: warning: unused variable '.+'"]}, |
| 221 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunused-value', |
| 222 | 'description': 'Statement with no effect or result unused', |
| 223 | 'patterns': [r".*: warning: statement with no effect", |
| 224 | r".*: warning: expression result unused"]}, |
| 225 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunused-result', |
| 226 | 'description': 'Ignoreing return value of function', |
| 227 | 'patterns': [r".*: warning: ignoring return value of function .+Wunused-result"]}, |
| 228 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmissing-field-initializers', |
| 229 | 'description': 'Missing initializer', |
| 230 | 'patterns': [r".*: warning: missing initializer"]}, |
| 231 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wdelete-non-virtual-dtor', |
| 232 | 'description': 'Need virtual destructor', |
| 233 | 'patterns': [r".*: warning: delete called .* has virtual functions but non-virtual destructor"]}, |
| 234 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 235 | 'description': 'skip, near initialization for ...', |
| 236 | 'patterns': [r".*: warning: \(near initialization for '.+'\)"]}, |
| 237 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wdate-time', |
| 238 | 'description': 'Expansion of data or time macro', |
| 239 | 'patterns': [r".*: warning: expansion of date or time macro is not reproducible"]}, |
| 240 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wformat', |
| 241 | 'description': 'Format string does not match arguments', |
| 242 | 'patterns': [r".*: warning: format '.+' expects type '.+', but argument [0-9]+ has type '.+'", |
| 243 | r".*: warning: more '%' conversions than data arguments", |
| 244 | r".*: warning: data argument not used by format string", |
| 245 | r".*: warning: incomplete format specifier", |
| 246 | r".*: warning: unknown conversion type .* in format", |
| 247 | r".*: warning: format .+ expects .+ but argument .+Wformat=", |
| 248 | r".*: warning: field precision should have .+ but argument has .+Wformat", |
| 249 | r".*: warning: format specifies type .+ but the argument has .*type .+Wformat"]}, |
| 250 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wformat-extra-args', |
| 251 | 'description': 'Too many arguments for format string', |
| 252 | 'patterns': [r".*: warning: too many arguments for format"]}, |
| 253 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wformat-invalid-specifier', |
| 254 | 'description': 'Invalid format specifier', |
| 255 | 'patterns': [r".*: warning: invalid .+ specifier '.+'.+format-invalid-specifier"]}, |
| 256 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wsign-compare', |
| 257 | 'description': 'Comparison between signed and unsigned', |
| 258 | 'patterns': [r".*: warning: comparison between signed and unsigned", |
| 259 | r".*: warning: comparison of promoted \~unsigned with unsigned", |
| 260 | r".*: warning: signed and unsigned type in conditional expression"]}, |
| 261 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 262 | 'description': 'Comparison between enum and non-enum', |
| 263 | 'patterns': [r".*: warning: enumeral and non-enumeral type in conditional expression"]}, |
| 264 | {'category': 'libpng', 'severity': Severity.MEDIUM, |
| 265 | 'description': 'libpng: zero area', |
| 266 | 'patterns': [r".*libpng warning: Ignoring attempt to set cHRM RGB triangle with zero area"]}, |
| 267 | {'category': 'aapt', 'severity': Severity.MEDIUM, |
| 268 | 'description': 'aapt: no comment for public symbol', |
| 269 | 'patterns': [r".*: warning: No comment for public symbol .+"]}, |
| 270 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmissing-braces', |
| 271 | 'description': 'Missing braces around initializer', |
| 272 | 'patterns': [r".*: warning: missing braces around initializer.*"]}, |
| 273 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 274 | 'description': 'No newline at end of file', |
| 275 | 'patterns': [r".*: warning: no newline at end of file"]}, |
| 276 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 277 | 'description': 'Missing space after macro name', |
| 278 | 'patterns': [r".*: warning: missing whitespace after the macro name"]}, |
| 279 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wcast-align', |
| 280 | 'description': 'Cast increases required alignment', |
| 281 | 'patterns': [r".*: warning: cast from .* to .* increases required alignment .*"]}, |
| 282 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wcast-qual', |
| 283 | 'description': 'Qualifier discarded', |
| 284 | 'patterns': [r".*: warning: passing argument [0-9]+ of '.+' discards qualifiers from pointer target type", |
| 285 | r".*: warning: assignment discards qualifiers from pointer target type", |
| 286 | r".*: warning: passing .+ to parameter of type .+ discards qualifiers", |
| 287 | r".*: warning: assigning to .+ from .+ discards qualifiers", |
| 288 | r".*: warning: initializing .+ discards qualifiers .+types-discards-qualifiers", |
| 289 | r".*: warning: return discards qualifiers from pointer target type"]}, |
| 290 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunknown-attributes', |
| 291 | 'description': 'Unknown attribute', |
| 292 | 'patterns': [r".*: warning: unknown attribute '.+'"]}, |
| 293 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wignored-attributes', |
| 294 | 'description': 'Attribute ignored', |
| 295 | 'patterns': [r".*: warning: '_*packed_*' attribute ignored", |
| 296 | r".*: warning: attribute declaration must precede definition .+ignored-attributes"]}, |
| 297 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wvisibility', |
| 298 | 'description': 'Visibility problem', |
| 299 | 'patterns': [r".*: warning: declaration of '.+' will not be visible outside of this function"]}, |
| 300 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wattributes', |
| 301 | 'description': 'Visibility mismatch', |
| 302 | 'patterns': [r".*: warning: '.+' declared with greater visibility than the type of its field '.+'"]}, |
| 303 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 304 | 'description': 'Shift count greater than width of type', |
| 305 | 'patterns': [r".*: warning: (left|right) shift count >= width of type"]}, |
| 306 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wextern-initializer', |
| 307 | 'description': 'extern <foo> is initialized', |
| 308 | 'patterns': [r".*: warning: '.+' initialized and declared 'extern'", |
| 309 | r".*: warning: 'extern' variable has an initializer"]}, |
| 310 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wold-style-declaration', |
| 311 | 'description': 'Old style declaration', |
| 312 | 'patterns': [r".*: warning: 'static' is not at beginning of declaration"]}, |
| 313 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wreturn-type', |
| 314 | 'description': 'Missing return value', |
| 315 | 'patterns': [r".*: warning: control reaches end of non-void function"]}, |
| 316 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wimplicit-int', |
| 317 | 'description': 'Implicit int type', |
| 318 | 'patterns': [r".*: warning: type specifier missing, defaults to 'int'", |
| 319 | r".*: warning: type defaults to 'int' in declaration of '.+'"]}, |
| 320 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmain-return-type', |
| 321 | 'description': 'Main function should return int', |
| 322 | 'patterns': [r".*: warning: return type of 'main' is not 'int'"]}, |
| 323 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wuninitialized', |
| 324 | 'description': 'Variable may be used uninitialized', |
| 325 | 'patterns': [r".*: warning: '.+' may be used uninitialized in this function"]}, |
| 326 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Wuninitialized', |
| 327 | 'description': 'Variable is used uninitialized', |
| 328 | 'patterns': [r".*: warning: '.+' is used uninitialized in this function", |
| 329 | r".*: warning: variable '.+' is uninitialized when used here"]}, |
| 330 | {'category': 'ld', 'severity': Severity.MEDIUM, 'option': '-fshort-enums', |
| 331 | 'description': 'ld: possible enum size mismatch', |
| 332 | 'patterns': [r".*: warning: .* uses variable-size enums yet the output is to use 32-bit enums; use of enum values across objects may fail"]}, |
| 333 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wpointer-sign', |
| 334 | 'description': 'Pointer targets differ in signedness', |
| 335 | 'patterns': [r".*: warning: pointer targets in initialization differ in signedness", |
| 336 | r".*: warning: pointer targets in assignment differ in signedness", |
| 337 | r".*: warning: pointer targets in return differ in signedness", |
| 338 | r".*: warning: pointer targets in passing argument [0-9]+ of '.+' differ in signedness"]}, |
| 339 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wstrict-overflow', |
| 340 | 'description': 'Assuming overflow does not occur', |
| 341 | 'patterns': [r".*: warning: assuming signed overflow does not occur when assuming that .* is always (true|false)"]}, |
| 342 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wempty-body', |
| 343 | 'description': 'Suggest adding braces around empty body', |
| 344 | 'patterns': [r".*: warning: suggest braces around empty body in an 'if' statement", |
| 345 | r".*: warning: empty body in an if-statement", |
| 346 | r".*: warning: suggest braces around empty body in an 'else' statement", |
| 347 | r".*: warning: empty body in an else-statement"]}, |
| 348 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wparentheses', |
| 349 | 'description': 'Suggest adding parentheses', |
| 350 | 'patterns': [r".*: warning: suggest explicit braces to avoid ambiguous 'else'", |
| 351 | r".*: warning: suggest parentheses around arithmetic in operand of '.+'", |
| 352 | r".*: warning: suggest parentheses around comparison in operand of '.+'", |
| 353 | r".*: warning: logical not is only applied to the left hand side of this comparison", |
| 354 | r".*: warning: using the result of an assignment as a condition without parentheses", |
| 355 | r".*: warning: .+ has lower precedence than .+ be evaluated first .+Wparentheses", |
| 356 | r".*: warning: suggest parentheses around '.+?' .+ '.+?'", |
| 357 | r".*: warning: suggest parentheses around assignment used as truth value"]}, |
| 358 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 359 | 'description': 'Static variable used in non-static inline function', |
| 360 | 'patterns': [r".*: warning: '.+' is static but used in inline function '.+' which is not static"]}, |
| 361 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wimplicit int', |
| 362 | 'description': 'No type or storage class (will default to int)', |
| 363 | 'patterns': [r".*: warning: data definition has no type or storage class"]}, |
| 364 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 365 | 'description': 'Null pointer', |
| 366 | 'patterns': [r".*: warning: Dereference of null pointer", |
| 367 | r".*: warning: Called .+ pointer is null", |
| 368 | r".*: warning: Forming reference to null pointer", |
| 369 | r".*: warning: Returning null reference", |
| 370 | r".*: warning: Null pointer passed as an argument to a 'nonnull' parameter", |
| 371 | r".*: warning: .+ results in a null pointer dereference", |
| 372 | r".*: warning: Access to .+ results in a dereference of a null pointer", |
| 373 | r".*: warning: Null pointer argument in"]}, |
| 374 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 375 | 'description': 'skip, parameter name (without types) in function declaration', |
| 376 | 'patterns': [r".*: warning: parameter names \(without types\) in function declaration"]}, |
| 377 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wstrict-aliasing', |
| 378 | 'description': 'Dereferencing <foo> breaks strict aliasing rules', |
| 379 | 'patterns': [r".*: warning: dereferencing .* break strict-aliasing rules"]}, |
| 380 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wpointer-to-int-cast', |
| 381 | 'description': 'Cast from pointer to integer of different size', |
| 382 | 'patterns': [r".*: warning: cast from pointer to integer of different size", |
| 383 | r".*: warning: initialization makes pointer from integer without a cast"]}, |
| 384 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wint-to-pointer-cast', |
| 385 | 'description': 'Cast to pointer from integer of different size', |
| 386 | 'patterns': [r".*: warning: cast to pointer from integer of different size"]}, |
| 387 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 388 | 'description': 'Symbol redefined', |
| 389 | 'patterns': [r".*: warning: "".+"" redefined"]}, |
| 390 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 391 | 'description': 'skip, ... location of the previous definition', |
| 392 | 'patterns': [r".*: warning: this is the location of the previous definition"]}, |
| 393 | {'category': 'ld', 'severity': Severity.MEDIUM, |
| 394 | 'description': 'ld: type and size of dynamic symbol are not defined', |
| 395 | 'patterns': [r".*: warning: type and size of dynamic symbol `.+' are not defined"]}, |
| 396 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 397 | 'description': 'Pointer from integer without cast', |
| 398 | 'patterns': [r".*: warning: assignment makes pointer from integer without a cast"]}, |
| 399 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 400 | 'description': 'Pointer from integer without cast', |
| 401 | 'patterns': [r".*: warning: passing argument [0-9]+ of '.+' makes pointer from integer without a cast"]}, |
| 402 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 403 | 'description': 'Integer from pointer without cast', |
| 404 | 'patterns': [r".*: warning: assignment makes integer from pointer without a cast"]}, |
| 405 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 406 | 'description': 'Integer from pointer without cast', |
| 407 | 'patterns': [r".*: warning: passing argument [0-9]+ of '.+' makes integer from pointer without a cast"]}, |
| 408 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 409 | 'description': 'Integer from pointer without cast', |
| 410 | 'patterns': [r".*: warning: return makes integer from pointer without a cast"]}, |
| 411 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunknown-pragmas', |
| 412 | 'description': 'Ignoring pragma', |
| 413 | 'patterns': [r".*: warning: ignoring #pragma .+"]}, |
| 414 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-W#pragma-messages', |
| 415 | 'description': 'Pragma warning messages', |
| 416 | 'patterns': [r".*: warning: .+W#pragma-messages"]}, |
| 417 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wclobbered', |
| 418 | 'description': 'Variable might be clobbered by longjmp or vfork', |
| 419 | 'patterns': [r".*: warning: variable '.+' might be clobbered by 'longjmp' or 'vfork'"]}, |
| 420 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wclobbered', |
| 421 | 'description': 'Argument might be clobbered by longjmp or vfork', |
| 422 | 'patterns': [r".*: warning: argument '.+' might be clobbered by 'longjmp' or 'vfork'"]}, |
| 423 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wredundant-decls', |
| 424 | 'description': 'Redundant declaration', |
| 425 | 'patterns': [r".*: warning: redundant redeclaration of '.+'"]}, |
| 426 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 427 | 'description': 'skip, previous declaration ... was here', |
| 428 | 'patterns': [r".*: warning: previous declaration of '.+' was here"]}, |
| 429 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wswitch-enum', |
| 430 | 'description': 'Enum value not handled in switch', |
| 431 | 'patterns': [r".*: warning: .*enumeration value.* not handled in switch.+Wswitch"]}, |
| 432 | {'category': 'java', 'severity': Severity.MEDIUM, 'option': '-encoding', |
| 433 | 'description': 'Java: Non-ascii characters used, but ascii encoding specified', |
| 434 | 'patterns': [r".*: warning: unmappable character for encoding ascii"]}, |
| 435 | {'category': 'java', 'severity': Severity.MEDIUM, |
| 436 | 'description': 'Java: Non-varargs call of varargs method with inexact argument type for last parameter', |
| 437 | 'patterns': [r".*: warning: non-varargs call of varargs method with inexact argument type for last parameter"]}, |
| 438 | {'category': 'java', 'severity': Severity.MEDIUM, |
| 439 | 'description': 'Java: Unchecked method invocation', |
| 440 | 'patterns': [r".*: warning: \[unchecked\] unchecked method invocation: .+ in class .+"]}, |
| 441 | {'category': 'java', 'severity': Severity.MEDIUM, |
| 442 | 'description': 'Java: Unchecked conversion', |
| 443 | 'patterns': [r".*: warning: \[unchecked\] unchecked conversion"]}, |
| 444 | {'category': 'java', 'severity': Severity.MEDIUM, |
| 445 | 'description': '_ used as an identifier', |
| 446 | 'patterns': [r".*: warning: '_' used as an identifier"]}, |
Ian Rogers | 32bb9bd | 2016-05-09 23:19:42 -0700 | [diff] [blame] | 447 | |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 448 | # Warnings from Error Prone. |
| 449 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 450 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 451 | 'description': 'Java: Use of deprecated member', |
| 452 | 'patterns': [r'.*: warning: \[deprecation\] .+']}, |
| 453 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 454 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 455 | 'description': 'Java: Unchecked conversion', |
| 456 | 'patterns': [r'.*: warning: \[unchecked\] .+']}, |
Ian Rogers | 32bb9bd | 2016-05-09 23:19:42 -0700 | [diff] [blame] | 457 | |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 458 | # Warnings from Error Prone (auto generated list). |
| 459 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 460 | 'severity': Severity.LOW, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 461 | 'description': |
| 462 | 'Java: Deprecated item is not annotated with @Deprecated', |
| 463 | 'patterns': [r".*: warning: \[DepAnn\] .+"]}, |
| 464 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 465 | 'severity': Severity.LOW, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 466 | 'description': |
| 467 | 'Java: Fallthrough warning suppression has no effect if warning is suppressed', |
| 468 | 'patterns': [r".*: warning: \[FallthroughSuppression\] .+"]}, |
| 469 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 470 | 'severity': Severity.LOW, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 471 | 'description': |
| 472 | 'Java: Prefer \'L\' to \'l\' for the suffix to long literals', |
| 473 | 'patterns': [r".*: warning: \[LongLiteralLowerCaseSuffix\] .+"]}, |
| 474 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 475 | 'severity': Severity.LOW, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 476 | 'description': |
| 477 | 'Java: @Binds is a more efficient and declaritive mechanism for delegating a binding.', |
| 478 | 'patterns': [r".*: warning: \[UseBinds\] .+"]}, |
| 479 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 480 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 481 | 'description': |
| 482 | 'Java: Assertions may be disabled at runtime and do not guarantee that execution will halt here; consider throwing an exception instead', |
| 483 | 'patterns': [r".*: warning: \[AssertFalse\] .+"]}, |
| 484 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 485 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 486 | 'description': |
| 487 | 'Java: Classes that implement Annotation must override equals and hashCode. Consider using AutoAnnotation instead of implementing Annotation by hand.', |
| 488 | 'patterns': [r".*: warning: \[BadAnnotationImplementation\] .+"]}, |
| 489 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 490 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 491 | 'description': |
| 492 | 'Java: BigDecimal(double) and BigDecimal.valueOf(double) may lose precision, prefer BigDecimal(String) or BigDecimal(long)', |
| 493 | 'patterns': [r".*: warning: \[BigDecimalLiteralDouble\] .+"]}, |
| 494 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 495 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 496 | 'description': |
| 497 | 'Java: Mockito cannot mock final classes', |
| 498 | 'patterns': [r".*: warning: \[CannotMockFinalClass\] .+"]}, |
| 499 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 500 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 501 | 'description': |
| 502 | 'Java: This code, which counts elements using a loop, can be replaced by a simpler library method', |
| 503 | 'patterns': [r".*: warning: \[ElementsCountedInLoop\] .+"]}, |
| 504 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 505 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 506 | 'description': |
| 507 | 'Java: Empty top-level type declaration', |
| 508 | 'patterns': [r".*: warning: \[EmptyTopLevelDeclaration\] .+"]}, |
| 509 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 510 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 511 | 'description': |
| 512 | 'Java: Classes that override equals should also override hashCode.', |
| 513 | 'patterns': [r".*: warning: \[EqualsHashCode\] .+"]}, |
| 514 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 515 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 516 | 'description': |
| 517 | 'Java: An equality test between objects with incompatible types always returns false', |
| 518 | 'patterns': [r".*: warning: \[EqualsIncompatibleType\] .+"]}, |
| 519 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 520 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 521 | 'description': |
| 522 | 'Java: If you return or throw from a finally, then values returned or thrown from the try-catch block will be ignored. Consider using try-with-resources instead.', |
| 523 | 'patterns': [r".*: warning: \[Finally\] .+"]}, |
| 524 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 525 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 526 | 'description': |
| 527 | 'Java: This annotation has incompatible modifiers as specified by its @IncompatibleModifiers annotation', |
| 528 | 'patterns': [r".*: warning: \[IncompatibleModifiers\] .+"]}, |
| 529 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 530 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 531 | 'description': |
| 532 | 'Java: Class should not implement both `Iterable` and `Iterator`', |
| 533 | 'patterns': [r".*: warning: \[IterableAndIterator\] .+"]}, |
| 534 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 535 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 536 | 'description': |
| 537 | 'Java: Floating-point comparison without error tolerance', |
| 538 | 'patterns': [r".*: warning: \[JUnit3FloatingPointComparisonWithoutDelta\] .+"]}, |
| 539 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 540 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 541 | 'description': |
| 542 | 'Java: Test class inherits from JUnit 3\'s TestCase but has JUnit 4 @Test annotations.', |
| 543 | 'patterns': [r".*: warning: \[JUnitAmbiguousTestClass\] .+"]}, |
| 544 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 545 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 546 | 'description': |
| 547 | 'Java: Enum switch statement is missing cases', |
| 548 | 'patterns': [r".*: warning: \[MissingCasesInEnumSwitch\] .+"]}, |
| 549 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 550 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 551 | 'description': |
| 552 | 'Java: Not calling fail() when expecting an exception masks bugs', |
| 553 | 'patterns': [r".*: warning: \[MissingFail\] .+"]}, |
| 554 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 555 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 556 | 'description': |
| 557 | 'Java: method overrides method in supertype; expected @Override', |
| 558 | 'patterns': [r".*: warning: \[MissingOverride\] .+"]}, |
| 559 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 560 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 561 | 'description': |
| 562 | 'Java: Source files should not contain multiple top-level class declarations', |
| 563 | 'patterns': [r".*: warning: \[MultipleTopLevelClasses\] .+"]}, |
| 564 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 565 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 566 | 'description': |
| 567 | 'Java: This update of a volatile variable is non-atomic', |
| 568 | 'patterns': [r".*: warning: \[NonAtomicVolatileUpdate\] .+"]}, |
| 569 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 570 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 571 | 'description': |
| 572 | 'Java: Static import of member uses non-canonical name', |
| 573 | 'patterns': [r".*: warning: \[NonCanonicalStaticMemberImport\] .+"]}, |
| 574 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 575 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 576 | 'description': |
| 577 | 'Java: equals method doesn\'t override Object.equals', |
| 578 | 'patterns': [r".*: warning: \[NonOverridingEquals\] .+"]}, |
| 579 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 580 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 581 | 'description': |
| 582 | 'Java: Constructors should not be annotated with @Nullable since they cannot return null', |
| 583 | 'patterns': [r".*: warning: \[NullableConstructor\] .+"]}, |
| 584 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 585 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 586 | 'description': |
| 587 | 'Java: @Nullable should not be used for primitive types since they cannot be null', |
| 588 | 'patterns': [r".*: warning: \[NullablePrimitive\] .+"]}, |
| 589 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 590 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 591 | 'description': |
| 592 | 'Java: void-returning methods should not be annotated with @Nullable, since they cannot return null', |
| 593 | 'patterns': [r".*: warning: \[NullableVoid\] .+"]}, |
| 594 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 595 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 596 | 'description': |
| 597 | 'Java: Package names should match the directory they are declared in', |
| 598 | 'patterns': [r".*: warning: \[PackageLocation\] .+"]}, |
| 599 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 600 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 601 | 'description': |
| 602 | 'Java: Second argument to Preconditions.* is a call to String.format(), which can be unwrapped', |
| 603 | 'patterns': [r".*: warning: \[PreconditionsErrorMessageEagerEvaluation\] .+"]}, |
| 604 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 605 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 606 | 'description': |
| 607 | 'Java: Preconditions only accepts the %s placeholder in error message strings', |
| 608 | 'patterns': [r".*: warning: \[PreconditionsInvalidPlaceholder\] .+"]}, |
| 609 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 610 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 611 | 'description': |
| 612 | 'Java: Passing a primitive array to a varargs method is usually wrong', |
| 613 | 'patterns': [r".*: warning: \[PrimitiveArrayPassedToVarargsMethod\] .+"]}, |
| 614 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 615 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 616 | 'description': |
| 617 | 'Java: Protobuf fields cannot be null, so this check is redundant', |
| 618 | 'patterns': [r".*: warning: \[ProtoFieldPreconditionsCheckNotNull\] .+"]}, |
| 619 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 620 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 621 | 'description': |
| 622 | 'Java: This annotation is missing required modifiers as specified by its @RequiredModifiers annotation', |
| 623 | 'patterns': [r".*: warning: \[RequiredModifiers\] .+"]}, |
| 624 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 625 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 626 | 'description': |
| 627 | 'Java: A static variable or method should not be accessed from an object instance', |
| 628 | 'patterns': [r".*: warning: \[StaticAccessedFromInstance\] .+"]}, |
| 629 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 630 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 631 | 'description': |
| 632 | 'Java: String comparison using reference equality instead of value equality', |
| 633 | 'patterns': [r".*: warning: \[StringEquality\] .+"]}, |
| 634 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 635 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 636 | 'description': |
| 637 | 'Java: Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution.', |
| 638 | 'patterns': [r".*: warning: \[TypeParameterUnusedInFormals\] .+"]}, |
| 639 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 640 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 641 | 'description': |
| 642 | 'Java: Using static imports for types is unnecessary', |
| 643 | 'patterns': [r".*: warning: \[UnnecessaryStaticImport\] .+"]}, |
| 644 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 645 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 646 | 'description': |
| 647 | 'Java: Unsynchronized method overrides a synchronized method.', |
| 648 | 'patterns': [r".*: warning: \[UnsynchronizedOverridesSynchronized\] .+"]}, |
| 649 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 650 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 651 | 'description': |
| 652 | 'Java: Non-constant variable missing @Var annotation', |
| 653 | 'patterns': [r".*: warning: \[Var\] .+"]}, |
| 654 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 655 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 656 | 'description': |
| 657 | 'Java: Because of spurious wakeups, Object.wait() and Condition.await() must always be called in a loop', |
| 658 | 'patterns': [r".*: warning: \[WaitNotInLoop\] .+"]}, |
| 659 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 660 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 661 | 'description': |
| 662 | 'Java: Subclasses of Fragment must be instantiable via Class#newInstance(): the class must be public, static and have a public nullary constructor', |
| 663 | 'patterns': [r".*: warning: \[FragmentNotInstantiable\] .+"]}, |
| 664 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 665 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 666 | 'description': |
| 667 | 'Java: Hardcoded reference to /sdcard', |
| 668 | 'patterns': [r".*: warning: \[HardCodedSdCardPath\] .+"]}, |
| 669 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 670 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 671 | 'description': |
| 672 | 'Java: Incompatible type as argument to Object-accepting Java collections method', |
| 673 | 'patterns': [r".*: warning: \[CollectionIncompatibleType\] .+"]}, |
| 674 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 675 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 676 | 'description': |
| 677 | 'Java: @AssistedInject and @Inject should not be used on different constructors in the same class.', |
| 678 | 'patterns': [r".*: warning: \[AssistedInjectAndInjectOnConstructors\] .+"]}, |
| 679 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 680 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 681 | 'description': |
| 682 | 'Java: Although Guice allows injecting final fields, doing so is not recommended because the injected value may not be visible to other threads.', |
| 683 | 'patterns': [r".*: warning: \[GuiceInjectOnFinalField\] .+"]}, |
| 684 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 685 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 686 | 'description': |
| 687 | 'Java: This method is not annotated with @Inject, but it overrides a method that is annotated with @com.google.inject.Inject. Guice will inject this method, and it is recommended to annotate it explicitly.', |
| 688 | 'patterns': [r".*: warning: \[OverridesGuiceInjectableMethod\] .+"]}, |
| 689 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 690 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 691 | 'description': |
| 692 | 'Java: Double-checked locking on non-volatile fields is unsafe', |
| 693 | 'patterns': [r".*: warning: \[DoubleCheckedLocking\] .+"]}, |
| 694 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 695 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 696 | 'description': |
| 697 | 'Java: Writes to static fields should not be guarded by instance locks', |
| 698 | 'patterns': [r".*: warning: \[StaticGuardedByInstance\] .+"]}, |
| 699 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 700 | 'severity': Severity.MEDIUM, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 701 | 'description': |
| 702 | 'Java: Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.', |
| 703 | 'patterns': [r".*: warning: \[SynchronizeOnNonFinalField\] .+"]}, |
| 704 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 705 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 706 | 'description': |
| 707 | 'Java: Reference equality used to compare arrays', |
| 708 | 'patterns': [r".*: warning: \[ArrayEquals\] .+"]}, |
| 709 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 710 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 711 | 'description': |
| 712 | 'Java: hashcode method on array does not hash array contents', |
| 713 | 'patterns': [r".*: warning: \[ArrayHashCode\] .+"]}, |
| 714 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 715 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 716 | 'description': |
| 717 | 'Java: Calling toString on an array does not provide useful information', |
| 718 | 'patterns': [r".*: warning: \[ArrayToString.*\] .+"]}, |
| 719 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 720 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 721 | 'description': |
| 722 | 'Java: Arrays.asList does not autobox primitive arrays, as one might expect.', |
| 723 | 'patterns': [r".*: warning: \[ArraysAsListPrimitiveArray\] .+"]}, |
| 724 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 725 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 726 | 'description': |
| 727 | 'Java: AsyncCallable should not return a null Future, only a Future whose result is null.', |
| 728 | 'patterns': [r".*: warning: \[AsyncCallableReturnsNull\] .+"]}, |
| 729 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 730 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 731 | 'description': |
| 732 | 'Java: AsyncFunction should not return a null Future, only a Future whose result is null.', |
| 733 | 'patterns': [r".*: warning: \[AsyncFunctionReturnsNull\] .+"]}, |
| 734 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 735 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 736 | 'description': |
| 737 | 'Java: Possible sign flip from narrowing conversion', |
| 738 | 'patterns': [r".*: warning: \[BadComparable\] .+"]}, |
| 739 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 740 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 741 | 'description': |
| 742 | 'Java: Shift by an amount that is out of range', |
| 743 | 'patterns': [r".*: warning: \[BadShiftAmount\] .+"]}, |
| 744 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 745 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 746 | 'description': |
| 747 | 'Java: valueOf provides better time and space performance', |
| 748 | 'patterns': [r".*: warning: \[BoxedPrimitiveConstructor\] .+"]}, |
| 749 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 750 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 751 | 'description': |
| 752 | 'Java: The called constructor accepts a parameter with the same name and type as one of its caller\'s parameters, but its caller doesn\'t pass that parameter to it. It\'s likely that it was intended to.', |
| 753 | 'patterns': [r".*: warning: \[ChainingConstructorIgnoresParameter\] .+"]}, |
| 754 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 755 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 756 | 'description': |
| 757 | 'Java: Ignored return value of method that is annotated with @CheckReturnValue', |
| 758 | 'patterns': [r".*: warning: \[CheckReturnValue\] .+"]}, |
| 759 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 760 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 761 | 'description': |
| 762 | 'Java: Inner class is non-static but does not reference enclosing class', |
| 763 | 'patterns': [r".*: warning: \[ClassCanBeStatic\] .+"]}, |
| 764 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 765 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 766 | 'description': |
| 767 | 'Java: The source file name should match the name of the top-level class it contains', |
| 768 | 'patterns': [r".*: warning: \[ClassName\] .+"]}, |
| 769 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 770 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 771 | 'description': |
| 772 | 'Java: This comparison method violates the contract', |
| 773 | 'patterns': [r".*: warning: \[ComparisonContractViolated\] .+"]}, |
| 774 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 775 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 776 | 'description': |
| 777 | 'Java: Comparison to value that is out of range for the compared type', |
| 778 | 'patterns': [r".*: warning: \[ComparisonOutOfRange\] .+"]}, |
| 779 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 780 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 781 | 'description': |
| 782 | 'Java: Non-compile-time constant expression passed to parameter with @CompileTimeConstant type annotation.', |
| 783 | 'patterns': [r".*: warning: \[CompileTimeConstant\] .+"]}, |
| 784 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 785 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 786 | 'description': |
| 787 | 'Java: Exception created but not thrown', |
| 788 | 'patterns': [r".*: warning: \[DeadException\] .+"]}, |
| 789 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 790 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 791 | 'description': |
| 792 | 'Java: Division by integer literal zero', |
| 793 | 'patterns': [r".*: warning: \[DivZero\] .+"]}, |
| 794 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 795 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 796 | 'description': |
| 797 | 'Java: Empty statement after if', |
| 798 | 'patterns': [r".*: warning: \[EmptyIf\] .+"]}, |
| 799 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 800 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 801 | 'description': |
| 802 | 'Java: == NaN always returns false; use the isNaN methods instead', |
| 803 | 'patterns': [r".*: warning: \[EqualsNaN\] .+"]}, |
| 804 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 805 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 806 | 'description': |
| 807 | 'Java: Method annotated @ForOverride must be protected or package-private and only invoked from declaring class', |
| 808 | 'patterns': [r".*: warning: \[ForOverride\] .+"]}, |
| 809 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 810 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 811 | 'description': |
| 812 | 'Java: Futures.getChecked requires a checked exception type with a standard constructor.', |
| 813 | 'patterns': [r".*: warning: \[FuturesGetCheckedIllegalExceptionType\] .+"]}, |
| 814 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 815 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 816 | 'description': |
| 817 | 'Java: Calling getClass() on an object of type Class returns the Class object for java.lang.Class; you probably meant to operate on the object directly', |
| 818 | 'patterns': [r".*: warning: \[GetClassOnClass\] .+"]}, |
| 819 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 820 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 821 | 'description': |
| 822 | 'Java: An object is tested for equality to itself using Guava Libraries', |
| 823 | 'patterns': [r".*: warning: \[GuavaSelfEquals\] .+"]}, |
| 824 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 825 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 826 | 'description': |
| 827 | 'Java: contains() is a legacy method that is equivalent to containsValue()', |
| 828 | 'patterns': [r".*: warning: \[HashtableContains\] .+"]}, |
| 829 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 830 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 831 | 'description': |
| 832 | 'Java: Cipher.getInstance() is invoked using either the default settings or ECB mode', |
| 833 | 'patterns': [r".*: warning: \[InsecureCipherMode\] .+"]}, |
| 834 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 835 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 836 | 'description': |
| 837 | 'Java: Invalid syntax used for a regular expression', |
| 838 | 'patterns': [r".*: warning: \[InvalidPatternSyntax\] .+"]}, |
| 839 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 840 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 841 | 'description': |
| 842 | 'Java: The argument to Class#isInstance(Object) should not be a Class', |
| 843 | 'patterns': [r".*: warning: \[IsInstanceOfClass\] .+"]}, |
| 844 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 845 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 846 | 'description': |
| 847 | 'Java: jMock tests must have a @RunWith(JMock.class) annotation, or the Mockery field must have a @Rule JUnit annotation', |
| 848 | 'patterns': [r".*: warning: \[JMockTestWithoutRunWithOrRuleAnnotation\] .+"]}, |
| 849 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 850 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 851 | 'description': |
| 852 | 'Java: Test method will not be run; please prefix name with "test"', |
| 853 | 'patterns': [r".*: warning: \[JUnit3TestNotRun\] .+"]}, |
| 854 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 855 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 856 | 'description': |
| 857 | 'Java: setUp() method will not be run; Please add a @Before annotation', |
| 858 | 'patterns': [r".*: warning: \[JUnit4SetUpNotRun\] .+"]}, |
| 859 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 860 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 861 | 'description': |
| 862 | 'Java: tearDown() method will not be run; Please add an @After annotation', |
| 863 | 'patterns': [r".*: warning: \[JUnit4TearDownNotRun\] .+"]}, |
| 864 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 865 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 866 | 'description': |
| 867 | 'Java: Test method will not be run; please add @Test annotation', |
| 868 | 'patterns': [r".*: warning: \[JUnit4TestNotRun\] .+"]}, |
| 869 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 870 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 871 | 'description': |
| 872 | 'Java: Printf-like format string does not match its arguments', |
| 873 | 'patterns': [r".*: warning: \[MalformedFormatString\] .+"]}, |
| 874 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 875 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 876 | 'description': |
| 877 | 'Java: Use of "YYYY" (week year) in a date pattern without "ww" (week in year). You probably meant to use "yyyy" (year) instead.', |
| 878 | 'patterns': [r".*: warning: \[MisusedWeekYear\] .+"]}, |
| 879 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 880 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 881 | 'description': |
| 882 | 'Java: A bug in Mockito will cause this test to fail at runtime with a ClassCastException', |
| 883 | 'patterns': [r".*: warning: \[MockitoCast\] .+"]}, |
| 884 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 885 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 886 | 'description': |
| 887 | 'Java: Missing method call for verify(mock) here', |
| 888 | 'patterns': [r".*: warning: \[MockitoUsage\] .+"]}, |
| 889 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 890 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 891 | 'description': |
| 892 | 'Java: Modifying a collection with itself', |
| 893 | 'patterns': [r".*: warning: \[ModifyingCollectionWithItself\] .+"]}, |
| 894 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 895 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 896 | 'description': |
| 897 | 'Java: Compound assignments to bytes, shorts, chars, and floats hide dangerous casts', |
| 898 | 'patterns': [r".*: warning: \[NarrowingCompoundAssignment\] .+"]}, |
| 899 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 900 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 901 | 'description': |
| 902 | 'Java: @NoAllocation was specified on this method, but something was found that would trigger an allocation', |
| 903 | 'patterns': [r".*: warning: \[NoAllocation\] .+"]}, |
| 904 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 905 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 906 | 'description': |
| 907 | 'Java: Static import of type uses non-canonical name', |
| 908 | 'patterns': [r".*: warning: \[NonCanonicalStaticImport\] .+"]}, |
| 909 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 910 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 911 | 'description': |
| 912 | 'Java: @CompileTimeConstant parameters should be final', |
| 913 | 'patterns': [r".*: warning: \[NonFinalCompileTimeConstant\] .+"]}, |
| 914 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 915 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 916 | 'description': |
| 917 | 'Java: Calling getAnnotation on an annotation that is not retained at runtime.', |
| 918 | 'patterns': [r".*: warning: \[NonRuntimeAnnotation\] .+"]}, |
| 919 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 920 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 921 | 'description': |
| 922 | 'Java: Numeric comparison using reference equality instead of value equality', |
| 923 | 'patterns': [r".*: warning: \[NumericEquality\] .+"]}, |
| 924 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 925 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 926 | 'description': |
| 927 | 'Java: Comparison using reference equality instead of value equality', |
| 928 | 'patterns': [r".*: warning: \[OptionalEquality\] .+"]}, |
| 929 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 930 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 931 | 'description': |
| 932 | 'Java: Varargs doesn\'t agree for overridden method', |
| 933 | 'patterns': [r".*: warning: \[Overrides\] .+"]}, |
| 934 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 935 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 936 | 'description': |
| 937 | 'Java: Literal passed as first argument to Preconditions.checkNotNull() can never be null', |
| 938 | 'patterns': [r".*: warning: \[PreconditionsCheckNotNull\] .+"]}, |
| 939 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 940 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 941 | 'description': |
| 942 | 'Java: First argument to `Preconditions.checkNotNull()` is a primitive rather than an object reference', |
| 943 | 'patterns': [r".*: warning: \[PreconditionsCheckNotNullPrimitive\] .+"]}, |
| 944 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 945 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 946 | 'description': |
| 947 | 'Java: Protobuf fields cannot be null', |
| 948 | 'patterns': [r".*: warning: \[ProtoFieldNullComparison\] .+"]}, |
| 949 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 950 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 951 | 'description': |
| 952 | 'Java: Comparing protobuf fields of type String using reference equality', |
| 953 | 'patterns': [r".*: warning: \[ProtoStringFieldReferenceEquality\] .+"]}, |
| 954 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 955 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 956 | 'description': |
| 957 | 'Java: Check for non-whitelisted callers to RestrictedApiChecker.', |
| 958 | 'patterns': [r".*: warning: \[RestrictedApiChecker\] .+"]}, |
| 959 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 960 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 961 | 'description': |
| 962 | 'Java: Return value of this method must be used', |
| 963 | 'patterns': [r".*: warning: \[ReturnValueIgnored\] .+"]}, |
| 964 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 965 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 966 | 'description': |
| 967 | 'Java: Variable assigned to itself', |
| 968 | 'patterns': [r".*: warning: \[SelfAssignment\] .+"]}, |
| 969 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 970 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 971 | 'description': |
| 972 | 'Java: An object is compared to itself', |
| 973 | 'patterns': [r".*: warning: \[SelfComparision\] .+"]}, |
| 974 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 975 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 976 | 'description': |
| 977 | 'Java: Variable compared to itself', |
| 978 | 'patterns': [r".*: warning: \[SelfEquality\] .+"]}, |
| 979 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 980 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 981 | 'description': |
| 982 | 'Java: An object is tested for equality to itself', |
| 983 | 'patterns': [r".*: warning: \[SelfEquals\] .+"]}, |
| 984 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 985 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 986 | 'description': |
| 987 | 'Java: Comparison of a size >= 0 is always true, did you intend to check for non-emptiness?', |
| 988 | 'patterns': [r".*: warning: \[SizeGreaterThanOrEqualsZero\] .+"]}, |
| 989 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 990 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 991 | 'description': |
| 992 | 'Java: Calling toString on a Stream does not provide useful information', |
| 993 | 'patterns': [r".*: warning: \[StreamToString\] .+"]}, |
| 994 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 995 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 996 | 'description': |
| 997 | 'Java: StringBuilder does not have a char constructor; this invokes the int constructor.', |
| 998 | 'patterns': [r".*: warning: \[StringBuilderInitWithChar\] .+"]}, |
| 999 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1000 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1001 | 'description': |
| 1002 | 'Java: Suppressing "deprecated" is probably a typo for "deprecation"', |
| 1003 | 'patterns': [r".*: warning: \[SuppressWarningsDeprecated\] .+"]}, |
| 1004 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1005 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1006 | 'description': |
| 1007 | 'Java: throwIfUnchecked(knownCheckedException) is a no-op.', |
| 1008 | 'patterns': [r".*: warning: \[ThrowIfUncheckedKnownChecked\] .+"]}, |
| 1009 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1010 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1011 | 'description': |
| 1012 | 'Java: Catching Throwable/Error masks failures from fail() or assert*() in the try block', |
| 1013 | 'patterns': [r".*: warning: \[TryFailThrowable\] .+"]}, |
| 1014 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1015 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1016 | 'description': |
| 1017 | 'Java: Type parameter used as type qualifier', |
| 1018 | 'patterns': [r".*: warning: \[TypeParameterQualifier\] .+"]}, |
| 1019 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1020 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1021 | 'description': |
| 1022 | 'Java: Non-generic methods should not be invoked with type arguments', |
| 1023 | 'patterns': [r".*: warning: \[UnnecessaryTypeArgument\] .+"]}, |
| 1024 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1025 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1026 | 'description': |
| 1027 | 'Java: Instance created but never used', |
| 1028 | 'patterns': [r".*: warning: \[UnusedAnonymousClass\] .+"]}, |
| 1029 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1030 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1031 | 'description': |
| 1032 | 'Java: Use of wildcard imports is forbidden', |
| 1033 | 'patterns': [r".*: warning: \[WildcardImport\] .+"]}, |
| 1034 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1035 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1036 | 'description': |
| 1037 | 'Java: Method parameter has wrong package', |
| 1038 | 'patterns': [r".*: warning: \[ParameterPackage\] .+"]}, |
| 1039 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1040 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1041 | 'description': |
| 1042 | 'Java: Certain resources in `android.R.string` have names that do not match their content', |
| 1043 | 'patterns': [r".*: warning: \[MislabeledAndroidString\] .+"]}, |
| 1044 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1045 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1046 | 'description': |
| 1047 | 'Java: Return value of android.graphics.Rect.intersect() must be checked', |
| 1048 | 'patterns': [r".*: warning: \[RectIntersectReturnValueIgnored\] .+"]}, |
| 1049 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1050 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1051 | 'description': |
| 1052 | 'Java: Invalid printf-style format string', |
| 1053 | 'patterns': [r".*: warning: \[FormatString\] .+"]}, |
| 1054 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1055 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1056 | 'description': |
| 1057 | 'Java: @AssistedInject and @Inject cannot be used on the same constructor.', |
| 1058 | 'patterns': [r".*: warning: \[AssistedInjectAndInjectOnSameConstructor\] .+"]}, |
| 1059 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1060 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1061 | 'description': |
| 1062 | 'Java: Injected constructors cannot be optional nor have binding annotations', |
| 1063 | 'patterns': [r".*: warning: \[InjectedConstructorAnnotations\] .+"]}, |
| 1064 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1065 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1066 | 'description': |
| 1067 | 'Java: The target of a scoping annotation must be set to METHOD and/or TYPE.', |
| 1068 | 'patterns': [r".*: warning: \[InjectInvalidTargetingOnScopingAnnotation\] .+"]}, |
| 1069 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1070 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1071 | 'description': |
| 1072 | 'Java: Abstract methods are not injectable with javax.inject.Inject.', |
| 1073 | 'patterns': [r".*: warning: \[JavaxInjectOnAbstractMethod\] .+"]}, |
| 1074 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1075 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1076 | 'description': |
| 1077 | 'Java: @javax.inject.Inject cannot be put on a final field.', |
| 1078 | 'patterns': [r".*: warning: \[JavaxInjectOnFinalField\] .+"]}, |
| 1079 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1080 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1081 | 'description': |
| 1082 | 'Java: A class may not have more than one injectable constructor.', |
| 1083 | 'patterns': [r".*: warning: \[MoreThanOneInjectableConstructor\] .+"]}, |
| 1084 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1085 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1086 | 'description': |
| 1087 | 'Java: Using more than one qualifier annotation on the same element is not allowed.', |
| 1088 | 'patterns': [r".*: warning: \[InjectMoreThanOneQualifier\] .+"]}, |
| 1089 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1090 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1091 | 'description': |
| 1092 | 'Java: A class can be annotated with at most one scope annotation', |
| 1093 | 'patterns': [r".*: warning: \[InjectMoreThanOneScopeAnnotationOnClass\] .+"]}, |
| 1094 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1095 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1096 | 'description': |
| 1097 | 'Java: Annotations cannot be both Qualifiers/BindingAnnotations and Scopes', |
| 1098 | 'patterns': [r".*: warning: \[OverlappingQualifierAndScopeAnnotation\] .+"]}, |
| 1099 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1100 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1101 | 'description': |
| 1102 | 'Java: Scope annotation on an interface or abstact class is not allowed', |
| 1103 | 'patterns': [r".*: warning: \[InjectScopeAnnotationOnInterfaceOrAbstractClass\] .+"]}, |
| 1104 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1105 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1106 | 'description': |
| 1107 | 'Java: Scoping and qualifier annotations must have runtime retention.', |
| 1108 | 'patterns': [r".*: warning: \[InjectScopeOrQualifierAnnotationRetention\] .+"]}, |
| 1109 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1110 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1111 | 'description': |
| 1112 | 'Java: Dagger @Provides methods may not return null unless annotated with @Nullable', |
| 1113 | 'patterns': [r".*: warning: \[DaggerProvidesNull\] .+"]}, |
| 1114 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1115 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1116 | 'description': |
| 1117 | 'Java: Scope annotation on implementation class of AssistedInject factory is not allowed', |
| 1118 | 'patterns': [r".*: warning: \[GuiceAssistedInjectScoping\] .+"]}, |
| 1119 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1120 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1121 | 'description': |
| 1122 | 'Java: A constructor cannot have two @Assisted parameters of the same type unless they are disambiguated with named @Assisted annotations. ', |
| 1123 | 'patterns': [r".*: warning: \[GuiceAssistedParameters\] .+"]}, |
| 1124 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1125 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1126 | 'description': |
| 1127 | 'Java: This method is not annotated with @Inject, but it overrides a method that is annotated with @javax.inject.Inject.', |
| 1128 | 'patterns': [r".*: warning: \[OverridesJavaxInjectableMethod\] .+"]}, |
| 1129 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1130 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1131 | 'description': |
| 1132 | 'Java: Checks for unguarded accesses to fields and methods with @GuardedBy annotations', |
| 1133 | 'patterns': [r".*: warning: \[GuardedByChecker\] .+"]}, |
| 1134 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1135 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1136 | 'description': |
| 1137 | 'Java: Invalid @GuardedBy expression', |
| 1138 | 'patterns': [r".*: warning: \[GuardedByValidator\] .+"]}, |
| 1139 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1140 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1141 | 'description': |
| 1142 | 'Java: Type declaration annotated with @Immutable is not immutable', |
| 1143 | 'patterns': [r".*: warning: \[Immutable\] .+"]}, |
| 1144 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1145 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1146 | 'description': |
| 1147 | 'Java: This method does not acquire the locks specified by its @LockMethod annotation', |
| 1148 | 'patterns': [r".*: warning: \[LockMethodChecker\] .+"]}, |
| 1149 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1150 | 'severity': Severity.HIGH, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1151 | 'description': |
| 1152 | 'Java: This method does not acquire the locks specified by its @UnlockMethod annotation', |
| 1153 | 'patterns': [r".*: warning: \[UnlockMethod\] .+"]}, |
Ian Rogers | 32bb9bd | 2016-05-09 23:19:42 -0700 | [diff] [blame] | 1154 | |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1155 | {'category': 'java', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1156 | 'severity': Severity.UNKNOWN, |
Ian Rogers | 6e52003 | 2016-05-13 08:59:00 -0700 | [diff] [blame] | 1157 | 'description': 'Java: Unclassified/unrecognized warnings', |
| 1158 | 'patterns': [r".*: warning: \[.+\] .+"]}, |
Ian Rogers | 32bb9bd | 2016-05-09 23:19:42 -0700 | [diff] [blame] | 1159 | |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1160 | {'category': 'aapt', 'severity': Severity.MEDIUM, |
| 1161 | 'description': 'aapt: No default translation', |
| 1162 | 'patterns': [r".*: warning: string '.+' has no default translation in .*"]}, |
| 1163 | {'category': 'aapt', 'severity': Severity.MEDIUM, |
| 1164 | 'description': 'aapt: Missing default or required localization', |
| 1165 | 'patterns': [r".*: warning: \*\*\*\* string '.+' has no default or required localization for '.+' in .+"]}, |
| 1166 | {'category': 'aapt', 'severity': Severity.MEDIUM, |
| 1167 | 'description': 'aapt: String marked untranslatable, but translation exists', |
| 1168 | 'patterns': [r".*: warning: string '.+' in .* marked untranslatable but exists in locale '??_??'"]}, |
| 1169 | {'category': 'aapt', 'severity': Severity.MEDIUM, |
| 1170 | 'description': 'aapt: empty span in string', |
| 1171 | 'patterns': [r".*: warning: empty '.+' span found in text '.+"]}, |
| 1172 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1173 | 'description': 'Taking address of temporary', |
| 1174 | 'patterns': [r".*: warning: taking address of temporary"]}, |
| 1175 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1176 | 'description': 'Possible broken line continuation', |
| 1177 | 'patterns': [r".*: warning: backslash and newline separated by space"]}, |
| 1178 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wundefined-var-template', |
| 1179 | 'description': 'Undefined variable template', |
| 1180 | 'patterns': [r".*: warning: instantiation of variable .* no definition is available"]}, |
| 1181 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wundefined-inline', |
| 1182 | 'description': 'Inline function is not defined', |
| 1183 | 'patterns': [r".*: warning: inline function '.*' is not defined"]}, |
| 1184 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Warray-bounds', |
| 1185 | 'description': 'Array subscript out of bounds', |
| 1186 | 'patterns': [r".*: warning: array subscript is above array bounds", |
| 1187 | r".*: warning: Array subscript is undefined", |
| 1188 | r".*: warning: array subscript is below array bounds"]}, |
| 1189 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1190 | 'description': 'Excess elements in initializer', |
| 1191 | 'patterns': [r".*: warning: excess elements in .+ initializer"]}, |
| 1192 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1193 | 'description': 'Decimal constant is unsigned only in ISO C90', |
| 1194 | 'patterns': [r".*: warning: this decimal constant is unsigned only in ISO C90"]}, |
| 1195 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmain', |
| 1196 | 'description': 'main is usually a function', |
| 1197 | 'patterns': [r".*: warning: 'main' is usually a function"]}, |
| 1198 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1199 | 'description': 'Typedef ignored', |
| 1200 | 'patterns': [r".*: warning: 'typedef' was ignored in this declaration"]}, |
| 1201 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Waddress', |
| 1202 | 'description': 'Address always evaluates to true', |
| 1203 | 'patterns': [r".*: warning: the address of '.+' will always evaluate as 'true'"]}, |
| 1204 | {'category': 'C/C++', 'severity': Severity.FIXMENOW, |
| 1205 | 'description': 'Freeing a non-heap object', |
| 1206 | 'patterns': [r".*: warning: attempt to free a non-heap object '.+'"]}, |
| 1207 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wchar-subscripts', |
| 1208 | 'description': 'Array subscript has type char', |
| 1209 | 'patterns': [r".*: warning: array subscript .+ type 'char'.+Wchar-subscripts"]}, |
| 1210 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1211 | 'description': 'Constant too large for type', |
| 1212 | 'patterns': [r".*: warning: integer constant is too large for '.+' type"]}, |
| 1213 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Woverflow', |
| 1214 | 'description': 'Constant too large for type, truncated', |
| 1215 | 'patterns': [r".*: warning: large integer implicitly truncated to unsigned type"]}, |
| 1216 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Winteger-overflow', |
| 1217 | 'description': 'Overflow in expression', |
| 1218 | 'patterns': [r".*: warning: overflow in expression; .*Winteger-overflow"]}, |
| 1219 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Woverflow', |
| 1220 | 'description': 'Overflow in implicit constant conversion', |
| 1221 | 'patterns': [r".*: warning: overflow in implicit constant conversion"]}, |
| 1222 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1223 | 'description': 'Declaration does not declare anything', |
| 1224 | 'patterns': [r".*: warning: declaration 'class .+' does not declare anything"]}, |
| 1225 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wreorder', |
| 1226 | 'description': 'Initialization order will be different', |
| 1227 | 'patterns': [r".*: warning: '.+' will be initialized after", |
| 1228 | r".*: warning: field .+ will be initialized after .+Wreorder"]}, |
| 1229 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 1230 | 'description': 'skip, ....', |
| 1231 | 'patterns': [r".*: warning: '.+'"]}, |
| 1232 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 1233 | 'description': 'skip, base ...', |
| 1234 | 'patterns': [r".*: warning: base '.+'"]}, |
| 1235 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 1236 | 'description': 'skip, when initialized here', |
| 1237 | 'patterns': [r".*: warning: when initialized here"]}, |
| 1238 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmissing-parameter-type', |
| 1239 | 'description': 'Parameter type not specified', |
| 1240 | 'patterns': [r".*: warning: type of '.+' defaults to 'int'"]}, |
| 1241 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmissing-declarations', |
| 1242 | 'description': 'Missing declarations', |
| 1243 | 'patterns': [r".*: warning: declaration does not declare anything"]}, |
| 1244 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wmissing-noreturn', |
| 1245 | 'description': 'Missing noreturn', |
| 1246 | 'patterns': [r".*: warning: function '.*' could be declared with attribute 'noreturn'"]}, |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1247 | # pylint:disable=anomalous-backslash-in-string |
| 1248 | # TODO(chh): fix the backslash pylint warning. |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1249 | {'category': 'gcc', 'severity': Severity.MEDIUM, |
| 1250 | 'description': 'Invalid option for C file', |
| 1251 | 'patterns': [r".*: warning: command line option "".+"" is valid for C\+\+\/ObjC\+\+ but not for C"]}, |
| 1252 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1253 | 'description': 'User warning', |
| 1254 | 'patterns': [r".*: warning: #warning "".+"""]}, |
| 1255 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wvexing-parse', |
| 1256 | 'description': 'Vexing parsing problem', |
| 1257 | 'patterns': [r".*: warning: empty parentheses interpreted as a function declaration"]}, |
| 1258 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wextra', |
| 1259 | 'description': 'Dereferencing void*', |
| 1260 | 'patterns': [r".*: warning: dereferencing 'void \*' pointer"]}, |
| 1261 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1262 | 'description': 'Comparison of pointer and integer', |
| 1263 | 'patterns': [r".*: warning: ordered comparison of pointer with integer zero", |
| 1264 | r".*: warning: .*comparison between pointer and integer"]}, |
| 1265 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1266 | 'description': 'Use of error-prone unary operator', |
| 1267 | 'patterns': [r".*: warning: use of unary operator that may be intended as compound assignment"]}, |
| 1268 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wwrite-strings', |
| 1269 | 'description': 'Conversion of string constant to non-const char*', |
| 1270 | 'patterns': [r".*: warning: deprecated conversion from string constant to '.+'"]}, |
| 1271 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wstrict-prototypes', |
| 1272 | 'description': 'Function declaration isn''t a prototype', |
| 1273 | 'patterns': [r".*: warning: function declaration isn't a prototype"]}, |
| 1274 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wignored-qualifiers', |
| 1275 | 'description': 'Type qualifiers ignored on function return value', |
| 1276 | 'patterns': [r".*: warning: type qualifiers ignored on function return type", |
| 1277 | r".*: warning: .+ type qualifier .+ has no effect .+Wignored-qualifiers"]}, |
| 1278 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1279 | 'description': '<foo> declared inside parameter list, scope limited to this definition', |
| 1280 | 'patterns': [r".*: warning: '.+' declared inside parameter list"]}, |
| 1281 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 1282 | 'description': 'skip, its scope is only this ...', |
| 1283 | 'patterns': [r".*: warning: its scope is only this definition or declaration, which is probably not what you want"]}, |
| 1284 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wcomment', |
| 1285 | 'description': 'Line continuation inside comment', |
| 1286 | 'patterns': [r".*: warning: multi-line comment"]}, |
| 1287 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wcomment', |
| 1288 | 'description': 'Comment inside comment', |
| 1289 | 'patterns': [r".*: warning: "".+"" within comment"]}, |
Chih-Hung Hsieh | 0862c48 | 2016-09-06 16:26:46 -0700 | [diff] [blame] | 1290 | # Warning "value stored is never read" could be from clang-tidy or clang static analyzer. |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1291 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
| 1292 | 'description': 'clang-analyzer Value stored is never read', |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1293 | 'patterns': [r".*: warning: Value stored to .+ is never read.*clang-analyzer-deadcode.DeadStores"]}, |
| 1294 | {'category': 'C/C++', 'severity': Severity.LOW, |
| 1295 | 'description': 'Value stored is never read', |
| 1296 | 'patterns': [r".*: warning: Value stored to .+ is never read"]}, |
| 1297 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wdeprecated-declarations', |
| 1298 | 'description': 'Deprecated declarations', |
| 1299 | 'patterns': [r".*: warning: .+ is deprecated.+deprecated-declarations"]}, |
| 1300 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wdeprecated-register', |
| 1301 | 'description': 'Deprecated register', |
| 1302 | 'patterns': [r".*: warning: 'register' storage class specifier is deprecated"]}, |
| 1303 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wpointer-sign', |
| 1304 | 'description': 'Converts between pointers to integer types with different sign', |
| 1305 | 'patterns': [r".*: warning: .+ converts between pointers to integer types with different sign"]}, |
| 1306 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 1307 | 'description': 'Extra tokens after #endif', |
| 1308 | 'patterns': [r".*: warning: extra tokens at end of #endif directive"]}, |
| 1309 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wenum-compare', |
| 1310 | 'description': 'Comparison between different enums', |
| 1311 | 'patterns': [r".*: warning: comparison between '.+' and '.+'.+Wenum-compare"]}, |
| 1312 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wconversion', |
| 1313 | 'description': 'Conversion may change value', |
| 1314 | 'patterns': [r".*: warning: converting negative value '.+' to '.+'", |
| 1315 | r".*: warning: conversion to '.+' .+ may (alter|change)"]}, |
| 1316 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wconversion-null', |
| 1317 | 'description': 'Converting to non-pointer type from NULL', |
| 1318 | 'patterns': [r".*: warning: converting to non-pointer type '.+' from NULL"]}, |
| 1319 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wnull-conversion', |
| 1320 | 'description': 'Converting NULL to non-pointer type', |
| 1321 | 'patterns': [r".*: warning: implicit conversion of NULL constant to '.+'"]}, |
| 1322 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wnon-literal-null-conversion', |
| 1323 | 'description': 'Zero used as null pointer', |
| 1324 | 'patterns': [r".*: warning: expression .* zero treated as a null pointer constant"]}, |
| 1325 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1326 | 'description': 'Implicit conversion changes value', |
| 1327 | 'patterns': [r".*: warning: implicit conversion .* changes value from .* to .*-conversion"]}, |
| 1328 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1329 | 'description': 'Passing NULL as non-pointer argument', |
| 1330 | 'patterns': [r".*: warning: passing NULL to non-pointer argument [0-9]+ of '.+'"]}, |
| 1331 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wctor-dtor-privacy', |
| 1332 | 'description': 'Class seems unusable because of private ctor/dtor', |
| 1333 | 'patterns': [r".*: warning: all member functions in class '.+' are private"]}, |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1334 | # skip this next one, because it only points out some RefBase-based classes where having a private destructor is perfectly fine |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1335 | {'category': 'C/C++', 'severity': Severity.SKIP, 'option': '-Wctor-dtor-privacy', |
| 1336 | 'description': 'Class seems unusable because of private ctor/dtor', |
| 1337 | 'patterns': [r".*: warning: 'class .+' only defines a private destructor and has no friends"]}, |
| 1338 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wctor-dtor-privacy', |
| 1339 | 'description': 'Class seems unusable because of private ctor/dtor', |
| 1340 | 'patterns': [r".*: warning: 'class .+' only defines private constructors and has no friends"]}, |
| 1341 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wgnu-static-float-init', |
| 1342 | 'description': 'In-class initializer for static const float/double', |
| 1343 | 'patterns': [r".*: warning: in-class initializer for static data member of .+const (float|double)"]}, |
| 1344 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wpointer-arith', |
| 1345 | 'description': 'void* used in arithmetic', |
| 1346 | 'patterns': [r".*: warning: pointer of type 'void \*' used in (arithmetic|subtraction)", |
| 1347 | r".*: warning: arithmetic on .+ to void is a GNU extension.*Wpointer-arith", |
| 1348 | r".*: warning: wrong type argument to increment"]}, |
| 1349 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wsign-promo', |
| 1350 | 'description': 'Overload resolution chose to promote from unsigned or enum to signed type', |
| 1351 | 'patterns': [r".*: warning: passing '.+' chooses '.+' over '.+'.*Wsign-promo"]}, |
| 1352 | {'category': 'cont.', 'severity': Severity.SKIP, |
| 1353 | 'description': 'skip, in call to ...', |
| 1354 | 'patterns': [r".*: warning: in call to '.+'"]}, |
| 1355 | {'category': 'C/C++', 'severity': Severity.HIGH, 'option': '-Wextra', |
| 1356 | 'description': 'Base should be explicitly initialized in copy constructor', |
| 1357 | 'patterns': [r".*: warning: base class '.+' should be explicitly initialized in the copy constructor"]}, |
| 1358 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1359 | 'description': 'VLA has zero or negative size', |
| 1360 | 'patterns': [r".*: warning: Declared variable-length array \(VLA\) has .+ size"]}, |
| 1361 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1362 | 'description': 'Return value from void function', |
| 1363 | 'patterns': [r".*: warning: 'return' with a value, in function returning void"]}, |
| 1364 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'multichar', |
| 1365 | 'description': 'Multi-character character constant', |
| 1366 | 'patterns': [r".*: warning: multi-character character constant"]}, |
| 1367 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'writable-strings', |
| 1368 | 'description': 'Conversion from string literal to char*', |
| 1369 | 'patterns': [r".*: warning: .+ does not allow conversion from string literal to 'char \*'"]}, |
| 1370 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wextra-semi', |
| 1371 | 'description': 'Extra \';\'', |
| 1372 | 'patterns': [r".*: warning: extra ';' .+extra-semi"]}, |
| 1373 | {'category': 'C/C++', 'severity': Severity.LOW, |
| 1374 | 'description': 'Useless specifier', |
| 1375 | 'patterns': [r".*: warning: useless storage class specifier in empty declaration"]}, |
| 1376 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wduplicate-decl-specifier', |
| 1377 | 'description': 'Duplicate declaration specifier', |
| 1378 | 'patterns': [r".*: warning: duplicate '.+' declaration specifier"]}, |
| 1379 | {'category': 'logtags', 'severity': Severity.LOW, |
| 1380 | 'description': 'Duplicate logtag', |
| 1381 | 'patterns': [r".*: warning: tag \".+\" \(.+\) duplicated in .+"]}, |
| 1382 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'typedef-redefinition', |
| 1383 | 'description': 'Typedef redefinition', |
| 1384 | 'patterns': [r".*: warning: redefinition of typedef '.+' is a C11 feature"]}, |
| 1385 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'gnu-designator', |
| 1386 | 'description': 'GNU old-style field designator', |
| 1387 | 'patterns': [r".*: warning: use of GNU old-style field designator extension"]}, |
| 1388 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'missing-field-initializers', |
| 1389 | 'description': 'Missing field initializers', |
| 1390 | 'patterns': [r".*: warning: missing field '.+' initializer"]}, |
| 1391 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'missing-braces', |
| 1392 | 'description': 'Missing braces', |
| 1393 | 'patterns': [r".*: warning: suggest braces around initialization of", |
| 1394 | r".*: warning: too many braces around scalar initializer .+Wmany-braces-around-scalar-init", |
| 1395 | r".*: warning: braces around scalar initializer"]}, |
| 1396 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'sign-compare', |
| 1397 | 'description': 'Comparison of integers of different signs', |
| 1398 | 'patterns': [r".*: warning: comparison of integers of different signs.+sign-compare"]}, |
| 1399 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'dangling-else', |
| 1400 | 'description': 'Add braces to avoid dangling else', |
| 1401 | 'patterns': [r".*: warning: add explicit braces to avoid dangling else"]}, |
| 1402 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'initializer-overrides', |
| 1403 | 'description': 'Initializer overrides prior initialization', |
| 1404 | 'patterns': [r".*: warning: initializer overrides prior initialization of this subobject"]}, |
| 1405 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'self-assign', |
| 1406 | 'description': 'Assigning value to self', |
| 1407 | 'patterns': [r".*: warning: explicitly assigning value of .+ to itself"]}, |
| 1408 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'gnu-variable-sized-type-not-at-end', |
| 1409 | 'description': 'GNU extension, variable sized type not at end', |
| 1410 | 'patterns': [r".*: warning: field '.+' with variable sized type '.+' not at the end of a struct or class"]}, |
| 1411 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'tautological-constant-out-of-range-compare', |
| 1412 | 'description': 'Comparison of constant is always false/true', |
| 1413 | 'patterns': [r".*: comparison of .+ is always .+Wtautological-constant-out-of-range-compare"]}, |
| 1414 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'overloaded-virtual', |
| 1415 | 'description': 'Hides overloaded virtual function', |
| 1416 | 'patterns': [r".*: '.+' hides overloaded virtual function"]}, |
| 1417 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'incompatible-pointer-types', |
| 1418 | 'description': 'Incompatible pointer types', |
| 1419 | 'patterns': [r".*: warning: incompatible pointer types .+Wincompatible-pointer-types"]}, |
| 1420 | {'category': 'logtags', 'severity': Severity.LOW, 'option': 'asm-operand-widths', |
| 1421 | 'description': 'ASM value size does not match register size', |
| 1422 | 'patterns': [r".*: warning: value size does not match register size specified by the constraint and modifier"]}, |
| 1423 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': 'tautological-compare', |
| 1424 | 'description': 'Comparison of self is always false', |
| 1425 | 'patterns': [r".*: self-comparison always evaluates to false"]}, |
| 1426 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': 'constant-logical-operand', |
| 1427 | 'description': 'Logical op with constant operand', |
| 1428 | 'patterns': [r".*: use of logical '.+' with constant operand"]}, |
| 1429 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': 'literal-suffix', |
| 1430 | 'description': 'Needs a space between literal and string macro', |
| 1431 | 'patterns': [r".*: warning: invalid suffix on literal.+ requires a space .+Wliteral-suffix"]}, |
| 1432 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '#warnings', |
| 1433 | 'description': 'Warnings from #warning', |
| 1434 | 'patterns': [r".*: warning: .+-W#warnings"]}, |
| 1435 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': 'absolute-value', |
| 1436 | 'description': 'Using float/int absolute value function with int/float argument', |
| 1437 | 'patterns': [r".*: warning: using .+ absolute value function .+ when argument is .+ type .+Wabsolute-value", |
| 1438 | r".*: warning: absolute value function '.+' given .+ which may cause truncation .+Wabsolute-value"]}, |
| 1439 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Wc++11-extensions', |
| 1440 | 'description': 'Using C++11 extensions', |
| 1441 | 'patterns': [r".*: warning: 'auto' type specifier is a C\+\+11 extension"]}, |
| 1442 | {'category': 'C/C++', 'severity': Severity.LOW, |
| 1443 | 'description': 'Refers to implicitly defined namespace', |
| 1444 | 'patterns': [r".*: warning: using directive refers to implicitly-defined namespace .+"]}, |
| 1445 | {'category': 'C/C++', 'severity': Severity.LOW, 'option': '-Winvalid-pp-token', |
| 1446 | 'description': 'Invalid pp token', |
| 1447 | 'patterns': [r".*: warning: missing .+Winvalid-pp-token"]}, |
Chih-Hung Hsieh | f8aaf60 | 2016-03-16 12:18:16 -0700 | [diff] [blame] | 1448 | |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1449 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1450 | 'description': 'Operator new returns NULL', |
| 1451 | 'patterns': [r".*: warning: 'operator new' must not return NULL unless it is declared 'throw\(\)' .+"]}, |
| 1452 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wnull-arithmetic', |
| 1453 | 'description': 'NULL used in arithmetic', |
| 1454 | 'patterns': [r".*: warning: NULL used in arithmetic", |
| 1455 | r".*: warning: comparison between NULL and non-pointer"]}, |
| 1456 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'header-guard', |
| 1457 | 'description': 'Misspelled header guard', |
| 1458 | 'patterns': [r".*: warning: '.+' is used as a header guard .+ followed by .+ different macro"]}, |
| 1459 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'empty-body', |
| 1460 | 'description': 'Empty loop body', |
| 1461 | 'patterns': [r".*: warning: .+ loop has empty body"]}, |
| 1462 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'enum-conversion', |
| 1463 | 'description': 'Implicit conversion from enumeration type', |
| 1464 | 'patterns': [r".*: warning: implicit conversion from enumeration type '.+'"]}, |
| 1465 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': 'switch', |
| 1466 | 'description': 'case value not in enumerated type', |
| 1467 | 'patterns': [r".*: warning: case value not in enumerated type '.+'"]}, |
| 1468 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1469 | 'description': 'Undefined result', |
| 1470 | 'patterns': [r".*: warning: The result of .+ is undefined", |
| 1471 | r".*: warning: passing an object that .+ has undefined behavior \[-Wvarargs\]", |
| 1472 | r".*: warning: 'this' pointer cannot be null in well-defined C\+\+ code;", |
| 1473 | r".*: warning: shifting a negative signed value is undefined"]}, |
| 1474 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1475 | 'description': 'Division by zero', |
| 1476 | 'patterns': [r".*: warning: Division by zero"]}, |
| 1477 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1478 | 'description': 'Use of deprecated method', |
| 1479 | 'patterns': [r".*: warning: '.+' is deprecated .+"]}, |
| 1480 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1481 | 'description': 'Use of garbage or uninitialized value', |
| 1482 | 'patterns': [r".*: warning: .+ is a garbage value", |
| 1483 | r".*: warning: Function call argument is an uninitialized value", |
| 1484 | r".*: warning: Undefined or garbage value returned to caller", |
| 1485 | r".*: warning: Called .+ pointer is.+uninitialized", |
| 1486 | r".*: warning: Called .+ pointer is.+uninitalized", # match a typo in compiler message |
| 1487 | r".*: warning: Use of zero-allocated memory", |
| 1488 | r".*: warning: Dereference of undefined pointer value", |
| 1489 | r".*: warning: Passed-by-value .+ contains uninitialized data", |
| 1490 | r".*: warning: Branch condition evaluates to a garbage value", |
| 1491 | r".*: warning: The .+ of .+ is an uninitialized value.", |
| 1492 | r".*: warning: .+ is used uninitialized whenever .+sometimes-uninitialized", |
| 1493 | r".*: warning: Assigned value is garbage or undefined"]}, |
| 1494 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1495 | 'description': 'Result of malloc type incompatible with sizeof operand type', |
| 1496 | 'patterns': [r".*: warning: Result of '.+' is converted to .+ incompatible with sizeof operand type"]}, |
| 1497 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wsizeof-array-argument', |
| 1498 | 'description': 'Sizeof on array argument', |
| 1499 | 'patterns': [r".*: warning: sizeof on array function parameter will return"]}, |
| 1500 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wsizeof-pointer-memacces', |
| 1501 | 'description': 'Bad argument size of memory access functions', |
| 1502 | 'patterns': [r".*: warning: .+\[-Wsizeof-pointer-memaccess\]"]}, |
| 1503 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1504 | 'description': 'Return value not checked', |
| 1505 | 'patterns': [r".*: warning: The return value from .+ is not checked"]}, |
| 1506 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1507 | 'description': 'Possible heap pollution', |
| 1508 | 'patterns': [r".*: warning: .*Possible heap pollution from .+ type .+"]}, |
| 1509 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1510 | 'description': 'Allocation size of 0 byte', |
| 1511 | 'patterns': [r".*: warning: Call to .+ has an allocation size of 0 byte"]}, |
| 1512 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1513 | 'description': 'Result of malloc type incompatible with sizeof operand type', |
| 1514 | 'patterns': [r".*: warning: Result of '.+' is converted to .+ incompatible with sizeof operand type"]}, |
| 1515 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wfor-loop-analysis', |
| 1516 | 'description': 'Variable used in loop condition not modified in loop body', |
| 1517 | 'patterns': [r".*: warning: variable '.+' used in loop condition.*Wfor-loop-analysis"]}, |
| 1518 | {'category': 'C/C++', 'severity': Severity.MEDIUM, |
| 1519 | 'description': 'Closing a previously closed file', |
| 1520 | 'patterns': [r".*: warning: Closing a previously closed file"]}, |
| 1521 | {'category': 'C/C++', 'severity': Severity.MEDIUM, 'option': '-Wunnamed-type-template-args', |
| 1522 | 'description': 'Unnamed template type argument', |
| 1523 | 'patterns': [r".*: warning: template argument.+Wunnamed-type-template-args"]}, |
Chih-Hung Hsieh | f8aaf60 | 2016-03-16 12:18:16 -0700 | [diff] [blame] | 1524 | |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1525 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 1526 | 'description': 'Discarded qualifier from pointer target type', |
| 1527 | 'patterns': [r".*: warning: .+ discards '.+' qualifier from pointer target type"]}, |
| 1528 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 1529 | 'description': 'Use snprintf instead of sprintf', |
| 1530 | 'patterns': [r".*: warning: .*sprintf is often misused; please use snprintf"]}, |
| 1531 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 1532 | 'description': 'Unsupported optimizaton flag', |
| 1533 | 'patterns': [r".*: warning: optimization flag '.+' is not supported"]}, |
| 1534 | {'category': 'C/C++', 'severity': Severity.HARMLESS, |
| 1535 | 'description': 'Extra or missing parentheses', |
| 1536 | 'patterns': [r".*: warning: equality comparison with extraneous parentheses", |
| 1537 | r".*: warning: .+ within .+Wlogical-op-parentheses"]}, |
| 1538 | {'category': 'C/C++', 'severity': Severity.HARMLESS, 'option': 'mismatched-tags', |
| 1539 | 'description': 'Mismatched class vs struct tags', |
| 1540 | 'patterns': [r".*: warning: '.+' defined as a .+ here but previously declared as a .+mismatched-tags", |
| 1541 | r".*: warning: .+ was previously declared as a .+mismatched-tags"]}, |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1542 | |
| 1543 | # these next ones are to deal with formatting problems resulting from the log being mixed up by 'make -j' |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1544 | {'category': 'C/C++', 'severity': Severity.SKIP, |
| 1545 | 'description': 'skip, ,', |
| 1546 | 'patterns': [r".*: warning: ,$"]}, |
| 1547 | {'category': 'C/C++', 'severity': Severity.SKIP, |
| 1548 | 'description': 'skip,', |
| 1549 | 'patterns': [r".*: warning: $"]}, |
| 1550 | {'category': 'C/C++', 'severity': Severity.SKIP, |
| 1551 | 'description': 'skip, In file included from ...', |
| 1552 | 'patterns': [r".*: warning: In file included from .+,"]}, |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1553 | |
Chih-Hung Hsieh | 90d4619 | 2016-03-29 15:33:11 -0700 | [diff] [blame] | 1554 | # warnings from clang-tidy |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1555 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1556 | 'description': 'clang-tidy readability', |
| 1557 | 'patterns': [r".*: .+\[readability-.+\]$"]}, |
| 1558 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1559 | 'description': 'clang-tidy c++ core guidelines', |
| 1560 | 'patterns': [r".*: .+\[cppcoreguidelines-.+\]$"]}, |
| 1561 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1562 | 'description': 'clang-tidy google-default-arguments', |
| 1563 | 'patterns': [r".*: .+\[google-default-arguments\]$"]}, |
| 1564 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1565 | 'description': 'clang-tidy google-runtime-int', |
| 1566 | 'patterns': [r".*: .+\[google-runtime-int\]$"]}, |
| 1567 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1568 | 'description': 'clang-tidy google-runtime-operator', |
| 1569 | 'patterns': [r".*: .+\[google-runtime-operator\]$"]}, |
| 1570 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1571 | 'description': 'clang-tidy google-runtime-references', |
| 1572 | 'patterns': [r".*: .+\[google-runtime-references\]$"]}, |
| 1573 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1574 | 'description': 'clang-tidy google-build', |
| 1575 | 'patterns': [r".*: .+\[google-build-.+\]$"]}, |
| 1576 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1577 | 'description': 'clang-tidy google-explicit', |
| 1578 | 'patterns': [r".*: .+\[google-explicit-.+\]$"]}, |
| 1579 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1580 | 'description': 'clang-tidy google-readability', |
| 1581 | 'patterns': [r".*: .+\[google-readability-.+\]$"]}, |
| 1582 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1583 | 'description': 'clang-tidy google-global', |
| 1584 | 'patterns': [r".*: .+\[google-global-.+\]$"]}, |
| 1585 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1586 | 'description': 'clang-tidy google- other', |
| 1587 | 'patterns': [r".*: .+\[google-.+\]$"]}, |
| 1588 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1589 | 'description': 'clang-tidy modernize', |
| 1590 | 'patterns': [r".*: .+\[modernize-.+\]$"]}, |
| 1591 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1592 | 'description': 'clang-tidy misc', |
| 1593 | 'patterns': [r".*: .+\[misc-.+\]$"]}, |
| 1594 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1595 | 'description': 'clang-tidy performance-faster-string-find', |
| 1596 | 'patterns': [r".*: .+\[performance-faster-string-find\]$"]}, |
| 1597 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1598 | 'description': 'clang-tidy performance-for-range-copy', |
| 1599 | 'patterns': [r".*: .+\[performance-for-range-copy\]$"]}, |
| 1600 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1601 | 'description': 'clang-tidy performance-implicit-cast-in-loop', |
| 1602 | 'patterns': [r".*: .+\[performance-implicit-cast-in-loop\]$"]}, |
| 1603 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1604 | 'description': 'clang-tidy performance-unnecessary-copy-initialization', |
| 1605 | 'patterns': [r".*: .+\[performance-unnecessary-copy-initialization\]$"]}, |
| 1606 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1607 | 'description': 'clang-tidy performance-unnecessary-value-param', |
| 1608 | 'patterns': [r".*: .+\[performance-unnecessary-value-param\]$"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1609 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1610 | 'description': 'clang-analyzer Unreachable code', |
| 1611 | 'patterns': [r".*: warning: This statement is never executed.*UnreachableCode"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1612 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1613 | 'description': 'clang-analyzer Size of malloc may overflow', |
| 1614 | 'patterns': [r".*: warning: .* size of .* may overflow .*MallocOverflow"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1615 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1616 | 'description': 'clang-analyzer Stream pointer might be NULL', |
| 1617 | 'patterns': [r".*: warning: Stream pointer might be NULL .*unix.Stream"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1618 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1619 | 'description': 'clang-analyzer Opened file never closed', |
| 1620 | 'patterns': [r".*: warning: Opened File never closed.*unix.Stream"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1621 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1622 | 'description': 'clang-analyzer sozeof() on a pointer type', |
| 1623 | 'patterns': [r".*: warning: .*calls sizeof.* on a pointer type.*SizeofPtr"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1624 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1625 | 'description': 'clang-analyzer Pointer arithmetic on non-array variables', |
| 1626 | 'patterns': [r".*: warning: Pointer arithmetic on non-array variables .*PointerArithm"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1627 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1628 | 'description': 'clang-analyzer Subtraction of pointers of different memory chunks', |
| 1629 | 'patterns': [r".*: warning: Subtraction of two pointers .*PointerSub"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1630 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1631 | 'description': 'clang-analyzer Access out-of-bound array element', |
| 1632 | 'patterns': [r".*: warning: Access out-of-bound array element .*ArrayBound"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1633 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1634 | 'description': 'clang-analyzer Out of bound memory access', |
| 1635 | 'patterns': [r".*: warning: Out of bound memory access .*ArrayBoundV2"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1636 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1637 | 'description': 'clang-analyzer Possible lock order reversal', |
| 1638 | 'patterns': [r".*: warning: .* Possible lock order reversal.*PthreadLock"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1639 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1640 | 'description': 'clang-analyzer Argument is a pointer to uninitialized value', |
| 1641 | 'patterns': [r".*: warning: .* argument is a pointer to uninitialized value .*CallAndMessage"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1642 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1643 | 'description': 'clang-analyzer cast to struct', |
| 1644 | 'patterns': [r".*: warning: Casting a non-structure type to a structure type .*CastToStruct"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1645 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1646 | 'description': 'clang-analyzer call path problems', |
| 1647 | 'patterns': [r".*: warning: Call Path : .+"]}, |
Chih-Hung Hsieh | 1eabb0e | 2016-10-05 11:53:20 -0700 | [diff] [blame] | 1648 | {'category': 'C/C++', 'severity': Severity.ANALYZER, |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1649 | 'description': 'clang-analyzer other', |
| 1650 | 'patterns': [r".*: .+\[clang-analyzer-.+\]$", |
| 1651 | r".*: Call Path : .+$"]}, |
| 1652 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1653 | 'description': 'clang-tidy CERT', |
| 1654 | 'patterns': [r".*: .+\[cert-.+\]$"]}, |
| 1655 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1656 | 'description': 'clang-tidy llvm', |
| 1657 | 'patterns': [r".*: .+\[llvm-.+\]$"]}, |
| 1658 | {'category': 'C/C++', 'severity': Severity.TIDY, |
| 1659 | 'description': 'clang-diagnostic', |
| 1660 | 'patterns': [r".*: .+\[clang-diagnostic-.+\]$"]}, |
Chih-Hung Hsieh | 90d4619 | 2016-03-29 15:33:11 -0700 | [diff] [blame] | 1661 | |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1662 | # catch-all for warnings this script doesn't know about yet |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1663 | {'category': 'C/C++', 'severity': Severity.UNKNOWN, |
| 1664 | 'description': 'Unclassified/unrecognized warnings', |
| 1665 | 'patterns': [r".*: warning: .+"]}, |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1666 | ] |
| 1667 | |
Chih-Hung Hsieh | 99459fc | 2016-09-22 13:43:12 -0700 | [diff] [blame] | 1668 | |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1669 | def project_name_and_pattern(name, pattern): |
| 1670 | return [name, '(^|.*/)' + pattern + '/.*: warning:'] |
| 1671 | |
| 1672 | |
| 1673 | def simple_project_pattern(pattern): |
| 1674 | return project_name_and_pattern(pattern, pattern) |
| 1675 | |
| 1676 | |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1677 | # A list of [project_name, file_path_pattern]. |
| 1678 | # project_name should not contain comma, to be used in CSV output. |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1679 | project_list = [ |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1680 | simple_project_pattern('art'), |
| 1681 | simple_project_pattern('bionic'), |
| 1682 | simple_project_pattern('bootable'), |
| 1683 | simple_project_pattern('build'), |
| 1684 | simple_project_pattern('cts'), |
| 1685 | simple_project_pattern('dalvik'), |
| 1686 | simple_project_pattern('developers'), |
| 1687 | simple_project_pattern('development'), |
| 1688 | simple_project_pattern('device'), |
| 1689 | simple_project_pattern('doc'), |
Chih-Hung Hsieh | 4354a33 | 2016-07-22 14:09:31 -0700 | [diff] [blame] | 1690 | # match external/google* before external/ |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1691 | project_name_and_pattern('external/google', 'external/google.*'), |
| 1692 | project_name_and_pattern('external/non-google', 'external'), |
| 1693 | simple_project_pattern('frameworks/av/camera'), |
| 1694 | simple_project_pattern('frameworks/av/cmds'), |
| 1695 | simple_project_pattern('frameworks/av/drm'), |
| 1696 | simple_project_pattern('frameworks/av/include'), |
| 1697 | simple_project_pattern('frameworks/av/media'), |
| 1698 | simple_project_pattern('frameworks/av/radio'), |
| 1699 | simple_project_pattern('frameworks/av/services'), |
| 1700 | project_name_and_pattern('frameworks/av/Other', 'frameworks/av'), |
| 1701 | simple_project_pattern('frameworks/base'), |
| 1702 | simple_project_pattern('frameworks/compile'), |
| 1703 | simple_project_pattern('frameworks/minikin'), |
| 1704 | simple_project_pattern('frameworks/native'), |
| 1705 | simple_project_pattern('frameworks/opt'), |
| 1706 | simple_project_pattern('frameworks/rs'), |
| 1707 | simple_project_pattern('frameworks/webview'), |
| 1708 | simple_project_pattern('frameworks/wilhelm'), |
| 1709 | project_name_and_pattern('frameworks/Other', 'frameworks'), |
| 1710 | simple_project_pattern('hardware/akm'), |
| 1711 | simple_project_pattern('hardware/broadcom'), |
| 1712 | simple_project_pattern('hardware/google'), |
| 1713 | simple_project_pattern('hardware/intel'), |
| 1714 | simple_project_pattern('hardware/interfaces'), |
| 1715 | simple_project_pattern('hardware/libhardware'), |
| 1716 | simple_project_pattern('hardware/libhardware_legacy'), |
| 1717 | simple_project_pattern('hardware/qcom'), |
| 1718 | simple_project_pattern('hardware/ril'), |
| 1719 | project_name_and_pattern('hardware/Other', 'hardware'), |
| 1720 | simple_project_pattern('kernel'), |
| 1721 | simple_project_pattern('libcore'), |
| 1722 | simple_project_pattern('libnativehelper'), |
| 1723 | simple_project_pattern('ndk'), |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1724 | # match vendor/unbungled_google/packages before other packages |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1725 | simple_project_pattern('unbundled_google'), |
| 1726 | simple_project_pattern('packages'), |
| 1727 | simple_project_pattern('pdk'), |
| 1728 | simple_project_pattern('prebuilts'), |
| 1729 | simple_project_pattern('system/bt'), |
| 1730 | simple_project_pattern('system/connectivity'), |
| 1731 | simple_project_pattern('system/core'), |
| 1732 | simple_project_pattern('system/extras'), |
| 1733 | simple_project_pattern('system/gatekeeper'), |
| 1734 | simple_project_pattern('system/keymaster'), |
| 1735 | simple_project_pattern('system/libhwbinder'), |
| 1736 | simple_project_pattern('system/media'), |
| 1737 | simple_project_pattern('system/netd'), |
| 1738 | simple_project_pattern('system/security'), |
| 1739 | simple_project_pattern('system/sepolicy'), |
| 1740 | simple_project_pattern('system/tools'), |
| 1741 | simple_project_pattern('system/vold'), |
| 1742 | project_name_and_pattern('system/Other', 'system'), |
| 1743 | simple_project_pattern('toolchain'), |
| 1744 | simple_project_pattern('test'), |
| 1745 | simple_project_pattern('tools'), |
Chih-Hung Hsieh | 4354a33 | 2016-07-22 14:09:31 -0700 | [diff] [blame] | 1746 | # match vendor/google* before vendor/ |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1747 | project_name_and_pattern('vendor/google', 'vendor/google.*'), |
| 1748 | project_name_and_pattern('vendor/non-google', 'vendor'), |
Chih-Hung Hsieh | 4354a33 | 2016-07-22 14:09:31 -0700 | [diff] [blame] | 1749 | # keep out/obj and other patterns at the end. |
Chih-Hung Hsieh | 9f76623 | 2016-09-27 15:39:28 -0700 | [diff] [blame] | 1750 | ['out/obj', |
| 1751 | '.*/(gen|obj[^/]*)/(include|EXECUTABLES|SHARED_LIBRARIES|' |
| 1752 | 'STATIC_LIBRARIES|NATIVE_TESTS)/.*: warning:'], |
| 1753 | ['other', '.*'] # all other unrecognized patterns |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1754 | ] |
| 1755 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1756 | project_patterns = [] |
| 1757 | project_names = [] |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1758 | warning_messages = [] |
| 1759 | warning_records = [] |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1760 | |
Chih-Hung Hsieh | e41c99b | 2016-09-12 16:20:49 -0700 | [diff] [blame] | 1761 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1762 | def initialize_arrays(): |
| 1763 | """Complete global arrays before they are used.""" |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1764 | global project_names, project_patterns |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1765 | project_names = [p[0] for p in project_list] |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1766 | project_patterns = [re.compile(p[1]) for p in project_list] |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1767 | for w in warn_patterns: |
| 1768 | w['members'] = [] |
| 1769 | if 'option' not in w: |
| 1770 | w['option'] = '' |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1771 | # Each warning pattern has a 'projects' dictionary, that |
| 1772 | # maps a project name to number of warnings in that project. |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1773 | w['projects'] = {} |
| 1774 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1775 | |
| 1776 | initialize_arrays() |
| 1777 | |
| 1778 | |
| 1779 | platform_version = 'unknown' |
| 1780 | target_product = 'unknown' |
| 1781 | target_variant = 'unknown' |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1782 | |
| 1783 | |
| 1784 | ##### Data and functions to dump html file. ################################## |
| 1785 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1786 | html_head_scripts = """\ |
| 1787 | <script type="text/javascript"> |
| 1788 | function expand(id) { |
| 1789 | var e = document.getElementById(id); |
| 1790 | var f = document.getElementById(id + "_mark"); |
| 1791 | if (e.style.display == 'block') { |
| 1792 | e.style.display = 'none'; |
| 1793 | f.innerHTML = '⊕'; |
| 1794 | } |
| 1795 | else { |
| 1796 | e.style.display = 'block'; |
| 1797 | f.innerHTML = '⊖'; |
| 1798 | } |
| 1799 | }; |
| 1800 | function expandCollapse(show) { |
| 1801 | for (var id = 1; ; id++) { |
| 1802 | var e = document.getElementById(id + ""); |
Chih-Hung Hsieh | 465b610 | 2016-06-22 19:15:12 -0700 | [diff] [blame] | 1803 | var f = document.getElementById(id + "_mark"); |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1804 | if (!e || !f) break; |
| 1805 | e.style.display = (show ? 'block' : 'none'); |
| 1806 | f.innerHTML = (show ? '⊖' : '⊕'); |
| 1807 | } |
| 1808 | }; |
| 1809 | </script> |
| 1810 | <style type="text/css"> |
| 1811 | th,td{border-collapse:collapse; border:1px solid black;} |
| 1812 | .button{color:blue;font-size:110%;font-weight:bolder;} |
| 1813 | .bt{color:black;background-color:transparent;border:none;outline:none; |
| 1814 | font-size:140%;font-weight:bolder;} |
| 1815 | .c0{background-color:#e0e0e0;} |
| 1816 | .c1{background-color:#d0d0d0;} |
| 1817 | .t1{border-collapse:collapse; width:100%; border:1px solid black;} |
| 1818 | </style> |
| 1819 | <script src="https://www.gstatic.com/charts/loader.js"></script> |
| 1820 | """ |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1821 | |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1822 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1823 | def html_big(param): |
| 1824 | return '<font size="+2">' + param + '</font>' |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1825 | |
Chih-Hung Hsieh | 465b610 | 2016-06-22 19:15:12 -0700 | [diff] [blame] | 1826 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1827 | def dump_html_prologue(title): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1828 | print '<html>\n<head>' |
| 1829 | print '<title>' + title + '</title>' |
| 1830 | print html_head_scripts |
| 1831 | emit_stats_by_project() |
| 1832 | print '</head>\n<body>' |
| 1833 | print html_big(title) |
| 1834 | print '<p>' |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1835 | |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 1836 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1837 | def dump_html_epilogue(): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1838 | print '</body>\n</head>\n</html>' |
Chih-Hung Hsieh | 99459fc | 2016-09-22 13:43:12 -0700 | [diff] [blame] | 1839 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1840 | |
| 1841 | def sort_warnings(): |
| 1842 | for i in warn_patterns: |
| 1843 | i['members'] = sorted(set(i['members'])) |
| 1844 | |
| 1845 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1846 | def emit_stats_by_project(): |
| 1847 | """Dump a google chart table of warnings per project and severity.""" |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1848 | # warnings[p][s] is number of warnings in project p of severity s. |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1849 | warnings = {p: {s: 0 for s in Severity.range} for p in project_names} |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1850 | for i in warn_patterns: |
| 1851 | s = i['severity'] |
| 1852 | for p in i['projects']: |
| 1853 | warnings[p][s] += i['projects'][p] |
| 1854 | |
| 1855 | # total_by_project[p] is number of warnings in project p. |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1856 | total_by_project = {p: sum(warnings[p][s] for s in Severity.range) |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1857 | for p in project_names} |
| 1858 | |
| 1859 | # total_by_severity[s] is number of warnings of severity s. |
| 1860 | total_by_severity = {s: sum(warnings[p][s] for p in project_names) |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1861 | for s in Severity.range} |
Chih-Hung Hsieh | e41c99b | 2016-09-12 16:20:49 -0700 | [diff] [blame] | 1862 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1863 | # emit table header |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1864 | stats_header = ['Project'] |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1865 | for s in Severity.range: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1866 | if total_by_severity[s]: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1867 | stats_header.append("<span style='background-color:{}'>{}</span>". |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1868 | format(Severity.colors[s], |
| 1869 | Severity.column_headers[s])) |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1870 | stats_header.append('TOTAL') |
Chih-Hung Hsieh | e41c99b | 2016-09-12 16:20:49 -0700 | [diff] [blame] | 1871 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1872 | # emit a row of warning counts per project, skip no-warning projects |
| 1873 | total_all_projects = 0 |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1874 | stats_rows = [] |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1875 | for p in project_names: |
| 1876 | if total_by_project[p]: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1877 | one_row = [p] |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1878 | for s in Severity.range: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1879 | if total_by_severity[s]: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1880 | one_row.append(warnings[p][s]) |
| 1881 | one_row.append(total_by_project[p]) |
| 1882 | stats_rows.append(one_row) |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1883 | total_all_projects += total_by_project[p] |
Chih-Hung Hsieh | e41c99b | 2016-09-12 16:20:49 -0700 | [diff] [blame] | 1884 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1885 | # emit a row of warning counts per severity |
| 1886 | total_all_severities = 0 |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1887 | one_row = ['<b>TOTAL</b>'] |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1888 | for s in Severity.range: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1889 | if total_by_severity[s]: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1890 | one_row.append(total_by_severity[s]) |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1891 | total_all_severities += total_by_severity[s] |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1892 | one_row.append(total_all_projects) |
| 1893 | stats_rows.append(one_row) |
| 1894 | print '<script>' |
| 1895 | emit_const_string_array('StatsHeader', stats_header) |
| 1896 | emit_const_object_array('StatsRows', stats_rows) |
| 1897 | print draw_table_javascript |
| 1898 | print '</script>' |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1899 | |
| 1900 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1901 | def dump_stats(): |
| 1902 | """Dump some stats about total number of warnings and such.""" |
| 1903 | known = 0 |
| 1904 | skipped = 0 |
| 1905 | unknown = 0 |
| 1906 | sort_warnings() |
| 1907 | for i in warn_patterns: |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1908 | if i['severity'] == Severity.UNKNOWN: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1909 | unknown += len(i['members']) |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 1910 | elif i['severity'] == Severity.SKIP: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1911 | skipped += len(i['members']) |
Ian Rogers | f382973 | 2016-05-10 12:06:01 -0700 | [diff] [blame] | 1912 | else: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1913 | known += len(i['members']) |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1914 | print 'Number of classified warnings: <b>' + str(known) + '</b><br>' |
| 1915 | print 'Number of skipped warnings: <b>' + str(skipped) + '</b><br>' |
| 1916 | print 'Number of unclassified warnings: <b>' + str(unknown) + '</b><br>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1917 | total = unknown + known + skipped |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1918 | extra_msg = '' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1919 | if total < 1000: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1920 | extra_msg = ' (low count may indicate incremental build)' |
| 1921 | print 'Total number of warnings: <b>' + str(total) + '</b>' + extra_msg |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1922 | |
Chih-Hung Hsieh | 465b610 | 2016-06-22 19:15:12 -0700 | [diff] [blame] | 1923 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1924 | # New base table of warnings, [severity, warn_id, project, warning_message] |
| 1925 | # Need buttons to show warnings in different grouping options. |
| 1926 | # (1) Current, group by severity, id for each warning pattern |
| 1927 | # sort by severity, warn_id, warning_message |
| 1928 | # (2) Current --byproject, group by severity, |
| 1929 | # id for each warning pattern + project name |
| 1930 | # sort by severity, warn_id, project, warning_message |
| 1931 | # (3) New, group by project + severity, |
| 1932 | # id for each warning pattern |
| 1933 | # sort by project, severity, warn_id, warning_message |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1934 | def emit_buttons(): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1935 | print ('<button class="button" onclick="expandCollapse(1);">' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1936 | 'Expand all warnings</button>\n' |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1937 | '<button class="button" onclick="expandCollapse(0);">' |
| 1938 | 'Collapse all warnings</button>\n' |
| 1939 | '<button class="button" onclick="groupBySeverity();">' |
| 1940 | 'Group warnings by severity</button>\n' |
| 1941 | '<button class="button" onclick="groupByProject();">' |
| 1942 | 'Group warnings by project</button><br>') |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 1943 | |
| 1944 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1945 | def all_patterns(category): |
| 1946 | patterns = '' |
| 1947 | for i in category['patterns']: |
| 1948 | patterns += i |
| 1949 | patterns += ' / ' |
| 1950 | return patterns |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1951 | |
| 1952 | |
| 1953 | def dump_fixed(): |
| 1954 | """Show which warnings no longer occur.""" |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1955 | anchor = 'fixed_warnings' |
| 1956 | mark = anchor + '_mark' |
| 1957 | print ('\n<br><p style="background-color:lightblue"><b>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1958 | '<button id="' + mark + '" ' |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1959 | 'class="bt" onclick="expand(\'' + anchor + '\');">' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1960 | '⊕</button> Fixed warnings. ' |
| 1961 | 'No more occurrences. Please consider turning these into ' |
| 1962 | 'errors if possible, before they are reintroduced in to the build' |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1963 | ':</b></p>') |
| 1964 | print '<blockquote>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1965 | fixed_patterns = [] |
| 1966 | for i in warn_patterns: |
| 1967 | if not i['members']: |
| 1968 | fixed_patterns.append(i['description'] + ' (' + |
| 1969 | all_patterns(i) + ')') |
| 1970 | if i['option']: |
| 1971 | fixed_patterns.append(' ' + i['option']) |
| 1972 | fixed_patterns.sort() |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1973 | print '<div id="' + anchor + '" style="display:none;"><table>' |
| 1974 | cur_row_class = 0 |
| 1975 | for text in fixed_patterns: |
| 1976 | cur_row_class = 1 - cur_row_class |
| 1977 | # remove last '\n' |
| 1978 | t = text[:-1] if text[-1] == '\n' else text |
| 1979 | print '<tr><td class="c' + str(cur_row_class) + '">' + t + '</td></tr>' |
| 1980 | print '</table></div>' |
| 1981 | print '</blockquote>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1982 | |
| 1983 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1984 | def find_project_index(line): |
| 1985 | for p in range(len(project_patterns)): |
| 1986 | if project_patterns[p].match(line): |
| 1987 | return p |
| 1988 | return -1 |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1989 | |
| 1990 | |
| 1991 | def classify_warning(line): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1992 | for i in range(len(warn_patterns)): |
| 1993 | w = warn_patterns[i] |
| 1994 | for cpat in w['compiled_patterns']: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 1995 | if cpat.match(line): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 1996 | w['members'].append(line) |
| 1997 | p = find_project_index(line) |
| 1998 | index = len(warning_messages) |
| 1999 | warning_messages.append(line) |
| 2000 | warning_records.append([i, p, index]) |
| 2001 | pname = '???' if p < 0 else project_names[p] |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2002 | # Count warnings by project. |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2003 | if pname in w['projects']: |
| 2004 | w['projects'][pname] += 1 |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 2005 | else: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2006 | w['projects'][pname] = 1 |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2007 | return |
| 2008 | else: |
| 2009 | # If we end up here, there was a problem parsing the log |
| 2010 | # probably caused by 'make -j' mixing the output from |
| 2011 | # 2 or more concurrent compiles |
| 2012 | pass |
Marco Nelissen | 594375d | 2009-07-14 09:04:04 -0700 | [diff] [blame] | 2013 | |
| 2014 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2015 | def compile_patterns(): |
| 2016 | """Precompiling every pattern speeds up parsing by about 30x.""" |
| 2017 | for i in warn_patterns: |
| 2018 | i['compiled_patterns'] = [] |
| 2019 | for pat in i['patterns']: |
| 2020 | i['compiled_patterns'].append(re.compile(pat)) |
| 2021 | |
| 2022 | |
| 2023 | def parse_input_file(): |
| 2024 | """Parse input file, match warning lines.""" |
| 2025 | global platform_version |
| 2026 | global target_product |
| 2027 | global target_variant |
| 2028 | infile = open(args.buildlog, 'r') |
| 2029 | line_counter = 0 |
| 2030 | |
| 2031 | warning_pattern = re.compile('.* warning:.*') |
| 2032 | compile_patterns() |
| 2033 | |
| 2034 | # read the log file and classify all the warnings |
| 2035 | warning_lines = set() |
| 2036 | for line in infile: |
| 2037 | # replace fancy quotes with plain ol' quotes |
| 2038 | line = line.replace('‘', "'") |
| 2039 | line = line.replace('’', "'") |
| 2040 | if warning_pattern.match(line): |
| 2041 | if line not in warning_lines: |
| 2042 | classify_warning(line) |
| 2043 | warning_lines.add(line) |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2044 | elif line_counter < 50: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2045 | # save a little bit of time by only doing this for the first few lines |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2046 | line_counter += 1 |
| 2047 | m = re.search('(?<=^PLATFORM_VERSION=).*', line) |
| 2048 | if m is not None: |
| 2049 | platform_version = m.group(0) |
| 2050 | m = re.search('(?<=^TARGET_PRODUCT=).*', line) |
| 2051 | if m is not None: |
| 2052 | target_product = m.group(0) |
| 2053 | m = re.search('(?<=^TARGET_BUILD_VARIANT=).*', line) |
| 2054 | if m is not None: |
| 2055 | target_variant = m.group(0) |
| 2056 | |
| 2057 | |
| 2058 | # Return s with escaped quotation characters. |
| 2059 | def escape_string(s): |
| 2060 | return s.replace('"', '\\"') |
| 2061 | |
| 2062 | |
| 2063 | # Return s without trailing '\n' and escape the quotation characters. |
| 2064 | def strip_escape_string(s): |
| 2065 | if not s: |
| 2066 | return s |
| 2067 | s = s[:-1] if s[-1] == '\n' else s |
| 2068 | return escape_string(s) |
| 2069 | |
| 2070 | |
| 2071 | def emit_warning_array(name): |
| 2072 | print 'var warning_{} = ['.format(name) |
| 2073 | for i in range(len(warn_patterns)): |
| 2074 | print '{},'.format(warn_patterns[i][name]) |
| 2075 | print '];' |
| 2076 | |
| 2077 | |
| 2078 | def emit_warning_arrays(): |
| 2079 | emit_warning_array('severity') |
| 2080 | print 'var warning_description = [' |
| 2081 | for i in range(len(warn_patterns)): |
| 2082 | if warn_patterns[i]['members']: |
| 2083 | print '"{}",'.format(escape_string(warn_patterns[i]['description'])) |
| 2084 | else: |
| 2085 | print '"",' # no such warning |
| 2086 | print '];' |
| 2087 | |
| 2088 | scripts_for_warning_groups = """ |
| 2089 | function compareMessages(x1, x2) { // of the same warning type |
| 2090 | return (WarningMessages[x1[2]] <= WarningMessages[x2[2]]) ? -1 : 1; |
| 2091 | } |
| 2092 | function byMessageCount(x1, x2) { |
| 2093 | return x2[2] - x1[2]; // reversed order |
| 2094 | } |
| 2095 | function bySeverityMessageCount(x1, x2) { |
| 2096 | // orer by severity first |
| 2097 | if (x1[1] != x2[1]) |
| 2098 | return x1[1] - x2[1]; |
| 2099 | return byMessageCount(x1, x2); |
| 2100 | } |
| 2101 | const ParseLinePattern = /^([^ :]+):(\\d+):(.+)/; |
| 2102 | function addURL(line) { |
| 2103 | if (FlagURL == "") return line; |
| 2104 | if (FlagSeparator == "") { |
| 2105 | return line.replace(ParseLinePattern, |
| 2106 | "<a href='" + FlagURL + "/$1'>$1</a>:$2:$3"); |
| 2107 | } |
| 2108 | return line.replace(ParseLinePattern, |
| 2109 | "<a href='" + FlagURL + "/$1" + FlagSeparator + "$2'>$1:$2</a>:$3"); |
| 2110 | } |
| 2111 | function createArrayOfDictionaries(n) { |
| 2112 | var result = []; |
| 2113 | for (var i=0; i<n; i++) result.push({}); |
| 2114 | return result; |
| 2115 | } |
| 2116 | function groupWarningsBySeverity() { |
| 2117 | // groups is an array of dictionaries, |
| 2118 | // each dictionary maps from warning type to array of warning messages. |
| 2119 | var groups = createArrayOfDictionaries(SeverityColors.length); |
| 2120 | for (var i=0; i<Warnings.length; i++) { |
| 2121 | var w = Warnings[i][0]; |
| 2122 | var s = WarnPatternsSeverity[w]; |
| 2123 | var k = w.toString(); |
| 2124 | if (!(k in groups[s])) |
| 2125 | groups[s][k] = []; |
| 2126 | groups[s][k].push(Warnings[i]); |
| 2127 | } |
| 2128 | return groups; |
| 2129 | } |
| 2130 | function groupWarningsByProject() { |
| 2131 | var groups = createArrayOfDictionaries(ProjectNames.length); |
| 2132 | for (var i=0; i<Warnings.length; i++) { |
| 2133 | var w = Warnings[i][0]; |
| 2134 | var p = Warnings[i][1]; |
| 2135 | var k = w.toString(); |
| 2136 | if (!(k in groups[p])) |
| 2137 | groups[p][k] = []; |
| 2138 | groups[p][k].push(Warnings[i]); |
| 2139 | } |
| 2140 | return groups; |
| 2141 | } |
| 2142 | var GlobalAnchor = 0; |
| 2143 | function createWarningSection(header, color, group) { |
| 2144 | var result = ""; |
| 2145 | var groupKeys = []; |
| 2146 | var totalMessages = 0; |
| 2147 | for (var k in group) { |
| 2148 | totalMessages += group[k].length; |
| 2149 | groupKeys.push([k, WarnPatternsSeverity[parseInt(k)], group[k].length]); |
| 2150 | } |
| 2151 | groupKeys.sort(bySeverityMessageCount); |
| 2152 | for (var idx=0; idx<groupKeys.length; idx++) { |
| 2153 | var k = groupKeys[idx][0]; |
| 2154 | var messages = group[k]; |
| 2155 | var w = parseInt(k); |
| 2156 | var wcolor = SeverityColors[WarnPatternsSeverity[w]]; |
| 2157 | var description = WarnPatternsDescription[w]; |
| 2158 | if (description.length == 0) |
| 2159 | description = "???"; |
| 2160 | GlobalAnchor += 1; |
| 2161 | result += "<table class='t1'><tr bgcolor='" + wcolor + "'><td>" + |
| 2162 | "<button class='bt' id='" + GlobalAnchor + "_mark" + |
| 2163 | "' onclick='expand(\\"" + GlobalAnchor + "\\");'>" + |
| 2164 | "⊕</button> " + |
| 2165 | description + " (" + messages.length + ")</td></tr></table>"; |
| 2166 | result += "<div id='" + GlobalAnchor + |
| 2167 | "' style='display:none;'><table class='t1'>"; |
| 2168 | var c = 0; |
| 2169 | messages.sort(compareMessages); |
| 2170 | for (var i=0; i<messages.length; i++) { |
| 2171 | result += "<tr><td class='c" + c + "'>" + |
| 2172 | addURL(WarningMessages[messages[i][2]]) + "</td></tr>"; |
| 2173 | c = 1 - c; |
| 2174 | } |
| 2175 | result += "</table></div>"; |
| 2176 | } |
| 2177 | if (result.length > 0) { |
| 2178 | return "<br><span style='background-color:" + color + "'><b>" + |
| 2179 | header + ": " + totalMessages + |
| 2180 | "</b></span><blockquote><table class='t1'>" + |
| 2181 | result + "</table></blockquote>"; |
| 2182 | |
| 2183 | } |
| 2184 | return ""; // empty section |
| 2185 | } |
| 2186 | function generateSectionsBySeverity() { |
| 2187 | var result = ""; |
| 2188 | var groups = groupWarningsBySeverity(); |
| 2189 | for (s=0; s<SeverityColors.length; s++) { |
| 2190 | result += createWarningSection(SeverityHeaders[s], SeverityColors[s], groups[s]); |
| 2191 | } |
| 2192 | return result; |
| 2193 | } |
| 2194 | function generateSectionsByProject() { |
| 2195 | var result = ""; |
| 2196 | var groups = groupWarningsByProject(); |
| 2197 | for (i=0; i<groups.length; i++) { |
| 2198 | result += createWarningSection(ProjectNames[i], 'lightgrey', groups[i]); |
| 2199 | } |
| 2200 | return result; |
| 2201 | } |
| 2202 | function groupWarnings(generator) { |
| 2203 | GlobalAnchor = 0; |
| 2204 | var e = document.getElementById("warning_groups"); |
| 2205 | e.innerHTML = generator(); |
| 2206 | } |
| 2207 | function groupBySeverity() { |
| 2208 | groupWarnings(generateSectionsBySeverity); |
| 2209 | } |
| 2210 | function groupByProject() { |
| 2211 | groupWarnings(generateSectionsByProject); |
| 2212 | } |
| 2213 | """ |
| 2214 | |
| 2215 | |
| 2216 | # Emit a JavaScript const string |
| 2217 | def emit_const_string(name, value): |
| 2218 | print 'const ' + name + ' = "' + escape_string(value) + '";' |
| 2219 | |
| 2220 | |
| 2221 | # Emit a JavaScript const integer array. |
| 2222 | def emit_const_int_array(name, array): |
| 2223 | print 'const ' + name + ' = [' |
| 2224 | for n in array: |
| 2225 | print str(n) + ',' |
| 2226 | print '];' |
| 2227 | |
| 2228 | |
| 2229 | # Emit a JavaScript const string array. |
| 2230 | def emit_const_string_array(name, array): |
| 2231 | print 'const ' + name + ' = [' |
| 2232 | for s in array: |
| 2233 | print '"' + strip_escape_string(s) + '",' |
| 2234 | print '];' |
| 2235 | |
| 2236 | |
| 2237 | # Emit a JavaScript const object array. |
| 2238 | def emit_const_object_array(name, array): |
| 2239 | print 'const ' + name + ' = [' |
| 2240 | for x in array: |
| 2241 | print str(x) + ',' |
| 2242 | print '];' |
| 2243 | |
| 2244 | |
| 2245 | def emit_js_data(): |
| 2246 | """Dump dynamic HTML page's static JavaScript data.""" |
| 2247 | emit_const_string('FlagURL', args.url if args.url else '') |
| 2248 | emit_const_string('FlagSeparator', args.separator if args.separator else '') |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 2249 | emit_const_string_array('SeverityColors', Severity.colors) |
| 2250 | emit_const_string_array('SeverityHeaders', Severity.headers) |
| 2251 | emit_const_string_array('SeverityColumnHeaders', Severity.column_headers) |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2252 | emit_const_string_array('ProjectNames', project_names) |
| 2253 | emit_const_int_array('WarnPatternsSeverity', |
| 2254 | [w['severity'] for w in warn_patterns]) |
| 2255 | emit_const_string_array('WarnPatternsDescription', |
| 2256 | [w['description'] for w in warn_patterns]) |
| 2257 | emit_const_string_array('WarnPatternsOption', |
| 2258 | [w['option'] for w in warn_patterns]) |
| 2259 | emit_const_string_array('WarningMessages', warning_messages) |
| 2260 | emit_const_object_array('Warnings', warning_records) |
| 2261 | |
| 2262 | draw_table_javascript = """ |
| 2263 | google.charts.load('current', {'packages':['table']}); |
| 2264 | google.charts.setOnLoadCallback(drawTable); |
| 2265 | function drawTable() { |
| 2266 | var data = new google.visualization.DataTable(); |
| 2267 | data.addColumn('string', StatsHeader[0]); |
| 2268 | for (var i=1; i<StatsHeader.length; i++) { |
| 2269 | data.addColumn('number', StatsHeader[i]); |
| 2270 | } |
| 2271 | data.addRows(StatsRows); |
| 2272 | for (var i=0; i<StatsRows.length; i++) { |
| 2273 | for (var j=0; j<StatsHeader.length; j++) { |
| 2274 | data.setProperty(i, j, 'style', 'border:1px solid black;'); |
| 2275 | } |
| 2276 | } |
| 2277 | var table = new google.visualization.Table(document.getElementById('stats_table')); |
| 2278 | table.draw(data, {allowHtml: true, alternatingRowStyle: true}); |
| 2279 | } |
| 2280 | """ |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2281 | |
| 2282 | |
| 2283 | def dump_html(): |
| 2284 | """Dump the html output to stdout.""" |
| 2285 | dump_html_prologue('Warnings for ' + platform_version + ' - ' + |
| 2286 | target_product + ' - ' + target_variant) |
| 2287 | dump_stats() |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2288 | print '<br><div id="stats_table"></div><br>' |
| 2289 | print '\n<script>' |
| 2290 | emit_js_data() |
| 2291 | print scripts_for_warning_groups |
| 2292 | print '</script>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2293 | emit_buttons() |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2294 | # Warning messages are grouped by severities or project names. |
| 2295 | print '<br><div id="warning_groups"></div>' |
| 2296 | if args.byproject: |
| 2297 | print '<script>groupByProject();</script>' |
| 2298 | else: |
| 2299 | print '<script>groupBySeverity();</script>' |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2300 | dump_fixed() |
| 2301 | dump_html_epilogue() |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 2302 | |
| 2303 | |
| 2304 | ##### Functions to count warnings and dump csv file. ######################### |
| 2305 | |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 2306 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2307 | def description_for_csv(category): |
| 2308 | if not category['description']: |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2309 | return '?' |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2310 | return category['description'] |
Chih-Hung Hsieh | 48a16ba | 2016-07-21 14:22:53 -0700 | [diff] [blame] | 2311 | |
| 2312 | |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2313 | def string_for_csv(s): |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2314 | # Only some Java warning desciptions have used quotation marks. |
| 2315 | # TODO(chh): if s has double quote character, s should be quoted. |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2316 | if ',' in s: |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2317 | # TODO(chh): replace a double quote with two double quotes in s. |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2318 | return '"{}"'.format(s) |
| 2319 | return s |
| 2320 | |
| 2321 | |
| 2322 | def count_severity(sev, kind): |
| 2323 | """Count warnings of given severity.""" |
| 2324 | total = 0 |
| 2325 | for i in warn_patterns: |
| 2326 | if i['severity'] == sev and i['members']: |
| 2327 | n = len(i['members']) |
| 2328 | total += n |
| 2329 | warning = string_for_csv(kind + ': ' + description_for_csv(i)) |
| 2330 | print '{},,{}'.format(n, warning) |
| 2331 | # print number of warnings for each project, ordered by project name. |
| 2332 | projects = i['projects'].keys() |
| 2333 | projects.sort() |
| 2334 | for p in projects: |
| 2335 | print '{},{},{}'.format(i['projects'][p], p, warning) |
| 2336 | print '{},,{}'.format(total, kind + ' warnings') |
| 2337 | return total |
| 2338 | |
| 2339 | |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2340 | # dump number of warnings in csv format to stdout |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2341 | def dump_csv(): |
| 2342 | """Dump number of warnings in csv format to stdout.""" |
| 2343 | sort_warnings() |
| 2344 | total = 0 |
Chih-Hung Hsieh | b426c54 | 2016-09-27 18:08:52 -0700 | [diff] [blame] | 2345 | for s in Severity.range: |
| 2346 | total += count_severity(s, Severity.column_headers[s]) |
Chih-Hung Hsieh | 6c0fdbb | 2016-09-26 10:56:43 -0700 | [diff] [blame] | 2347 | print '{},,{}'.format(total, 'All warnings') |
| 2348 | |
| 2349 | |
Meike Baumgärtner | ac9d5df | 2016-09-28 10:48:06 -0700 | [diff] [blame] | 2350 | def main(): |
| 2351 | parse_input_file() |
| 2352 | if args.gencsv: |
| 2353 | dump_csv() |
| 2354 | else: |
| 2355 | dump_html() |
Chih-Hung Hsieh | 2a38c37 | 2016-09-22 19:22:07 -0700 | [diff] [blame] | 2356 | |
Meike Baumgärtner | ac9d5df | 2016-09-28 10:48:06 -0700 | [diff] [blame] | 2357 | |
| 2358 | # Run main function if warn.py is the main program. |
| 2359 | if __name__ == '__main__': |
| 2360 | main() |