blob: bafb466c8362b63c143a2e5c1e3293dfccd4338e [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Nan Zhang61eaedb2017-11-02 13:28:15 -070021 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070022 "strings"
23 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070024
Colin Crossa4f08812018-10-02 22:03:40 -070025 "android/soong/android"
26 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080027 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070028 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070029)
30
31var buildDir string
32
33func setUp() {
34 var err error
35 buildDir, err = ioutil.TempDir("", "soong_java_test")
36 if err != nil {
37 panic(err)
38 }
39}
40
41func tearDown() {
42 os.RemoveAll(buildDir)
43}
44
45func TestMain(m *testing.M) {
46 run := func() int {
47 setUp()
48 defer tearDown()
49
50 return m.Run()
51 }
52
53 os.Exit(run())
54}
Colin Cross527012a2017-11-30 22:56:16 -080055
56func testConfig(env map[string]string) android.Config {
Colin Crossb1974532019-02-15 10:37:39 -080057 return TestConfig(buildDir, env)
Colin Cross1369cdb2017-09-29 17:58:17 -070058}
59
Colin Cross527012a2017-11-30 22:56:16 -080060func testContext(config android.Config, bp string,
61 fs map[string][]byte) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070062
Colin Cross4c428df2017-09-15 17:36:05 -070063 ctx := android.NewTestArchContext()
Colin Cross72bb3632017-07-13 16:23:21 -070064 ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(AndroidAppFactory))
Jaewoong Jung2ad817c2019-01-18 14:27:16 -080065 ctx.RegisterModuleType("android_app_certificate", android.ModuleFactoryAdaptor(AndroidAppCertificateFactory))
Jaewoong Jung33695b92019-04-15 09:48:31 -070066 ctx.RegisterModuleType("android_app_import", android.ModuleFactoryAdaptor(AndroidAppImportFactory))
Colin Crossa97c5d32018-03-28 14:58:31 -070067 ctx.RegisterModuleType("android_library", android.ModuleFactoryAdaptor(AndroidLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070068 ctx.RegisterModuleType("android_test", android.ModuleFactoryAdaptor(AndroidTestFactory))
Colin Cross638149e2019-01-05 22:12:12 -080069 ctx.RegisterModuleType("android_test_helper_app", android.ModuleFactoryAdaptor(AndroidTestHelperAppFactory))
70 ctx.RegisterModuleType("java_binary", android.ModuleFactoryAdaptor(BinaryFactory))
Colin Cross6b4a32d2017-12-05 13:42:45 -080071 ctx.RegisterModuleType("java_binary_host", android.ModuleFactoryAdaptor(BinaryHostFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080072 ctx.RegisterModuleType("java_device_for_host", android.ModuleFactoryAdaptor(DeviceForHostFactory))
73 ctx.RegisterModuleType("java_host_for_device", android.ModuleFactoryAdaptor(HostForDeviceFactory))
Colin Cross9ae1b922018-06-26 17:59:05 -070074 ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(LibraryFactory))
Colin Cross2acdae82017-09-15 19:44:24 -070075 ctx.RegisterModuleType("java_library_host", android.ModuleFactoryAdaptor(LibraryHostFactory))
Colin Cross638149e2019-01-05 22:12:12 -080076 ctx.RegisterModuleType("java_test", android.ModuleFactoryAdaptor(TestFactory))
Colin Cross74d73e22017-08-02 11:05:49 -070077 ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(ImportFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080078 ctx.RegisterModuleType("java_import_host", android.ModuleFactoryAdaptor(ImportFactoryHost))
Colin Cross89536d42017-07-07 14:35:50 -070079 ctx.RegisterModuleType("java_defaults", android.ModuleFactoryAdaptor(defaultsFactory))
Colin Cross1369cdb2017-09-29 17:58:17 -070080 ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(SystemModulesFactory))
Colin Cross54250902017-12-05 09:28:08 -080081 ctx.RegisterModuleType("java_genrule", android.ModuleFactoryAdaptor(genRuleFactory))
Colin Crossbe9cdb82019-01-21 21:37:16 -080082 ctx.RegisterModuleType("java_plugin", android.ModuleFactoryAdaptor(PluginFactory))
Colin Cross42be7612019-02-21 18:12:14 -080083 ctx.RegisterModuleType("dex_import", android.ModuleFactoryAdaptor(DexImportFactory))
Pirama Arumuga Nainar955dc492018-04-17 14:58:42 -070084 ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(android.FileGroupFactory))
Colin Cross54190b32017-10-09 15:34:10 -070085 ctx.RegisterModuleType("genrule", android.ModuleFactoryAdaptor(genrule.GenRuleFactory))
Nan Zhang581fd212018-01-10 16:06:12 -080086 ctx.RegisterModuleType("droiddoc", android.ModuleFactoryAdaptor(DroiddocFactory))
87 ctx.RegisterModuleType("droiddoc_host", android.ModuleFactoryAdaptor(DroiddocHostFactory))
Nan Zhangf4936b02018-08-01 15:00:28 -070088 ctx.RegisterModuleType("droiddoc_template", android.ModuleFactoryAdaptor(ExportedDroiddocDirFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090089 ctx.RegisterModuleType("java_sdk_library", android.ModuleFactoryAdaptor(SdkLibraryFactory))
Jaewoong Jung525443a2019-02-28 15:35:54 -080090 ctx.RegisterModuleType("override_android_app", android.ModuleFactoryAdaptor(OverrideAndroidAppModuleFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090091 ctx.RegisterModuleType("prebuilt_apis", android.ModuleFactoryAdaptor(PrebuiltApisFactory))
Colin Cross5ea9bcc2017-07-27 15:41:32 -070092 ctx.PreArchMutators(android.RegisterPrebuiltsPreArchMutators)
93 ctx.PreArchMutators(android.RegisterPrebuiltsPostDepsMutators)
Colin Cross89536d42017-07-07 14:35:50 -070094 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Jaewoong Jung525443a2019-02-28 15:35:54 -080095 ctx.PreArchMutators(android.RegisterOverridePreArchMutators)
Jiyong Parkc678ad32018-04-10 13:07:10 +090096 ctx.PreArchMutators(func(ctx android.RegisterMutatorsContext) {
Inseob Kimc0907f12019-02-08 21:00:45 +090097 ctx.TopDown("prebuilt_apis", PrebuiltApisMutator).Parallel()
98 ctx.TopDown("java_sdk_library", SdkLibraryMutator).Parallel()
Jiyong Parkc678ad32018-04-10 13:07:10 +090099 })
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800100 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross9bdfaf02019-04-18 10:56:44 -0700101 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700102
103 // Register module types and mutators from cc needed for JNI testing
104 ctx.RegisterModuleType("cc_library", android.ModuleFactoryAdaptor(cc.LibraryFactory))
105 ctx.RegisterModuleType("cc_object", android.ModuleFactoryAdaptor(cc.ObjectFactory))
106 ctx.RegisterModuleType("toolchain_library", android.ModuleFactoryAdaptor(cc.ToolchainLibraryFactory))
Colin Cross47fa9d32019-03-26 10:51:39 -0700107 ctx.RegisterModuleType("llndk_library", android.ModuleFactoryAdaptor(cc.LlndkLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700108 ctx.PreDepsMutators(func(ctx android.RegisterMutatorsContext) {
109 ctx.BottomUp("link", cc.LinkageMutator).Parallel()
110 ctx.BottomUp("begin", cc.BeginMutator).Parallel()
111 })
112
Colin Crossb1974532019-02-15 10:37:39 -0800113 bp += GatherRequiredDepsForTest()
Colin Cross1369cdb2017-09-29 17:58:17 -0700114
Colin Cross824bee32017-11-22 17:27:51 -0800115 mockFS := map[string][]byte{
Jiyong Park58c518b2018-05-12 22:29:12 +0900116 "Android.bp": []byte(bp),
117 "a.java": nil,
118 "b.java": nil,
119 "c.java": nil,
120 "b.kt": nil,
121 "a.jar": nil,
122 "b.jar": nil,
Jaewoong Jung5c6572e2019-06-17 17:40:56 -0700123 "APP_NOTICE": nil,
124 "GENRULE_NOTICE": nil,
125 "LIB_NOTICE": nil,
126 "TOOL_NOTICE": nil,
Jiyong Park58c518b2018-05-12 22:29:12 +0900127 "java-res/a/a": nil,
128 "java-res/b/b": nil,
129 "java-res2/a": nil,
130 "java-fg/a.java": nil,
131 "java-fg/b.java": nil,
132 "java-fg/c.java": nil,
133 "api/current.txt": nil,
134 "api/removed.txt": nil,
135 "api/system-current.txt": nil,
136 "api/system-removed.txt": nil,
137 "api/test-current.txt": nil,
138 "api/test-removed.txt": nil,
Colin Cross9bdfaf02019-04-18 10:56:44 -0700139 "framework/aidl/a.aidl": nil,
Colin Cross0532fb02017-10-02 16:57:40 -0700140
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100141 "prebuilts/sdk/14/public/android.jar": nil,
142 "prebuilts/sdk/14/public/framework.aidl": nil,
143 "prebuilts/sdk/14/system/android.jar": nil,
Colin Cross98fd5742019-01-09 23:04:25 -0800144 "prebuilts/sdk/17/public/android.jar": nil,
145 "prebuilts/sdk/17/public/framework.aidl": nil,
146 "prebuilts/sdk/17/system/android.jar": nil,
Colin Crossff0daf42019-04-02 16:10:56 -0700147 "prebuilts/sdk/25/public/android.jar": nil,
148 "prebuilts/sdk/25/public/framework.aidl": nil,
149 "prebuilts/sdk/25/system/android.jar": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700150 "prebuilts/sdk/current/core/android.jar": nil,
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100151 "prebuilts/sdk/current/public/android.jar": nil,
152 "prebuilts/sdk/current/public/framework.aidl": nil,
153 "prebuilts/sdk/current/public/core.jar": nil,
154 "prebuilts/sdk/current/system/android.jar": nil,
155 "prebuilts/sdk/current/test/android.jar": nil,
Jiyong Park58c518b2018-05-12 22:29:12 +0900156 "prebuilts/sdk/28/public/api/foo.txt": nil,
157 "prebuilts/sdk/28/system/api/foo.txt": nil,
158 "prebuilts/sdk/28/test/api/foo.txt": nil,
159 "prebuilts/sdk/28/public/api/foo-removed.txt": nil,
160 "prebuilts/sdk/28/system/api/foo-removed.txt": nil,
161 "prebuilts/sdk/28/test/api/foo-removed.txt": nil,
162 "prebuilts/sdk/28/public/api/bar.txt": nil,
163 "prebuilts/sdk/28/system/api/bar.txt": nil,
164 "prebuilts/sdk/28/test/api/bar.txt": nil,
165 "prebuilts/sdk/28/public/api/bar-removed.txt": nil,
166 "prebuilts/sdk/28/system/api/bar-removed.txt": nil,
167 "prebuilts/sdk/28/test/api/bar-removed.txt": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700168 "prebuilts/sdk/tools/core-lambda-stubs.jar": nil,
Sundong Ahn27eecb92018-06-21 13:47:17 +0900169 "prebuilts/sdk/Android.bp": []byte(`prebuilt_apis { name: "sdk", api_dirs: ["14", "28", "current"],}`),
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800170
Jaewoong Jung9c6f3142019-04-26 14:31:50 -0700171 "prebuilts/apk/app.apk": nil,
Jaewoong Jung9e0fbd52019-08-13 14:11:33 -0700172 "prebuilts/apk/app_arm.apk": nil,
173 "prebuilts/apk/app_arm64.apk": nil,
Jaewoong Jung9c6f3142019-04-26 14:31:50 -0700174 "prebuilts/apk/app_xhdpi.apk": nil,
175 "prebuilts/apk/app_xxhdpi.apk": nil,
Jaewoong Jung33695b92019-04-15 09:48:31 -0700176
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800177 // For framework-res, which is an implicit dependency for framework
Dan Willemsenadbfc492019-04-09 21:36:26 -0700178 "AndroidManifest.xml": nil,
179 "build/make/target/product/security/testkey": nil,
Colin Cross6b4a32d2017-12-05 13:42:45 -0800180
181 "build/soong/scripts/jar-wrapper.sh": nil,
Colin Cross7fdd2b72018-01-02 18:14:25 -0800182
Colin Cross66dbc0b2017-12-28 12:23:20 -0800183 "build/make/core/proguard.flags": nil,
184 "build/make/core/proguard_basic_keeps.flags": nil,
185
Colin Cross7fdd2b72018-01-02 18:14:25 -0800186 "jdk8/jre/lib/jce.jar": nil,
187 "jdk8/jre/lib/rt.jar": nil,
Nan Zhang61819ce2018-05-04 18:49:16 -0700188 "jdk8/lib/tools.jar": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800189
190 "bar-doc/a.java": nil,
191 "bar-doc/b.java": nil,
Jiyong Park1e440682018-05-23 18:42:04 +0900192 "bar-doc/IFoo.aidl": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800193 "bar-doc/known_oj_tags.txt": nil,
194 "external/doclava/templates-sdk": nil,
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800195
196 "cert/new_cert.x509.pem": nil,
197 "cert/new_cert.pk8": nil,
Colin Cross824bee32017-11-22 17:27:51 -0800198 }
199
200 for k, v := range fs {
201 mockFS[k] = v
202 }
203
204 ctx.MockFileSystem(mockFS)
Colin Cross72bb3632017-07-13 16:23:21 -0700205
Colin Cross527012a2017-11-30 22:56:16 -0800206 return ctx
207}
208
209func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800210 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800211
212 pathCtx := android.PathContextForTesting(config, nil)
213 setDexpreoptTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
214
215 ctx.Register()
Jiyong Park58c518b2018-05-12 22:29:12 +0900216 _, errs := ctx.ParseFileList(".", []string{"Android.bp", "prebuilts/sdk/Android.bp"})
Logan Chien42039712018-03-12 16:29:17 +0800217 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700218 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800219 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800220}
221
222func testJava(t *testing.T, bp string) *android.TestContext {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800223 t.Helper()
Colin Cross527012a2017-11-30 22:56:16 -0800224 config := testConfig(nil)
225 ctx := testContext(config, bp, nil)
226 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700227
228 return ctx
229}
230
Colin Cross2acdae82017-09-15 19:44:24 -0700231func moduleToPath(name string) string {
232 switch {
233 case name == `""`:
234 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700235 case strings.HasSuffix(name, ".jar"):
236 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700237 default:
238 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700239 }
240}
241
Colin Cross72bb3632017-07-13 16:23:21 -0700242func TestSimple(t *testing.T) {
243 ctx := testJava(t, `
244 java_library {
245 name: "foo",
246 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700247 libs: ["bar"],
248 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700249 }
250
251 java_library {
252 name: "bar",
253 srcs: ["b.java"],
254 }
255
256 java_library {
257 name: "baz",
258 srcs: ["c.java"],
259 }
Colin Crossd5934c82017-10-02 13:55:26 -0700260 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700261
Colin Cross4c428df2017-09-15 17:36:05 -0700262 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700263 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700264
265 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
266 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
267 }
268
Colin Cross1ee23172017-10-18 14:44:18 -0700269 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700270 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
271 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700272
Nan Zhanged19fc32017-10-19 13:06:22 -0700273 if !strings.Contains(javac.Args["classpath"], barTurbine) {
274 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700275 }
276
Nan Zhanged19fc32017-10-19 13:06:22 -0700277 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
278 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700279 }
280
281 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
282 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700283 }
284}
285
Colin Crossd5934c82017-10-02 13:55:26 -0700286func TestArchSpecific(t *testing.T) {
287 ctx := testJava(t, `
288 java_library {
289 name: "foo",
290 srcs: ["a.java"],
291 target: {
292 android: {
293 srcs: ["b.java"],
294 },
295 },
296 }
297 `)
298
299 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
300 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
301 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
302 }
303}
304
Colin Cross6b4a32d2017-12-05 13:42:45 -0800305func TestBinary(t *testing.T) {
306 ctx := testJava(t, `
307 java_library_host {
308 name: "foo",
309 srcs: ["a.java"],
310 }
311
312 java_binary_host {
313 name: "bar",
314 srcs: ["b.java"],
315 static_libs: ["foo"],
316 }
317 `)
318
319 buildOS := android.BuildOs.String()
320
321 bar := ctx.ModuleForTests("bar", buildOS+"_common")
322 barJar := bar.Output("bar.jar").Output.String()
323 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
324 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
325
326 // Test that the install binary wrapper depends on the installed jar file
327 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
328 t.Errorf("expected binary wrapper implicits [%q], got %v",
329 barJar, barWrapperDeps)
330 }
331
332}
333
Colin Cross72bb3632017-07-13 16:23:21 -0700334func TestPrebuilts(t *testing.T) {
335 ctx := testJava(t, `
336 java_library {
337 name: "foo",
338 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700339 libs: ["bar"],
340 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700341 }
342
Colin Cross74d73e22017-08-02 11:05:49 -0700343 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700344 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700345 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700346 }
347
Colin Cross74d73e22017-08-02 11:05:49 -0700348 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700349 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700350 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700351 }
Colin Cross42be7612019-02-21 18:12:14 -0800352
353 dex_import {
354 name: "qux",
355 jars: ["b.jar"],
356 }
Colin Cross72bb3632017-07-13 16:23:21 -0700357 `)
358
Colin Cross4c428df2017-09-15 17:36:05 -0700359 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700360 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700361 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
362 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700363
Colin Cross37f6d792018-07-12 12:28:41 -0700364 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
365 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700366 }
367
Colin Cross37f6d792018-07-12 12:28:41 -0700368 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
369 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700370 }
Colin Cross42be7612019-02-21 18:12:14 -0800371
372 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700373}
374
Colin Cross89536d42017-07-07 14:35:50 -0700375func TestDefaults(t *testing.T) {
376 ctx := testJava(t, `
377 java_defaults {
378 name: "defaults",
379 srcs: ["a.java"],
380 libs: ["bar"],
381 static_libs: ["baz"],
Sasha Smundak4eaeab42019-04-16 17:16:58 -0700382 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700383 }
384
385 java_library {
386 name: "foo",
387 defaults: ["defaults"],
388 }
389
390 java_library {
391 name: "bar",
392 srcs: ["b.java"],
393 }
394
395 java_library {
396 name: "baz",
397 srcs: ["c.java"],
398 }
Sasha Smundak4eaeab42019-04-16 17:16:58 -0700399
400 android_test {
401 name: "atestOptimize",
402 defaults: ["defaults"],
403 optimize: {enabled: true},
404 }
405
406 android_test {
407 name: "atestNoOptimize",
408 defaults: ["defaults"],
409 }
410
411 android_test {
412 name: "atestDefault",
413 srcs: ["a.java"],
414 }
Colin Cross89536d42017-07-07 14:35:50 -0700415 `)
416
Colin Cross4c428df2017-09-15 17:36:05 -0700417 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700418 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700419
420 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
421 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
422 }
423
Nan Zhanged19fc32017-10-19 13:06:22 -0700424 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
425 if !strings.Contains(javac.Args["classpath"], barTurbine) {
426 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700427 }
428
Colin Cross1ee23172017-10-18 14:44:18 -0700429 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700430 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
431 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700432 }
Sasha Smundak4eaeab42019-04-16 17:16:58 -0700433
434 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
435 if atestOptimize.Output == nil {
436 t.Errorf("atestOptimize should optimize APK")
437 }
438
439 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
440 if atestNoOptimize.Output == nil {
441 t.Errorf("atestNoOptimize should not optimize APK")
442 }
443
444 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
445 if atestDefault.Output == nil {
446 t.Errorf("atestDefault should optimize APK")
447 }
Colin Cross89536d42017-07-07 14:35:50 -0700448}
449
Colin Cross0f37af02017-09-27 17:42:05 -0700450func TestResources(t *testing.T) {
451 var table = []struct {
452 name string
453 prop string
454 extra string
455 args string
456 }{
457 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700458 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700459 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800460 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700461 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700462 },
463 {
464 // Test that a module with java_resources includes the files
465 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700466 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
467 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700468 },
469 {
470 // Test that a module with a filegroup in java_resources includes the files with the
471 // path prefix
472 name: "resource filegroup",
473 prop: `java_resources: [":foo-res"]`,
474 extra: `
475 filegroup {
476 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800477 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700478 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700479 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700480 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700481 },
482 {
483 // Test that a module with "include_srcs: true" includes its source files in the resources jar
484 name: "include sources",
485 prop: `include_srcs: true`,
Colin Crossaf9c55b2017-10-03 14:50:08 -0700486 args: "-C . -f a.java -f b.java -f c.java",
Colin Cross0f37af02017-09-27 17:42:05 -0700487 },
Colin Cross0ead1d72018-04-10 13:07:42 -0700488 {
489 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
490 name: "wildcard dirs",
491 prop: `java_resource_dirs: ["java-res/*"]`,
492 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
493 },
494 {
495 // Test that a module exclude_java_resource_dirs excludes the files
496 name: "wildcard dirs",
497 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
498 args: "-C java-res/a -f java-res/a/a",
499 },
Colin Crosscedd4762018-09-13 11:26:19 -0700500 {
501 // Test wildcards in java_resources
502 name: "wildcard files",
503 prop: `java_resources: ["java-res/**/*"]`,
504 args: "-C . -f java-res/a/a -f java-res/b/b",
505 },
506 {
507 // Test exclude_java_resources with java_resources
508 name: "wildcard files with exclude",
509 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
510 args: "-C . -f java-res/a/a",
511 },
512 {
513 // Test exclude_java_resources with java_resource_dirs
514 name: "resource dirs with exclude files",
515 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
516 args: "-C java-res -f java-res/a/a",
517 },
518 {
519 // Test exclude_java_resource_dirs with java_resource_dirs
520 name: "resource dirs with exclude files",
521 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
522 args: "-C java-res -f java-res/a/a -f java-res/b/b",
523 },
Colin Cross0f37af02017-09-27 17:42:05 -0700524 }
525
526 for _, test := range table {
527 t.Run(test.name, func(t *testing.T) {
528 ctx := testJava(t, `
529 java_library {
530 name: "foo",
531 srcs: [
532 "a.java",
533 "b.java",
534 "c.java",
535 ],
536 `+test.prop+`,
537 }
538 `+test.extra)
539
Colin Cross331a1212018-08-15 20:40:52 -0700540 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700541 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700542
543 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
544 t.Errorf("foo combined jars %v does not contain %q",
545 foo.Inputs.Strings(), fooRes.Output.String())
546 }
547
Colin Crossaf9c55b2017-10-03 14:50:08 -0700548 if fooRes.Args["jarArgs"] != test.args {
549 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700550 fooRes.Args["jarArgs"], test.args)
551 }
552 })
553 }
554}
555
Colin Cross54190b32017-10-09 15:34:10 -0700556func TestGeneratedSources(t *testing.T) {
557 ctx := testJava(t, `
558 java_library {
559 name: "foo",
560 srcs: [
561 "a*.java",
562 ":gen",
563 "b*.java",
564 ],
565 }
566
567 genrule {
568 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800569 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700570 out: ["gen.java"],
571 }
572 `)
573
574 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
575 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
576
Colin Cross15e86d92017-10-20 15:07:08 -0700577 if filepath.Base(genrule.Output.String()) != "gen.java" {
578 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700579 }
580
581 if len(javac.Inputs) != 3 ||
582 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700583 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700584 javac.Inputs[2].String() != "b.java" {
585 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
586 }
587}
588
Nan Zhang61eaedb2017-11-02 13:28:15 -0700589func TestTurbine(t *testing.T) {
590 ctx := testJava(t, `
591 java_library {
592 name: "foo",
593 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900594 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700595 }
596
597 java_library {
598 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800599 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700600 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900601 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700602 }
603
604 java_library {
605 name: "baz",
606 srcs: ["c.java"],
607 libs: ["bar"],
608 sdk_version: "14",
609 }
610 `)
611
612 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
613 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
614 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
615 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
616 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
617
618 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
619 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
620 }
621
622 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
623 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
624 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
625 }
626 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
627 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
628 }
629 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
630 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
631 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100632 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -0700633 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100634 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700635 }
636}
637
638func TestSharding(t *testing.T) {
639 ctx := testJava(t, `
640 java_library {
641 name: "bar",
642 srcs: ["a.java","b.java","c.java"],
643 javac_shard_size: 1
644 }
645 `)
646
647 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
648 for i := 0; i < 3; i++ {
649 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
650 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
651 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
652 }
653 }
654}
655
Nan Zhang581fd212018-01-10 16:06:12 -0800656func TestDroiddoc(t *testing.T) {
657 ctx := testJava(t, `
Dan Willemsencc090972018-02-26 14:33:31 -0800658 droiddoc_template {
659 name: "droiddoc-templates-sdk",
660 path: ".",
661 }
Nan Zhang581fd212018-01-10 16:06:12 -0800662 droiddoc {
663 name: "bar-doc",
664 srcs: [
665 "bar-doc/*.java",
Jiyong Park1e440682018-05-23 18:42:04 +0900666 "bar-doc/IFoo.aidl",
Nan Zhang581fd212018-01-10 16:06:12 -0800667 ],
668 exclude_srcs: [
669 "bar-doc/b.java"
670 ],
Dan Willemsencc090972018-02-26 14:33:31 -0800671 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -0800672 hdf: [
673 "android.whichdoc offline",
674 ],
675 knowntags: [
676 "bar-doc/known_oj_tags.txt",
677 ],
678 proofread_file: "libcore-proofread.txt",
679 todo_file: "libcore-docs-todo.html",
680 args: "-offlinemode -title \"libcore\"",
681 }
682 `)
683
Nan Zhang3bb14202018-02-28 10:14:25 -0800684 stubsJar := filepath.Join(buildDir, ".intermediates", "bar-doc", "android_common", "bar-doc-stubs.srcjar")
685 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Output("bar-doc-stubs.srcjar")
Nan Zhang581fd212018-01-10 16:06:12 -0800686 if stubsJar != barDoc.Output.String() {
687 t.Errorf("expected stubs Jar [%q], got %q", stubsJar, barDoc.Output.String())
688 }
Jiyong Park1e440682018-05-23 18:42:04 +0900689 inputs := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc").Inputs
690 var javaSrcs []string
691 for _, i := range inputs {
692 javaSrcs = append(javaSrcs, i.Base())
693 }
694 if len(javaSrcs) != 2 || javaSrcs[0] != "a.java" || javaSrcs[1] != "IFoo.java" {
695 t.Errorf("inputs of bar-doc must be []string{\"a.java\", \"IFoo.java\", but was %#v.", javaSrcs)
696 }
Nan Zhang581fd212018-01-10 16:06:12 -0800697}
698
Colin Cross54250902017-12-05 09:28:08 -0800699func TestJarGenrules(t *testing.T) {
700 ctx := testJava(t, `
701 java_library {
702 name: "foo",
703 srcs: ["a.java"],
704 }
705
706 java_genrule {
707 name: "jargen",
708 tool_files: ["b.java"],
709 cmd: "$(location b.java) $(in) $(out)",
710 out: ["jargen.jar"],
711 srcs: [":foo"],
712 }
713
714 java_library {
715 name: "bar",
716 static_libs: ["jargen"],
717 srcs: ["c.java"],
718 }
719
720 java_library {
721 name: "baz",
722 libs: ["jargen"],
723 srcs: ["c.java"],
724 }
725 `)
726
727 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
728 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
729 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
730 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
731 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
732
733 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
734 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
735 }
736
737 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
738 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
739 }
740
741 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
742 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
743 }
744
745 if len(barCombined.Inputs) != 2 ||
746 barCombined.Inputs[0].String() != bar.Output.String() ||
747 barCombined.Inputs[1].String() != jargen.Output.String() {
748 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
749 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
750 }
751}
752
Nan Zhang27e284d2018-02-09 21:03:53 +0000753func TestExcludeFileGroupInSrcs(t *testing.T) {
754 ctx := testJava(t, `
755 java_library {
756 name: "foo",
757 srcs: ["a.java", ":foo-srcs"],
758 exclude_srcs: ["a.java", ":foo-excludes"],
759 }
760
761 filegroup {
762 name: "foo-srcs",
763 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
764 }
765
766 filegroup {
767 name: "foo-excludes",
768 srcs: ["java-fg/a.java", "java-fg/b.java"],
769 }
770 `)
771
772 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
773
774 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
775 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
776 }
777}
Jiyong Parkc678ad32018-04-10 13:07:10 +0900778
779func TestJavaSdkLibrary(t *testing.T) {
780 ctx := testJava(t, `
781 droiddoc_template {
782 name: "droiddoc-templates-sdk",
783 path: ".",
784 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900785 java_sdk_library {
786 name: "foo",
787 srcs: ["a.java", "b.java"],
788 api_packages: ["foo"],
789 }
790 java_sdk_library {
791 name: "bar",
792 srcs: ["a.java", "b.java"],
793 api_packages: ["bar"],
794 }
795 java_library {
796 name: "baz",
797 srcs: ["c.java"],
798 libs: ["foo", "bar"],
799 sdk_version: "system_current",
800 }
Jiyong Park1be96912018-05-28 18:02:19 +0900801 java_library {
802 name: "qux",
803 srcs: ["c.java"],
804 libs: ["baz"],
805 sdk_version: "system_current",
806 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900807 `)
808
809 // check the existence of the internal modules
810 ctx.ModuleForTests("foo", "android_common")
811 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix, "android_common")
812 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900813 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkTestApiSuffix, "android_common")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900814 ctx.ModuleForTests("foo"+sdkDocsSuffix, "android_common")
815 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900816 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkTestApiSuffix, "android_common")
Jaewoong Jungb9a11512019-01-15 10:47:05 -0800817 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_arm64_armv8-a")
Jiyong Park58c518b2018-05-12 22:29:12 +0900818 ctx.ModuleForTests("foo.api.public.28", "")
819 ctx.ModuleForTests("foo.api.system.28", "")
820 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900821
822 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
823 // tests if baz is actually linked to the stubs lib
824 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
825 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
826 "foo.stubs.system.jar")
827 }
828 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +0900829 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +0900830 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +0900831 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900832 }
833 // test if baz is not linked to the system variant of foo
834 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
835 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
836 "foo.stubs.jar")
837 }
Jiyong Park1be96912018-05-28 18:02:19 +0900838
839 // test if baz has exported SDK lib names foo and bar to qux
840 qux := ctx.ModuleForTests("qux", "android_common")
841 if quxLib, ok := qux.Module().(*Library); ok {
842 sdkLibs := quxLib.ExportedSdkLibs()
843 if len(sdkLibs) != 2 || !android.InList("foo", sdkLibs) || !android.InList("bar", sdkLibs) {
844 t.Errorf("qux should export \"foo\" and \"bar\" but exports %v", sdkLibs)
845 }
846 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900847}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +0200848
849var compilerFlagsTestCases = []struct {
850 in string
851 out bool
852}{
853 {
854 in: "a",
855 out: false,
856 },
857 {
858 in: "-a",
859 out: true,
860 },
861 {
862 in: "-no-jdk",
863 out: false,
864 },
865 {
866 in: "-no-stdlib",
867 out: false,
868 },
869 {
870 in: "-kotlin-home",
871 out: false,
872 },
873 {
874 in: "-kotlin-home /some/path",
875 out: false,
876 },
877 {
878 in: "-include-runtime",
879 out: false,
880 },
881 {
882 in: "-Xintellij-plugin-root",
883 out: false,
884 },
885}
886
887type mockContext struct {
888 android.ModuleContext
889 result bool
890}
891
892func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
893 // CheckBadCompilerFlags calls this function when the flag should be rejected
894 ctx.result = false
895}
896
897func TestCompilerFlags(t *testing.T) {
898 for _, testCase := range compilerFlagsTestCases {
899 ctx := &mockContext{result: true}
900 CheckKotlincFlags(ctx, []string{testCase.in})
901 if ctx.result != testCase.out {
902 t.Errorf("incorrect output:")
903 t.Errorf(" input: %#v", testCase.in)
904 t.Errorf(" expected: %#v", testCase.out)
905 t.Errorf(" got: %#v", ctx.result)
906 }
907 }
908}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800909
910// TODO(jungjw): Consider making this more robust by ignoring path order.
911func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
912 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
913 flags := strings.Split(variables["javacFlags"], " ")
914 got := ""
915 for _, flag := range flags {
916 keyEnd := strings.Index(flag, "=")
917 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
918 got = flag[keyEnd+1:]
919 break
920 }
921 }
922 if expected != got {
923 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
924 }
925}
926
927func TestPatchModule(t *testing.T) {
928 bp := `
929 java_library {
930 name: "foo",
931 srcs: ["a.java"],
932 }
933
934 java_library {
935 name: "bar",
936 srcs: ["b.java"],
937 no_standard_libs: true,
938 system_modules: "none",
939 patch_module: "java.base",
940 }
941
942 java_library {
943 name: "baz",
944 srcs: ["c.java"],
945 patch_module: "java.base",
946 }
947 `
948
949 t.Run("1.8", func(t *testing.T) {
950 // Test default javac 1.8
951 ctx := testJava(t, bp)
952
953 checkPatchModuleFlag(t, ctx, "foo", "")
954 checkPatchModuleFlag(t, ctx, "bar", "")
955 checkPatchModuleFlag(t, ctx, "baz", "")
956 })
957
958 t.Run("1.9", func(t *testing.T) {
959 // Test again with javac 1.9
960 config := testConfig(map[string]string{"EXPERIMENTAL_USE_OPENJDK9": "true"})
961 ctx := testContext(config, bp, nil)
962 run(t, ctx, config)
963
964 checkPatchModuleFlag(t, ctx, "foo", "")
965 expected := "java.base=.:" + buildDir
966 checkPatchModuleFlag(t, ctx, "bar", expected)
Insun Kang23433862019-01-24 20:46:28 +0900967 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework"), moduleToPath("updatable_media_stubs")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800968 checkPatchModuleFlag(t, ctx, "baz", expected)
969 })
970}