| commit | a5ae7c1c9fdbaaa648ae7bcf945ce714fcba91cc | [log] [tgz] |
|---|---|---|
| author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | Fri Aug 28 20:26:49 2015 +0000 |
| committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | Fri Aug 28 20:26:49 2015 +0000 |
| tree | ed609439904135d6bbb0da82fb4e8718677cb2cd | |
| parent | 18188f126182961d3882347f27d3e82f5f2f71e3 [diff] |
DI: Require subprogram definitions to be distinct
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@246327 91177308-0d34-0410-b5e6-96231b3b80d8