tree d2e596d9885a7eb2ae48d1a50d66a380ff342d47
parent 22a815a49ac75baa6d227c96ad812dcb863ab029
author Rui Ueyama <ruiu@google.com> 1506547164 +0000
committer Rui Ueyama <ruiu@google.com> 1506547164 +0000

Do not remove a target file in FileOutputBuffer::create().

FileOutputBuffer::create() attempts to remove a target file if the file
is a regular one, which results in an unexpected result in a failure
scenario.

If something goes wrong and the user of FileOutputBuffer decides to not
call commit(), it leaves nothing. An existing file is removed, and no
new file is created.

What we should do is to atomically replace an existing file with a new
file using rename(), so that it wouldn't remove an existing file without
creating a new one.

Differential Revision: https://reviews.llvm.org/D38283

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@314345 91177308-0d34-0410-b5e6-96231b3b80d8