| commit | 5b65c9f715a02b08e44d20b88657fbae8d22351f | [log] [tgz] |
|---|---|---|
| author | Primiano Tucci <primiano@google.com> | Mon Jan 29 22:58:25 2018 +0000 |
| committer | Primiano Tucci <primiano@google.com> | Mon Jan 29 22:58:25 2018 +0000 |
| tree | 7e4dc4084994dd5b0244211bbbeef5ade571990b | |
| parent | d38f88f246def8410854a8f978e8be355041db9f [diff] |
ipc: Fix dontreply logic when using derived Deferred messages This is a follow up to Id56e124bbad0870c4a29653289bf021cfdbf4c14. The previous CL added the right boilerplate but failed to work as intended end-to-end. The reason was in the callback argument adaptor in the Deferred class that was always binding the adapter even when the original callback was empty. Unfortunately this bug was not unveiled by the unittest because the test was using the DeferredBase class (without the callback adapter) and not a derivate like the production code. This CL fixes the issue and the unittest (verified that the unittest change alone without the change in deferred.h would have failed). Test: perfetto_unittests --gtest_filter=ClientImplTest.InvokeMethodDropReply Change-Id: I6fd11f7c27452526559beeb595641d141f6261f2
This project is meant to be built both as part of the Android tree and from a standalone checkout
For internal docs see this page
Android is the platform targeted in the first milestones. Right now Linux desktop and OSX are maintained best-effort.
This project uses Android AOSP Gerrit for code reviews and uses the Google C++ style. Currently targets -std=c++11.
You can use both git cl upload from Chromium depot tools or Android repo to upload patches.
git cl is quite convenient as it supports code auto-formatting via git cl format.
See https://source.android.com/source/contributing for more details about external contributions and CLA signing.
See docs/build_instructions.md
Continuous build and test coverage is available at perfetto-ci.appspot.com. Trybots: CLs uploaded to gerrit are automatically submitted to TravisCI within one minute and made available on the CI page above. The relevant code lives in the infra/ directory.
$ tools/ninja -C out/default (tracing_unittests | tracing_benchmarks) $ out/default/tracing_unittests --gtest_help
Either connect a device in ADB mode or use the bundled emulator.
To start the emulator:$ tools/run_android_emulator (arm | arm64) &
To run the tests (either on the emulator or physical device):$ tools/run_android_test out/default tracing_unittests