commit 214209947eaaefc78a566a50e97299fac7d7e7fb
author Adrian DC <radian.dc@gmail.com> Fri Mar 09 07:59:58 2018 +0100
committer Jackeagle <jackeagle102@gmail.com> Mon Aug 13 21:52:04 2018 -0600
tree 8cb0f2e77c00decbe807ad2e32f072fa5d7200c2
parent f33903d03a446fd2ccdf4c8ee169ca9420cb6d17

perfetto_cmd: Resolve missing O_CREAT mode

 src/perfetto_cmd/perfetto_cmd.cc:359:65:
  error: 'open' has superfluous mode bits; missing O_CREAT?

Change-Id: Id051a878a93268c42cd4d3e664247b98ed40dc25

src/perfetto_cmd/perfetto_cmd.cc

diff --git a/src/perfetto_cmd/perfetto_cmd.cc b/src/perfetto_cmd/perfetto_cmd.cc
index 9614642..ebdd740 100644
--- a/src/perfetto_cmd/perfetto_cmd.cc
+++ b/src/perfetto_cmd/perfetto_cmd.cc
@@ -356,7 +356,7 @@
     // If we are tracing to DropBox, there's no need to make a
     // filesystem-visible temporary file.
     // TODO(skyostil): Fall back to base::TempFile for older devices.
-    fd.reset(open(kTempDropBoxTraceDir, O_TMPFILE | O_RDWR, 0600));
+    fd.reset(open(kTempDropBoxTraceDir, O_CREAT | O_TMPFILE | O_RDWR, 0600));
     if (!fd) {
       PERFETTO_ELOG("Could not create a temporary trace file in %s",
                     kTempDropBoxTraceDir);