tree ccdbab212092cba2a4d7909f28873c1a36f4a04d
parent 0864814583a1f334c05231fd73cfb8fed6002a92
author Nicolas Iooss <nicolas.iooss@m4x.org> 1489786240 +0100
committer James Carter <jwcart2@tycho.nsa.gov> 1490120422 -0400

libsepol/cil: avoid freeing uninitialized values

cil_resolve_ast() begins by checking whether one of its parameters is
NULL and "goto exit;" when it is the case. As extra_args has not been
initialized there, this leads to calling cil_destroy_tree_node_stack(),
__cil_ordered_lists_destroy()... on garbage values.

In practise this cannot happen because cil_resolve_ast() is only called
by cil_compile() after cil_build_ast() succeeded. As the if condition
exists nonetheless, fix the body of the if block in order to silence a
warning reported by clang Static Analyzer.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>