commit 079813e2da59f35e2744af7a785d01d9f490e280
author reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fri Jun 14 17:46:07 2013 +0000
committer reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fri Jun 14 17:46:07 2013 +0000
tree 324225786afe45649c38faa629dc8f021737cee9
parent 07a052484f684056d87eb13229d80011e9985e95

speculative fix in TransitionView. don't validate after detachFromParent (we may have been deleted)

git-svn-id: http://skia.googlecode.com/svn/trunk@9619 2bbb7eff-a529-9590-31e7-b0007b416f81

samplecode/TransitionView.cpp

diff --git a/samplecode/TransitionView.cpp b/samplecode/TransitionView.cpp
index 1caff13..e4fa38e 100644
--- a/samplecode/TransitionView.cpp
+++ b/samplecode/TransitionView.cpp
@@ -77,12 +77,18 @@
     }
     virtual bool onEvent(const SkEvent& evt) {
         if (evt.isType(gReplaceTransitionEvt)) {
+            SkView* prev = fPrev;
+            prev->ref();
+
             fPrev->detachFromParent();
             fPrev = (SkView*)SkEventSink::FindSink(evt.getFast32());
             (void)SampleView::SetUsePipe(fPrev, SkOSMenu::kOffState);
             //attach the new fPrev and call unref to balance the ref in onDraw
             this->attachChildToBack(fPrev)->unref();
             this->inval(NULL);
+            
+            SkASSERT(1 == prev->getRefCnt());
+            prev->unref();
             return true;
         }
         if (evt.isType("transition-done")) {