Reland "Reland "[skif] Draw FilterResults directly for layer restoration""
This reverts commit a063eaeaf1e09e4d6f42e0f44a5723622a46d21c.
Reason for revert: android wasn't actually broken, removed invalid assert, added staging define for flutter build.
Original change's description:
> Revert "Reland "[skif] Draw FilterResults directly for layer restoration""
>
> This reverts commit c41b7710600a1adc50b8e8ff7c2de3420b545e96.
>
> Reason for revert: failing unit tests in android and flutter
>
> Original change's description:
> > Reland "[skif] Draw FilterResults directly for layer restoration"
> >
> > This reverts commit 33502f9b0c7d845adceb4907d1c7dc1f22b3fd4c.
> >
> > Reason for revert: staging for g3 has landed
> >
> > Original change's description:
> > > Revert "[skif] Draw FilterResults directly for layer restoration"
> > >
> > > This reverts commit 84b5116f98fbea7e625f0efc5ffa7943b1399746.
> > >
> > > Reason for revert: g3 also needs staging.
> > >
> > > Original change's description:
> > > > [skif] Draw FilterResults directly for layer restoration
> > > >
> > > > Many of the upfront optimization analysis is handled automatically in
> > > > applyColorFilter() and drawing with the blender. This means that when
> > > > we have a restore that floods the clip we don't force the input image
> > > > to flood as well, we can apply that at the very end during rendering.
> > > >
> > > > Additionally, any deferred effects like color filters and matrix
> > > > transforms from the final filters in the DAG can be applied when
> > > > drawing directly to the restore target device. Eventually when we get
> > > > to deferring the shader evaluation, this will further allow a filters
> > > > to avoid intermediate renderpasses.
> > > >
> > > > The overall logic is simpler now as well, and the empty input filter
> > > > case can reuse internalDrawDeviceWithFilter() now too.
> > > >
> > > > Bug: b/40040587
> > > > Bug: b/40042615
> > > > Change-Id: I12c452918f2229abdc55b4df4a18a1ccc2abf3aa
> > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759117
> > > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > >
> > > Bug: b/40040587
> > > Bug: b/40042615
> > > Change-Id: Ibd02b91adffab199b73e865c027cfee2726445ad
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761276
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> >
> > Bug: b/40040587
> > Bug: b/40042615
> > Change-Id: I316813e2f7268f75be4c5afa5b80deb6627c1141
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761380
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
>
> Bug: b/40040587
> Bug: b/40042615
> Change-Id: I00a828e597f20574113232b917668401eae3ff9b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761418
> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: b/40040587
Bug: b/40042615
Change-Id: Ie3b1e4164b023bc0fdf256a1af571ed4582895de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762982
Reviewed-by: Robert Phillips <robertphillips@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
5 files changed